Skip to contentSkip to conversation

common/cmd_mii.c bug and patch

U-Boot-Users Andrew Dyer 2 participants 2 messages Dec 29, 2004 – Sep 24, 2005

lore
Share & tools
lore
#0 lore raw

The mii info command (the !CONFIG_TERSE_MII version) has a bug in current cvs. If the phy address is passed to the command the code assigns the variable addr to start, instead of the values of addrlo which is extracted from the command line. At that point in the code addr is always 0.

to demonstrate find a board with a phy at a non-zero address, compare the results of 'mii info' and mii info 1' (substitute the phy address on the test board for 1).

Also in this file on lines 55 and 418 there are two places where a call to mii_init() is conditionally compiled in, but one condition includes defined(CONFIG_MCF52x2) and the other doesn't. Is this intentional?

Signature · 6 lines
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-mii-info-patch.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20041228/1e83566e/attachment.txt 
#1 lore raw
Quoted 6 lines · In message <[email protected]> you wrote:

The mii info command (the !CONFIG_TERSE_MII version) has a bug in current cvs. If the phy address is passed to the command the code assigns the variable addr to start, instead of the values of addrlo which is extracted from the command line. At that point in the code addr is always 0.

Added, thanks. But please don;t forget to include a CHANGELOG entry!

Quoted 4 lines

Also in this file on lines 55 and 418 there are two places where a call to mii_init() is conditionally compiled in, but one condition includes defined(CONFIG_MCF52x2) and the other doesn't. Is this intentional?

Probably not, but I don't have any MCF52x2 systems to test.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The whole world is about three drinks behind."     - Humphrey Bogart