load_module: no BUG if module_subsys uninitialized
PATCH 1/1 load_module: no BUG if module_subsys uninitialized
[I discovered after sending my previous message that Gmail helpfully line-wrapped and de-tabified my patch. I'm resending it as an attachment; apologies for the error.]
Invoking load_module() before param_sysfs_init() is called crashes in mod_sysfs_setup(), since the kset in module_subsys is not initialized yet.
Another patch for the same symptom (module_subsys-initialize-earlier.patch) moves param_sysfs_init() to the subsys initcalls, but this is still not early enough in the boot process in some cases. In particular, topology_init() causes /sbin/hotplug to run, which requests net-pf-1 (the UNIX socket protocol) which can be compiled as a module. Moving param_sysfs_init() to the postcore initcalls fixes this particular race, but there might well be other cases where a usermodehelper causes a module to load earlier still.
The patch below makes load_module() return an error rather than crashing the kernel if invoked before module_subsys is initialized.
kernel/module.c +6 -0
@@ -998,6 +998,12 @@ {int err; +if (!module_subsys.kset.subsys) { +printk (KERN_ERR "%s: module_subsys not initialized\n" , + mod->name); + err = -EINVAL ; + goto out; + }memset (&mod->mkobj.kobj,0 ,sizeof (mod->mkobj.kobj)); err =kobject_set_name (&mod->mkobj.kobj,"%s" , mod->name);if (err)
Quoted 7 lines · Ed Swierk
[I discovered after sending my previous message that Gmail helpfully line-wrapped and de-tabified my patch. I'm resending it as an attachment; apologies for the error.]
Invoking
load_module()beforeparam_sysfs_init()is called crashes inmod_sysfs_setup(), since the kset inmodule_subsysis not initialized yet.
How are you calling load_module before this init call is made?
thanks,
greg k-h
Quoted 1 line · Greg KH
How are you calling
load_modulebefore this init call is made?
In my case, net-pf-1 is getting modprobed as a result of hotplug trying to create a UNIX socket. Calls to hotplug begin after the topology_init initcall.
--Ed
Quoted 6 lines · Ed Swierk
Quoted 1 line · Greg KH
How are you calling
load_modulebefore this init call is made?In my case, net-pf-1 is getting modprobed as a result of hotplug trying to create a UNIX socket. Calls to hotplug begin after the
topology_initinitcall.
So, with this patch the module will still not be loaded properly, right? Well, I guess at least we don't oops... ok.
thanks,
greg k-h
Quoted 2 lines · Greg KH
So, with this patch the module will still not be loaded properly, right? Well, I guess at least we don't oops... ok.
Correct. sys_init_module() ends up returning an error to /sbin/modprobe, which trickles down to request_module() if it was invoked via kmod. The module doesn't get loaded, but at least the error message states which module it is, and as you say, at least we don't oops.
I think that not oopsing is pretty important in a case where a goofy but technically valid configuration (compiling Unix sockets as a module, and trying to boot with a rootfs containing a version of /sbin/hotplug that requires Unix sockets) collides with an obscure kernel implementation detail (initcall ordering).
--Ed