Skip to contentSkip to conversation

workqueue: Use wake_up_worker() to wake up first idle worker

PATCH linmiaohe 1 participant 1 message Aug 24, 2020

lore
Share & tools
lore

linmiaohe

author
#0 lore raw

friendly ping :)

Quoted 39 lines

Miaohe Lin <[email protected]> wrote:
From: Miaohe Lin <[email protected]>

Use wrapper function wake_up_worker() to wake up first idle worker.

---
kernel/workqueue.c | 10 ++++------

1 file changed, 4 insertions(+), 6 deletions(-)
kernel/workqueue.c +4 -7
@@ -864,7 +864,7 @@ void wq_worker_running(struct task_struct *task)
 */
 void wq_worker_sleeping(struct task_struct *task)  {
-	struct worker *next, *worker = kthread_data(task);
+	struct worker *worker = kthread_data(task);
 	struct worker_pool *pool;
 
 	/*
@@ -896,11 +896,9 @@ void wq_worker_sleeping(struct task_struct *task)
 	 * lock is safe.
 	 */
 	if (atomic_dec_and_test(&pool->nr_running) &&
-	    !list_empty(&pool->worklist)) {
-		next = first_idle_worker(pool);
-		if (next)
-			wake_up_process(next->task);
-	}
+	    !list_empty(&pool->worklist))
+		wake_up_worker(pool);
+
 	raw_spin_unlock_irq(&pool->lock);
 }
 
--

2.19.1