Skip to contentSkip to conversation

Query on skip_onerr field in struct cpuhp_step

DISCUSSION Mukesh Ojha 2 participants 4 messages Aug 21, 2018 – Aug 25, 2018

lore
Share & tools
lore
#0 lore raw

Hi All,

This is about one of field in struct cpuhp_step

* @skip_onerr: Do not invoke the functions on error rollback *              Will go away once the notifiers are gone bool                    skip_onerr;

Why this field was introduced, can anyone explain the history behind ? As i don't see it being set from anywhere

If it is specifically was dependent on notifiers, did we missed to remove it as the notifiers are gone or the usecase still there? And If it is still valid, in what scenario i would not want my callback to be called in rollback path?

Thanks,
Mukesh

#1 lore raw
Quoted 8 lines · Mukesh Ojha

Hi All,

This is about one of field in struct cpuhp_step

* @skip_onerr: Do not invoke the functions on error rollback *              Will go away once the notifiers are gone bool                    skip_onerr;

Quoted 5 lines

Why this field was introduced, can anyone explain the history behind ? As i don't see it being set from anywhere

If it is specifically was dependent on notifiers, did we missed to remove it as the notifiers are gone or the usecase still there?

As the comment says....

#2 lore raw
Quoted 9 lines · Thomas Gleixner
Quoted 8 lines · Mukesh Ojha

Hi All,

This is about one of field in struct cpuhp_step

* @skip_onerr: Do not invoke the functions on error rollback *              Will go away once the notifiers are gone bool                    skip_onerr;

Quoted 6 lines
Quoted 5 lines

Why this field was introduced, can anyone explain the history behind ? As i don't see it being set from anywhere

If it is specifically was dependent on notifiers, did we missed to remove it as the notifiers are gone or the usecase still there?

As the comment says....

Thanks for your reply
Sorry, for further question but i did not get the comment ..did you mean, we can remove this from the structure as notifier are not their now. ?

Also if you are aware with the history, can you tell , why would i want to avoid a call in undo_cpu_up path?

Thanks,
Mukesh

#3 lore raw
Quoted 8 lines · Mukesh Ojha
Quoted 3 lines · Thomas Gleixner
Quoted 2 lines

If it is specifically was dependent on notifiers, did we missed to remove it as the notifiers are gone or the usecase still there?

As the comment says....

Thanks for your reply
Sorry, for further question but i did not get the comment ..did you mean, we can remove this from the structure as notifier are not their now. ?

Yes, that's why the comment for that member says: Remove after conversion.

Quoted 2 lines

Also if you are aware with the history, can you tell , why would i want to avoid a call in undo_cpu_up path?

Because the notifiers worked completely differently. Go back in the git history where the initial conversion from notifiers to the state machine happened.

Thanks,

tglx