Skip to contentSkip to conversation

A mea culpa undefined reference in v2021.10-rc2, padding_algos, linker lists

DISCUSSION Alex G. 2 participants 2 messages Aug 18, 2021 – Aug 19, 2021

lore
Share & tools
lore

Alex G.

author
#0 lore raw

Hi Simon,

I'm seeing an undefined reference to padding_pkcs_15_verify with v2021.10-rc2. It happens when enabling FIT_SIGNATURE. I've tracked it down to the following two commits:

commit 92c960bc1d ("lib: rsa: Remove #ifdefs from rsa.h") commit 61416fe9df ("Kconfig: FIT_SIGNATURE should not select RSA_VERIFY")

Individually, each commit is fine, but when put together, they cause the issue, as the static inline padding_pkcs_15_verify() implementation is removed from rsa.h.

My hypothesis is that moving padding_algos to a linker list will solve this specific problem. I realize you might be working on the same part of the code. Should I address this issue, or should I wait for your series?

Alex

#1 lore raw

Hi Alex,

Quoted 10 lines · Alex G.

Hi Simon,

I'm seeing an undefined reference to padding_pkcs_15_verify with v2021.10-rc2. It happens when enabling FIT_SIGNATURE. I've tracked it down to the following two commits:

commit 92c960bc1d ("lib: rsa: Remove #ifdefs from rsa.h") commit 61416fe9df ("Kconfig: FIT_SIGNATURE should not select RSA_VERIFY")

Quoted 7 lines

Individually, each commit is fine, but when put together, they cause the issue, as the static inline padding_pkcs_15_verify() implementation is removed from rsa.h.

My hypothesis is that moving padding_algos to a linker list will solve this specific problem. I realize you might be working on the same part of the code. Should I address this issue, or should I wait for your series?

No I'm not doing anything here actually. I did rebase my image series but have not touched it since. One day.

Regards,
Simon