Skip to contentSkip to conversation

i2c: i801: Fix missing Kconfig dependency

PATCH Superseded Heiner Kallweit 1 participant 2 messages Apr 4, 2024 I2C subsystem host drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: i801: Fix missing Kconfig dependency

The original change adds usage of i2c_root_adapter(), which is implemented in i2c-mux.c. So we need I2C_MUX to avoid a linker error.

Fixes 71b494e043d2 ("i2c: i801: Call i2c_register_spd for muxed child segments")
---
 drivers/i2c/busses/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/Kconfig +1 -0
index 97989c914..201c5fc17 100644
@@ -111,6 +111,7 @@ config I2C_I801
 	select P2SB if X86
 	select CHECK_SIGNATURE if X86 && DMI
 	select I2C_SMBUS
+	select I2C_MUX
 	help
 	  If you say yes to this option, support will be included for the Intel
 	  801 family of mainboard I2C interfaces.  Specifically, the following
Signature · 1 line
2.44.0
#1 lore raw
Quoted 16 lines · Heiner Kallweit

The original change adds usage of i2c_root_adapter(), which is implemented in i2c-mux.c. So we need I2C_MUX to avoid a linker error.

Fixes 71b494e043d2 ("i2c: i801: Call i2c_register_spd for muxed child segments")
---
 drivers/i2c/busses/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/Kconfig +0 -0
index 97989c914..201c5fc17 100644

drivers/i2c/busses/Kconfig config I2C_I801 · line 117

Quoted 7 lines
drivers/i2c/busses/Kconfig +1 -0
@@ -111,6 +111,7 @@ config I2C_I801
 	select P2SB if X86
 	select CHECK_SIGNATURE if X86 && DMI
 	select I2C_SMBUS
+	select I2C_MUX
 	help
 	  If you say yes to this option, support will be included for the Intel
 	  801 family of mainboard I2C interfaces.  Specifically, the following

Please disregard, I'll send an improved version shortly.
Issue with this version is that I2C_MUX may be enabled even if I2C_MUX_GPIO is unset and the mux part is disabled.