Skip to contentSkip to conversation

mmc-utils: Add basic erase error check

PATCH Applied Christian Löhle 3 participants 3 messages Jan 16, 2023 – Feb 9, 2023 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 mmc-utils: Add basic erase error check

Check for erase specific R1 errors so e.g. an OOR erase is not reported as successful when it never executed.

There could be checks for more error bits but R1_ERASE_SEQ_ERROR on CMD38 should catch all that are reported by hardware anyway.

---
-v3: Check for ERASE_PARAM on CMD36
-v2: Remove unneeded error bit checking

 mmc_cmds.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
mmc_cmds.c +12 -1
index e6d3273..6c50bbe 100644
@@ -54,7 +54,6 @@
 #define WPTYPE_PWRON 2
 #define WPTYPE_PERM 3
 
-
 int read_extcsd(int fd, __u8 *ext_csd)
 {
 	int ret = 0;
@@ -2668,6 +2667,18 @@ static int erase(int dev_fd, __u32 argin, __u32 start, __u32 end)
 	if (ret)
 		perror("Erase multi-cmd ioctl");
 
+	/* Does not work for SPI cards */
+	if (multi_cmd->cmds[1].response[0] & R1_ERASE_PARAM) {
+		fprintf(stderr, "Erase start response: 0x%08x\n",
+				multi_cmd->cmds[0].response[0]);
+		ret = -EIO;
+	}
+	if (multi_cmd->cmds[2].response[0] & R1_ERASE_SEQ_ERROR) {
+		fprintf(stderr, "Erase response: 0x%08x\n",
+				multi_cmd->cmds[2].response[0]);
+		ret = -EIO;
+	}
+
 	free(multi_cmd);
 	return ret;
 }
Signature · 6 lines
2.37.3


Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
Reviewed-by on v3 1/1
#1 lore raw
Quoted 7 lines

Check for erase specific R1 errors so e.g. an OOR erase is not reported as successful when it never executed.

There could be checks for more error bits but R1_ERASE_SEQ_ERROR on CMD38 should catch all that are reported by hardware anyway.

Quoted 45 lines

---

(quoted diff) +0 -2
-v3: Check for ERASE_PARAM on CMD36
-v2: Remove unneeded error bit checking
 mmc_cmds.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
mmc_cmds.c +12 -1
index e6d3273..6c50bbe 100644
@@ -54,7 +54,6 @@
 #define WPTYPE_PWRON 2
 #define WPTYPE_PERM 3
 
-
 int read_extcsd(int fd, __u8 *ext_csd)
 {
        int ret = 0;
@@ -2668,6 +2667,18 @@ static int erase(int dev_fd, __u32 argin, __u32 start,
 __u32 end)
        if (ret)
                perror("Erase multi-cmd ioctl");
 
+       /* Does not work for SPI cards */
+       if (multi_cmd->cmds[1].response[0] & R1_ERASE_PARAM) {
+               fprintf(stderr, "Erase start response: 0x%08x\n",
+                               multi_cmd->cmds[0].response[0]);
+               ret = -EIO;
+       }
+       if (multi_cmd->cmds[2].response[0] & R1_ERASE_SEQ_ERROR) {
+               fprintf(stderr, "Erase response: 0x%08x\n",
+                               multi_cmd->cmds[2].response[0]);
+               ret = -EIO;
+       }
+
        free(multi_cmd);
        return ret;

}
--
2.37.3

Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director:
Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782

Applied
#2 lore raw
In reply to Christian Löhle
Quoted 8 lines · Christian Löhle

Check for erase specific R1 errors so e.g. an OOR erase is not reported as successful when it never executed.

There could be checks for more error bits but R1_ERASE_SEQ_ERROR on CMD38 should catch all that are reported by hardware anyway.

Applied to git.kernel.org/pub/scm/utils/mmc/mmc-utils.git master, thanks!

Kind regards
Uffe

Quoted 45 lines

---

(quoted diff) +0 -2
-v3: Check for ERASE_PARAM on CMD36
-v2: Remove unneeded error bit checking
 mmc_cmds.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
mmc_cmds.c +12 -2
index e6d3273..6c50bbe 100644
@@ -54,7 +54,6 @@
 #define WPTYPE_PWRON 2
 #define WPTYPE_PERM 3
 
-
 int read_extcsd(int fd, __u8 *ext_csd)
 {
        int ret = 0;
@@ -2668,6 +2667,18 @@ static int erase(int dev_fd, __u32 argin, __u32 start, __u32 end)
        if (ret)
                perror("Erase multi-cmd ioctl");
 
+       /* Does not work for SPI cards */
+       if (multi_cmd->cmds[1].response[0] & R1_ERASE_PARAM) {
+               fprintf(stderr, "Erase start response: 0x%08x\n",
+                               multi_cmd->cmds[0].response[0]);
+               ret = -EIO;
+       }
+       if (multi_cmd->cmds[2].response[0] & R1_ERASE_SEQ_ERROR) {
+               fprintf(stderr, "Erase response: 0x%08x\n",
+                               multi_cmd->cmds[2].response[0]);
+               ret = -EIO;
+       }
+
        free(multi_cmd);
        return ret;
 }
--

2.37.3

Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782