Skip to contentSkip to conversation

amdgpu's dce_vX_0_afmt_setmode(): why so different from radeon's

DISCUSSION Alexandre Demers 2 participants 2 messages Aug 23, 2016 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

While looking at dce_v8_0_afmt_setmode(), I was thinking how crammed it was and how unintuitive it looked. I compared it to its radeon counterpart and I realized how readable this last one was. I had a look at the other dce_vX_0_afmt_setmode() under amdgpu and they all look alike.

Can somebody explain why the amdgpu's side just includes everything in dce_vX_0_afmt_setmode() instead of having a nicely structured and readable presentation as it is under radeon?

I'm trying to structure the thing a bit more like the radeon's side for dce6, but their are some differences in the step order and even a few more registry read and write calls. Any clue will be welcomed.

Cheers.

Signature · 6 lines
Alexandre Demers

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): c9ab6753-06f6-da9a-eb81-4c88ad31fe7d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 15 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Alexandre Demers
Sent: Monday, August 22, 2016 11:29 PM
To: [email protected]
Cc: Alexander Deucher; Christian König
Subject: amdgpu's dce_vX_0_afmt_setmode(): why so different from radeon's

While looking at dce_v8_0_afmt_setmode(), I was thinking how crammed it was and how unintuitive it looked. I compared it to its radeon counterpart and I realized how readable this last one was. I had a look at the other dce_vX_0_afmt_setmode() under amdgpu and they all look alike.

Quoted 7 lines

Can somebody explain why the amdgpu's side just includes everything in dce_vX_0_afmt_setmode() instead of having a nicely structured and readable presentation as it is under radeon?

I'm trying to structure the thing a bit more like the radeon's side for dce6, but their are some differences in the step order and even a few more registry read and write calls. Any clue will be welcomed.

Audio support was never implemented in amdgpu. You need to use DAL for audio support in amdgpu. Radeon supports audio.

Alex

Quoted 10 lines

Cheers.

--
Alexandre Demers

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx