KVM: s390: vsie: store guest addresses of satellite blocks in vsie_page
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 41 lines · Christian Borntraeger
Quoted 27 lines · David Hildenbrand
Quoted 11 lines · Christian Borntraeger
Quoted 8 lines · Christian Borntraeger
Quoted 6 lines · Christian Borntraeger
David,
this seems to have broken VSIE f�r guests with >64vcpus as we only pin the first page of the SCA. Starting guest3 with 240 vcpu triggers quickly guest2 crashes. Can you have a look?
Quoted 5 lines
Quoted 2 lines
Hmm, or maybe it was always broken and we never supported pinning of ESCA properly?
4.15.0 is also broken, must be an earlier change.
Maybe something as simple as this:
arch/s390/kvm/kvm-s390.c +0
-0arch/s390/kvm/kvm-s390.c static void sca_add_vcpu(struct kvm_vcpu *vcpu) · line 2152
Quoted 7 lines
arch/s390/kvm/kvm-s390.c +1
-0@@ -2146,6 +2146,7 @@ static void sca_add_vcpu(struct kvm_vcpu *vcpu)/* we still need the basic sca for the ipte control */ vcpu->arch.sie_block->scaoh = (__u32)(((__u64 )sca) >>32 ); vcpu->arch.sie_block->scaol = (__u32 )(__u64 )sca; +return ; }read_lock (&vcpu->kvm->arch.sca_lock);if (vcpu->kvm->arch.use_esca) {
Quoted 2 lines
can you spin a patch with proper Fixes tags?
Sure, thanks for reporting!
Signature · 3 lines
Thanks, David / dhildenb