hwmon: pmbus: ibm-cffps depends on LEDS_CLASS
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 7 lines · Guenter Roeck
Quoted 4 lines · Arnd Bergmann
Building without
CONFIG_LEDS_CLASScauses a link failure:
drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
ibm-cffps.c:(.text+0x4f4): undefined reference to`devm_of_led_classdev_register'
Quoted 1 line
Quoted 8 lines
Quoted 3 lines
This adds the required dependency.
Fixes f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor(CFF) power supply driver")
Quoted 1 line
Signed-off-by Arnd Bergmann <[email protected]>I wanted to let Edward decide if he wants the new dependency or conditional code in the driver. Not having heard from him, I'll take your patch instead for now.
Thanks, yes this is a good solution for this driver. Didn't think about that during testing... Thanks Arnd.
Eddie
Quoted 24 lines
Thanks,
GuenterQuoted 19 lines
---
drivers/hwmon/pmbus/Kconfig| 1 +1 file changed, 1 insertion(+)drivers/hwmon/pmbus/Kconfig +0
-0@@ -39,6 +39,7 @@ config SENSORS_ADM1275config
SENSORS_IBM_CFFPS
tristate "IBM Common Form Factor Power Supply"
+ depends onLEDS_CLASS
help
If you say yes here you get hardware monitoring support for the IBM Common Form Factor power supply.
--
2.9.0