Skip to contentSkip to conversation

usb: Add streams support to epautoconf.

PATCH [email protected] 2 participants 4 messages Dec 21, 2010 – Dec 28, 2010 Arm Qualcomm mailing list

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · Greg KH

Ok, but please note the word of "proprietary" usually means something

else when talking about kernel code (i.e. licensing issues.)

Quoted 2 lines

I'll be glad to take this type of patch when you also provide a patch

that uses the callback, but not before then.

What I meant by "proprietary" is not proprietary in the terms of kernel world. I meant a unique algorithm, different from the default. Sorry for the misunderstanding.
Currently we don't have a unique algorithm. When implementing this change we thought it may be useful for other controllers but for us the default implementation was good enough.
Maya Erez
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

#1 lore raw
Quoted 5 lines · On Tue, Dec 21, 2010 at 05:46:34AM -0800, [email protected] wrote:
Quoted 2 lines · Greg KH

Ok, but please note the word of "proprietary" usually means something

else when talking about kernel code (i.e. licensing issues.)

Quoted 2 lines

I'll be glad to take this type of patch when you also provide a patch

Quoted 8 lines

that uses the callback, but not before then.

What I meant by "proprietary" is not proprietary in the terms of kernel world. I meant a unique algorithm, different from the default. Sorry for the misunderstanding.
Currently we don't have a unique algorithm. When implementing this change we thought it may be useful for other controllers but for us the default implementation was good enough.

First rule of kernel development, "don't add infrastructure that you do not need today."

thanks,

greg k-h

#2 lore raw
Quoted 3 lines · Greg KH

First rule of kernel development, "don't add infrastructure that you do not need today."

We beleive that the chip-specific code for net2280 and goku at the beginning of usb_ep_autoconfig can be moved to this new gadget op, therefore it is also needed for today's implementation. I will do the cahnge and send a new patch for review
Thanks,
Maya Erez
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

#3 lore raw
Quoted 5 lines
Quoted 1 line · Maya Erez

We beleive that the chip-specific code for net2280 and goku at the beginning of usb_ep_autoconfig can be moved to this new gadget op, therefore it is also needed for today's implementation. I will do the cahnge and send a new patch for review

Since the unique implementation of net2280 and goku don't cover all EPs types and since we don't have the ability to fully test it, we didn't feel confident to do the changes in their code. Therefore, we decided to remove the new gadget_op.
Thanks,
Maya Erez
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum