Skip to contentSkip to conversation

EDAC: altera: Remove unnecessary print function dev_err()

PATCH In review [email protected] 2 participants 2 messages Nov 6, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC: altera: Remove unnecessary print function dev_err()

Eliminate the follow coccicheck warning:

./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because platform_get_irq() already prints an error ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because platform_get_irq() already prints an error

---
 drivers/edac/altera_edac.c | 2 --
 1 file changed, 2 deletions(-)
drivers/edac/altera_edac.c +0 -2
index e7e8e624a436..bd5b15ceb872 100644
@@ -2150,7 +2150,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
 
 	edac->sb_irq = platform_get_irq(pdev, 0);
 	if (edac->sb_irq < 0) {
-		dev_err(&pdev->dev, "No SBERR IRQ resource\n");
 		return edac->sb_irq;
 	}
 
@@ -2185,7 +2184,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
 #else
 	edac->db_irq = platform_get_irq(pdev, 1);
 	if (edac->db_irq < 0) {
-		dev_err(&pdev->dev, "No DBERR IRQ resource\n");
 		return edac->db_irq;
 	}
 	irq_set_chained_handler_and_data(edac->db_irq,
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · On Sun, 2022-11-06 at 21:33 +0800, [email protected] wrote:

Eliminate the follow coccicheck warning:

./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because platform_get_irq() already prints an error ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because platform_get_irq() already prints an error

[]

drivers/edac/altera_edac.c

Quoted 1 line
drivers/edac/altera_edac.c +0 -0

[]

drivers/edac/altera_edac.c static int altr_edac_a10_probe(struct platform_device *pdev) · line 2154

Quoted 7 lines
drivers/edac/altera_edac.c +0 -1
@@ -2150,7 +2150,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
 
 	edac->sb_irq = platform_get_irq(pdev, 0);
 	if (edac->sb_irq < 0) {
-		dev_err(&pdev->dev, "No SBERR IRQ resource\n");
 		return edac->sb_irq;
 	}

Should delete now unnecessary braces too

Quoted 9 lines
drivers/edac/altera_edac.c +0 -1
@@ -2185,7 +2184,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
 #else
 	edac->db_irq = platform_get_irq(pdev, 1);
 	if (edac->db_irq < 0) {
-		dev_err(&pdev->dev, "No DBERR IRQ resource\n");
 		return edac->db_irq;
 	}
 	irq_set_chained_handler_and_data(edac->db_irq,