Skip to contentSkip to conversation

io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC

PATCH In review Jens Axboe 2 participants 6 messages Oct 7, 2022 – Oct 14, 2022 io_uring

lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC

The msg variants of sending aren't audited separately, so we should not be setting audit_skip for the zerocopy sendmsg variant either.

Fixes 493108d95f14 ("io_uring/net: zerocopy sendmsg")

---

io_uring/opdef.c +0 -1
index 2330f6da791e..83dc0f9ad3b2 100644
@@ -510,7 +510,6 @@ const struct io_op_def io_op_defs[] = {
 		.needs_file		= 1,
 		.unbound_nonreg_file	= 1,
 		.pollout		= 1,
-		.audit_skip		= 1,
 		.ioprio			= 1,
 		.manual_alloc		= 1,
 #if defined(CONFIG_NET)
Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 5 lines · Paul Moore
Quoted 4 lines · Jens Axboe

The msg variants of sending aren't audited separately, so we should not be setting audit_skip for the zerocopy sendmsg variant either.

Quoted 7 lines
Quoted 3 lines
Fixes 493108d95f14 ("io_uring/net: zerocopy sendmsg")

Thanks Jens.

Hi Jens, I just wanted to check on this, are you planning to send this to Linus during the v6.1-rcX cycle?

Signature · 1 line
paul-moore.com
author maintainer
#3 lore raw
Quoted 11 lines · Paul Moore
Quoted 9 lines · Paul Moore
Quoted 8 lines · Jens Axboe

The msg variants of sending aren't audited separately, so we should not be setting audit_skip for the zerocopy sendmsg variant either.

Fixes 493108d95f14 ("io_uring/net: zerocopy sendmsg")
Quoted 6 lines
Quoted 3 lines

Thanks Jens.

Hi Jens, I just wanted to check on this, are you planning to send this to Linus during the v6.1-rcX cycle?

Yes, it was included in the pull sent out earlier today.

#4 lore raw
Quoted 11 lines · Jens Axboe
Quoted 10 lines · Paul Moore
Quoted 9 lines · Paul Moore
Quoted 8 lines · Jens Axboe

The msg variants of sending aren't audited separately, so we should not be setting audit_skip for the zerocopy sendmsg variant either.

Fixes 493108d95f14 ("io_uring/net: zerocopy sendmsg")
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Thanks Jens.

Hi Jens, I just wanted to check on this, are you planning to send this to Linus during the v6.1-rcX cycle?

Yes, it was included in the pull sent out earlier today.

Great, thanks again for your help in taking care of this.

Signature · 1 line
paul-moore.com
author maintainer
#5 lore raw
Quoted 14 lines · Paul Moore
Quoted 13 lines · Jens Axboe
Quoted 12 lines · Paul Moore
Quoted 11 lines · Paul Moore
Quoted 8 lines · Jens Axboe

The msg variants of sending aren't audited separately, so we should not be setting audit_skip for the zerocopy sendmsg variant either.

Fixes 493108d95f14 ("io_uring/net: zerocopy sendmsg")

Thanks Jens.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Hi Jens, I just wanted to check on this, are you planning to send this to Linus during the v6.1-rcX cycle?

Yes, it was included in the pull sent out earlier today.

Great, thanks again for your help in taking care of this.

Not a problem, thanks for letting me know about it!

Signature · 1 line
Jens Axboe