Skip to contentSkip to conversation

pata_jmicron: no drives found on post 2.6.25 kernels

BISECTED Shaohua Li 5 participants 8 messages May 20, 2008 – May 22, 2008 1 message not in the archive PCI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Shaohua Li

author
#1 lore raw
Quoted 9 lines · Plamen Petrov

Hello, folks!

After 2.6.26 merge window opened, the optical drives in my computer, hanging off a JMicron controler were not detected by linux any more.

Luca Tettamanti reported similar troubles:
http://marc.info/?l=linux-kernel&m=120958791323911&w=2

Quoted 8 lines

Its been 20 days, so I decided to bisect.
git bisect revealed that commit 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
is the one causing pata_jmicron to fail to detect drives, connected to the JMicron controler on my motherboard. At least in my case, anyway...
Changing kernel config to CONFIG_PCIEASPM=n makes the drives attached to the JMicron SATA/PATA controller usable again.

When you enable this option, did you change any ASPM policy? By default, we are using the BIOS setting, so it shouldn't change any thing.

Also can you please send me the 'lspci -vvvxxxx' output with/without the ASPM enabled?

Thanks,
Shaohua

#2 lore raw

Shaohua Li написа:

Quoted 18 lines · Plamen Petrov
Quoted 9 lines

Hello, folks!

After 2.6.26 merge window opened, the optical drives in my computer, hanging off a JMicron controler were not detected by linux any more.

Luca Tettamanti reported similar troubles:
http://marc.info/?l=linux-kernel&m=120958791323911&w=2

Quoted 8 lines

Its been 20 days, so I decided to bisect.
git bisect revealed that commit 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
is the one causing pata_jmicron to fail to detect drives, connected to the JMicron controler on my motherboard. At least in my case, anyway...
Changing kernel config to CONFIG_PCIEASPM=n makes the drives attached to the JMicron SATA/PATA controller usable again.

Quoted 3 lines

When you enable this option, did you change any ASPM policy? By default, we are using the BIOS setting, so it shouldn't change any thing.

No, I did not change any ASPM policy, mainly because I do not how.

Quoted 3 lines

Also can you please send me the 'lspci -vvvxxxx' output with/without the ASPM enabled?

Checkout the attached files. Sorry for the delay - I was away from the machine in question.

Quoted 3 lines

Thanks,
Shaohua

Thanks for your time,
Plamen

Signature · 16 lines
Plamen Petrov, network & system administrator
Filial - Silistra
RU "Angel Kantchev"
http://fs.ru.acad.bg/
--------------------------------
this message is UTF8 encoded 

_
___
_____
------------------------------------------
This message was sent by the mail server
at fs.ru.acad.bg using the web interface:
   https://fs.ru.acad.bg/s/m/webmail
E-mail [email protected] with anything,
regarding the server itself
author
#3 lore raw
Quoted 20 lines · Plamen Petrov

Shaohua Li написа:

Quoted 18 lines · Plamen Petrov
Quoted 17 lines

Hello, folks!

After 2.6.26 merge window opened, the optical drives in my computer, hanging off a JMicron controler were not detected by linux any more.

Luca Tettamanti reported similar troubles:
http://marc.info/?l=linux-kernel&m=120958791323911&w=2

Its been 20 days, so I decided to bisect.
git bisect revealed that commit 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
is the one causing pata_jmicron to fail to detect drives, connected to the JMicron controler on my motherboard. At least in my case, anyway...
Changing kernel config to CONFIG_PCIEASPM=n makes the drives attached to the JMicron SATA/PATA controller usable again.

Quoted 9 lines
Quoted 3 lines

When you enable this option, did you change any ASPM policy? By default, we are using the BIOS setting, so it shouldn't change any thing.

No, I did not change any ASPM policy, mainly because I do not how.

Quoted 3 lines

Also can you please send me the 'lspci -vvvxxxx' output with/without the ASPM enabled?

Can you please try below patch?
The Slot 03:00.* of JMicron controller has two functions, but one is PCIE endpoint the other isn't PCIE device, very strange. PCIE spec defines all functions should have the same config for ASPM, so disable ASPM for the whole slot in this case.

drivers/pci/pcie/aspm.c +20 -0
Index: linux/drivers/pci/pcie/aspm.c
===================================================================
@@ -506,6 +506,23 @@ static void free_link_state(struct pci_d
 	pdev->link_state = NULL;
 }
 
+static int pcie_aspm_sanity_check(struct pci_dev *pdev)
+{
+	struct pci_dev *child_dev;
+	int child_pos;
+
+	/*
+	 * Some functions in a slot might not all be PCIE functions, very
+	 * strange. Disable ASPM for the whole slot
+	 */
+	list_for_each_entry(child_dev, &pdev->subordinate->devices, bus_list) {
+		child_pos = pci_find_capability(child_dev, PCI_CAP_ID_EXP);
+		if (!child_pos)
+			return -EINVAL;
+	}
+	return 0;
+}
+
 /*
  * pcie_aspm_init_link_state: Initiate PCI express link state.
  * It is called after the pcie and its children devices are scaned.
@@ -526,6 +543,9 @@ void pcie_aspm_init_link_state(struct pc
 	if (list_empty(&pdev->subordinate->devices))
 		goto out;
 
+	if (pcie_aspm_sanity_check(pdev))
+		goto out;
+
 	mutex_lock(&aspm_lock);
 
 	link_state = kzalloc(sizeof(*link_state), GFP_KERNEL);
#4 lore raw

Shaohua Li написа:

Quoted 27 lines · Plamen Petrov
Quoted 26 lines

Shaohua Li написа:

Quoted 18 lines · Plamen Petrov
Quoted 9 lines

Hello, folks!

After 2.6.26 merge window opened, the optical drives in my computer, hanging off a JMicron controler were not detected by linux any more.

Luca Tettamanti reported similar troubles:
http://marc.info/?l=linux-kernel&m=120958791323911&w=2

Quoted 8 lines

Its been 20 days, so I decided to bisect.
git bisect revealed that commit 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
is the one causing pata_jmicron to fail to detect drives, connected to the JMicron controler on my motherboard. At least in my case, anyway...
Changing kernel config to CONFIG_PCIEASPM=n makes the drives attached to the JMicron SATA/PATA controller usable again.

Quoted 3 lines

When you enable this option, did you change any ASPM policy? By default, we are using the BIOS setting, so it shouldn't change any thing.

No, I did not change any ASPM policy, mainly because I do not how.

Quoted 9 lines
Quoted 3 lines
Quoted 3 lines

Also can you please send me the 'lspci -vvvxxxx' output with/without the ASPM enabled?

Can you please try below patch?
The Slot 03:00.* of JMicron controller has two functions, but one is PCIE endpoint the other isn't PCIE device, very strange. PCIE spec defines all functions should have the same config for ASPM, so disable ASPM for the whole slot in this case.

With the provided patch applied on top of latest git tree, the optical drive connected to the JMicron controller WORKS with CONFIG_PCIEASPM=y.

Just in case - this is on a Gigabyte GA-P35-DS3R v2.1 motherboard, BIOS F11.

Thanks!

Plamen Petrov, network & system administrator
Filial - Silistra
RU "Angel Kantchev"
http://fs.ru.acad.bg/
--------------------------------
this message is UTF8 encoded

_
___
_____
------------------------------------------
This message was sent by the mail server
at fs.ru.acad.bg using the web interface:
https://fs.ru.acad.bg/s/m/webmail
E-mail [email protected] with anything,
regarding the server itself

#5 lore raw
In reply to Shaohua Li
Quoted 25 lines · Shaohua Li
Quoted 24 lines · Plamen Petrov

Shaohua Li написа:

Quoted 21 lines · Plamen Petrov
Quoted 9 lines

Hello, folks!

After 2.6.26 merge window opened, the optical drives in my computer, hanging off a JMicron controler were not detected by linux any more.

Luca Tettamanti reported similar troubles:
http://marc.info/?l=linux-kernel&m=120958791323911&w=2

Quoted 8 lines

Its been 20 days, so I decided to bisect.
git bisect revealed that commit 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
is the one causing pata_jmicron to fail to detect drives, connected to the JMicron controler on my motherboard. At least in my case, anyway...
Changing kernel config to CONFIG_PCIEASPM=n makes the drives attached to the JMicron SATA/PATA controller usable again.

When you enable this option, did you change any ASPM policy? By default, we are using the BIOS setting, so it shouldn't change any thing.

Quoted 6 lines
Quoted 5 lines

No, I did not change any ASPM policy, mainly because I do not how.

Quoted 3 lines

Also can you please send me the 'lspci -vvvxxxx' output with/without the ASPM enabled?

Can you please try below patch?

I confirm that the patch fixes the issue when CONFIG_ASPM is enabled.

Quoted 2 lines

The Slot 03:00.* of JMicron controller has two functions, but one is PCIE endpoint the other isn't PCIE device, very strange.

Right, that's what I'm seeing here (motherboard is an ASUS P5B-E). I'm attaching the output of lspci.

thanks,
Luca

author
#6 lore raw
Quoted 33 lines · Luca Tettamanti
Quoted 25 lines · Shaohua Li
Quoted 24 lines · Plamen Petrov

Shaohua Li написа:

Quoted 21 lines · Plamen Petrov
Quoted 9 lines

Hello, folks!

After 2.6.26 merge window opened, the optical drives in my computer, hanging off a JMicron controler were not detected by linux any more.

Luca Tettamanti reported similar troubles:
http://marc.info/?l=linux-kernel&m=120958791323911&w=2

Quoted 8 lines

Its been 20 days, so I decided to bisect.
git bisect revealed that commit 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
is the one causing pata_jmicron to fail to detect drives, connected to the JMicron controler on my motherboard. At least in my case, anyway...
Changing kernel config to CONFIG_PCIEASPM=n makes the drives attached to the JMicron SATA/PATA controller usable again.

When you enable this option, did you change any ASPM policy? By default, we are using the BIOS setting, so it shouldn't change any thing.

Quoted 6 lines
Quoted 5 lines

No, I did not change any ASPM policy, mainly because I do not how.

Quoted 3 lines

Also can you please send me the 'lspci -vvvxxxx' output with/without the ASPM enabled?

Can you please try below patch?

Quoted 7 lines

I confirm that the patch fixes the issue when CONFIG_ASPM is enabled.

Quoted 2 lines

The Slot 03:00.* of JMicron controller has two functions, but one is PCIE endpoint the other isn't PCIE device, very strange.

Right, that's what I'm seeing here (motherboard is an ASUS P5B-E). I'm attaching the output of lspci.

Jesse, can you take this patch. It should be safe for 2.6.26.

Thanks,
Shaohua

#7 lore raw
Quoted 36 lines · Shaohua Li
Quoted 35 lines · Luca Tettamanti
Quoted 25 lines · Shaohua Li
Quoted 24 lines · Plamen Petrov

Shaohua Li написа:

Quoted 22 lines · Plamen Petrov
Quoted 9 lines

Hello, folks!

After 2.6.26 merge window opened, the optical drives in my computer, hanging off a JMicron controler were not detected by linux any more.

Luca Tettamanti reported similar troubles:
http://marc.info/?l=linux-kernel&m=120958791323911&w=2

Quoted 8 lines

Its been 20 days, so I decided to bisect.
git bisect revealed that commit 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
is the one causing pata_jmicron to fail to detect drives, connected to the JMicron controler on my motherboard. At least in my case, anyway...
Changing kernel config to CONFIG_PCIEASPM=n makes the drives attached to the JMicron SATA/PATA controller usable again.

When you enable this option, did you change any ASPM policy? By default, we are using the BIOS setting, so it shouldn't change any thing.

Quoted 6 lines
Quoted 4 lines

No, I did not change any ASPM policy, mainly because I do not how.

Quoted 2 lines

Also can you please send me the 'lspci -vvvxxxx' output with/without the ASPM enabled?

Can you please try below patch?

I confirm that the patch fixes the issue when CONFIG_ASPM is enabled.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

The Slot 03:00.* of JMicron controller has two functions, but one is PCIE endpoint the other isn't PCIE device, very strange.

Right, that's what I'm seeing here (motherboard is an ASUS P5B-E). I'm attaching the output of lspci.

Jesse, can you take this patch. It should be safe for 2.6.26.

Definitely. Thanks Shaohua.

Jesse

#8 lore raw
In reply to a message not in the archive
Quoted 7 lines · Plamen Petrov

git bisect revealed that commit 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b
is the one causing pata_jmicron to fail to detect drives, connected to the JMicron controler on my motherboard. At least in my case, anyway...
Changing kernel config to CONFIG_PCIEASPM=n makes the drives attached to the JMicron SATA/PATA controller usable again.

The PCIE ASM stuff is experimental and for good reason it appears.

Not an ATA layer bug - a PCIE one so once the PCIE folks fix their stuff hopefully it'll magically start working.