jsm: IRQ handlers doesn't need to have IRQ_DISABLED enabled
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/2 jsm: IRQ handlers doesn't need to have IRQ_DISABLED enabled
Currently jsm is showing the following message when loaded:
IRQ 432/JSM: IRQF_DISABLED is not guaranteed on shared IRQs
It's because the request_irq() is called using IRQF_DISABLED and IRQF_SHARED.
Actually there is no need to use IRQF_DISABLED in this driver.
Signed-off-by Breno Leitao <[email protected]>
--- drivers/serial/jsm/jsm_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/jsm/jsm_driver.c +1 -1
@@ -123,7 +123,7 @@ static int __devinit jsm_probe_one(struct pci_dev *pdev, const struct pci_device } rc =request_irq (brd->irq, brd->bd_ops->intr, -IRQF_DISABLED |IRQF_SHARED ,"JSM" , brd); +IRQF_SHARED ,"JSM" , brd);if (rc) {printk (KERN_WARNING "Failed to hook IRQ %d\n" ,brd->irq); goto out_iounmap;
Signature · 1 line
1.6.0.4
PATCH 2/2 jsm: Rewriting a bad log message
Actually jsm displays "Device Added" 8 times (for a 8 port device). This silly patch just makes things more informative, showing the port (instead of the device) that was added.
Signed-off-by Breno Leitao <[email protected]>
--- drivers/serial/jsm/jsm_tty.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/jsm/jsm_tty.c +1 -1
@@ -472,7 +472,7 @@ int __devinit jsm_uart_port_init(struct jsm_board *brd)if (uart_add_one_port (&jsm_uart_driver, &brd->channels[i]->uart_port))printk (KERN_INFO "jsm: add device failed\n" );else -printk (KERN_INFO "Added device \n" ); +printk (KERN_INFO "jsm: Port %d added\n" , i); }jsm_printk (INIT ,INFO , &brd->pci_dev,"finish\n" );
Signature · 1 line
1.6.0.4