Skip to contentSkip to conversation

bsearch: fix overflow and avoid unnecessary calculation

PATCH Superseded André Goddard Rosa 1 participant 1 message Nov 11, 2009

lore
Share & tools
lore
#0 lore raw

v4 cover bsearch: fix overflow and avoid unnecessary calculation

Fix a rare overflow situation which can occur when working with large arrays. Also, remove an unneeded calculation.

changelog:
v4: fix the overflow which could still happen when the number of array
elements to search approached the maximum value of size_t and to find the key element we would need to traverse the whole binary tree (making 'start' idx tend towards 'end' idx), as pointed by review feedback from Rusty Russell (thanks!)
v3: fix the comment/example of patch 02/02 at v2 patch series
v2: fix a bug introduced into 01/02 of the v1 patch series
v1: initial submission

André Goddard Rosa (2):
bsearch: avoid unneeded decrement arithmetic
bsearch: prevent overflow when computing middle comparison element

 lib/bsearch.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)