Skip to contentSkip to conversation

remove cast from void*

PATCH In review matt mooney 4 participants 6 messages Sep 28, 2010 – Nov 3, 2010

Subsystems (5)
Arm (32-bit) Arm sub-architectures PowerPC Kernel janitors +1 more subsystems
lore
Share & tools
lore

matt mooney

author
#0 lore raw

cover remove cast from void*

Hi guys,

This is a resend to see if anyone wants to pick these up. They are now being sent to the trivial mailing list.

Thanks,
mfm

matt mooney (3):
arm: remove cast from void*
powerpc: remove cast from void*
trace: remove cast from void*

 arch/arm/mach-omap2/mailbox.c                |    8 ++++----
 arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
 kernel/trace/ftrace.c                        |    4 ++--
 kernel/trace/trace.c                         |    2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
1.7.2.1
author
#1 lore raw

PATCH RESEND 1/3 arm: remove cast from void*

Unnecessary cast from void* in assignment.

Signed-off-by matt mooney <[email protected]>
Acked-by Hiroshi DOYU <[email protected]>
---
 arch/arm/mach-omap2/mailbox.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/mailbox.c +4 -4
index 42dbfa4..40ddeca 100644
@@ -181,7 +181,7 @@ static int omap2_mbox_fifo_full(struct omap_mbox *mbox)
 static void omap2_mbox_enable_irq(struct omap_mbox *mbox,
 		omap_mbox_type_t irq)
 {
-	struct omap_mbox2_priv *p = (struct omap_mbox2_priv *)mbox->priv;
+	struct omap_mbox2_priv *p = mbox->priv;
 	u32 l, bit = (irq = IRQ_TX) ? p->notfull_bit : p->newmsg_bit;
 
 	l = mbox_read_reg(p->irqenable);

@@ -192,7 +192,7 @@ static void omap2_mbox_enable_irq(struct omap_mbox *mbox,
 static void omap2_mbox_disable_irq(struct omap_mbox *mbox,
 		omap_mbox_type_t irq)
 {
-	struct omap_mbox2_priv *p = (struct omap_mbox2_priv *)mbox->priv;
+	struct omap_mbox2_priv *p = mbox->priv;
 	u32 l, bit = (irq = IRQ_TX) ? p->notfull_bit : p->newmsg_bit;
 	l = mbox_read_reg(p->irqdisable);
 	l &= ~bit;

@@ -202,7 +202,7 @@ static void omap2_mbox_disable_irq(struct omap_mbox *mbox,
 static void omap2_mbox_ack_irq(struct omap_mbox *mbox,
 		omap_mbox_type_t irq)
 {
-	struct omap_mbox2_priv *p = (struct omap_mbox2_priv *)mbox->priv;
+	struct omap_mbox2_priv *p = mbox->priv;
 	u32 bit = (irq = IRQ_TX) ? p->notfull_bit : p->newmsg_bit;
 
 	mbox_write_reg(bit, p->irqstatus);

@@ -214,7 +214,7 @@ static void omap2_mbox_ack_irq(struct omap_mbox *mbox,
 static int omap2_mbox_is_irq(struct omap_mbox *mbox,
 		omap_mbox_type_t irq)
 {
-	struct omap_mbox2_priv *p = (struct omap_mbox2_priv *)mbox->priv;
+	struct omap_mbox2_priv *p = mbox->priv;
 	u32 bit = (irq = IRQ_TX) ? p->notfull_bit : p->newmsg_bit;
 	u32 enable = mbox_read_reg(p->irqenable);
 	u32 status = mbox_read_reg(p->irqstatus);
Signature · 1 line
1.7.2.1
author
#3 lore raw

PATCH RESEND 2/3 powerpc: remove cast from void*

In reply to matt mooney

Unnecessary cast from void* in assignment.

Signed-off-by matt mooney <[email protected]>
---
 arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/platforms/pseries/hvCall_inst.c +1 -1
index e19ff02..f106662 100644
@@ -55,7 +55,7 @@ static void hc_stop(struct seq_file *m, void *p)
 static int hc_show(struct seq_file *m, void *p)
 {
 	unsigned long h_num = (unsigned long)p;
-	struct hcall_stats *hs = (struct hcall_stats *)m->private;
+	struct hcall_stats *hs = m->private;
 
 	if (hs[h_num].num_calls) {
 		if (cpu_has_feature(CPU_FTR_PURR))
Signature · 1 line
1.7.2.1
#4 lore raw

Re: [PATCH 2/3 RESEND] powerpc: remove cast from void*

In reply to matt mooney
Quoted 12 lines · matt mooney

Unnecessary cast from void* in assignment.

Signed-off-by matt mooney <[email protected]>
---
 arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/platforms/pseries/hvCall_inst.c +0 -0
index e19ff02..f106662 100644

arch/powerpc/platforms/pseries/hvCall_inst.c static void hc_stop(struct seq_file *m, void *p) · line 61

Quoted 8 lines
arch/powerpc/platforms/pseries/hvCall_inst.c +1 -1
@@ -55,7 +55,7 @@ static void hc_stop(struct seq_file *m, void *p)
 static int hc_show(struct seq_file *m, void *p)
 {
 	unsigned long h_num = (unsigned long)p;
-	struct hcall_stats *hs = (struct hcall_stats *)m->private;
+	struct hcall_stats *hs = m->private;
 
 	if (hs[h_num].num_calls) {
 		if (cpu_has_feature(CPU_FTR_PURR))

This doesn't seem to be present in 37-rc1, so I am taking it to trivial queue. If this has been already merged to another tree, let me know.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#5 lore raw

Re: [PATCH 2/3 RESEND] powerpc: remove cast from void*

Quoted 20 lines · Jiri Kosina
Quoted 18 lines · matt mooney

Unnecessary cast from void* in assignment.

Signed-off-by matt mooney <[email protected]>
---
 arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/platforms/pseries/hvCall_inst.c +1 -1
index e19ff02..f106662 100644
@@ -55,7 +55,7 @@ static void hc_stop(struct seq_file *m, void *p)
 static int hc_show(struct seq_file *m, void *p)
 {
 	unsigned long h_num = (unsigned long)p;
-	struct hcall_stats *hs = (struct hcall_stats *)m->private;
+	struct hcall_stats *hs = m->private;
Quoted 5 lines

arch/powerpc/platforms/pseries/hvCall_inst.c static void hc_stop(struct seq_file *m, void *p) · line 61

Quoted 2 lines
arch/powerpc/platforms/pseries/hvCall_inst.c +0 -0
 	if (hs[h_num].num_calls) {
 		if (cpu_has_feature(CPU_FTR_PURR))

This doesn't seem to be present in 37-rc1, so I am taking it to trivial queue. If this has been already merged to another tree, let me know.

Looks like I missed it, but Ack.

Cheers,
Ben.