drivers/input/serio: Use pr_fmt and pr_<level>
Subsystems (4)
cover drivers/input/serio: Use pr_fmt and pr_<level>
Standardize the logging messages a bit.
Joe Perches (2):
drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use drivers/input/serio: Use pr_fmt and pr_<level>
drivers/input/serio/ambakmi.c | 5 ++- drivers/input/serio/ct82c710.c | 10 ++-- drivers/input/serio/gscps2.c | 15 +++--- drivers/input/serio/hil_mlc.c | 17 +++--- drivers/input/serio/hp_sdc.c | 51 +++++++++--------- drivers/input/serio/hp_sdc_mlc.c | 46 ++++++++-------- drivers/input/serio/i8042-x86ia64io.h | 2 +- drivers/input/serio/i8042.c | 94 +++++++++++++++----------------- drivers/input/serio/i8042.h | 19 ++++--- drivers/input/serio/maceps2.c | 5 ++- drivers/input/serio/parkbd.c | 8 ++- drivers/input/serio/q40kbd.c | 6 ++- drivers/input/serio/rpckbd.c | 6 ++- drivers/input/serio/sa1111ps2.c | 11 +++-- drivers/input/serio/serio.c | 8 ++-- drivers/input/serio/serio_raw.c | 8 ++- drivers/input/serio/serport.c | 6 ++- 17 files changed, 167 insertions(+), 150 deletions(-)
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 1/2 drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use
Standardized message logging prefixes.
Removed \n from dbg macro, added \n to each dbg call site. A couple of uses of dbg already had a \n.
Removed direct use of __FILE__ from dbg, converted to pr_fmt(fmt) Added non-debug printf argument verification of dbg calls Removed "i8042.c" from printks, converted to pr_<level>
---
Changes from v1:
Changed one printk in i8042-x86ia6410.h
There are other printks in this file that use a PNP prefix that were not changed. If modified, these would have an "i8042: " prefix. Moved the dbg timestamp to the beginning of line.
drivers/input/serio/i8042-x86ia64io.h | 2 +- drivers/input/serio/i8042.c | 94 +++++++++++++++----------------- drivers/input/serio/i8042.h | 19 ++++--- 3 files changed, 57 insertions(+), 58 deletions(-)
drivers/input/serio/i8042-x86ia64io.h +1 -1
@@ -741,7 +741,7 @@ static int __init i8042_pnp_init(void)#endif if (i8042_nopnp) { -printk (KERN_INFO "i8042: PNP detection disabled\n" ); +pr_info ("PNP detection disabled\n" );return 0 ; }
drivers/input/serio/i8042.c +44 -50
309 lines not on this page · raw message
drivers/input/serio/i8042.h +12 -7
@@ -89,15 +89,20 @@#ifdef DEBUG static unsigned long i8042_start_time;#define dbg_init () do { i8042_start_time = jiffies; } while (0) -#define dbg(format, arg...) \ - do { \ - if (i8042_debug) \ - printk(KERN_DEBUG __FILE__ ": " format " [%d]\n" , \ - ## arg, (int) (jiffies - i8042_start_time)); \ - } while (0) +#define dbg(format, arg...) \ +do { \ + if (i8042_debug) \ + printk(KERN_DEBUG KBUILD_MODNAME ": [%d] " format, \ + (int)(jiffies - i8042_start_time), ##arg); \ +} while (0) +#else #define dbg_init () do { } while (0) -#define dbg(format, arg...) do {} while (0) +#define dbg(format, arg...) \ +do { \ + if (0) \ + printk(KERN_DEBUG pr_fmt(format), ##arg); \ +} while (0)#endif #endif /* _I8042_H */
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 2/2 drivers/input/serio: Use pr_fmt and pr_<level>
In reply to Joe PerchesRemove PREFIX and PFX defines and uses.
Keep "serio: " prefixes.
Add a missing newline to a message.
Compile tested x86 only.
--- drivers/input/serio/ambakmi.c | 5 +++- drivers/input/serio/ct82c710.c | 10 ++++--- drivers/input/serio/gscps2.c | 15 ++++++----- drivers/input/serio/hil_mlc.c | 17 ++++++------ drivers/input/serio/hp_sdc.c | 51 ++++++++++++++++++------------------- drivers/input/serio/hp_sdc_mlc.c | 46 ++++++++++++++++------------------ drivers/input/serio/i8042.c | 2 +- drivers/input/serio/maceps2.c | 5 +++- drivers/input/serio/parkbd.c | 8 +++-- drivers/input/serio/q40kbd.c | 6 +++- drivers/input/serio/rpckbd.c | 6 +++- drivers/input/serio/sa1111ps2.c | 11 +++++--- drivers/input/serio/serio.c | 8 +++--- drivers/input/serio/serio_raw.c | 8 +++-- drivers/input/serio/serport.c | 6 +++- 15 files changed, 111 insertions(+), 93 deletions(-)
drivers/input/serio/ambakmi.c +4 -1
@@ -9,6 +9,9 @@* the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. */ + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/module.h> #include <linux/init.h> #include <linux/serio.h>
@@ -82,7 +85,7 @@ static int amba_kmi_open(struct serio *io) ret =request_irq (kmi->irq, amba_kmi_int,0 ,"kmi-pl050" , kmi);if (ret) { -printk (KERN_ERR "kmi: failed to claim IRQ%d\n" , kmi->irq); +pr_err ("failed to claim IRQ%d\n" , kmi->irq);writeb (0 ,KMICR ); goto clk_disable; }
drivers/input/serio/ct82c710.c +6 -4
@@ -26,6 +26,8 @@* Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/delay.h> #include <linux/module.h> #include <linux/ioport.h>
@@ -98,12 +100,12 @@ static int ct82c170_wait(void)static void ct82c710_close (struct serio *serio) {if (ct82c170_wait ()) -printk (KERN_WARNING "ct82c710.c: Device busy in close()\n" ); +pr_warn ("Device busy in close()\n" );outb_p (inb_p (CT82C710_STATUS ) & ~(CT82C710_ENABLE |CT82C710_INTS_ON ),CT82C710_STATUS );if (ct82c170_wait ()) -printk (KERN_WARNING "ct82c710.c: Device busy in close()\n" ); +pr_warn ("Device busy in close()\n" );free_irq (CT82C710_IRQ ,NULL ); }
@@ -127,7 +129,7 @@ static int ct82c710_open(struct serio *serio)outb_p (status,CT82C710_STATUS );/* Enable interrupts */ while (ct82c170_wait ()) { -printk (KERN_ERR "ct82c710: Device busy in open()\n" ); +pr_err ("Device busy in open()\n" ); status &= ~(CT82C710_ENABLE |CT82C710_INTS_ON );outb_p (status,CT82C710_STATUS );free_irq (CT82C710_IRQ ,NULL );
@@ -239,7 +241,7 @@ static int __init ct82c710_init(void)serio_register_port (ct82c710_port); -printk (KERN_INFO "serio: C&T 82c710 mouse port at %#llx irq %d\n" , +pr_info ("serio: C&T 82c710 mouse port at %#llx irq %d\n" , (unsigned long long )CT82C710_DATA ,CT82C710_IRQ );return 0 ;
drivers/input/serio/gscps2.c +8 -7
@@ -22,6 +22,8 @@* was usable/enabled ?) */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/init.h> #include <linux/module.h> #include <linux/slab.h>
@@ -42,8 +44,6 @@ MODULE_DESCRIPTION("HP GSC PS2 port driver");MODULE_LICENSE ("GPL" );MODULE_DEVICE_TABLE (parisc, gscps2_device_tbl); -#define PFX "gscps2.c: " -/* * Driver constants */
@@ -151,7 +151,8 @@ static inline int gscps2_writeb_output(struct gscps2port *ps2port, u8 data)char *addr = ps2port->addr;if (!wait_TBE (addr)) { - printk(KERN_DEBUG PFX "timeout - could not write byte %#x\n", data); + printk(KERN_DEBUG pr_fmt("timeout - could not write byte %#x\n"), + data);return 0 ; }
@@ -287,7 +288,7 @@ static int gscps2_write(struct serio *port, unsigned char data)struct gscps2port *ps2port = port->port_data;if (!gscps2_writeb_output (ps2port, data)) { - printk(KERN_DEBUG PFX "sending byte %#x failed.\n", data); + printk(KERN_DEBUG pr_fmt("sending byte %#x failed\n"), data);return -1 ; }return 0 ;
@@ -373,8 +374,8 @@ static int __devinit gscps2_probe(struct parisc_device *dev) goto fail_miserably;if (ps2port->id !=GSC_ID_KEYBOARD && ps2port->id !=GSC_ID_MOUSE ) { - printk(KERN_WARNING PFX "Unsupported PS/2 port at 0x%08lx (id=%d) ignored\n", - hpa, ps2port->id); +pr_warn ("Unsupported PS/2 port at 0x%08lx (id=%d) ignored\n" , + hpa, ps2port->id); ret = -ENODEV ; goto fail; }
@@ -384,7 +385,7 @@ static int __devinit gscps2_probe(struct parisc_device *dev) goto fail;#endif - printk(KERN_INFO "serio: %s port at 0x%p irq %d @ %s\n", + pr_info("serio: %s port at 0x%p irq %d @ %s\n", ps2port->port->name, ps2port->addr, ps2port->padev->irq,
drivers/input/serio/hil_mlc.c +8 -9
@@ -52,6 +52,8 @@* and to initiate probes of the loop for new devices. */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/hil_mlc.h> #include <linux/errno.h> #include <linux/kernel.h>
@@ -69,8 +71,6 @@ MODULE_LICENSE("Dual BSD/GPL");EXPORT_SYMBOL (hil_mlc_register);EXPORT_SYMBOL (hil_mlc_unregister); -#define PREFIX "HIL MLC: " -static LIST_HEAD (hil_mlcs);static DEFINE_RWLOCK (hil_mlcs_lock);static struct timer_list hil_mlcs_kicker;
@@ -248,7 +248,7 @@ static int hilse_match(hil_mlc *mlc, int unused) goto err;#ifdef HIL_MLC_DEBUG - printk(KERN_DEBUG PREFIX "new in slot %i\n", rc); + printk(KERN_DEBUG pr_fmt("new in slot %i\n"), rc);#endif hil_mlc_copy_di_scratch (mlc, rc); mlc->di_map[mlc->ddi] = rc;
@@ -260,14 +260,14 @@ static int hilse_match(hil_mlc *mlc, int unused) mlc->di_map[mlc->ddi] = rc;#ifdef HIL_MLC_DEBUG - printk(KERN_DEBUG PREFIX "same in slot %i\n", rc); + printk(KERN_DEBUG pr_fmt("same in slot %i\n"), rc);#endif mlc->serio_map[rc].di_revmap = mlc->ddi;hil_mlc_clean_serio_map (mlc);return 0 ; err: - printk(KERN_ERR PREFIX "Residual device slots exhausted, close some serios!\n"); +pr_err ("Residual device slots exhausted, close some serios!\n" );return 1 ; }
@@ -419,8 +419,7 @@ static int hilse_take_rnm(hil_mlc *mlc, int unused) mlc->di_scratch.rnm[i] = mlc->ipacket[i] &HIL_PKT_DATA_MASK ; - printk(KERN_INFO PREFIX "Device name gotten: %16s\n", - mlc->di_scratch.rnm); +pr_info ("Device name gotten: %16s\n" , mlc->di_scratch.rnm);return 0 ; }
@@ -626,7 +625,7 @@ static int hilse_donode(hil_mlc *mlc)#ifdef HIL_MLC_DEBUG if (mlc->seidx && mlc->seidx != seidx && mlc->seidx !=41 && mlc->seidx !=42 && mlc->seidx !=43 ) { - printk(KERN_DEBUG PREFIX "z%i \n {%i}", doze, mlc->seidx); + printk(KERN_DEBUG pr_fmt("z%i {%i}\n)", doze, mlc->seidx); doze =0 ; }
@@ -776,7 +775,7 @@ static void hil_mlcs_process(unsigned long unused)if (mlc->seidx !=41 && mlc->seidx !=42 && mlc->seidx !=43 ) - printk(KERN_DEBUG PREFIX " + "); +printk (KERN_CONT " + " );#endif } }
drivers/input/serio/hp_sdc.c +25 -26
162 lines not on this page · raw message
drivers/input/serio/hp_sdc_mlc.c +22 -24
120 lines not on this page · raw message
drivers/input/serio/i8042.c +1 -1
@@ -772,7 +772,7 @@ static int __init i8042_check_aux(void)if (i8042_toggle_aux (false)) {pr_warn ("Failed to disable AUX port, but continuing anyway... Is this a SiS?\n" ); -pr_warn ("If AUX port is really absent please use the 'i8042.noaux' option.\n" ); +pr_warn ("If AUX port is really absent please use the 'i8042.noaux' option\n" ); }if (i8042_toggle_aux (true))
drivers/input/serio/maceps2.c +4 -1
@@ -7,6 +7,9 @@* it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation */ + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/module.h> #include <linux/init.h> #include <linux/serio.h>
@@ -91,7 +94,7 @@ static int maceps2_open(struct serio *dev)struct maceps2_data *data = (struct maceps2_data *)dev->port_data;if (request_irq (data->irq, maceps2_interrupt,0 ,"PS2 port" , dev)) { -printk (KERN_ERR "Could not allocate PS/2 IRQ\n" ); +pr_err ("Could not allocate PS/2 IRQ\n" );return -EBUSY ; }
drivers/input/serio/parkbd.c +5 -3
@@ -44,6 +44,8 @@* with 300 mA power reqirement of a typical AT keyboard. */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/module.h> #include <linux/parport.h> #include <linux/slab.h>
@@ -148,7 +150,7 @@ static int parkbd_getport(void) pp =parport_find_number (parkbd_pp_no);if (pp ==NULL ) { -printk (KERN_ERR "parkbd: no such parport\n" ); +pr_err ("no such parport\n" );return -ENODEV ; }
@@ -201,8 +203,8 @@ static int __init parkbd_init(void)serio_register_port (parkbd_port); -printk (KERN_INFO "serio: PARKBD %s adapter on %s\n" , - parkbd_mode ?"AT" :"XT" , parkbd_dev->port->name); +pr_info ("serio: PARKBD %s adapter on %s\n" , + parkbd_mode ?"AT" :"XT" , parkbd_dev->port->name);return 0 ; }
drivers/input/serio/q40kbd.c +4 -2
@@ -29,6 +29,8 @@* Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/module.h> #include <linux/init.h> #include <linux/serio.h>
@@ -95,7 +97,7 @@ static int q40kbd_open(struct serio *port)q40kbd_flush ();if (request_irq (Q40_IRQ_KEYBOARD , q40kbd_interrupt,0 ,"q40kbd" ,NULL )) { -printk (KERN_ERR "q40kbd.c: Can't get irq %d.\n" ,Q40_IRQ_KEYBOARD ); +pr_err ("Can't get irq %d\n" ,Q40_IRQ_KEYBOARD );return -EBUSY ; }
@@ -129,7 +131,7 @@ static int __devinit q40kbd_probe(struct platform_device *dev)strlcpy (q40kbd_port->phys,"Q40" ,sizeof (q40kbd_port->phys));serio_register_port (q40kbd_port); -printk (KERN_INFO "serio: Q40 kbd registered\n" ); +pr_info ("serio: Q40 kbd registered\n" );return 0 ; }
drivers/input/serio/rpckbd.c +4 -2
@@ -27,6 +27,8 @@* Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/module.h> #include <linux/interrupt.h> #include <linux/init.h>
@@ -84,12 +86,12 @@ static int rpckbd_open(struct serio *port)iomd_readb (IOMD_KARTRX );if (request_irq (IRQ_KEYBOARDRX , rpckbd_rx,0 ,"rpckbd" , port) !=0 ) { -printk (KERN_ERR "rpckbd.c: Could not allocate keyboard receive IRQ\n" ); +pr_err ("Could not allocate keyboard receive IRQ\n" );return -EBUSY ; }if (request_irq (IRQ_KEYBOARDTX , rpckbd_tx,0 ,"rpckbd" , port) !=0 ) { -printk (KERN_ERR "rpckbd.c: Could not allocate keyboard transmit IRQ\n" ); +pr_err ("Could not allocate keyboard transmit IRQ\n" );free_irq (IRQ_KEYBOARDRX ,NULL );return -EBUSY ; }
drivers/input/serio/sa1111ps2.c +7 -4
@@ -7,6 +7,9 @@* it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License. */ + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/module.h> #include <linux/init.h> #include <linux/input.h>
@@ -129,16 +132,16 @@ static int ps2_open(struct serio *io) ret =request_irq (ps2if->dev->irq[0 ], ps2_rxint,0 ,SA1111_DRIVER_NAME (ps2if->dev), ps2if);if (ret) { -printk (KERN_ERR "sa1111ps2: could not allocate IRQ%d: %d\n" , - ps2if->dev->irq[0 ], ret); +pr_err ("could not allocate IRQ%d: %d\n" , + ps2if->dev->irq[0 ], ret);return ret; } ret =request_irq (ps2if->dev->irq[1 ], ps2_txint,0 ,SA1111_DRIVER_NAME (ps2if->dev), ps2if);if (ret) { -printk (KERN_ERR "sa1111ps2: could not allocate IRQ%d: %d\n" , - ps2if->dev->irq[1 ], ret); +pr_err ("could not allocate IRQ%d: %d\n" , + ps2if->dev->irq[1 ], ret);free_irq (ps2if->dev->irq[0 ], ps2if);return ret; }
drivers/input/serio/serio.c +4 -4
@@ -200,8 +200,8 @@ static int serio_queue_event(void *object, struct module *owner, }if (!try_module_get (owner)) { -pr_warning ("Can't get module reference, dropping event %d\n" , - event_type); +pr_warn ("Can't get module reference, dropping event %d\n" , + event_type);kfree (event); retval = -EINVAL ; goto out;
@@ -818,8 +818,8 @@ static void serio_attach_driver(struct serio_driver *drv) error =driver_attach (&drv->driver);if (error) -pr_warning ("driver_attach() failed for %s with error %d\n" , - drv->driver.name, error); +pr_warn ("driver_attach() failed for %s with error %d\n" , + drv->driver.name, error); }int __serio_register_driver (struct serio_driver *drv,struct module *owner,const char *mod_name)
drivers/input/serio/serio_raw.c +5 -3
@@ -9,6 +9,8 @@* the Free Software Foundation. */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/sched.h> #include <linux/slab.h> #include <linux/smp_lock.h>
@@ -277,7 +279,7 @@ static int serio_raw_connect(struct serio *serio, struct serio_driver *drv)int err;if (!(serio_raw =kzalloc (sizeof (struct serio_raw ),GFP_KERNEL ))) { -printk (KERN_ERR "serio_raw.c: can't allocate memory for a device\n" ); +pr_err ("can't allocate memory for a device\n" );return -ENOMEM ; }
@@ -309,12 +311,12 @@ static int serio_raw_connect(struct serio *serio, struct serio_driver *drv) }if (err) { -printk (KERN_INFO "serio_raw: failed to register raw access device for %s\n" , +pr_info ("failed to register raw access device for %s\n" , serio->phys); goto out_close; } -printk (KERN_INFO "serio_raw: raw access enabled on %s (%s, minor %d)\n" , +pr_info ("raw access enabled on %s (%s, minor %d)\n" , serio->phys, serio_raw->name, serio_raw->dev.minor); goto out;
drivers/input/serio/serport.c +4 -2
@@ -13,6 +13,8 @@* the Free Software Foundation. */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <asm/uaccess.h> #include <linux/kernel.h> #include <linux/sched.h>
@@ -168,7 +170,7 @@ static ssize_t serport_ldisc_read(struct tty_struct * tty, struct file * file, u serio->dev.parent = tty->dev;serio_register_port (serport->serio); -printk (KERN_INFO "serio: Serial port %s\n" ,tty_name (tty, name)); +pr_info ("serio: Serial port %s\n" ,tty_name (tty, name));wait_event_interruptible (serport->wait,test_bit (SERPORT_DEAD , &serport->flags));serio_unregister_port (serport->serio);
@@ -238,7 +240,7 @@ static int __init serport_init(void)int retval; retval =tty_register_ldisc (N_MOUSE , &serport_ldisc);if (retval) -printk (KERN_ERR "serport.c: Error registering line discipline.\n" ); +pr_err ("Error registering line discipline\n" );return retval; }
Signature · 1 line
1.7.3.1.g432b3.dirty