remove unnecessary semicolons
Subsystems (49)
cover remove unnecessary semicolons
ya trivial series...
Joe Perches (44):
arch/arm: Remove unnecessary semicolons arch/microblaze: Remove unnecessary semicolons arch/um: Remove unnecessary semicolons drivers/cpufreq: Remove unnecessary semicolons drivers/gpio: Remove unnecessary semicolons drivers/i2c: Remove unnecessary semicolons drivers/isdn: Remove unnecessary semicolons drivers/leds: Remove unnecessary semicolons drivers/media/video: Remove unnecessary semicolons drivers/misc: Remove unnecessary semicolons drivers/mmc: Remove unnecessary semicolons drivers/net/bnx2x: Remove unnecessary semicolons drivers/net/e1000e: Remove unnecessary semicolons drivers/net/ixgbe: Remove unnecessary semicolons drivers/net/vxge: Remove unnecessary semicolons drivers/net/wireless/ath: Remove unnecessary semicolons drivers/net/wireless/iwlwifi: Remove unnecessary semicolons drivers/net/cnic.c: Remove unnecessary semicolons drivers/platform/x86: Remove unnecessary semicolons drivers/power: Remove unnecessary semicolons drivers/s390/net: Remove unnecessary semicolons drivers/scsi/be2iscsi: Remove unnecessary semicolons drivers/scsi/bfa: Remove unnecessary semicolons drivers/scsi/lpfc: Remove unnecessary semicolons drivers/scsi/pm8001: Remove unnecessary semicolons drivers/scsi/qla2xxx: Remove unnecessary semicolons drivers/serial: Remove unnecessary semicolons drivers/spi: Remove unnecessary semicolons drivers/staging: Remove unnecessary semicolons drivers/usb/gadget: Remove unnecessary semicolons drivers/xen: Remove unnecessary semicolons
fs/9p: Remove unnecessary semicolons
fs/ceph: Remove unnecessary semicolons
fs/logfs: Remove unnecessary semicolons
fs/nfs: Remove unnecessary semicolons
fs/ocfs2: Remove unnecessary semicolons
fs/ubifs: Remove unnecessary semicolons include/linux/if_macvlan.h: Remove unnecessary semicolons include/net/caif/cfctrl.h: Remove unnecessary semicolons mm/hugetlb.c: Remove unnecessary semicolons net/ipv6/mcast.c: Remove unnecessary semicolons net/sunrpc/addr.c: Remove unnecessary semicolons sound/core/pcm_lib.c: Remove unnecessary semicolons sound/soc/codecs: Remove unnecessary semicolons
arch/arm/mach-at91/at91cap9_devices.c | 2 +- arch/arm/mach-at91/at91sam9g45_devices.c | 2 +- arch/arm/mach-at91/at91sam9rl_devices.c | 2 +- arch/arm/mach-nuc93x/time.c | 2 +- arch/arm/mach-tegra/tegra2_clocks.c | 2 +- arch/arm/mach-w90x900/cpu.c | 2 +- arch/arm/plat-mxc/irq.c | 2 +- arch/microblaze/lib/memmove.c | 2 +- arch/um/drivers/mmapper_kern.c | 2 +- drivers/cpufreq/cpufreq_conservative.c | 2 +- drivers/gpio/langwell_gpio.c | 2 +- drivers/i2c/busses/i2c-designware.c | 2 +- drivers/isdn/hardware/mISDN/mISDNinfineon.c | 4 ++-- drivers/isdn/hardware/mISDN/mISDNisar.c | 2 +- drivers/leds/leds-mc13783.c | 2 +- drivers/media/video/cx88/cx88-blackbird.c | 2 +- drivers/media/video/davinci/vpfe_capture.c | 2 +- drivers/media/video/em28xx/em28xx-cards.c | 2 +- drivers/misc/bmp085.c | 2 +- drivers/misc/isl29020.c | 2 +- drivers/mmc/host/davinci_mmc.c | 2 +- drivers/net/bnx2x/bnx2x_link.c | 4 ++-- drivers/net/bnx2x/bnx2x_main.c | 2 +- drivers/net/cnic.c | 2 +- drivers/net/e1000e/netdev.c | 2 +- drivers/net/ixgbe/ixgbe_sriov.c | 2 +- drivers/net/vxge/vxge-main.c | 2 +- drivers/net/wireless/ath/ath9k/htc.h | 2 +- drivers/net/wireless/iwlwifi/iwl-agn.c | 2 +- drivers/platform/x86/classmate-laptop.c | 2 +- drivers/platform/x86/thinkpad_acpi.c | 2 +- drivers/power/intel_mid_battery.c | 2 +- drivers/s390/net/qeth_core_sys.c | 2 +- drivers/scsi/be2iscsi/be_main.c | 4 ++-- drivers/scsi/bfa/bfa_fcs_lport.c | 2 +- drivers/scsi/lpfc/lpfc_bsg.c | 2 +- drivers/scsi/pm8001/pm8001_init.c | 2 +- drivers/scsi/qla2xxx/qla_isr.c | 4 ++-- drivers/scsi/qla2xxx/qla_nx.c | 2 +- drivers/serial/mrst_max3110.c | 2 +- drivers/spi/amba-pl022.c | 2 +- drivers/spi/spi_nuc900.c | 2 +- .../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 2 +- drivers/staging/ath6kl/os/linux/ar6000_drv.c | 2 +- drivers/staging/bcm/InterfaceInit.c | 2 +- drivers/staging/bcm/InterfaceIsr.c | 2 +- drivers/staging/bcm/Misc.c | 4 ++-- .../comedi/drivers/addi-data/APCI1710_Tor.c | 2 +- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 2 +- .../comedi/drivers/addi-data/hwdrv_apci1516.c | 2 +- .../comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- drivers/staging/comedi/drivers/amplc_pci230.c | 2 +- drivers/staging/comedi/drivers/cb_das16_cs.c | 2 +- drivers/staging/comedi/drivers/comedi_bond.c | 2 +- drivers/staging/crystalhd/crystalhd_hw.c | 2 +- drivers/staging/go7007/go7007-driver.c | 2 +- drivers/staging/iio/accel/lis3l02dq_ring.c | 2 +- .../staging/intel_sst/intel_sst_drv_interface.c | 4 ++-- drivers/staging/keucr/smilmain.c | 4 ++-- drivers/staging/keucr/smilsub.c | 4 ++-- drivers/staging/msm/lcdc_toshiba_wvga_pt.c | 2 +- drivers/staging/rt2860/common/cmm_data_pci.c | 4 ++-- drivers/staging/rt2860/rt_linux.c | 2 +- drivers/staging/rt2860/rtmp.h | 2 +- drivers/staging/rtl8192e/ieee80211/ieee80211_tx.c | 2 +- drivers/staging/rtl8192e/r819xE_phy.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 2 +- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging/rtl8712/rtl8712_efuse.c | 2 +- drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- drivers/staging/tidspbridge/core/tiomap3430.c | 4 ++-- drivers/staging/tidspbridge/rmgr/nldr.c | 2 +- drivers/staging/vt6655/card.c | 2 +- drivers/staging/vt6655/iwctl.c | 2 +- drivers/staging/vt6655/wpa2.c | 4 ++-- drivers/staging/vt6656/baseband.c | 2 +- drivers/staging/vt6656/iwctl.c | 2 +- drivers/staging/vt6656/power.c | 2 +- drivers/staging/vt6656/wpa2.c | 4 ++-- drivers/usb/gadget/f_fs.c | 2 +- drivers/xen/swiotlb-xen.c | 2 +- fs/9p/acl.c | 2 +- fs/9p/xattr.c | 2 +- fs/ceph/mds_client.c | 2 +- fs/logfs/readwrite.c | 2 +- fs/nfs/getroot.c | 2 +- fs/ocfs2/refcounttree.c | 2 +- fs/ubifs/scan.c | 2 +- include/linux/if_macvlan.h | 2 +- include/net/caif/cfctrl.h | 2 +- mm/hugetlb.c | 2 +- net/ipv6/mcast.c | 2 +- net/sunrpc/addr.c | 2 +- sound/core/pcm_lib.c | 2 +- sound/soc/codecs/wm8904.c | 2 +- sound/soc/codecs/wm8940.c | 1 - sound/soc/codecs/wm8993.c | 2 +- sound/soc/codecs/wm_hubs.c | 2 +- 100 files changed, 111 insertions(+), 112 deletions(-)
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 1/44 arch/arm: Remove unnecessary semicolons
--- arch/arm/mach-at91/at91cap9_devices.c | 2 +- arch/arm/mach-at91/at91sam9g45_devices.c | 2 +- arch/arm/mach-at91/at91sam9rl_devices.c | 2 +- arch/arm/mach-nuc93x/time.c | 2 +- arch/arm/mach-tegra/tegra2_clocks.c | 2 +- arch/arm/mach-w90x900/cpu.c | 2 +- arch/arm/plat-mxc/irq.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)
arch/arm/mach-at91/at91cap9_devices.c +1 -1
@@ -171,7 +171,7 @@ void __init at91_add_device_usba(struct usba_platform_data *data)*/ usba_udc_data.pdata.vbus_pin = -EINVAL ; usba_udc_data.pdata.num_ep =ARRAY_SIZE (usba_udc_ep); -memcpy (usba_udc_data.ep, usba_udc_ep,sizeof (usba_udc_ep));; +memcpy (usba_udc_data.ep, usba_udc_ep,sizeof (usba_udc_ep));if (data && data->vbus_pin >0 ) {at91_set_gpio_input (data->vbus_pin,0 );
arch/arm/mach-at91/at91sam9g45_devices.c +1 -1
@@ -256,7 +256,7 @@ void __init at91_add_device_usba(struct usba_platform_data *data) { usba_udc_data.pdata.vbus_pin = -EINVAL ; usba_udc_data.pdata.num_ep =ARRAY_SIZE (usba_udc_ep); -memcpy (usba_udc_data.ep, usba_udc_ep,sizeof (usba_udc_ep));; +memcpy (usba_udc_data.ep, usba_udc_ep,sizeof (usba_udc_ep));if (data && data->vbus_pin >0 ) {at91_set_gpio_input (data->vbus_pin,0 );
arch/arm/mach-at91/at91sam9rl_devices.c +1 -1
@@ -145,7 +145,7 @@ void __init at91_add_device_usba(struct usba_platform_data *data)*/ usba_udc_data.pdata.vbus_pin = -EINVAL ; usba_udc_data.pdata.num_ep =ARRAY_SIZE (usba_udc_ep); -memcpy (usba_udc_data.ep, usba_udc_ep,sizeof (usba_udc_ep));; +memcpy (usba_udc_data.ep, usba_udc_ep,sizeof (usba_udc_ep));if (data && data->vbus_pin >0 ) {at91_set_gpio_input (data->vbus_pin,0 );
arch/arm/mach-nuc93x/time.c +1 -1
@@ -82,7 +82,7 @@ static void nuc93x_timer_setup(void) timer0_load = (rate /TICKS_PER_SEC );__raw_writel (timer0_load,REG_TICR0 ); - val |= (PERIOD |COUNTEN |INTEN |PRESCALE );; + val |= (PERIOD |COUNTEN |INTEN |PRESCALE );__raw_writel (val,REG_TCSR0 ); }
arch/arm/mach-tegra/tegra2_clocks.c +1 -1
@@ -293,7 +293,7 @@ static int tegra2_super_clk_set_parent(struct clk *c, struct clk *p)const struct clk_mux_sel *sel;int shift; - val =clk_readl (c->reg +SUPER_CLK_MUX );; + val =clk_readl (c->reg +SUPER_CLK_MUX );BUG_ON (((val &SUPER_STATE_MASK ) !=SUPER_STATE_RUN ) && ((val &SUPER_STATE_MASK ) !=SUPER_STATE_IDLE )); shift = ((val & SUPER_STATE_MASK) == SUPER_STATE_IDLE) ?
arch/arm/mach-w90x900/cpu.c +1 -1
@@ -60,7 +60,7 @@ static DEFINE_CLK(emc, 7); static DEFINE_SUBCLK(rmii, 2); static DEFINE_CLK(usbd, 8); static DEFINE_CLK(usbh, 9); -static DEFINE_CLK(g2d, 10);; +static DEFINE_CLK(g2d, 10); static DEFINE_CLK(pwm, 18); static DEFINE_CLK(ps2, 24); static DEFINE_CLK(kpi, 25);
arch/arm/plat-mxc/irq.c +1 -1
@@ -53,7 +53,7 @@ int imx_irq_set_priority(unsigned char irq, unsigned char prio)unsigned int mask =0x0F << irq %8 *4 ;if (irq >=MXC_INTERNAL_IRQS ) -return -EINVAL ;; +return -EINVAL ; temp =__raw_readl (avic_base +AVIC_NIPRIORITY (irq /8 )); temp &= ~mask;
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 2/44 arch/microblaze: Remove unnecessary semicolons
In reply to Joe Perches--- arch/microblaze/lib/memmove.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/microblaze/lib/memmove.c +1 -1
@@ -182,7 +182,7 @@ void *memmove(void *v_dst, const void *v_src, __kernel_size_t c)for (; c >=4 ; c -=4 ) { value = *--i_src; *--i_dst = buf_hold | ((value &0xFF000000 )>>24 ); - buf_hold = (value &0xFFFFFF ) <<8 ;; + buf_hold = (value &0xFFFFFF ) <<8 ; }#endif /* Realign the source */
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 02/44] arch/microblaze: Remove unnecessary semicolons
Quoted 4 lines · Joe Perches
Signed-off-by Joe Perches <[email protected]>--- arch/microblaze/lib/memmove.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied.
Thanks,
Michal
Quoted 14 lines
arch/microblaze/lib/memmove.c +1
-1@@ -182,7 +182,7 @@ void *memmove(void *v_dst, const void *v_src, __kernel_size_t c)for (; c >=4 ; c -=4 ) { value = *--i_src; *--i_dst = buf_hold | ((value &0xFF000000 )>>24 ); - buf_hold = (value &0xFFFFFF ) <<8 ;; + buf_hold = (value &0xFFFFFF ) <<8 ; }#endif /* Realign the source */
Signature · 4 lines
Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian
PATCH 3/44 arch/um: Remove unnecessary semicolons
In reply to Joe Perches--- arch/um/drivers/mmapper_kern.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/drivers/mmapper_kern.c +1 -1
@@ -122,7 +122,7 @@ static int __init mmapper_init(void)if (err) {printk (KERN_ERR "mmapper - misc_register failed, err = %d\n" , err); -return err;; +return err; }return 0 ; }
Signature · 13 lines
1.7.3.1.g432b3.dirty ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
PATCH 4/44 drivers/cpufreq: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/cpufreq/cpufreq_conservative.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/cpufreq/cpufreq_conservative.c +1 -1
@@ -118,7 +118,7 @@ static inline cputime64_t get_cpu_idle_time_jiffy(unsigned int cpu,if (wall) *wall = (cputime64_t )jiffies_to_usecs (cur_wall_time); -return (cputime64_t )jiffies_to_usecs (idle_time);; +return (cputime64_t )jiffies_to_usecs (idle_time); }static inline cputime64_t get_cpu_idle_time (unsigned int cpu,cputime64_t *wall)
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 5/44 drivers/gpio: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/gpio/langwell_gpio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpio/langwell_gpio.c +1 -1
@@ -122,7 +122,7 @@ static int lnw_gpio_direction_output(struct gpio_chip *chip,lnw_gpio_set (chip, offset, value);spin_lock_irqsave (&lnw->lock, flags); value =readl (gpdr); - value |=BIT (offset %32 );; + value |=BIT (offset %32 );writel (value, gpdr);spin_unlock_irqrestore (&lnw->lock, flags);return 0 ;
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 6/44 drivers/i2c: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/i2c/busses/i2c-designware.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-designware.c +1 -1
@@ -390,7 +390,7 @@ i2c_dw_xfer_msg(struct dw_i2c_dev *dev)int tx_limit, rx_limit;u32 addr = msgs[dev->msg_write_idx].addr;u32 buf_len = dev->tx_buf_len; -u8 *buf = dev->tx_buf;; +u8 *buf = dev->tx_buf; intr_mask =DW_IC_INTR_DEFAULT_MASK ;
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 7/44 drivers/isdn: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/isdn/hardware/mISDN/mISDNinfineon.c | 4 ++-- drivers/isdn/hardware/mISDN/mISDNisar.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/isdn/hardware/mISDN/mISDNinfineon.c +2 -2
@@ -420,7 +420,7 @@ enable_hwirq(struct inf_hw *hw)break ;case INF_NICCY : val =inl ((u32 )hw->cfg.start +NICCY_IRQ_CTRL_REG ); - val |=NICCY_IRQ_ENABLE ;; + val |=NICCY_IRQ_ENABLE ;outl (val, (u32 )hw->cfg.start +NICCY_IRQ_CTRL_REG );break ;case INF_SCT_1 :
@@ -924,7 +924,7 @@ setup_instance(struct inf_hw *card)mISDNipac_init (&card->ipac, card);if (card->ipac.isac.dch.dev.Bprotocols ==0 ) - goto error_setup;; + goto error_setup; err =mISDN_register_device (&card->ipac.isac.dch.dev, &card->pdev->dev, card->name);
drivers/isdn/hardware/mISDN/mISDNisar.c +1 -1
@@ -264,7 +264,7 @@ load_firmware(struct isar_hw *isar, const u8 *buf, int size)while (noc) { val =le16_to_cpu (*sp++); *mp++ = val >>8 ; - *mp++ = val &0xFF ;; + *mp++ = val &0xFF ; noc--; }spin_lock_irqsave (isar->hwlock, flags);
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 07/44] drivers/isdn: Remove unnecessary semicolons
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:26 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Applied.
PATCH 8/44 drivers/leds: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/leds/leds-mc13783.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/leds-mc13783.c +1 -1
@@ -234,7 +234,7 @@ static int __devinit mc13783_leds_prepare(struct platform_device *pdev) MC13783_LED_Cx_PERIOD;if (pdata->flags &MC13783_LED_TRIODE_TC3 ) - reg |= MC13783_LED_Cx_TRIODE_TC_BIT;; + reg |= MC13783_LED_Cx_TRIODE_TC_BIT; ret =mc13783_reg_write (dev,MC13783_REG_LED_CONTROL_5 , reg);if (ret)
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 9/44 drivers/media/video: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/media/video/cx88/cx88-blackbird.c | 2 +- drivers/media/video/davinci/vpfe_capture.c | 2 +- drivers/media/video/em28xx/em28xx-cards.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/media/video/cx88/cx88-blackbird.c +1 -1
@@ -1065,7 +1065,7 @@ static int mpeg_open(struct file *file) err = drv->request_acquire (drv);if (err !=0 ) {dprintk (1 ,"%s: Unable to acquire hardware, %d\n" , __func__, err); -mutex_unlock (&dev->core->lock);; +mutex_unlock (&dev->core->lock);return err; } }
drivers/media/video/davinci/vpfe_capture.c +1 -1
@@ -1276,7 +1276,7 @@ static int vpfe_videobuf_prepare(struct videobuf_queue *vq, vb->size = vpfe_dev->fmt.fmt.pix.sizeimage; vb->field = field; - ret =videobuf_iolock (vq, vb,NULL );; + ret =videobuf_iolock (vq, vb,NULL );if (ret <0 )return ret;
drivers/media/video/em28xx/em28xx-cards.c +1 -1
@@ -2408,7 +2408,7 @@ void em28xx_register_i2c_ir(struct em28xx *dev) dev->init_data.get_key = em28xx_get_key_em_haup; dev->init_data.name ="i2c IR (EM2840 Hauppauge)" ;case EM2820_BOARD_LEADTEK_WINFAST_USBII_DELUXE : - dev->init_data.ir_codes =RC_MAP_WINFAST_USBII_DELUXE ;; + dev->init_data.ir_codes =RC_MAP_WINFAST_USBII_DELUXE ; dev->init_data.get_key = em28xx_get_key_winfast_usbii_deluxe; dev->init_data.name ="i2c IR (EM2820 Winfast TV USBII Deluxe)" ;break ;
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 10/44 drivers/misc: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/misc/bmp085.c | 2 +- drivers/misc/isl29020.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/misc/bmp085.c +1 -1
@@ -216,7 +216,7 @@ static s32 bmp085_get_temperature(struct bmp085_data *data, int *temperature) *temperature = (x1+x2+8 ) >>4 ; exit: -return status;; +return status; }/*
drivers/misc/isl29020.c +1 -1
@@ -158,7 +158,7 @@ static int als_set_default_config(struct i2c_client *client)dev_err (&client->dev,"default write failed." );return retval; } -return 0 ;; +return 0 ; } static int isl29020_probe(struct i2c_client *client,
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 11/44 drivers/mmc: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/mmc/host/davinci_mmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/davinci_mmc.c +1 -1
@@ -480,7 +480,7 @@ static void mmc_davinci_send_dma_request(struct mmc_davinci_host *host,struct scatterlist *sg;unsigned sg_len;unsigned bytes_left = host->bytes_left; -const unsigned shift =ffs (rw_threshold) -1 ;; +const unsigned shift =ffs (rw_threshold) -1 ;if (host->data_dir ==DAVINCI_MMC_DATADIR_WRITE ) { template = &host->tx_template;
Signature · 1 line
1.7.3.1.g432b3.dirty
Chris Ball
AppliedRe: [PATCH 11/44] drivers/mmc: Remove unnecessary semicolons
Hi Joe,
Quoted 11 lines · Joe Perches
Signed-off-by Joe Perches <[email protected]>--- drivers/mmc/host/davinci_mmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mmc/host/davinci_mmc.c +0
-0
drivers/mmc/host/davinci_mmc.c static void mmc_davinci_send_dma_request(struct mmc_davinci_host *host, · line 486
Quoted 8 lines
drivers/mmc/host/davinci_mmc.c +1
-1@@ -480,7 +480,7 @@ static void mmc_davinci_send_dma_request(struct mmc_davinci_host *host,struct scatterlist *sg;unsigned sg_len;unsigned bytes_left = host->bytes_left; -const unsigned shift =ffs (rw_threshold) -1 ;; +const unsigned shift =ffs (rw_threshold) -1 ;if (host->data_dir ==DAVINCI_MMC_DATADIR_WRITE ) { template = &host->tx_template;
Pushed to mmc-next for .38, thanks.
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child
PATCH 12/44 drivers/net/bnx2x: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/net/bnx2x/bnx2x_link.c | 4 ++-- drivers/net/bnx2x/bnx2x_main.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/bnx2x/bnx2x_link.c +2 -2
@@ -3904,7 +3904,7 @@ static u8 bnx2x_8726_read_sfp_module_eeprom(struct bnx2x_phy *phy, MDIO_PMA_REG_SFP_TWO_WIRE_CTRL, &val);if ((val &MDIO_PMA_REG_SFP_TWO_WIRE_CTRL_STATUS_MASK ) ==MDIO_PMA_REG_SFP_TWO_WIRE_STATUS_IDLE ) -return 0 ;; +return 0 ;msleep (1 ); }return -EINVAL ;
@@ -3988,7 +3988,7 @@ static u8 bnx2x_8727_read_sfp_module_eeprom(struct bnx2x_phy *phy, MDIO_PMA_REG_SFP_TWO_WIRE_CTRL, &val);if ((val &MDIO_PMA_REG_SFP_TWO_WIRE_CTRL_STATUS_MASK ) ==MDIO_PMA_REG_SFP_TWO_WIRE_STATUS_IDLE ) -return 0 ;; +return 0 ;msleep (1 ); }
drivers/net/bnx2x/bnx2x_main.c +1 -1
@@ -8078,7 +8078,7 @@ static void __devinit bnx2x_get_port_hwinfo(struct bnx2x *bp)int port =BP_PORT (bp);u32 val, val2;u32 config; -u32 ext_phy_type, ext_phy_config;; +u32 ext_phy_type, ext_phy_config; bp->link_params.bp = bp; bp->link_params.port = port;
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 12/44] drivers/net/bnx2x: Remove unnecessary semicolons
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:31 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Applied.
PATCH 13/44 drivers/net/e1000e: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/net/e1000e/netdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/e1000e/netdev.c +1 -1
@@ -4595,7 +4595,7 @@ dma_error: i += tx_ring->count; i--; buffer_info = &tx_ring->buffer_info[i]; -e1000_put_txbuf (adapter, buffer_info);; +e1000_put_txbuf (adapter, buffer_info); }return 0 ;
Signature · 14 lines
1.7.3.1.g432b3.dirty ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Re: [PATCH 13/44] drivers/net/e1000e: Remove unnecessary semicolons
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:32 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Applied.
PATCH 14/44 drivers/net/ixgbe: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/net/ixgbe/ixgbe_sriov.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ixgbe/ixgbe_sriov.c +1 -1
@@ -68,7 +68,7 @@ static int ixgbe_set_vf_multicasts(struct ixgbe_adapter *adapter,* addresses */ for (i =0 ; i < entries; i++) { - vfinfo->vf_mc_hashes[i] = hash_list[i];; + vfinfo->vf_mc_hashes[i] = hash_list[i]; }for (i =0 ; i < vfinfo->num_vf_mc_hashes; i++) {
Signature · 14 lines
1.7.3.1.g432b3.dirty ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
RE: [PATCH 14/44] drivers/net/ixgbe: Remove unnecessary semicolons
Quoted 29 lines
-----Original Message-----
From: Joe Perches [mailto:[email protected]]
Sent: Sunday, November 14, 2010 7:05 PM
To: Jiri Kosina
Cc: Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V; Waskiewicz Jr, Peter P; Duyck, Alexander H; Ronciak, John; [email protected]; [email protected]; [email protected]
Subject: [PATCH 14/44]drivers/net/ixgbe: Remove unnecessary semicolonsSigned-off-by Joe Perches <[email protected]>--- drivers/net/ixgbe/ixgbe_sriov.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/net/ixgbe/ixgbe_sriov.c +1
-1@@ -68,7 +68,7 @@ static int ixgbe_set_vf_multicasts(struct ixgbe_adapter*adapter, * addresses */ for (i =0 ; i < entries; i++) { - vfinfo->vf_mc_hashes[i] = hash_list[i];; + vfinfo->vf_mc_hashes[i] = hash_list[i]; }
Quoted 3 lines
for (i = 0; i <
vfinfo->num_vf_mc_hashes; i++) {
--
1.7.3.1.g432b3.dirty
Acked By: Greg Rose <[email protected]>
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Re: [PATCH 14/44] drivers/net/ixgbe: Remove unnecessary semicolons
In reply to Joe PerchesFrom: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:33 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Applied.
PATCH 15/44 drivers/net/vxge: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/net/vxge/vxge-main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/vxge/vxge-main.c +1 -1
@@ -2062,7 +2062,7 @@ static irqreturn_t vxge_isr_napi(int irq, void *dev_id)struct __vxge_hw_device *hldev;u64 reason;enum vxge_hw_status status; -struct vxgedev *vdev = (struct vxgedev *) dev_id;; +struct vxgedev *vdev = (struct vxgedev *)dev_id;vxge_debug_intr (VXGE_TRACE ,"%s:%d" , __func__, __LINE__);
Signature · 1 line
1.7.3.1.g432b3.dirty
David Miller
maintainerRe: [PATCH 15/44] drivers/net/vxge: Remove unnecessary semicolons
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:34 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Not applicable to net-next-2.6
PATCH 16/44 drivers/net/wireless/ath: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/net/wireless/ath/ath9k/htc.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/ath/ath9k/htc.h +1 -1
@@ -434,7 +434,7 @@ void ath9k_htc_beaconep(void *drv_priv, struct sk_buff *skb,void ath9k_htc_station_work (struct work_struct *work);void ath9k_htc_aggr_work (struct work_struct *work); -void ath9k_ani_work (struct work_struct *work);; +void ath9k_ani_work (struct work_struct *work);int ath9k_tx_init (struct ath9k_htc_priv *priv);void ath9k_tx_tasklet (unsigned long data);
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 17/44 drivers/net/wireless/iwlwifi: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/net/wireless/iwlwifi/iwl-agn.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/iwlwifi/iwl-agn.c +1 -1
@@ -2420,7 +2420,7 @@ static const char *desc_lookup(u32 num) max =ARRAY_SIZE (advanced_lookup) -1 ;for (i =0 ; i < max; i++) {if (advanced_lookup[i].num == num) -break ;; +break ; }return advanced_lookup[i].name; }
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 18/44 drivers/net/cnic.c: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/net/cnic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/cnic.c +1 -1
@@ -1695,7 +1695,7 @@ static int cnic_bnx2x_iscsi_ofld1(struct cnic_dev *dev, struct kwqe *wqes[], *work = num;return -EINVAL ; } - *work =2 + req2->num_additional_wqes;; + *work =2 + req2->num_additional_wqes; l5_cid = req1->iscsi_conn_id;if (l5_cid >=MAX_ISCSI_TBL_SZ )
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 18/44] drivers/net/cnic.c: Remove unnecessary semicolons
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:37 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Applied.
PATCH 19/44 drivers/platform/x86: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/platform/x86/classmate-laptop.c | 2 +- drivers/platform/x86/thinkpad_acpi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/classmate-laptop.c +1 -1
@@ -653,7 +653,7 @@ static void cmpc_keys_handler(struct acpi_device *dev, u32 event)if ((event &0x0F ) <ARRAY_SIZE (cmpc_keys_codes)) code = cmpc_keys_codes[event &0x0F ]; - inputdev =dev_get_drvdata (&dev->dev);; + inputdev =dev_get_drvdata (&dev->dev);input_report_key (inputdev, code, !(event &0x10 )); }
drivers/platform/x86/thinkpad_acpi.c +1 -1
@@ -6345,7 +6345,7 @@ static int __init brightness_init(struct ibm_init_struct *iibm) "as change notification\n");tpacpi_hotkey_driver_mask_set (hotkey_driver_mask |TP_ACPI_HKEY_BRGHTUP_MASK - |TP_ACPI_HKEY_BRGHTDWN_MASK );; + |TP_ACPI_HKEY_BRGHTDWN_MASK );return 0 ; }
Signature · 1 line
1.7.3.1.g432b3.dirty
Matthew Garrett
AppliedRe: [PATCH 19/44] drivers/platform/x86: Remove unnecessary semicolons
Applied, thanks.
Signature · 1 line
Matthew Garrett | [email protected]
PATCH 20/44 drivers/power: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/power/intel_mid_battery.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/power/intel_mid_battery.c +1 -1
@@ -522,7 +522,7 @@ static int pmic_battery_set_charger(struct pmic_power_module_info *pbi,if (retval) {dev_warn (pbi->dev,"%s(): ipc pmic read failed\n" , __func__); -return retval;; +return retval; }return 0 ;
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 21/44 drivers/s390/net: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/s390/net/qeth_core_sys.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/s390/net/qeth_core_sys.c +1 -1
@@ -372,7 +372,7 @@ static ssize_t qeth_dev_performance_stats_store(struct device *dev, i =simple_strtoul (buf, &tmp,16 );if ((i ==0 ) || (i ==1 )) {if (i == card->options.performance_stats) - goto out;; + goto out; card->options.performance_stats = i;if (i ==0 ) memset(&card->perf_stats, 0,
Signature · 1 line
1.7.3.1.g432b3.dirty
David Miller
maintainerRe: [PATCH 21/44] drivers/s390/net: Remove unnecessary semicolons
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:40 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
I'll let the s390 folks take this one.
Re: [PATCH 21/44] drivers/s390/net: Remove unnecessary semicolons
Quoted 6 lines · David Miller
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:40 -0800Quoted 1 line
Signed-off-by Joe Perches <[email protected]>I'll let the s390 folks take this one.
Ok, added this one to my patch queue. Thx!
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 22/44 drivers/scsi/be2iscsi: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/scsi/be2iscsi/be_main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/be2iscsi/be_main.c +2 -2
@@ -618,7 +618,7 @@ static void beiscsi_get_params(struct beiscsi_hba *phba) + BE2_NOPOUT_REQ)); phba->params.cxns_per_ctrl = phba->fw_config.iscsi_cid_count; phba->params.asyncpdus_per_ctrl = phba->fw_config.iscsi_cid_count *2 ; - phba->params.icds_per_ctrl = phba->fw_config.iscsi_icd_count;; + phba->params.icds_per_ctrl = phba->fw_config.iscsi_icd_count; phba->params.num_sge_per_io =BE2_SGE ; phba->params.defpdu_hdr_sz =BE2_DEFPDU_HDR_SZ ; phba->params.defpdu_data_sz =BE2_DEFPDU_DATA_SZ ;
@@ -781,7 +781,7 @@ static irqreturn_t be_isr(int irq, void *dev_id)int isr; phba = dev_id; - ctrl = &phba->ctrl;; + ctrl = &phba->ctrl; isr =ioread32 (ctrl->csr +CEV_ISR0_OFFSET + (PCI_FUNC (ctrl->pdev->devfn) *CEV_ISR_SIZE ));if (!isr)
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 23/44 drivers/scsi/bfa: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/scsi/bfa/bfa_fcs_lport.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/bfa/bfa_fcs_lport.c +1 -1
@@ -1683,7 +1683,7 @@ bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld)memcpy (attr->value, fcs_hba_attr->driver_version, attr->len); attr->len =fc_roundup (attr->len,sizeof (u32)); curr_ptr +=sizeof (attr->type) +sizeof (attr->len) + attr->len; - len += attr->len;; + len += attr->len; count++; attr->len =cpu_to_be16 (attr->len +sizeof (attr->type) +sizeof (attr->len));
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 24/44 drivers/scsi/lpfc: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/scsi/lpfc/lpfc_bsg.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/lpfc/lpfc_bsg.c +1 -1
@@ -617,7 +617,7 @@ lpfc_bsg_rport_els(struct fc_bsg_job *job) dd_data->context_un.iocb.cmdiocbq = cmdiocbq; dd_data->context_un.iocb.rspiocbq = rspiocbq; dd_data->context_un.iocb.set_job = job; - dd_data->context_un.iocb.bmp =NULL ;; + dd_data->context_un.iocb.bmp =NULL ; dd_data->context_un.iocb.ndlp = ndlp;if (phba->cfg_poll &DISABLE_FCP_RING_INT ) {
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 25/44 drivers/scsi/pm8001: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/scsi/pm8001/pm8001_init.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/pm8001/pm8001_init.c +1 -1
@@ -160,7 +160,7 @@ static void pm8001_free(struct pm8001_hba_info *pm8001_ha)static void pm8001_tasklet (unsigned long opaque) {struct pm8001_hba_info *pm8001_ha; - pm8001_ha = (struct pm8001_hba_info *)opaque;; + pm8001_ha = (struct pm8001_hba_info *)opaque;if (unlikely (!pm8001_ha))BUG_ON (1 );PM8001_CHIP_DISP ->isr (pm8001_ha);
Signature · 1 line
1.7.3.1.g432b3.dirty
RE: [PATCH 25/44] drivers/scsi/pm8001: Remove unnecessary semicolons
drivers/scsi/pm8001/pm8001_init.c static void pm8001_free(struct pm8001_hba_info
Quoted 12 lines
Signed-off-by Joe Perches <[email protected]>--- drivers/scsi/pm8001/pm8001_init.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/scsi/pm8001/pm8001_init.c +0
-0@@ -160,7 +160,7 @@ static void pm8001_free(struct pm8001_hba_info
*pm8001_ha)
Quoted 10 lines
drivers/scsi/pm8001/pm8001_init.c +1
-2static void pm8001_tasklet (unsigned long opaque) {struct pm8001_hba_info *pm8001_ha; - pm8001_ha = (struct pm8001_hba_info *)opaque;; + pm8001_ha = (struct pm8001_hba_info *)opaque;if (unlikely (!pm8001_ha))BUG_ON (1 );PM8001_CHIP_DISP ->isr (pm8001_ha); --1.7.3.1.g432b3.dirty
[Jack Wang] Acked-by: Jack Wang <[email protected]> Thanks！
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 26/44 drivers/scsi/qla2xxx: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/scsi/qla2xxx/qla_isr.c | 4 ++-- drivers/scsi/qla2xxx/qla_nx.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +2 -2
@@ -1049,7 +1049,7 @@ qla2x00_ct_entry(scsi_qla_host_t *vha, struct req_que *req, }DEBUG2 (qla2x00_dump_buffer ((uint8_t *)pkt,sizeof (*pkt))); }else { - bsg_job->reply->result =DID_OK <<16 ;; + bsg_job->reply->result =DID_OK <<16 ; bsg_job->reply->reply_payload_rcv_len = bsg_job->reply_payload.payload_len; bsg_job->reply_len =0 ;
@@ -1144,7 +1144,7 @@ qla24xx_els_ct_entry(scsi_qla_host_t *vha, struct req_que *req,DEBUG2 (qla2x00_dump_buffer ((uint8_t *)pkt,sizeof (*pkt))); }else { - bsg_job->reply->result =DID_OK <<16 ;; + bsg_job->reply->result =DID_OK <<16 ; bsg_job->reply->reply_payload_rcv_len = bsg_job->reply_payload.payload_len; bsg_job->reply_len =0 ; }
drivers/scsi/qla2xxx/qla_nx.c +1 -1
@@ -1022,7 +1022,7 @@ ql82xx_rom_lock_d(struct qla_hw_data *ha)qla_printk (KERN_WARNING , ha,"ROM lock failed\n" );return -1 ; } -return 0 ;; +return 0 ; } static int
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 27/44 drivers/serial: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/serial/mrst_max3110.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/mrst_max3110.c +1 -1
@@ -56,7 +56,7 @@ struct uart_max3110 {wait_queue_head_t wq;struct task_struct *main_thread;struct task_struct *read_thread; -struct mutex thread_mutex;; +struct mutex thread_mutex;u32 baud;u16 cur_conf;
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 28/44 drivers/spi: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/spi/amba-pl022.c | 2 +- drivers/spi/spi_nuc900.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/spi/amba-pl022.c +1 -1
@@ -956,7 +956,7 @@ static int configure_dma(struct pl022 *pl022) tx_conf.dst_addr_width =DMA_SLAVE_BUSWIDTH_2_BYTES ;break ;case WRITING_U32 : - tx_conf.dst_addr_width =DMA_SLAVE_BUSWIDTH_4_BYTES ;; + tx_conf.dst_addr_width =DMA_SLAVE_BUSWIDTH_4_BYTES ;break ; }
drivers/spi/spi_nuc900.c +1 -1
@@ -449,7 +449,7 @@ err_iomap:release_mem_region (hw->res->start,resource_size (hw->res));kfree (hw->ioarea); err_pdata: -spi_master_put (hw->master);; +spi_master_put (hw->master); err_nomem:return err;
Signature · 1 line
1.7.3.1.g432b3.dirty
Grant Likely
AppliedRe: [PATCH 28/44] drivers/spi: Remove unnecessary semicolons
Quoted 1 line · Joe Perches
Signed-off-by Joe Perches <[email protected]>
applied, thanks.
g.
Quoted 34 lines
--- drivers/spi/amba-pl022.c | 2 +- drivers/spi/spi_nuc900.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/spi/amba-pl022.c +1
-1@@ -956,7 +956,7 @@ static int configure_dma(struct pl022 *pl022) tx_conf.dst_addr_width =DMA_SLAVE_BUSWIDTH_2_BYTES ;break ;case WRITING_U32 : - tx_conf.dst_addr_width =DMA_SLAVE_BUSWIDTH_4_BYTES ;; + tx_conf.dst_addr_width =DMA_SLAVE_BUSWIDTH_4_BYTES ;break ; }drivers/spi/spi_nuc900.c +1
-1@@ -449,7 +449,7 @@ err_iomap:release_mem_region (hw->res->start,resource_size (hw->res));kfree (hw->ioarea); err_pdata: -spi_master_put (hw->master);; +spi_master_put (hw->master); err_nomem:return err;Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 29/44 drivers/staging: Remove unnecessary semicolons
In reply to Joe Perches--- .../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 2 +- drivers/staging/ath6kl/os/linux/ar6000_drv.c | 2 +- drivers/staging/bcm/InterfaceInit.c | 2 +- drivers/staging/bcm/InterfaceIsr.c | 2 +- drivers/staging/bcm/Misc.c | 4 ++-- .../comedi/drivers/addi-data/APCI1710_Tor.c | 2 +- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 2 +- .../comedi/drivers/addi-data/hwdrv_apci1516.c | 2 +- .../comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- drivers/staging/comedi/drivers/amplc_pci230.c | 2 +- drivers/staging/comedi/drivers/cb_das16_cs.c | 2 +- drivers/staging/comedi/drivers/comedi_bond.c | 2 +- drivers/staging/crystalhd/crystalhd_hw.c | 2 +- drivers/staging/go7007/go7007-driver.c | 2 +- drivers/staging/iio/accel/lis3l02dq_ring.c | 2 +- .../staging/intel_sst/intel_sst_drv_interface.c | 4 ++-- drivers/staging/keucr/smilmain.c | 4 ++-- drivers/staging/keucr/smilsub.c | 4 ++-- drivers/staging/msm/lcdc_toshiba_wvga_pt.c | 2 +- drivers/staging/rt2860/common/cmm_data_pci.c | 4 ++-- drivers/staging/rt2860/rt_linux.c | 2 +- drivers/staging/rt2860/rtmp.h | 2 +- drivers/staging/rtl8192e/ieee80211/ieee80211_tx.c | 2 +- drivers/staging/rtl8192e/r819xE_phy.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 2 +- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging/rtl8712/rtl8712_efuse.c | 2 +- drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- drivers/staging/tidspbridge/core/tiomap3430.c | 4 ++-- drivers/staging/tidspbridge/rmgr/nldr.c | 2 +- drivers/staging/vt6655/card.c | 2 +- drivers/staging/vt6655/iwctl.c | 2 +- drivers/staging/vt6655/wpa2.c | 4 ++-- drivers/staging/vt6656/baseband.c | 2 +- drivers/staging/vt6656/iwctl.c | 2 +- drivers/staging/vt6656/power.c | 2 +- drivers/staging/vt6656/wpa2.c | 4 ++-- 39 files changed, 47 insertions(+), 47 deletions(-)
drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif.c +1 -1
@@ -876,7 +876,7 @@ HIFAckInterrupt(HIF_DEVICE *device)void HIFUnMaskInterrupt (HIF_DEVICE *device) { -int ret;; +int ret;AR_DEBUG_ASSERT (device !=NULL );AR_DEBUG_ASSERT (device->func !=NULL );
drivers/staging/ath6kl/os/linux/ar6000_drv.c +1 -1
@@ -4439,7 +4439,7 @@ skip_key:for (i = assoc_req_ie_pos; i < assoc_req_ie_pos + assocReqLen -4 ; i++) {AR_DEBUG_PRINTF (ATH_DEBUG_WLAN_CONNECT ,("%2.2x " , assocInfo[i]));sprintf (pos,"%2.2x" , assocInfo[i]); - pos +=2 ;; + pos +=2 ; }AR_DEBUG_PRINTF (ATH_DEBUG_WLAN_CONNECT ,("\n" ));
drivers/staging/bcm/InterfaceInit.c +1 -1
@@ -265,7 +265,7 @@ usbbcm_device_probe(struct usb_interface *intf, const struct usb_device_id *id)uint32_t uiNackZeroLengthInt=4 ;if (wrmalt (psAdapter,DISABLE_USB_ZERO_LEN_INT , &uiNackZeroLengthInt,sizeof (uiNackZeroLengthInt))) { -return -EIO ;; +return -EIO ; } }
drivers/staging/bcm/InterfaceIsr.c +1 -1
@@ -87,7 +87,7 @@ static void read_int_callback(struct urb *urb/*, struct pt_regs *regs*/)BCM_DEBUG_PRINT (Adapter,DBG_TYPE_OTHERS ,INTF_INIT ,DBG_LVL_ALL ,"Interrupt IN endPoint has got halted/stalled...need to clear this" ); Adapter->bEndPointHalted = TRUE ;wake_up (&Adapter->tx_packet_wait_queue); - urb->status =STATUS_SUCCESS ;; + urb->status =STATUS_SUCCESS ;return ; }/* software-driven interface shutdown */
drivers/staging/bcm/Misc.c +2 -2
@@ -764,7 +764,7 @@ void SendIdleModeResponse(PMINI_ADAPTER Adapter)/* Wake the LED Thread with IDLEMODE_ENTER State */ Adapter->DriverState =LOWPOWER_MODE_ENTER ; -BCM_DEBUG_PRINT (Adapter,DBG_TYPE_RX ,RX_DPC ,DBG_LVL_ALL ,"LED Thread is Running..Hence Setting LED Event as IDLEMODE_ENTER jiffies:%ld" ,jiffies);; +BCM_DEBUG_PRINT (Adapter,DBG_TYPE_RX ,RX_DPC ,DBG_LVL_ALL ,"LED Thread is Running..Hence Setting LED Event as IDLEMODE_ENTER jiffies:%ld" ,jiffies);wake_up (&Adapter->LEDInfo.notify_led_event);/* Wait for 1 SEC for LED to OFF */
@@ -1410,7 +1410,7 @@ int bcm_parse_target_params(PMINI_ADAPTER Adapter)void beceem_parse_target_struct (PMINI_ADAPTER Adapter) { -UINT uiHostDrvrCfg6 =0 , uiEEPROMFlag =0 ;; +UINT uiHostDrvrCfg6 =0 , uiEEPROMFlag =0 ;if (ntohl (Adapter->pstargetparams->m_u32PhyParameter2) &AUTO_SYNC_DISABLE ) {
drivers/staging/comedi/drivers/addi-data/APCI1710_Tor.c +1 -1
@@ -1008,7 +1008,7 @@ int i_APCI1710_InsnWriteEnableDisableTorCounter(struct comedi_device *dev, b_ExternGate = (unsigned char ) data[3 ]; b_CycleMode = (unsigned char ) data[4 ]; b_InterruptEnable = (unsigned char ) data[5 ]; - i_ReturnValue = insn->n;; + i_ReturnValue = insn->n; devpriv->tsk_Current = current;/* Save the current process task structure */ /**************************/ /* Test the module number */
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c +1 -1
@@ -2850,7 +2850,7 @@ static int i_APCI1500_Reset(struct comedi_device *dev) i_Logic =0 ; i_CounterLogic =0 ; i_InterruptMask =0 ; - i_InputChannel =0 ;; + i_InputChannel =0 ; i_TimerCounter1Enabled =0 ; i_TimerCounter2Enabled =0 ; i_WatchdogCounter3Enabled =0 ;
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1516.c +1 -1
@@ -335,7 +335,7 @@ int i_APCI1516_WriteDigitalOutput(struct comedi_device *dev, struct comedi_subdereturn -EINVAL ; }/* if else data[3]==1) */ }/* if else data[3]==0) */ -return (insn->n);; +return (insn->n); }/*
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c +1 -1
@@ -339,7 +339,7 @@ int i_APCI3501_ConfigAnalogOutput(struct comedi_device *dev, struct comedi_subdeint i_APCI3501_WriteAnalogOutput (struct comedi_device *dev,struct comedi_subdevice *s,struct comedi_insn *insn,unsigned int *data) { -unsigned int ul_Command1 =0 , ul_Channel_no, ul_Polarity, ul_DAC_Ready =0 ;; +unsigned int ul_Command1 =0 , ul_Channel_no, ul_Polarity, ul_DAC_Ready =0 ; ul_Channel_no =CR_CHAN (insn->chanspec);
drivers/staging/comedi/drivers/amplc_pci230.c +1 -1
@@ -971,7 +971,7 @@ static int pci230_attach(struct comedi_device *dev, struct comedi_devconfig *it)if (thisboard->ao_chans >0 ) { s->type =COMEDI_SUBD_AO ; s->subdev_flags =SDF_WRITABLE |SDF_GROUND ; - s->n_chan = thisboard->ao_chans;; + s->n_chan = thisboard->ao_chans; s->maxdata = (1 << thisboard->ao_bits) -1 ; s->range_table = &pci230_ao_range; s->insn_write = &pci230_ao_winsn;
drivers/staging/comedi/drivers/cb_das16_cs.c +1 -1
@@ -169,7 +169,7 @@ static int das16cs_attach(struct comedi_device *dev,if (!link)return -EIO ; - dev->iobase = link->resource[0 ]->start;; + dev->iobase = link->resource[0 ]->start;printk ("I/O base=0x%04lx " , dev->iobase);printk ("fingerprint:\n" );
drivers/staging/comedi/drivers/comedi_bond.c +1 -1
@@ -370,7 +370,7 @@ static int doDevConfig(struct comedi_device *dev, struct comedi_devconfig *it)struct comedi_device *devs_opened[COMEDI_NUM_BOARD_MINORS ];memset (devs_opened,0 ,sizeof (devs_opened)); - devpriv->name[0 ] =0 ;; + devpriv->name[0 ] =0 ;/* Loop through all comedi devices specified on the command-line, building our device list */ for (i =0 ; i <COMEDI_NDEVCONFOPTS && (!i || it->options[i]); ++i) {
drivers/staging/crystalhd/crystalhd_hw.c +1 -1
@@ -1711,7 +1711,7 @@ enum BC_STATUS crystalhd_download_fw(struct crystalhd_adp *adp, void *buffer, ui }BCMLOG (BCMLOG_INFO ,"Firmware Downloaded Successfully\n" ); -return BC_STS_SUCCESS ;; +return BC_STS_SUCCESS ; } enum BC_STATUS crystalhd_do_fw_cmd(struct crystalhd_hw *hw,
drivers/staging/go7007/go7007-driver.c +1 -1
@@ -624,7 +624,7 @@ struct go7007 *go7007_alloc(struct go7007_board_info *board, struct device *dev) go->dvd_mode =0 ; go->interlace_coding =0 ;for (i =0 ; i <4 ; ++i) - go->modet[i].enable =0 ;; + go->modet[i].enable =0 ;for (i =0 ; i <1624 ; ++i) go->modet_map[i] =0 ; go->audio_deliver =NULL ;
drivers/staging/iio/accel/lis3l02dq_ring.c +1 -1
@@ -517,7 +517,7 @@ int lis3l02dq_configure_ring(struct iio_dev *indio_dev) ret =iio_alloc_pollfunc (indio_dev,NULL , &lis3l02dq_poll_func_th);if (ret) - goto error_iio_sw_rb_free;; + goto error_iio_sw_rb_free; indio_dev->modes |=INDIO_RING_TRIGGERED ;return 0 ;
drivers/staging/intel_sst/intel_sst_drv_interface.c +2 -2
@@ -171,9 +171,9 @@ static int sst_get_sfreq(struct snd_sst_params *str_param)case SST_CODEC_TYPE_MP3 :return str_param->sparams.uc.mp3_params.sfreq;case SST_CODEC_TYPE_AAC : -return str_param->sparams.uc.aac_params.sfreq;; +return str_param->sparams.uc.aac_params.sfreq;case SST_CODEC_TYPE_WMA9 : -return str_param->sparams.uc.wma_params.sfreq;; +return str_param->sparams.uc.wma_params.sfreq;default :return 0 ; }
drivers/staging/keucr/smilmain.c +2 -2
@@ -153,9 +153,9 @@ int Media_D_ReadSector(struct us_data *us, DWORD start,WORD count,BYTE *buf)WORD len, bn;//if (Check_D_MediaPower()) ; �b 6250 don't care -// return(ErrCode); ; +// return(ErrCode); //if (Check_D_MediaFmt(fdoExt)) ; -// return(ErrCode); ; +// return(ErrCode); if (Conv_D_MediaAddr (us, start))return (ErrCode);
drivers/staging/keucr/smilsub.c +2 -2
@@ -763,8 +763,8 @@ int Ssfdc_D_WriteSectForCopy(struct us_data *us, BYTE *buf, BYTE *redundant) bcb->CDB[7 ] = (BYTE )addr; bcb->CDB[6 ] = (BYTE )(addr/0x0100 ); bcb->CDB[5 ] = Media.Zone/2 ; - bcb->CDB[8 ] = *(redundant+REDT_ADDR1H );; - bcb->CDB[9 ] = *(redundant+REDT_ADDR1L );; + bcb->CDB[8 ] = *(redundant+REDT_ADDR1H ); + bcb->CDB[9 ] = *(redundant+REDT_ADDR1L ); result =ENE_SendScsiCmd (us,FDIR_WRITE , buf,0 );if (result !=USB_STOR_XFER_GOOD )
drivers/staging/msm/lcdc_toshiba_wvga_pt.c +1 -1
@@ -77,7 +77,7 @@ static void toshiba_spi_write(char cmd, uint32 data, int num)/* followed by parameter bytes */ if (num) { - bp = (char *)&data;; + bp = (char *)&data; bp += (num -1 );while (num) {toshiba_spi_write_byte (1 , *bp);
drivers/staging/rt2860/common/cmm_data_pci.c +2 -2
@@ -137,7 +137,7 @@ u16 RtmpPCI_WriteSingleTxResource(struct rt_rtmp_adapter *pAd, pTxD->SDPtr0 = BufBasePaLow; pTxD->SDLen0 =TXINFO_SIZE +TXWI_SIZE + hwHeaderLen;/* include padding */ - pTxD->SDPtr1 =PCI_MAP_SINGLE (pAd, pTxBlk,0 ,1 ,PCI_DMA_TODEVICE );; + pTxD->SDPtr1 =PCI_MAP_SINGLE (pAd, pTxBlk,0 ,1 ,PCI_DMA_TODEVICE ); pTxD->SDLen1 = pTxBlk->SrcBufLen; pTxD->LastSec0 =0 ; pTxD->LastSec1 = (bIsLast) ?1 :0 ;
@@ -215,7 +215,7 @@ u16 RtmpPCI_WriteMultiTxResource(struct rt_rtmp_adapter *pAd, pTxD->SDPtr0 = BufBasePaLow; pTxD->SDLen0 = firstDMALen;/* include padding */ - pTxD->SDPtr1 =PCI_MAP_SINGLE (pAd, pTxBlk,0 ,1 ,PCI_DMA_TODEVICE );; + pTxD->SDPtr1 =PCI_MAP_SINGLE (pAd, pTxBlk,0 ,1 ,PCI_DMA_TODEVICE ); pTxD->SDLen1 = pTxBlk->SrcBufLen; pTxD->LastSec0 =0 ; pTxD->LastSec1 = (bIsLast) ?1 :0 ;
drivers/staging/rt2860/rt_linux.c +1 -1
@@ -854,7 +854,7 @@ void send_monitor_packets(struct rt_rtmp_adapter *pAd, struct rt_rx_blk *pRxBlk) RSSI1, RSSI_1),ConvertToRssi (pAd, pRxBlk->pRxWI->RSSI2, - RSSI_2));; + RSSI_2)); ph->signal.did = DIDmsg_lnxind_wlansniffrm_signal; ph->signal.status =0 ;
drivers/staging/rt2860/rtmp.h +1 -1
@@ -2978,7 +2978,7 @@ void LinkDown(struct rt_rtmp_adapter *pAd, IN BOOLEAN IsReqFromAP);void IterateOnBssTab (struct rt_rtmp_adapter *pAd); -void IterateOnBssTab2 (struct rt_rtmp_adapter *pAd);; +void IterateOnBssTab2 (struct rt_rtmp_adapter *pAd);void JoinParmFill (struct rt_rtmp_adapter *pAd,struct rt_mlme_join_req *JoinReq,unsigned long BssIdx);
drivers/staging/rtl8192e/ieee80211/ieee80211_tx.c +1 -1
@@ -822,7 +822,7 @@ int ieee80211_rtl_xmit(struct sk_buff *skb, struct net_device *dev) { txb->queue_index =UP2AC (skb->priority); } else { - txb->queue_index =WME_AC_BK ;; + txb->queue_index =WME_AC_BK ; }
drivers/staging/rtl8192e/r819xE_phy.c +1 -1
@@ -2596,7 +2596,7 @@ u8 rtl8192_phy_ConfigRFWithHeaderFile(struct net_device* dev, RF90_RADIO_PATH_Ebreak ; } -return ret;; +return ret; }/******************************************************************************
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c +1 -1
@@ -754,7 +754,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev) { txb->queue_index =UP2AC (skb->priority); } else { - txb->queue_index =WME_AC_BK ;; + txb->queue_index =WME_AC_BK ; }
drivers/staging/rtl8192u/r8192U_core.c +1 -1
@@ -5085,7 +5085,7 @@ static void rtl8192_query_rxphystatus(//Get Rx snr value in DB tmp_rxsnr = pofdm_buf->rxsnr_X[i]; rx_snrX = (char )(tmp_rxsnr); -//rx_snrX >>= 1;; +//rx_snrX >>= 1; rx_snrX /=2 ; priv->stats.rxSNRdB[i] = (long )rx_snrX;
drivers/staging/rtl8192u/r819xU_phy.c +1 -1
@@ -1011,7 +1011,7 @@ u8 rtl8192_phy_ConfigRFWithHeaderFile(struct net_device* dev, RF90_RADIO_PATH_Ebreak ; } -return ret;; +return ret; }/******************************************************************************
drivers/staging/rtl8712/rtl8712_efuse.c +1 -1
@@ -428,7 +428,7 @@ u8 r8712_efuse_access(struct _adapter *padapter, u8 bRead, u16 start_addr, u16 cnts, u8 *data) { int i; -u8 res = true;; +u8 res = true;if (start_addr >EFUSE_MAX_SIZE )return false;
drivers/staging/rtl8712/rtl8712_xmit.c +1 -1
@@ -148,7 +148,7 @@ static u32 get_ff_hwaddr(struct xmit_frame *pxmitframe)case 0x11 :case 0x12 :case 0x13 : - addr =RTL8712_DMA_H2CCMD ;; + addr =RTL8712_DMA_H2CCMD ;break ;default : addr =RTL8712_DMA_BEQ ;/*RTL8712_EP_LO;*/
drivers/staging/rtl8712/rtl871x_xmit.c +1 -1
@@ -372,7 +372,7 @@ static sint xmitframe_addmic(struct _adapter *padapter, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; datalen = pattrib->pktlen - pattrib->hdrlen; - pframe = pxmitframe->buf_addr +TXDESC_OFFSET ;; + pframe = pxmitframe->buf_addr +TXDESC_OFFSET ; if (bmcst) { if (!memcmp(psecuritypriv->XGrptxmickey [psecuritypriv->XGrpKeyid].skey,
drivers/staging/tidspbridge/core/tiomap3430.c +2 -2
@@ -596,7 +596,7 @@ static int bridge_brd_start(struct bridge_dev_context *dev_ctxt,dev_dbg (bridge,"DSP c_int00 Address = 0x%x\n" , dsp_addr);if (dsp_debug)while (__raw_readw (dw_sync_addr)) - ;; + ;/* Wait for DSP to clear word in shared memory */ /* Read the Location */
@@ -1671,7 +1671,7 @@ static int pte_set(struct pg_table_attrs *pt, u32 pa, u32 va,/* Find a free L2 PT. */ for (i =0 ; (i < pt->l2_num_pages) && (pt->pg_info[i].num_entries !=0 ); i++) - ;; + ;if (i < pt->l2_num_pages) { l2_page_num = i; l2_base_pa = pt->l2_base_pa + (l2_page_num *
drivers/staging/tidspbridge/rmgr/nldr.c +1 -1
@@ -943,7 +943,7 @@ static int add_ovly_info(void *handle, struct dbll_sect_info *sect_info,/* Determine which phase this section belongs to */ for (pch = sect_name +1 ; *pch && *pch != seps; pch++) - ;; + ;if (*pch) { pch++;/* Skip over the ':' */
drivers/staging/vt6655/card.c +1 -1
@@ -2058,7 +2058,7 @@ bool CARDbSoftwareReset (void *pDeviceHandler)QWORD CARDqGetTSFOffset (unsigned char byRxRate,QWORD qwTSF1,QWORD qwTSF2) {QWORD qwTSFOffset; -unsigned short wRxBcnTSFOffst=0 ;; +unsigned short wRxBcnTSFOffst=0 ;HIDWORD (qwTSFOffset) =0 ;LODWORD (qwTSFOffset) =0 ;
drivers/staging/vt6655/iwctl.c +1 -1
@@ -2073,7 +2073,7 @@ int iwctl_giwencodeext(struct net_device *dev,struct iw_point *wrq, char *extra) { - return -EOPNOTSUPP;; + return -EOPNOTSUPP; } int iwctl_siwmlme(struct net_device *dev,
drivers/staging/vt6655/wpa2.c +2 -2
@@ -216,7 +216,7 @@ WPA2vParseRSN ( m = *((unsigned short *) &(pRSN->abyRSN[4 ]));if (pRSN->len >=10 +m*4 ) {// ver(2) + GK(4) + PK count(2) + PKS(4*m) + AKMSS count(2) - pBSSNode->wAKMSSAuthCount = *((unsigned short *) &(pRSN->abyRSN[6 +4 *m]));; + pBSSNode->wAKMSSAuthCount = *((unsigned short *) &(pRSN->abyRSN[6 +4 *m])); j =0 ; pbyOUI = &(pRSN->abyRSN[8 +4 *m]);for (i =0 ; (i < pBSSNode->wAKMSSAuthCount) && (j <sizeof (pBSSNode->abyAKMSSAuthType)/sizeof (unsigned char )); i++) {
@@ -235,7 +235,7 @@ WPA2vParseRSN ( pBSSNode->wAKMSSAuthCount = (unsigned short )j;DBG_PRT (MSG_LEVEL_DEBUG ,KERN_INFO "wAKMSSAuthCount: %d\n" , pBSSNode->wAKMSSAuthCount); - n = *((unsigned short *) &(pRSN->abyRSN[6 +4 *m]));; + n = *((unsigned short *) &(pRSN->abyRSN[6 +4 *m]));if (pRSN->len >=12 +4 *m+4 *n) {// ver(2)+GK(4)+PKCnt(2)+PKS(4*m)+AKMSSCnt(2)+AKMSS(4*n)+Cap(2) pBSSNode->sRSNCapObj.bRSNCapExist = true; pBSSNode->sRSNCapObj.wRSNCap = *((unsigned short *) &(pRSN->abyRSN[8 +4 *m+4 *n]));
drivers/staging/vt6656/baseband.c +1 -1
@@ -963,7 +963,7 @@ BBvSetAntennaMode (PSDevice pDevice, BYTE byAntennaMode)break ;case ANT_RXB : pDevice->byBBRxConf &=0xFE ; - pDevice->byBBRxConf |=0x02 ;; + pDevice->byBBRxConf |=0x02 ;break ; }
drivers/staging/vt6656/iwctl.c +1 -1
@@ -1883,7 +1883,7 @@ int iwctl_giwencodeext(struct net_device *dev,struct iw_point *wrq, char *extra) { - return -EOPNOTSUPP;; + return -EOPNOTSUPP; } int iwctl_siwmlme(struct net_device *dev,
drivers/staging/vt6656/power.c +1 -1
@@ -192,7 +192,7 @@ BOOL PSbConsiderPowerDown(void *hDeviceContext,// check if already in Doze mode ControlvReadByte (pDevice,MESSAGE_REQUEST_MACREG ,MAC_REG_PSCTL , &byData);if ( (byData &PSCTL_PS ) !=0 ) -return TRUE;; +return TRUE;if (pMgmt->eCurrMode !=WMAC_MODE_IBSS_STA ) {// check if in TIM wake period
drivers/staging/vt6656/wpa2.c +2 -2
@@ -215,7 +215,7 @@ WPA2vParseRSN ( m = *((PWORD ) &(pRSN->abyRSN[4 ]));if (pRSN->len >=10 +m*4 ) {// ver(2) + GK(4) + PK count(2) + PKS(4*m) + AKMSS count(2) - pBSSNode->wAKMSSAuthCount = *((PWORD ) &(pRSN->abyRSN[6 +4 *m]));; + pBSSNode->wAKMSSAuthCount = *((PWORD ) &(pRSN->abyRSN[6 +4 *m])); j =0 ; pbyOUI = &(pRSN->abyRSN[8 +4 *m]);for (i =0 ; (i < pBSSNode->wAKMSSAuthCount) && (j <sizeof (pBSSNode->abyAKMSSAuthType)/sizeof (BYTE )); i++) {
@@ -234,7 +234,7 @@ WPA2vParseRSN ( pBSSNode->wAKMSSAuthCount = (WORD )j;DBG_PRT (MSG_LEVEL_DEBUG ,KERN_INFO "wAKMSSAuthCount: %d\n" , pBSSNode->wAKMSSAuthCount); - n = *((PWORD ) &(pRSN->abyRSN[6 +4 *m]));; + n = *((PWORD ) &(pRSN->abyRSN[6 +4 *m]));if (pRSN->len >=12 +4 *m+4 *n) {// ver(2)+GK(4)+PKCnt(2)+PKS(4*m)+AKMSSCnt(2)+AKMSS(4*n)+Cap(2) pBSSNode->sRSNCapObj.bRSNCapExist = TRUE; pBSSNode->sRSNCapObj.wRSNCap = *((PWORD ) &(pRSN->abyRSN[8 +4 *m+4 *n]));
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 30/44 drivers/usb/gadget: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/usb/gadget/f_fs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/gadget/f_fs.c +1 -1
@@ -2096,7 +2096,7 @@ static int __ffs_func_bind_do_descs(enum ffs_entity_type type, u8 *valuep, ep =usb_ep_autoconfig (func->gadget, ds);if (unlikely (!ep))return -ENOTSUPP ; - ep->driver_data = func->eps + idx;; + ep->driver_data = func->eps + idx; req =usb_ep_alloc_request (ep,GFP_KERNEL );if (unlikely (!req))
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 31/44 drivers/xen: Remove unnecessary semicolons
In reply to Joe Perches--- drivers/xen/swiotlb-xen.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/xen/swiotlb-xen.c +1 -1
@@ -54,7 +54,7 @@ u64 start_dma_addr;static dma_addr_t xen_phys_to_bus (phys_addr_t paddr) { -return phys_to_machine (XPADDR (paddr)).maddr;; +return phys_to_machine (XPADDR (paddr)).maddr; }static phys_addr_t xen_bus_to_phys (dma_addr_t baddr)
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 32/44 fs/9p: Remove unnecessary semicolons
In reply to Joe Perches--- fs/9p/acl.c | 2 +- fs/9p/xattr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
fs/9p/acl.c +1 -1
@@ -28,7 +28,7 @@ static struct posix_acl *__v9fs_get_acl(struct p9_fid *fid, char *name) {ssize_t size;void *value =NULL ; -struct posix_acl *acl =NULL ;; +struct posix_acl *acl =NULL ; size =v9fs_fid_xattr_get (fid, name,NULL ,0 );if (size >0 ) {
fs/9p/xattr.c +1 -1
@@ -133,7 +133,7 @@ int v9fs_xattr_set(struct dentry *dentry, const char *name, "p9_client_xattrcreate failed %d\n", retval); goto error; } - msize = fid->clnt->msize;; + msize = fid->clnt->msize;while (value_len) {if (value_len > (msize -P9_IOHDRSZ )) write_count = msize -P9_IOHDRSZ ;
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 33/44 fs/ceph: Remove unnecessary semicolons
In reply to Joe Perches--- fs/ceph/mds_client.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ceph/mds_client.c +1 -1
@@ -2023,7 +2023,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg) }else {struct ceph_inode_info *ci =ceph_inode (req->r_inode);struct ceph_cap *cap = -ceph_get_cap_for_mds (ci, req->r_mds);; +ceph_get_cap_for_mds (ci, req->r_mds);dout ("already using auth" ); if ((!cap || cap != ci->i_auth_cap) ||
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 34/44 fs/logfs: Remove unnecessary semicolons
In reply to Joe Perches--- fs/logfs/readwrite.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/logfs/readwrite.c +1 -1
@@ -481,7 +481,7 @@ static int inode_write_alias(struct super_block *sb, val =inode_val0 (inode);break ;case INODE_USED_OFS : - val =cpu_to_be64 (li->li_used_bytes);; + val =cpu_to_be64 (li->li_used_bytes);break ;case INODE_SIZE_OFS : val =cpu_to_be64 (i_size_read (inode));
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 35/44 fs/nfs: Remove unnecessary semicolons
In reply to Joe Perches--- fs/nfs/getroot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/nfs/getroot.c +1 -1
@@ -190,7 +190,7 @@ struct dentry *nfs4_get_root(struct super_block *sb, struct nfs_fh *mntfh) fattr =nfs_alloc_fattr ();if (fattr ==NULL ) -return ERR_PTR (-ENOMEM );; +return ERR_PTR (-ENOMEM );/* get the actual root for this mount */ error = server->nfs_client->rpc_ops->getattr (server, mntfh, fattr);
Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 36/44 fs/ocfs2: Remove unnecessary semicolons
In reply to Joe Perches--- fs/ocfs2/refcounttree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ocfs2/refcounttree.c +1 -1
@@ -3704,7 +3704,7 @@ int ocfs2_refcount_cow_xattr(struct inode *inode, context->cow_start = cow_start; context->cow_len = cow_len; context->ref_tree = ref_tree; - context->ref_root_bh = ref_root_bh;; + context->ref_root_bh = ref_root_bh; context->cow_object = xv; context->cow_duplicate_clusters = ocfs2_duplicate_clusters_by_jbd;
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 36/44] fs/ocfs2: Remove unnecessary semicolons
Quoted 1 line · Joe Perches
Signed-off-by Joe Perches <[email protected]>
Quoted 20 lines
--- fs/ocfs2/refcounttree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)fs/ocfs2/refcounttree.c +1
-1@@ -3704,7 +3704,7 @@ int ocfs2_refcount_cow_xattr(struct inode *inode, context->cow_start = cow_start; context->cow_len = cow_len; context->ref_tree = ref_tree; - context->ref_root_bh = ref_root_bh;; + context->ref_root_bh = ref_root_bh; context->cow_object = xv; context->cow_duplicate_clusters = ocfs2_duplicate_clusters_by_jbd;Signature · 1 line
1.7.3.1.g432b3.dirty
Signature · 9 lines
Life's Little Instruction Book #237 "Seek out the good in people." Joel Becker Senior Development Manager Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127
PATCH 37/44 fs/ubifs: Remove unnecessary semicolons
In reply to Joe Perches--- fs/ubifs/scan.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ubifs/scan.c +1 -1
@@ -328,7 +328,7 @@ struct ubifs_scan_leb *ubifs_scan(const struct ubifs_info *c, int lnum,if (!quiet)ubifs_err ("empty space starts at non-aligned offset %d" , offs); - goto corrupted;; + goto corrupted; }ubifs_end_scan (c, sleb, lnum, offs);
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 37/44] fs/ubifs: Remove unnecessary semicolons
Quoted 4 lines · Joe Perches
Signed-off-by Joe Perches <[email protected]>--- fs/ubifs/scan.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, I'll pick this up.
Signature · 2 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий)
PATCH 38/44 include/linux/if_macvlan.h: Remove unnecessary semicolons
In reply to Joe Perches--- include/linux/if_macvlan.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/if_macvlan.h +1 -1
@@ -69,7 +69,7 @@ static inline void macvlan_count_rx(const struct macvlan_dev *vlan, rx_stats =this_cpu_ptr (vlan->rx_stats);if (likely (success)) {u64_stats_update_begin (&rx_stats->syncp); - rx_stats->rx_packets++;; + rx_stats->rx_packets++; rx_stats->rx_bytes += len;if (multicast) rx_stats->rx_multicast++;
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 38/44] include/linux/if_macvlan.h: Remove unnecessary semicolons
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:57 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Applied.
PATCH 39/44 include/net/caif/cfctrl.h: Remove unnecessary semicolons
In reply to Joe Perches--- include/net/caif/cfctrl.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/net/caif/cfctrl.h +1 -1
@@ -51,7 +51,7 @@ struct cfctrl_rsp {void (*restart_rsp)(void );void (*radioset_rsp)(void );void (*reject_rsp)(struct cflayer *layer,u8 linkid, -struct cflayer *client_layer);; +struct cflayer *client_layer); };/* Link Setup Parameters for CAIF-Links. */
Signature · 1 line
1.7.3.1.g432b3.dirty
RE: [PATCH 39/44] include/net/caif/cfctrl.h: Remove unnecessary semicolons
Quoted 2 lines
Signed-off-by Joe Perches <[email protected]>
Looks good to me.
Re: [PATCH 39/44] include/net/caif/cfctrl.h: Remove unnecessary semicolons
In reply to Joe PerchesFrom: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:04:58 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Applied.
PATCH 40/44 mm/hugetlb.c: Remove unnecessary semicolons
In reply to Joe Perches--- mm/hugetlb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
mm/hugetlb.c +1 -1
@@ -540,7 +540,7 @@ static struct page *dequeue_huge_page_vma(struct hstate *h,/* If reserves cannot be used, ensure enough pages are in the pool */ if (avoid_reserve && h->free_huge_pages - h->resv_huge_pages ==0 ) - goto err;; + goto err;for_each_zone_zonelist_nodemask (zone, z, zonelist,MAX_NR_ZONES -1 , nodemask) {
Signature · 8 lines
1.7.3.1.g432b3.dirty -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 40/44] mm/hugetlb.c: Remove unnecessary semicolons
Quoted 5 lines · Joe Perches
Signed-off-by Joe Perches <[email protected]>--- mm/hugetlb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 22 lines
mm/hugetlb.c +1
-1@@ -540,7 +540,7 @@ static struct page *dequeue_huge_page_vma(struct hstate *h,/* If reserves cannot be used, ensure enough pages are in the pool */ if (avoid_reserve && h->free_huge_pages - h->resv_huge_pages ==0 ) - goto err;; + goto err;for_each_zone_zonelist_nodemask (zone, z, zonelist,MAX_NR_ZONES -1 , nodemask) {Signature · 7 lines
1.7.3.1.g432b3.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Signature · 10 lines
Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 41/44 net/ipv6/mcast.c: Remove unnecessary semicolons
In reply to Joe Perches--- net/ipv6/mcast.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv6/mcast.c +1 -1
@@ -257,7 +257,7 @@ static struct inet6_dev *ip6_mc_find_dev_rcu(struct net *net,return NULL ; idev =__in6_dev_get (dev);if (!idev) -return NULL ;; +return NULL ;read_lock_bh (&idev->lock);if (idev->dead) {read_unlock_bh (&idev->lock);
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 41/44] net/ipv6/mcast.c: Remove unnecessary semicolons
From: Joe Perches <[email protected]>
Date: Sun, 14 Nov 2010 19:05:00 -0800
Quoted 1 line
Signed-off-by Joe Perches <[email protected]>
Applied.
PATCH 42/44 net/sunrpc/addr.c: Remove unnecessary semicolons
In reply to Joe Perches--- net/sunrpc/addr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/sunrpc/addr.c +1 -1
@@ -151,7 +151,7 @@ static size_t rpc_pton4(const char *buf, const size_t buflen,return 0 ; sin->sin_family =AF_INET ; -return sizeof (struct sockaddr_in );; +return sizeof (struct sockaddr_in ); }#if defined(CONFIG_IPV6 ) || defined(CONFIG_IPV6_MODULE )
Signature · 6 lines
1.7.3.1.g432b3.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 43/44 sound/core/pcm_lib.c: Remove unnecessary semicolons
In reply to Joe Perches--- sound/core/pcm_lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
sound/core/pcm_lib.c +1 -1
@@ -223,7 +223,7 @@ static void xrun_log(struct snd_pcm_substream *substream, entry->jiffies = jiffies; entry->pos = pos; entry->period_size = runtime->period_size; - entry->buffer_size = runtime->buffer_size;; + entry->buffer_size = runtime->buffer_size; entry->old_hw_ptr = runtime->status->hw_ptr; entry->hw_ptr_base = runtime->hw_ptr_base; log->idx = (log->idx +1 ) %XRUN_LOG_CNT ;
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 43/44] sound/core/pcm_lib.c: Remove unnecessary semicolons
At Sun, 14 Nov 2010 19:05:02 -0800,
Quoted 2 lines · Joe Perches
Signed-off-by Joe Perches <[email protected]>
Applied now. Thanks.
Takashi
Quoted 20 lines
--- sound/core/pcm_lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)sound/core/pcm_lib.c +1
-1@@ -223,7 +223,7 @@ static void xrun_log(struct snd_pcm_substream *substream, entry->jiffies = jiffies; entry->pos = pos; entry->period_size = runtime->period_size; - entry->buffer_size = runtime->buffer_size;; + entry->buffer_size = runtime->buffer_size; entry->old_hw_ptr = runtime->status->hw_ptr; entry->hw_ptr_base = runtime->hw_ptr_base; log->idx = (log->idx +1 ) %XRUN_LOG_CNT ;Signature · 1 line
1.7.3.1.g432b3.dirty
PATCH 44/44 sound/soc/codecs: Remove unnecessary semicolons
In reply to Joe Perches--- sound/soc/codecs/wm8904.c | 2 +- sound/soc/codecs/wm8940.c | 1 - sound/soc/codecs/wm8993.c | 2 +- sound/soc/codecs/wm_hubs.c | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-)
sound/soc/codecs/wm8904.c +1 -1
@@ -1590,7 +1590,7 @@ static int wm8904_hw_params(struct snd_pcm_substream *substream, - wm8904->fs);for (i =1 ; i <ARRAY_SIZE (clk_sys_rates); i++) { cur_val =abs ((wm8904->sysclk_rate / - clk_sys_rates[i].ratio) - wm8904->fs);; + clk_sys_rates[i].ratio) - wm8904->fs);if (cur_val < best_val) { best = i; best_val = cur_val;
sound/soc/codecs/wm8940.c +0 -1
@@ -735,7 +735,6 @@ static int wm8940_probe(struct snd_soc_codec *codec)return ret;return ret; -; }static int wm8940_remove (struct snd_soc_codec *codec)
sound/soc/codecs/wm8993.c +1 -1
@@ -1225,7 +1225,7 @@ static int wm8993_hw_params(struct snd_pcm_substream *substream, - wm8993->fs);for (i =1 ; i <ARRAY_SIZE (clk_sys_rates); i++) { cur_val =abs ((wm8993->sysclk_rate / - clk_sys_rates[i].ratio) - wm8993->fs);; + clk_sys_rates[i].ratio) - wm8993->fs);if (cur_val < best_val) { best = i; best_val = cur_val;
sound/soc/codecs/wm_hubs.c +1 -1
@@ -112,7 +112,7 @@ static void calibrate_dc_servo(struct snd_soc_codec *codec)switch (hubs->dcs_readback_mode) {case 0 : reg_l =snd_soc_read (codec,WM8993_DC_SERVO_READBACK_1 ) - &WM8993_DCS_INTEG_CHAN_0_MASK ;; + &WM8993_DCS_INTEG_CHAN_0_MASK ; reg_r =snd_soc_read (codec,WM8993_DC_SERVO_READBACK_2 ) &WM8993_DCS_INTEG_CHAN_1_MASK ;break ;
Signature · 1 line
1.7.3.1.g432b3.dirty
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 7 lines · Joe Perches
Signed-off-by Joe Perches <[email protected]>--- sound/soc/codecs/wm8904.c | 2 +- sound/soc/codecs/wm8940.c | 1 - sound/soc/codecs/wm8993.c | 2 +- sound/soc/codecs/wm_hubs.c | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-)
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
In reply to Joe PerchesQuoted 1 line · Joe Perches
Signed-off-by Joe Perches <[email protected]>
This doesn't apply against current -next, could you please regenerate against that?
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
---
V2: against -next
sound/soc/codecs/wm8904.c | 2 +- sound/soc/codecs/wm8940.c | 1 - sound/soc/codecs/wm8993.c | 2 +- sound/soc/codecs/wm_hubs.c | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-)
sound/soc/codecs/wm8904.c +1 -1
@@ -1591,7 +1591,7 @@ static int wm8904_hw_params(struct snd_pcm_substream *substream, - wm8904->fs);for (i =1 ; i <ARRAY_SIZE (clk_sys_rates); i++) { cur_val =abs ((wm8904->sysclk_rate / - clk_sys_rates[i].ratio) - wm8904->fs);; + clk_sys_rates[i].ratio) - wm8904->fs);if (cur_val < best_val) { best = i; best_val = cur_val;
sound/soc/codecs/wm8940.c +0 -1
@@ -736,7 +736,6 @@ static int wm8940_probe(struct snd_soc_codec *codec)return ret;return ret; -; }static int wm8940_remove (struct snd_soc_codec *codec)
sound/soc/codecs/wm8993.c +1 -1
@@ -1227,7 +1227,7 @@ static int wm8993_hw_params(struct snd_pcm_substream *substream, - wm8993->fs);for (i =1 ; i <ARRAY_SIZE (clk_sys_rates); i++) { cur_val =abs ((wm8993->sysclk_rate / - clk_sys_rates[i].ratio) - wm8993->fs);; + clk_sys_rates[i].ratio) - wm8993->fs);if (cur_val < best_val) { best = i; best_val = cur_val;
sound/soc/codecs/wm_hubs.c +1 -1
@@ -119,7 +119,7 @@ static void calibrate_dc_servo(struct snd_soc_codec *codec)switch (hubs->dcs_readback_mode) {case 0 : reg_l =snd_soc_read (codec,WM8993_DC_SERVO_READBACK_1 ) - &WM8993_DCS_INTEG_CHAN_0_MASK ;; + &WM8993_DCS_INTEG_CHAN_0_MASK ; reg_r =snd_soc_read (codec,WM8993_DC_SERVO_READBACK_2 ) &WM8993_DCS_INTEG_CHAN_1_MASK ;break ;
Mark Brown
AppliedRe: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 1 line · Joe Perches
Signed-off-by Joe Perches <[email protected]>
Applied, thanks.
Please try to use changelog formats consistent with the code you're modifying.
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 5 lines · Mark Brown
Quoted 1 line · Joe Perches
Signed-off-by Joe Perches <[email protected]>Applied, thanks.
Please try to use changelog formats consistent with the code you're modifying.
I think it's more important to use consistent changelogs for a patch series.
If you want your own subsystem changelog consistency, I think you should change the format to what you desire.
cheers, Joe
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 7 lines · Joe Perches
Quoted 2 lines · Mark Brown
Please try to use changelog formats consistent with the code you're modifying.
I think it's more important to use consistent changelogs for a patch series.
...since...?
Quoted 2 lines
If you want your own subsystem changelog consistency, I think you should change the format to what you desire.
Which is what I'm doing but it's annoying to have to constantly hand edit changelogs.
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 7 lines · Mark Brown
Quoted 5 lines · Joe Perches
Quoted 2 lines · Mark Brown
Please try to use changelog formats consistent with the code you're modifying.
I think it's more important to use consistent changelogs for a patch series.
...since...?
1995...
Since there isn't a consistent standard for subsystems changelogs and automating scripts for the desires of individual subsystem maintainers is not feasible.
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 9 lines · Joe Perches
Quoted 6 lines · Mark Brown
Quoted 2 lines · Joe Perches
I think it's more important to use consistent changelogs for a patch series.
...since...?
1995...
That's not really a reason. It seems that...
Quoted 3 lines
Since there isn't a consistent standard for subsystems changelogs and automating scripts for the desires of individual subsystem maintainers is not feasible.
...you mean that you wish to do this since it makes your life as a script author easier. I'd suggest using pattern matching to look up the rules for generating the prefixes (it's pretty much entirely prefixes) in the same way you're handling figuring out who to mail - that'd probably cover it in an automatable fashion.
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 4 lines · Mark Brown
I'd suggest using pattern matching to look up the
rules for generating the prefixes (it's pretty much entirely prefixes) in the same way you're handling figuring out who to mail - that'd probably cover it in an automatable fashion.
Publish a tool that works and I'll use it.
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 8 lines · Joe Perches
Quoted 4 lines · Mark Brown
I'd suggest using pattern matching to look up the
rules for generating the prefixes (it's pretty much entirely prefixes) in the same way you're handling figuring out who to mail - that'd probably cover it in an automatable fashion.Publish a tool that works and I'll use it.
It appears your scripts are already hooked into get_maintainers.pl which would seem the obvious place to do this? Sadly I don't do perl, though it looks like you're doing pretty much all the work on that anyway.
The main thing here is to avoid your patches sticking out - as well as the hassle applying them stuff like this is also a red flag on review.
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 10 lines · Mark Brown
Quoted 6 lines · Joe Perches
Quoted 4 lines · Mark Brown
I'd suggest using pattern matching to look up the
rules for generating the prefixes (it's pretty much entirely prefixes) in the same way you're handling figuring out who to mail - that'd probably cover it in an automatable fashion.Publish a tool that works and I'll use it.
It appears your scripts are already hooked into get_maintainers.pl which would seem the obvious place to do this? Sadly I don't do perl, though it looks like you're doing pretty much all the work on that anyway.
Sadly, no it's not the right place.
That script just generates cc email addresses
for pre-formatted commit patches.
It'd have to be a script that modifies the git commit subject line to the taste of the subsystem maintainer.
Right now, I use a commit script that's something like:
#!/bin/bash
echo "$1: Remove unnecessary semicolons" > msg
echo >> msg
#cat >> msg <<EOF
#Unnecessary semicolons should not exist.
#EOF
git commit -s -F msg $1
There could be a modification to $1 (path)
or some such.
Maybe a script like ./scripts/convert_commit_subject_to_subsystem_maintainer_taste or something.
Care to write one in sh/bash/perl/python/c/ocaml/c#?
As far as I know, the only subsystem pedants^H^H^H^H^Hople that care much about the commit subject style are arch/x86 and sound.
I can understand the desire of these subsystem maintainers to have a consistent style. I think though that requiring a subject header style without providing more than a general guideline is a but much.
I'd use any other automated tool you want to provide.
cheers, Joe
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Quoted 7 lines · Joe Perches
Quoted 3 lines · Mark Brown
It appears your scripts are already hooked into get_maintainers.pl which would seem the obvious place to do this? Sadly I don't do perl, though it looks like you're doing pretty much all the work on that anyway.
Sadly, no it's not the right place.
To query MAINTAINERS? I'd assume that's where you'd want to put that stuff?
Quoted 8 lines
There could be a modification to $1 (path)
or some such.Maybe a script like
./scripts/convert_commit_subject_to_subsystem_maintainer_tasteor something.Care to write one in sh/bash/perl/python/c/ocaml/c#?
Like I say I'd expect this to be a get_maintainers based lookup to dump some data out?
Quoted 3 lines
As far as I know, the only subsystem pedants^H^H^H^H^Hople that care much about the commit subject style are
arch/x86and sound.
If you look at the kernel you'll see quite a few subsystems which have some sort of standard practice which they do try to enforce, you shouldn't take silence as people being happy here - it's taken me some considerable time to get round to mentioning this, for example, and I might not have bothered if the patch had applied first time around. Like working against -next it's one of these things that would make your patches easier to deal with.
Quoted 4 lines
I can understand the desire of these subsystem maintainers to have a consistent style. I think though that requiring a subject header style without providing more than a general guideline is a but much.
The general guideline I tend to go with is that if what you're doing looks odd for the code you're submitting against for some reason you're doing something wrong unless you understand why you're doing something different and there's a good reason.
Quoted 1 line
I'd use any other automated tool you want to provide.
Like I say, I'd expect the lookup from the database to be handled by get_maintainers.pl. Having a separate database would seem odd.
rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 8 lines · Mark Brown
Quoted 5 lines · Joe Perches
Quoted 3 lines · Mark Brown
It appears your scripts are already hooked into get_maintainers.pl which would seem the obvious place to do this? Sadly I don't do perl, though it looks like you're doing pretty much all the work on that anyway.
Sadly, no it's not the right place.
To query
MAINTAINERS? I'd assume that's where you'd want to put that stuff?
I trimmed cc's and added Andrew Morton and Florian Mickler. First thread link for them: http://lkml.org/lkml/2010/11/15/262
I use get_maintainer to find email addresses with "git send-email --cc-cmd=" but sure it could be extended to find some other new information in the MAINTAINERS file.
Anyway, I think that get_maintainers isn't the proper tool to rewrite commit subject lines, though it could certainly do the lookup of a key in the MAINTAINERS file.
Maybe add a new MAINTAINERS section line something like:
"C: CommitSubjectGrammarStyle"
where CommitSubjectGrammarStyle is something more information rich than "style 1", "style 2".
Perhaps you'll propose a grammar to convert path to header and go through and add these "C:" style entries to the sections you maintain.
Also, what would you expect the output to be when a single patch modified files from 2 subsystems that use different styles?
cheers, Joe
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 4 lines · Joe Perches
Maybe add a new
MAINTAINERSsection line something like:
"C: CommitSubjectGrammarStyle"
where CommitSubjectGrammarStyle is something more information rich than "style 1", "style 2".
Something printfish would seem reasonable?
Quoted 3 lines
Also, what would you expect the output to be when a single patch modified files from 2 subsystems that use different styles?
The traditional thing is "ThingX/ThingY: blah" but as with anything else you need to be sensible.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
In reply to Joe PerchesQuoted 30 lines · On Tue, 16 Nov 2010 06:51:17 -0800 Joe Perches <[email protected]> wrote:
Quoted 8 lines · Mark Brown
Quoted 5 lines · Joe Perches
Quoted 3 lines · Mark Brown
It appears your scripts are already hooked into get_maintainers.pl which would seem the obvious place to do this? Sadly I don't do perl, though it looks like you're doing pretty much all the work on that anyway.
Sadly, no it's not the right place.
To query
MAINTAINERS? I'd assume that's where you'd want to put that stuff?I trimmed cc's and added Andrew Morton and Florian Mickler. First thread link for them: http://lkml.org/lkml/2010/11/15/262
I use
get_maintainerto find email addresses with "git send-email --cc-cmd=" but sure it could be extended to find some other new information in theMAINTAINERSfile.Anyway, I think that
get_maintainersisn't the proper tool to rewrite commit subject lines, though it could certainly do the lookup of a key in theMAINTAINERSfile.Maybe add a new
MAINTAINERSsection line something like:
"C: CommitSubjectGrammarStyle"
where CommitSubjectGrammarStyle is something more information rich than "style 1", "style 2".Perhaps you'll propose a grammar to convert path to header and go through and add these "C:" style entries to the sections you maintain.
Quoted 6 lines
Also, what would you expect the output to be when a single patch modified files from 2 subsystems that use different styles?
cheers, Joe
My first reaction to this is, it's silly. Certainly a subsystem-maintainer is capable of hacking something together that suits his needs or may just use a good editor to get the job done. After all, he might want to edit the commit message anyway. Also he has to have his act together for all non-conforming submitters anyway, because shurely, telling people to re-edit their patches subject line is not what one would consider "welcoming to newbies", or whatever it is kernel subsystem maintainers have to be nowadays *g*...
On second thought, if that facility existed, i think nobody would mind it either. So, why not. I don't see a way to specify what to do with cross-subsystem patches though.
(MAINTAINERS seems to be the logical place to put this information.)
Regards,
Flo
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 8 lines · Florian Mickler
My first reaction to this is, it's silly. Certainly a subsystem-maintainer is capable of hacking something together that suits his needs or may just use a good editor to get the job done. After all, he might want to edit the commit message anyway. Also he has to have his act together for all non-conforming submitters anyway, because shurely, telling people to re-edit their patches subject line is not what one would consider "welcoming to newbies", or whatever it is kernel subsystem maintainers have to be nowadays *g*...
So, my general policy on this is that I tend to push back on patches which don't just work with the toolset (subject lines are just one part of it) to a variable extent depending on who's submitting and what they're submitting. One of the factors is that the more patches are coming from someone the easier I expect their patches to be to work with.
The reason this came up is that this is one of the issues with Joe's patches (which are rather frequent) but he is only willing to do things that he can automate.
Quoted 2 lines
(
MAINTAINERSseems to be the logical place to put this information.)
Indeed.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 18 lines · On Tue, 16 Nov 2010 18:12:27 +0000 Mark Brown…
Quoted 8 lines · Florian Mickler
My first reaction to this is, it's silly. Certainly a subsystem-maintainer is capable of hacking something together that suits his needs or may just use a good editor to get the job done. After all, he might want to edit the commit message anyway. Also he has to have his act together for all non-conforming submitters anyway, because shurely, telling people to re-edit their patches subject line is not what one would consider "welcoming to newbies", or whatever it is kernel subsystem maintainers have to be nowadays *g*...
So, my general policy on this is that I tend to push back on patches which don't just work with the toolset (subject lines are just one part of it) to a variable extent depending on who's submitting and what they're submitting. One of the factors is that the more patches are coming from someone the easier I expect their patches to be to work with.
Quoted 3 lines
The reason this came up is that this is one of the issues with Joe's patches (which are rather frequent) but he is only willing to do things that he can automate.
Hehe, I know that I wouldn't want to hand edit every autogenerated patch people throw at me... What about just dropping everything before the last "]" or ":" and putting an autogenerated prefix before it in a pre-commit hook on your side?
That should work most of the time... don't know... maybe other subsystem maintainers have some more suggestions on reducing the workload... this could even be an interesting topic for some summit...
Regards,
Flo
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 6 lines · Florian Mickler
Hehe, I know that I wouldn't want to hand edit every autogenerated patch people throw at me... What about just dropping everything before the last "]" or ":" and putting an autogenerated prefix before it in a pre-commit hook on your side?
That should work most of the time... don't know... maybe other
It's the most of the time bit that worries me, I'm generally reluctant to script things like this when the scripts aren't very widely used and it's a pain to get hooks distributed over all my systems and working for all the things I need to apply patches for.
Quoted 1 line
From my point of view my current approach is actually working pretty
well with most submitters, even people doing similar janitorial stuff.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 9 lines · On Tue, 16 Nov 2010 19:55:31 +0000 Mark Brown wrote:
Quoted 6 lines · Florian Mickler
Hehe, I know that I wouldn't want to hand edit every autogenerated patch people throw at me... What about just dropping everything before the last "]" or ":" and putting an autogenerated prefix before it in a pre-commit hook on your side?
That should work most of the time... don't know... maybe other
Quoted 7 lines
It's the most of the time bit that worries me, I'm generally reluctant to script things like this when the scripts aren't very widely used and it's a pain to get hooks distributed over all my systems and working for all the things I need to apply patches for.
From my point of view my current approach is actually working pretty well with most submitters, even people doing similar janitorial stuff.
I don't know what you asked Joe to change, but asking someone to use the documented canonical patch format:
<quote>
The canonical patch subject line is:
Subject: [PATCH 001/123] subsystem: summary phrase
</quote>
should be fine. And there is no need for printf-ish templates for this in MAINTAINERS either.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 9 lines · Randy Dunlap
On Tue, 16 Nov 2010 19:55:31 +0000 Mark Brown wrote:
I don't know what you asked Joe to change, but asking someone to use the documented canonical patch format:
<quote>
The canonical patch subject line is:
Subject: [PATCH 001/123] subsystem: summary phrase
</quote>
should be fine. And there is no need for printf-ish templates for this inMAINTAINERSeither.
I've never read that before. Learn something new etc... It seems path prefixes aren't good nor even commonly used.
A review of kernel patch subjects:
$ git log --no-merges --pretty=oneline | \ cut -f2- -d" " | cut -f1 -d: | sort | uniq -c | sort -rn
is interesting. Here's the head:
5007 x86
3943 Staging
3220 USB
2790 sh
2707 KVM
2624 ARM
2449 ALSA
1571 Input
1549 ASoC
1470 iwlwifi
1423 ACPI
1397 mac80211
1384 V4L/DVB
1226 sched
1200 Btrfs
1184 powerpc
1106 [NETFILTER]
1080 MIPS
1049 net
1047 ide
1014 drm/i915
993 staging
921 ath9kSome subsystem maintainers like upper case, some mixed, some lower. Some aren't consistent. (Staging/staging)
It doesn't seem a rule can be pregenerated so maybe adding these "C:" lines to MAINTAINERS has some value.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 35 lines · On Tue, 16 Nov 2010 12:42:36 -0800 Joe Perches wrote:
Quoted 9 lines · Randy Dunlap
On Tue, 16 Nov 2010 19:55:31 +0000 Mark Brown wrote:
I don't know what you asked Joe to change, but asking someone to use the documented canonical patch format:
<quote>
The canonical patch subject line is:
Subject: [PATCH 001/123] subsystem: summary phrase
</quote>
should be fine. And there is no need for printf-ish templates for this inMAINTAINERSeither.I've never read that before. Learn something new etc... It seems path prefixes aren't good nor even commonly used.
A review of kernel patch subjects:
$ git log --no-merges --pretty=oneline | \ cut -f2- -d" " | cut -f1 -d: | sort | uniq -c | sort -rnis interesting. Here's the head:
5007 x86 3943 Staging 3220 USB 2790 sh 2707 KVM 2624 ARM 2449 ALSA 1571 Input 1549 ASoC 1470 iwlwifi 1423 ACPI 1397 mac80211 1384 V4L/DVB 1226 sched 1200 Btrfs
Quoted 8 lines
1184 powerpc
1106 [NETFILTER]
1080 MIPS
1049 net
1047 ide
1014 drm/i915
993 staging
921 ath9k$ARCH is a commonly accepted substitute for subsystem.
And yes, lots of people use <drivername> there as well.
Quoted 2 lines
Some subsystem maintainers like upper case, some mixed, some lower. Some aren't consistent. (Staging/staging)
Case usually doesn't matter to most of us.
Quoted 2 lines
It doesn't seem a rule can be pregenerated so maybe adding these "C:" lines to
MAINTAINERShas some value.
Hopefully it won't go that far.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 6 lines · Randy Dunlap
Quoted 2 lines · On Tue, 16 Nov 2010 12:42:36 -0800 Joe Perches wrote:
Some subsystem maintainers like upper case, some mixed, some lower. Some aren't consistent. (Staging/staging)
Case usually doesn't matter to most of us.
Given that we're working in case sensitive languages here it's probably safe to assume that a reasonable proportion of people will care; being reasonably consistent with existing practice for the subsystem seems sensible.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 6 lines · On Tue, 16 Nov 2010 23:22:58 +0000 Mark Brown wrote:
Quoted 4 lines · Randy Dunlap
Quoted 2 lines · On Tue, 16 Nov 2010 12:42:36 -0800 Joe Perches wrote:
Some subsystem maintainers like upper case, some mixed, some lower. Some aren't consistent. (Staging/staging)
Quoted 6 lines
Quoted 1 line
Case usually doesn't matter to most of us.
Given that we're working in case sensitive languages here it's probably safe to assume that a reasonable proportion of people will care; being reasonably consistent with existing practice for the subsystem seems sensible.
Greg takes patches that say STAGING or Staging or staging.
DaveM takes patches that say net: or netdev: or network: or NET:
The sound maintainers take patches that say sound: or alsa: or ALSA:
etc.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 10 lines · Randy Dunlap
Quoted 8 lines · On Tue, 16 Nov 2010 23:22:58 +0000 Mark Brown wrote:
Quoted 1 line · Randy Dunlap
Case usually doesn't matter to most of us.
Given that we're working in case sensitive languages here it's probably safe to assume that a reasonable proportion of people will care; being reasonably consistent with existing practice for the subsystem seems sensible.
Quoted 7 lines
Greg takes patches that say STAGING or Staging or staging.
DaveM takes patches that say net: or netdev: or network: or NET:
The sound maintainers take patches that say sound: or alsa: or ALSA:
etc.
...and best practice would be to pay attention to what the standard thing is for the subsystem and follow that. We shouldn't be suggesting that people just ignore the case, though obviously if it's not clear then it's not worth worrying too much about it.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
In reply to Randy DunlapQuoted 11 lines · Randy Dunlap
Quoted 9 lines · On Tue, 16 Nov 2010 23:22:58 +0000 Mark Brown wrote:
Quoted 4 lines · Randy Dunlap
Quoted 2 lines · On Tue, 16 Nov 2010 12:42:36 -0800 Joe Perches wrote:
Some subsystem maintainers like upper case, some mixed, some lower. Some aren't consistent. (Staging/staging)
Case usually doesn't matter to most of us.
Given that we're working in case sensitive languages here it's probably safe to assume that a reasonable proportion of people will care; being reasonably consistent with existing practice for the subsystem seems sensible.
Greg takes patches that say STAGING or Staging or staging.
Greg seems to rewrite patch subjects and is inconsistent about case, so he might be doing that by hand.
Quoted 1 line
DaveM takes patches that say net: or netdev: or network: or NET:
DaveM doesn't appear to be choosy about patch subject lines. He seems to take any sensible patch and as far as I know he doesn't edit the subject lines. He does reject inferior patches outright.
Quoted 1 line
The sound maintainers take patches that say sound: or alsa: or ALSA:
The sound maintainers seem to rewrite patch subjects on an ad-hoc basis.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 23 lines · On Tue, 16 Nov 2010 15:57:55 -0800 Joe Perches wrote:
Quoted 11 lines · Randy Dunlap
Quoted 9 lines · On Tue, 16 Nov 2010 23:22:58 +0000 Mark Brown wrote:
Quoted 4 lines · Randy Dunlap
Quoted 2 lines · On Tue, 16 Nov 2010 12:42:36 -0800 Joe Perches wrote:
Some subsystem maintainers like upper case, some mixed, some lower. Some aren't consistent. (Staging/staging)
Case usually doesn't matter to most of us.
Given that we're working in case sensitive languages here it's probably safe to assume that a reasonable proportion of people will care; being reasonably consistent with existing practice for the subsystem seems sensible.
Greg takes patches that say STAGING or Staging or staging.
Greg seems to rewrite patch subjects and is inconsistent about case, so he might be doing that by hand.
Quoted 1 line
DaveM takes patches that say net: or netdev: or network: or NET:
DaveM doesn't appear to be choosy about patch subject lines. He seems to take any sensible patch and as far as I know he doesn't edit the subject lines. He does reject inferior patches outright.
Quoted 4 lines
Quoted 1 line
The sound maintainers take patches that say sound: or alsa: or ALSA:
The sound maintainers seem to rewrite patch subjects on an ad-hoc basis.
OK, I can accept your summary.
However, I can't tell that we are making any progress.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
In reply to Mark BrownQuoted 9 lines · Mark Brown
Quoted 4 lines · Randy Dunlap
Quoted 2 lines · On Tue, 16 Nov 2010 12:42:36 -0800 Joe Perches wrote:
Some subsystem maintainers like upper case, some mixed, some lower. Some aren't consistent. (Staging/staging)
Case usually doesn't matter to most of us.
Given that we're working in case sensitive languages here it's probably safe to assume that a reasonable proportion of people will care; being reasonably consistent with existing practice for the subsystem seems sensible.
Presumably the tool would also have to traverse up the tree to find the appropriate style so every MAINTAINERS section would not need a C entry.
ie: sound/soc/codecs/foo could use the C: entry for sound/soc/
Perhaps something like:
C: ASoC basename:
and for arch/x86/:
C: x86, dirname:
etc.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
In reply to Randy DunlapQuoted 11 lines · Randy Dunlap
I don't know what you asked Joe to change, but asking someone to use the documented canonical patch format:
<quote>
The canonical patch subject line is:Subject: [PATCH 001/123] subsystem: summary phrase
</quote>should be fine. And there is no need for printf-ish templates for this in
MAINTAINERSeither.
That's exactly what I asked him to do. He said he's not willing to use anything for "subsystem" which can't be automatically generated.
The formats I mentioned because some subsystems have their own things within this format like "subsystem: driver:" or whatever. While it's probably not an issue for the sort of patch Joe generates if we do have a tool for this I'd expect it'll go the same way that checkpatch does and get used by people doing more specific work. It'd be good to try to head off the friction that may cause by at least having an idea how we might cope with that.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 8 lines · On Nov 16 Mark Brown wrote:
Quoted 5 lines · Randy Dunlap
I don't know what you asked Joe to change, but asking someone to use the documented canonical patch format:
<quote>
The canonical patch subject line is:
Quoted 8 lines
Quoted 5 lines
Subject: [PATCH 001/123] subsystem: summary phrase
</quote>should be fine. And there is no need for printf-ish templates for this in
MAINTAINERSeither.That's exactly what I asked him to do. He said he's not willing to use anything for "subsystem" which can't be automatically generated.
Why should we codify our conventions in MAINTAINERS to accommodate the specific problem of virtually a _single_ patch author?
Conventions are living and are being adjusted all the time, as code organization changes, people join and go, projects start and cease.
Said author please looks the conventions up in the git history. If he finds that this decelerates his patch generation rate, he can surely code a script that looks into git for him and suggests plausible prefixes for his patch titles to him. Or he can collect a kind of database (a config file) locally for his own use in which he records conventional prefixes on the go.
Signature · 3 lines
Stefan Richter -=====-==-=- =-== =---= http://arcgraph.de/sr/
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 21 lines · Stefan Richter
Quoted 6 lines
Quoted 5 lines
I don't know what you asked Joe to change, but asking someone to use the documented canonical patch format:
<quote>
The canonical patch subject line is:Quoted 8 lines
Quoted 5 lines
Subject: [PATCH 001/123] subsystem: summary phrase
</quote>should be fine. And there is no need for printf-ish templates for this in
MAINTAINERSeither.That's exactly what I asked him to do. He said he's not willing to use anything for "subsystem" which can't be automatically generated.
Why should we codify our conventions in
MAINTAINERSto accommodate the specific problem of virtually a _single_ patch author?Conventions are living and are being adjusted all the time, as code organization changes, people join and go, projects start and cease.
Quoted 6 lines
Said author please looks the conventions up in the git history. If he finds that this decelerates his patch generation rate, he can surely code a script that looks into git for him and suggests plausible prefixes for his patch titles to him. Or he can collect a kind of database (a config file) locally for his own use in which he records conventional prefixes on the go.
Come on guys, this debate is really horribly boring.
Either the maintainer wants the patch. Then he is certainly able to apply it no matter the subject line (I personally am getting a lot of patches which don't follow the format I am using in my tree ... converting
Subject: lines is so trivial that I have never felt like bothering anyone about it ... it's basically single condition in a shellscript). Or the maintainer doesn't feel like the patch is worth it, and then the subject-line format really doesn't matter.
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 4 lines · Jiri Kosina
Quoted 2 lines · Stefan Richter
Why should we codify our conventions in
MAINTAINERSto accommodate the specific problem of virtually a _single_ patch author?
It seems to be the way we're heading in general - look at all the recent work on MAINTAINERS and get_maintainer.pl. There seems to be a genral push to make all this stuff automatable.
Quoted 5 lines
Either the maintainer wants the patch. Then he is certainly able to apply it no matter the subject line (I personally am getting a lot of patches which don't follow the format I am using in my tree ... converting
Subject: lines is so trivial that I have never felt like bothering anyone about it ... it's basically single condition in a shellscript). Or the
It's slightly more than that if you're dealing with more than one area, and I also find this sort of stuff is a good flag for scrubbing the patch in greater detail - when patches stand out from a 1000ft visual overview there's a fair chance that there's other issues so if people regularly submit good patches that have only cosmetic issues I find it's worth guiding them away from that.
Quoted 2 lines
maintainer doesn't feel like the patch is worth it, and then the subject-line format really doesn't matter.
In this case if I don't apply it it's likely to end up going in via your tree and then I'll still have to deal with the merge conflicts which are more annoying.
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 9 lines · On Nov 17 Mark Brown wrote:
Quoted 4 lines · Jiri Kosina
Quoted 2 lines · Stefan Richter
Why should we codify our conventions in
MAINTAINERSto accommodate the specific problem of virtually a _single_ patch author?It seems to be the way we're heading in general - look at all the recent work on
MAINTAINERSand get_maintainer.pl. There seems to be a genral push to make all this stuff automatable.
get_maintainer.pl, used with judgment and together with "gitk the/patched/source.c" is nice not only for people like Joe who regularly work tree-wide but also for ones like me who only rarely want to submit a bug report or patch for a subsystem with they are unfamiliar with.
But the thought of a database of "how to start a good patch title" is far-fetched. Really, as a patch author, just look how other people write patch titles and judge whether this is good for your work too or not.
Quoted 6 lines
Quoted 5 lines
Either the maintainer wants the patch. Then he is certainly able to apply it no matter the subject line (I personally am getting a lot of patches which don't follow the format I am using in my tree ... converting
Subject: lines is so trivial that I have never felt like bothering anyone about it ... it's basically single condition in a shellscript). Or the
Quoted 6 lines
It's slightly more than that if you're dealing with more than one area, and I also find this sort of stuff is a good flag for scrubbing the patch in greater detail - when patches stand out from a 1000ft visual overview there's a fair chance that there's other issues so if people regularly submit good patches that have only cosmetic issues I find it's worth guiding them away from that.
On one hand Jiri is right that maintainers can adjust title prefixes ad hoc. (Downside: Weaker connection to mailinglist archives.) On the other hand, in the case of long-term prolific authors like Joe it is more optimal if there is a good patch title right from the outset.
So, if this boring thread does at least yield the conclusion that ${path}/${filename}: is a bad title prefix, at least something was won. :-)
Another thought: Whether a typical part of a mass conversion, e.g. to use a new helper macro without change of functionality, is named
[PATCH] [subsystem] driver: use foo_bar helper
or
[PATCH] use foo_bar helper in subsystem, driver
does not really matter, does it? This change is more about the helper than about the driver. It is really a different kind of changeset than a functional change that we want to be called
[PATCH] [subsystem] driver: fix crash at disconnection
or so. This is something that those who look for release notes of that driver or subsystem want to grep in the changelog.
Or in other words: If you as patch author wonder what would be a good title for your patch, then ask yourself: How should this change show up in kernel release notes that are constructed from the git shortlog? Sometimes the answer to this question includes among else a prefix with a canonical subsystem name (even case sensitive, with brackets or colon), whereas other times such formalities are utterly pointless.
[Sorry for the spent electrons. But OTOH, issues like (1.) optimum use of reviewer bandwidth, (2.) kernel changelog alias release notes /do/ matter.]
Signature · 3 lines
Stefan Richter -=====-==-=- =-== =---= http://arcgraph.de/sr/
Re: rfc: rewrite commit subject line for subsystem maintainer preference tool
Quoted 3 lines · Stefan Richter
So, if this boring thread does at least yield the conclusion that ${path}/${filename}: is a bad title prefix, at least something was won. :-)
I've changed my scripts to use this style:
Subject: [PATCH] $(basename $(dirname $file)): commit desc...
until a better tool is available.
Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
In reply to Joe PerchesQuoted 9 lines · Joe Perches
Quoted 5 lines · Mark Brown
Quoted 1 line · Joe Perches
Signed-off-by Joe Perches <[email protected]>Applied, thanks.
Please try to use changelog formats consistent with the code you're modifying.I think it's more important to use consistent changelogs for a patch series.
And I agree here. Having to learn code-style quirks for patches is bad, having to learn new changelog style for each subsystem is very bad.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html