Skip to contentSkip to conversation

send-pull-request: Use current date in mail headers

PATCH Applied Darren Hart 4 participants 5 messages Dec 20, 2010 – Dec 21, 2010

lore
Share & tools
lore
#0 lore raw

cover send-pull-request: Use current date in mail headers

This series was sent using the updated send-pull-request script. See PATCH 1/1 for details.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: dvhart/git-pull
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/git-pull

Thanks,
Darren Hart <[email protected]>
---

Darren Hart (1):
send-pull-request: Use current date in mail headers

 scripts/send-pull-request |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
#1 lore raw

PATCH 1/1 send-pull-request: Use current date in mail headers

Some users experience problems viewing the pull requests as a sequential mail series due to the script using the git commit date for the patches and today's date for the cover letter.

Address this by renaming the email Date: header to Old-Date: and adding a new Date: header with a current timestamp.

---
 scripts/send-pull-request |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
scripts/send-pull-request +5 -1
index 0576a5d..03a78f9 100755
@@ -118,7 +118,11 @@ if [ "$cont" == "y" ] || [ "$cont" == "Y" ]; then
         # 
         # Use tail to remove the email envelope from git or formail as
         # msmtp (sendmail) would choke on them.
-        cat $PATCH | formail -I "To: $TO" -I "CC: $CC" | tail -n +2 | sendmail -t
+        #
+        # Modify the patch date for sequential delivery, but retain the
+        # original date as "Old-Date".
+        DATE=$(date +"%a, %d %b %Y %k:%M:%S %z")
+        cat $PATCH | formail -I "To: $TO" -I "CC: $CC" -i "Date: $DATE" | tail -n +2 | sendmail -t
         if [ $? -eq 1 ]; then
             ERROR=1
         fi
Signature · 1 line
1.7.1
#3 lore raw
In reply to Darren Hart
Quoted 12 lines · Darren Hart

This series was sent using the updated send-pull-request script. See PATCH 1/1 for details.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: dvhart/git-pull
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/git-pull

Thanks,
Darren Hart<[email protected]>
---

Quoted 5 lines

Darren Hart (1):
send-pull-request: Use current date in mail headers

  scripts/send-pull-request |    6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)

Much better, thanks

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
Acked-by on v1 1/1
#2 lore raw
In reply to Darren Hart
Quoted 10 lines · Darren Hart

Some users experience problems viewing the pull requests as a sequential mail series due to the script using the git commit date for the patches and today's date for the cover letter.

Address this by renaming the email Date: header to Old-Date: and adding a new Date: header with a current timestamp.

Quoted 21 lines
---
 scripts/send-pull-request |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
scripts/send-pull-request +5 -1
index 0576a5d..03a78f9 100755
@@ -118,7 +118,11 @@ if [ "$cont" == "y" ] || [ "$cont" == "Y" ]; then
         # 
         # Use tail to remove the email envelope from git or formail as
         # msmtp (sendmail) would choke on them.
-        cat $PATCH | formail -I "To: $TO" -I "CC: $CC" | tail -n +2 | sendmail -t
+        #
+        # Modify the patch date for sequential delivery, but retain the
+        # original date as "Old-Date".
+        DATE=$(date +"%a, %d %b %Y %k:%M:%S %z")
+        cat $PATCH | formail -I "To: $TO" -I "CC: $CC" -i "Date: $DATE" | tail -n +2 | sendmail -t
         if [ $? -eq 1 ]; then
             ERROR=1
         fi
Signature · 2 lines
Joshua Lock
        Intel Open Source Technology Centre
Applied
#4 lore raw
In reply to Darren Hart
Quoted 15 lines · Darren Hart

This series was sent using the updated send-pull-request script. See PATCH 1/1 for details.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: dvhart/git-pull
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/git-pull

Thanks,
Darren Hart<[email protected]>
---

Darren Hart (1):
send-pull-request: Use current date in mail headers

Quoted 8 lines
  scripts/send-pull-request |    6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Merged into Master

Thanks
Sau!