Skip to contentSkip to conversation

add initial bb.fetch2 code

PATCH In review Yu Ke 3 participants 17 messages Jan 8, 2011 – Jan 11, 2011

lore
Share & tools
lore

Yu Ke

author
#0 lore raw

cover add initial bb.fetch2 code

this patchset add bb.fetch2 as initiaial code base for fetcher overhaul, and bb.fetcher.instance is introduced to swtich between bb.fetch and bb.fetch2.

The purpose of this patchset is to provide a place holder for fetcher overhaul. currently the bb.fetch2 code is mostly the same as bb.fetch. In the future, fetcher overhaul change will come to bb.fetch2, and this allow us to conduct fetcher change without impacting the existing fetcher bb.fetch.

there is no functional change with this patchset, the bb.fetcher.instance is set to bb.fetch by default.

Thanks Richard for the suggestion.

this patchset has been teseted by
- qemux86 poky-image-sato with empty $DL_DIR

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: kyu3/fetch2-initial
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kyu3/fetch2-initial

Thanks,
Yu Ke <[email protected]>
---

Yu Ke (7):
fetch2: copy bb.fetch to bb.fetch2 as initial code base bb.fetch2: replace bb.fetch with bb.fetch2 in the bb.fetch2
bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2
BBHandler: remove bb.fetch referrence
bb.cooker: remove bb.fetch.persistent_database_connection referrence
bb: replace bb.fetch referrence with bb.fetcher instance
bbclass: replace the bb.fetch referrence with bb.fetcher instance

 bitbake/lib/bb/command.py                  |    3 +-
 bitbake/lib/bb/cooker.py                   |   10 +-
 bitbake/lib/bb/fetch2/__init__.py          |  833 ++++++++++++++++++++++++++++
 bitbake/lib/bb/fetch2/bzr.py               |  148 +++++
 bitbake/lib/bb/fetch2/cvs.py               |  172 ++++++
 bitbake/lib/bb/fetch2/git.py               |  261 +++++++++
 bitbake/lib/bb/fetch2/hg.py                |  180 ++++++
 bitbake/lib/bb/fetch2/local.py             |   73 +++
 bitbake/lib/bb/fetch2/osc.py               |  143 +++++
 bitbake/lib/bb/fetch2/perforce.py          |  206 +++++++
 bitbake/lib/bb/fetch2/repo.py              |   98 ++++
 bitbake/lib/bb/fetch2/ssh.py               |  118 ++++
 bitbake/lib/bb/fetch2/svk.py               |  104 ++++
 bitbake/lib/bb/fetch2/svn.py               |  204 +++++++
 bitbake/lib/bb/fetch2/wget.py              |   93 +++
 bitbake/lib/bb/fetcher.py                  |   26 +
 bitbake/lib/bb/parse/parse_py/BBHandler.py |    2 +-
 meta/classes/base.bbclass                  |   20 +-
 meta/classes/distrodata.bbclass            |   18 +-
 meta/classes/patch.bbclass                 |    4 +-
 meta/classes/sstate.bbclass                |   10 +-
 meta/classes/utility-tasks.bbclass         |   12 +-
 meta/classes/utils.bbclass                 |    2 +-
 23 files changed, 2697 insertions(+), 43 deletions(-)
 create mode 100644 bitbake/lib/bb/fetch2/__init__.py
 create mode 100644 bitbake/lib/bb/fetch2/bzr.py
 create mode 100644 bitbake/lib/bb/fetch2/cvs.py
 create mode 100644 bitbake/lib/bb/fetch2/git.py
 create mode 100644 bitbake/lib/bb/fetch2/hg.py
 create mode 100644 bitbake/lib/bb/fetch2/local.py
 create mode 100644 bitbake/lib/bb/fetch2/osc.py
 create mode 100644 bitbake/lib/bb/fetch2/perforce.py
 create mode 100644 bitbake/lib/bb/fetch2/repo.py
 create mode 100644 bitbake/lib/bb/fetch2/ssh.py
 create mode 100644 bitbake/lib/bb/fetch2/svk.py
 create mode 100644 bitbake/lib/bb/fetch2/svn.py
 create mode 100644 bitbake/lib/bb/fetch2/wget.py
 create mode 100644 bitbake/lib/bb/fetcher.py
author
#2 lore raw

PATCH 2/7 bb.fetch2: replace bb.fetch with bb.fetch2 in the bb.fetch2

bb.fetch2 is copied from bb.fetch, and has many bb.fetch referrence. Fix these referrence with bb.fetch2 referrence

---
 bitbake/lib/bb/fetch2/__init__.py |   22 +++++++++++-----------
 bitbake/lib/bb/fetch2/bzr.py      |    2 +-
 bitbake/lib/bb/fetch2/git.py      |    8 ++++----
 bitbake/lib/bb/fetch2/hg.py       |   10 +++++-----
 bitbake/lib/bb/fetch2/local.py    |    2 +-
 bitbake/lib/bb/fetch2/osc.py      |    8 ++++----
 bitbake/lib/bb/fetch2/perforce.py |    6 +++---
 bitbake/lib/bb/fetch2/repo.py     |    4 ++--
 bitbake/lib/bb/fetch2/ssh.py      |    4 ++--
 bitbake/lib/bb/fetch2/svk.py      |    8 ++++----
 bitbake/lib/bb/fetch2/svn.py      |   10 +++++-----
 bitbake/lib/bb/fetch2/wget.py     |    2 +-
 12 files changed, 43 insertions(+), 43 deletions(-)
bitbake/lib/bb/fetch2/__init__.py +11 -11
index 67e5add..3a209d3 100644
@@ -134,9 +134,9 @@ def uri_replace(uri, uri_find, uri_replace, d):
                 result_decoded[loc] = re.sub(i, uri_replace_decoded[loc], uri_decoded[loc])
                 if uri_find_decoded.index(i) == 2:
                     if d:
-                        localfn = bb.fetch.localpath(uri, d)
+                        localfn = bb.fetch2.localpath(uri, d)
                         if localfn:
-                            result_decoded[loc] = os.path.join(os.path.dirname(result_decoded[loc]), os.path.basename(bb.fetch.localpath(uri, d)))
+                            result_decoded[loc] = os.path.join(os.path.dirname(result_decoded[loc]), os.path.basename(bb.fetch2.localpath(uri, d)))
             else:
                 return uri
     return encodeurl(result_decoded)
@@ -158,7 +158,7 @@ def fetcher_init(d):
     elif srcrev_policy == "clear":
         logger.debug(1, "Clearing SRCREV cache due to cache policy of: %s", srcrev_policy)
         try:
-            bb.fetch.saved_headrevs = pd['BB_URI_HEADREVS'].items()
+            bb.fetch2.saved_headrevs = pd['BB_URI_HEADREVS'].items()
         except:
             pass
         del pd['BB_URI_HEADREVS']
@@ -177,7 +177,7 @@ def fetcher_compare_revisions(d):
 
     pd = persist_data.persist(d)
     data = pd['BB_URI_HEADREVS'].items()
-    data2 = bb.fetch.saved_headrevs
+    data2 = bb.fetch2.saved_headrevs
 
     changed = False
     for key in data:
@@ -375,7 +375,7 @@ def get_srcrev(d):
     #
     # Neater solutions welcome!
     #
-    if bb.fetch.srcrev_internal_call:
+    if bb.fetch2.srcrev_internal_call:
         return "SRCREVINACTION"
 
     scms = []
@@ -491,7 +491,7 @@ def try_mirrors(d, uri, mirrors, check = False, force = False):
         if newuri != uri:
             try:
                 ud = FetchData(newuri, ld)
-            except bb.fetch.NoMethodError:
+            except bb.fetch2.NoMethodError:
                 logger.debug(1, "No method for %s", uri)
                 continue
 
@@ -505,9 +505,9 @@ def try_mirrors(d, uri, mirrors, check = False, force = False):
                 else:
                     ud.method.go(newuri, ud, ld)
                     return ud.localpath
-            except (bb.fetch.MissingParameterError,
-                    bb.fetch.FetchError,
-                    bb.fetch.MD5SumError):
+            except (bb.fetch2.MissingParameterError,
+                    bb.fetch2.FetchError,
+                    bb.fetch2.MD5SumError):
                 import sys
                 (type, value, traceback) = sys.exc_info()
                 logger.debug(2, "Mirror fetch failure: %s" % value)
@@ -568,10 +568,10 @@ class FetchData(object):
                 self.localpath = local
             if not local:
                 try:
-                    bb.fetch.srcrev_internal_call = True
+                    bb.fetch2.srcrev_internal_call = True
                     self.localpath = self.method.localpath(self.url, self, d)
                 finally:
-                    bb.fetch.srcrev_internal_call = False
+                    bb.fetch2.srcrev_internal_call = False
                 # We have to clear data's internal caches since the cached value of SRCREV is now wrong.
                 # Horrible...
                 bb.data.delVar("ISHOULDNEVEREXIST", d)
bitbake/lib/bb/fetch2/bzr.py +1 -1
index afaf799..3d23b4d 100644
@@ -28,7 +28,7 @@ import sys
 import logging
 import bb
 from bb import data
-from bb.fetch import Fetch, FetchError, runfetchcmd, logger
+from bb.fetch2 import Fetch, FetchError, runfetchcmd, logger
 
 class Bzr(Fetch):
     def supports(self, url, ud, d):
bitbake/lib/bb/fetch2/git.py +4 -4
index de415ec..e8ad3b4 100644
@@ -23,9 +23,9 @@ BitBake 'Fetch' git implementation
 import os
 import bb
 from   bb    import data
-from   bb.fetch import Fetch
-from   bb.fetch import runfetchcmd
-from   bb.fetch import logger
+from   bb.fetch2 import Fetch
+from   bb.fetch2 import runfetchcmd
+from   bb.fetch2 import logger
 
 class Git(Fetch):
     """Class to fetch a module or modules from git repositories"""
@@ -225,7 +225,7 @@ class Git(Fetch):
         cmd = "%s ls-remote %s://%s%s%s %s" % (basecmd, ud.proto, username, ud.host, ud.path, ud.branch)
         output = runfetchcmd(cmd, d, True)
         if not output:
-            raise bb.fetch.FetchError("Fetch command %s gave empty output\n" % (cmd))
+            raise bb.fetch2.FetchError("Fetch command %s gave empty output\n" % (cmd))
         return output.split()[0]
 
     def _build_revision(self, url, ud, d):
bitbake/lib/bb/fetch2/hg.py +5 -5
index 3c649a6..9e91bec 100644
@@ -29,11 +29,11 @@ import sys
 import logging
 import bb
 from bb import data
-from bb.fetch import Fetch
-from bb.fetch import FetchError
-from bb.fetch import MissingParameterError
-from bb.fetch import runfetchcmd
-from bb.fetch import logger
+from bb.fetch2 import Fetch
+from bb.fetch2 import FetchError
+from bb.fetch2 import MissingParameterError
+from bb.fetch2 import runfetchcmd
+from bb.fetch2 import logger
 
 class Hg(Fetch):
     """Class to fetch from mercurial repositories"""
bitbake/lib/bb/fetch2/local.py +1 -1
index 6aa9e45..bcb30df 100644
@@ -29,7 +29,7 @@ import os
 import bb
 import bb.utils
 from   bb import data
-from   bb.fetch import Fetch
+from   bb.fetch2 import Fetch
 
 class Local(Fetch):
     def supports(self, url, urldata, d):
bitbake/lib/bb/fetch2/osc.py +4 -4
index 2682096..06ac5a9 100644
@@ -11,10 +11,10 @@ import  sys
 import logging
 import  bb
 from    bb       import data
-from    bb.fetch import Fetch
-from    bb.fetch import FetchError
-from    bb.fetch import MissingParameterError
-from    bb.fetch import runfetchcmd
+from    bb.fetch2 import Fetch
+from    bb.fetch2 import FetchError
+from    bb.fetch2 import MissingParameterError
+from    bb.fetch2 import runfetchcmd
 
 class Osc(Fetch):
     """Class to fetch a module or modules from Opensuse build server
bitbake/lib/bb/fetch2/perforce.py +3 -3
index 222ed7e..18b2781 100644
@@ -30,9 +30,9 @@ import os
 import logging
 import bb
 from   bb import data
-from   bb.fetch import Fetch
-from   bb.fetch import FetchError
-from   bb.fetch import logger
+from   bb.fetch2 import Fetch
+from   bb.fetch2 import FetchError
+from   bb.fetch2 import logger
 
 class Perforce(Fetch):
     def supports(self, url, ud, d):
bitbake/lib/bb/fetch2/repo.py +2 -2
index 03642e7..3330957 100644
@@ -26,8 +26,8 @@ BitBake "Fetch" repo (git) implementation
 import os
 import bb
 from   bb    import data
-from   bb.fetch import Fetch
-from   bb.fetch import runfetchcmd
+from   bb.fetch2 import Fetch
+from   bb.fetch2 import runfetchcmd
 
 class Repo(Fetch):
     """Class to fetch a module or modules from repo (git) repositories"""
bitbake/lib/bb/fetch2/ssh.py +2 -2
index 86c76f4..8b28322 100644
@@ -38,8 +38,8 @@ IETF secsh internet draft:
 
 import re, os
 from   bb import data
-from   bb.fetch import Fetch
-from   bb.fetch import FetchError
+from   bb.fetch2 import Fetch
+from   bb.fetch2 import FetchError
 
 
 __pattern__ = re.compile(r'''
bitbake/lib/bb/fetch2/svk.py +4 -4
index 595a9da..7990ff2 100644
@@ -29,10 +29,10 @@ import os
 import logging
 import bb
 from   bb import data
-from   bb.fetch import Fetch
-from   bb.fetch import FetchError
-from   bb.fetch import MissingParameterError
-from   bb.fetch import logger
+from   bb.fetch2 import Fetch
+from   bb.fetch2 import FetchError
+from   bb.fetch2 import MissingParameterError
+from   bb.fetch2 import logger
 
 class Svk(Fetch):
     """Class to fetch a module or modules from svk repositories"""
bitbake/lib/bb/fetch2/svn.py +5 -5
index 8f053ab..3315b15 100644
@@ -28,11 +28,11 @@ import sys
 import logging
 import bb
 from   bb import data
-from   bb.fetch import Fetch
-from   bb.fetch import FetchError
-from   bb.fetch import MissingParameterError
-from   bb.fetch import runfetchcmd
-from   bb.fetch import logger
+from   bb.fetch2 import Fetch
+from   bb.fetch2 import FetchError
+from   bb.fetch2 import MissingParameterError
+from   bb.fetch2 import runfetchcmd
+from   bb.fetch2 import logger
 
 class Svn(Fetch):
     """Class to fetch a module or modules from svn repositories"""
bitbake/lib/bb/fetch2/wget.py +1 -1
index 4d4bdfd..cf36cca 100644
@@ -30,7 +30,7 @@ import logging
 import bb
 import urllib
 from   bb import data
-from   bb.fetch import Fetch, FetchError, encodeurl, decodeurl, logger, runfetchcmd
+from   bb.fetch2 import Fetch, FetchError, encodeurl, decodeurl, logger, runfetchcmd
 
 class Wget(Fetch):
     """Class to fetch urls via 'wget'"""
Signature · 1 line
1.7.0.4
author
#1 lore raw

PATCH 1/7 fetch2: copy bb.fetch to bb.fetch2 as initial code base

In reply to Yu Ke

bb.fetch2 is intended as a place holder for fetcher overhaul this patch copy exactly bb.fetch as bb.fetch2 initial code base

---
 bitbake/lib/bb/fetch2/__init__.py |  833 +++++++++++++++++++++++++++++++++++++
 bitbake/lib/bb/fetch2/bzr.py      |  148 +++++++
 bitbake/lib/bb/fetch2/cvs.py      |  172 ++++++++
 bitbake/lib/bb/fetch2/git.py      |  261 ++++++++++++
 bitbake/lib/bb/fetch2/hg.py       |  180 ++++++++
 bitbake/lib/bb/fetch2/local.py    |   73 ++++
 bitbake/lib/bb/fetch2/osc.py      |  143 +++++++
 bitbake/lib/bb/fetch2/perforce.py |  206 +++++++++
 bitbake/lib/bb/fetch2/repo.py     |   98 +++++
 bitbake/lib/bb/fetch2/ssh.py      |  118 ++++++
 bitbake/lib/bb/fetch2/svk.py      |  104 +++++
 bitbake/lib/bb/fetch2/svn.py      |  204 +++++++++
 bitbake/lib/bb/fetch2/wget.py     |   93 ++++
 13 files changed, 2633 insertions(+), 0 deletions(-)
 create mode 100644 bitbake/lib/bb/fetch2/__init__.py
 create mode 100644 bitbake/lib/bb/fetch2/bzr.py
 create mode 100644 bitbake/lib/bb/fetch2/cvs.py
 create mode 100644 bitbake/lib/bb/fetch2/git.py
 create mode 100644 bitbake/lib/bb/fetch2/hg.py
 create mode 100644 bitbake/lib/bb/fetch2/local.py
 create mode 100644 bitbake/lib/bb/fetch2/osc.py
 create mode 100644 bitbake/lib/bb/fetch2/perforce.py
 create mode 100644 bitbake/lib/bb/fetch2/repo.py
 create mode 100644 bitbake/lib/bb/fetch2/ssh.py
 create mode 100644 bitbake/lib/bb/fetch2/svk.py
 create mode 100644 bitbake/lib/bb/fetch2/svn.py
 create mode 100644 bitbake/lib/bb/fetch2/wget.py
bitbake/lib/bb/fetch2/__init__.py new file +833 -0
new file mode 100644
index 0000000..67e5add
@@ -0,0 +1,833 @@
+# ex:ts=4:sw=4:sts=4:et
+# -*- tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*-
+"""
+BitBake 'Fetch' implementations
+
+Classes for obtaining upstream sources for the
+BitBake build tools.
+"""
+
+# Copyright (C) 2003, 2004  Chris Larson
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# Based on functions from the base bb module, Copyright 2003 Holger Schurig
+
+from __future__ import absolute_import
+from __future__ import print_function
+import os, re
+import logging
+import bb
+from   bb import data
+from   bb import persist_data
+
+logger = logging.getLogger("BitBake.Fetch")
+
+class MalformedUrl(Exception):
+    """Exception raised when encountering an invalid url"""
+
+class FetchError(Exception):
+    """Exception raised when a download fails"""
+
+class NoMethodError(Exception):
+    """Exception raised when there is no method to obtain a supplied url or set of urls"""
+
+class MissingParameterError(Exception):
+    """Exception raised when a fetch method is missing a critical parameter in the url"""
+
+class ParameterError(Exception):
+    """Exception raised when a url cannot be proccessed due to invalid parameters."""
+
+class MD5SumError(Exception):
+    """Exception raised when a MD5SUM of a file does not match the expected one"""
+
+class InvalidSRCREV(Exception):
+    """Exception raised when an invalid SRCREV is encountered"""
+
+def decodeurl(url):
+    """Decodes an URL into the tokens (scheme, network location, path,
+    user, password, parameters).
+    """
+
+    m = re.compile('(?P<type>[^:]*)://((?P<user>.+)@)?(?P<location>[^;]+)(;(?P<parm>.*))?').match(url)
+    if not m:
+        raise MalformedUrl(url)
+
+    type = m.group('type')
+    location = m.group('location')
+    if not location:
+        raise MalformedUrl(url)
+    user = m.group('user')
+    parm = m.group('parm')
+
+    locidx = location.find('/')
+    if locidx != -1 and type.lower() != 'file':
+        host = location[:locidx]
+        path = location[locidx:]
+    else:
+        host = ""
+        path = location
+    if user:
+        m = re.compile('(?P<user>[^:]+)(:?(?P<pswd>.*))').match(user)
+        if m:
+            user = m.group('user')
+            pswd = m.group('pswd')
+    else:
+        user = ''
+        pswd = ''
+
+    p = {}
+    if parm:
+        for s in parm.split(';'):
+            s1, s2 = s.split('=')
+            p[s1] = s2
+
+    return (type, host, path, user, pswd, p)
+
+def encodeurl(decoded):
+    """Encodes a URL from tokens (scheme, network location, path,
+    user, password, parameters).
+    """
+
+    (type, host, path, user, pswd, p) = decoded
+
+    if not type or not path:
+        raise MissingParameterError("Type or path url components missing when encoding %s" % decoded)
+    url = '%s://' % type
+    if user:
+        url += "%s" % user
+        if pswd:
+            url += ":%s" % pswd
+        url += "@"
+    if host:
+        url += "%s" % host
+    url += "%s" % path
+    if p:
+        for parm in p:
+            url += ";%s=%s" % (parm, p[parm])
+
+    return url
+
+def uri_replace(uri, uri_find, uri_replace, d):
+    if not uri or not uri_find or not uri_replace:
+        logger.debug(1, "uri_replace: passed an undefined value, not replacing")
+    uri_decoded = list(decodeurl(uri))
+    uri_find_decoded = list(decodeurl(uri_find))
+    uri_replace_decoded = list(decodeurl(uri_replace))
+    result_decoded = ['', '', '', '', '', {}]
+    for i in uri_find_decoded:
+        loc = uri_find_decoded.index(i)
+        result_decoded[loc] = uri_decoded[loc]
+        if isinstance(i, basestring):
+            if (re.match(i, uri_decoded[loc])):
+                result_decoded[loc] = re.sub(i, uri_replace_decoded[loc], uri_decoded[loc])
+                if uri_find_decoded.index(i) == 2:
+                    if d:
+                        localfn = bb.fetch.localpath(uri, d)
+                        if localfn:
+                            result_decoded[loc] = os.path.join(os.path.dirname(result_decoded[loc]), os.path.basename(bb.fetch.localpath(uri, d)))
+            else:
+                return uri
+    return encodeurl(result_decoded)
+
+methods = []
+urldata_cache = {}
+saved_headrevs = {}
+
+def fetcher_init(d):
+    """
+    Called to initialize the fetchers once the configuration data is known.
+    Calls before this must not hit the cache.
+    """
+    pd = persist_data.persist(d)
+    # When to drop SCM head revisions controlled by user policy
+    srcrev_policy = bb.data.getVar('BB_SRCREV_POLICY', d, 1) or "clear"
+    if srcrev_policy == "cache":
+        logger.debug(1, "Keeping SRCREV cache due to cache policy of: %s", srcrev_policy)
+    elif srcrev_policy == "clear":
+        logger.debug(1, "Clearing SRCREV cache due to cache policy of: %s", srcrev_policy)
+        try:
+            bb.fetch.saved_headrevs = pd['BB_URI_HEADREVS'].items()
+        except:
+            pass
+        del pd['BB_URI_HEADREVS']
+    else:
+        raise FetchError("Invalid SRCREV cache policy of: %s" % srcrev_policy)
+
+    for m in methods:
+        if hasattr(m, "init"):
+            m.init(d)
+
+def fetcher_compare_revisions(d):
+    """
+    Compare the revisions in the persistant cache with current values and
+    return true/false on whether they've changed.
+    """
+
+    pd = persist_data.persist(d)
+    data = pd['BB_URI_HEADREVS'].items()
+    data2 = bb.fetch.saved_headrevs
+
+    changed = False
+    for key in data:
+        if key not in data2 or data2[key] != data[key]:
+            logger.debug(1, "%s changed", key)
+            changed = True
+            return True
+        else:
+            logger.debug(2, "%s did not change", key)
+    return False
+
+# Function call order is usually:
+#   1. init
+#   2. go
+#   3. localpaths
+# localpath can be called at any time
+
+def init(urls, d, setup = True):
+    urldata = {}
+
+    fn = bb.data.getVar('FILE', d, 1)
+    if fn in urldata_cache:
+        urldata = urldata_cache[fn]
+
+    for url in urls:
+        if url not in urldata:
+            urldata[url] = FetchData(url, d)
+
+    if setup:
+        for url in urldata:
+            if not urldata[url].setup:
+                urldata[url].setup_localpath(d)
+
+    urldata_cache[fn] = urldata
+    return urldata
+
+def mirror_from_string(data):
+    return [ i.split() for i in (data or "").replace('\\n','\n').split('\n') if i ]
+
+def removefile(f):
+    try:
+        os.remove(f)
+    except:
+        pass
+
+def verify_checksum(u, ud, d):
+    """
+    verify the MD5 and SHA256 checksum for downloaded src
+
+    return value:
+        - True: checksum matched
+        - False: checksum unmatched
+
+    if checksum is missing in recipes file, "BB_STRICT_CHECKSUM" decide the return value.
+    if BB_STRICT_CHECKSUM = "1" then return false as unmatched, otherwise return true as
+    matched
+    """
+
+    if not ud.type in ["http", "https", "ftp", "ftps"]:
+        return
+
+    md5data = bb.utils.md5_file(ud.localpath)
+    sha256data = bb.utils.sha256_file(ud.localpath)
+
+    if (ud.md5_expected == None or ud.sha256_expected == None):
+        bb.warn("Missing SRC_URI checksum for %s, consider to add\n" \
+                "SRC_URI[%s] = \"%s\"\nSRC_URI[%s] = \"%s\"" \
+                % (ud.localpath, ud.md5_name, md5data, ud.sha256_name, sha256data))
+        if bb.data.getVar("BB_STRICT_CHECKSUM", d, True) == "1":
+            raise FetchError("No checksum specified for %s." % u)
+        return
+
+    if (ud.md5_expected != md5data or ud.sha256_expected != sha256data):
+        bb.error("The checksums for '%s' did not match." % ud.localpath)
+        bb.error("Expected MD5: '%s' and Got: '%s'" % (ud.md5_expected, md5data))
+        bb.error("Expected SHA256: '%s' and Got: '%s'" % (ud.sha256_expected, sha256data))
+        raise FetchError("%s checksum mismatch." % u)
+
+def go(d, urls = None):
+    """
+    Fetch all urls
+    init must have previously been called
+    """
+    if not urls:
+        urls = d.getVar("SRC_URI", 1).split()
+    urldata = init(urls, d, True)
+
+    for u in urls:
+        ud = urldata[u]
+        m = ud.method
+        localpath = ""
+
+        if not ud.localfile:
+            continue
+
+        lf = bb.utils.lockfile(ud.lockfile)
+
+        if m.try_premirror(u, ud, d):
+            # First try fetching uri, u, from PREMIRRORS
+            mirrors = mirror_from_string(bb.data.getVar('PREMIRRORS', d, True))
+            localpath = try_mirrors(d, u, mirrors, False, m.forcefetch(u, ud, d))
+        elif os.path.exists(ud.localfile):
+            localpath = ud.localfile
+
+        # Need to re-test forcefetch() which will return true if our copy is too old
+        if m.forcefetch(u, ud, d) or not localpath:
+            # Next try fetching from the original uri, u
+            try:
+                m.go(u, ud, d)
+                localpath = ud.localpath
+            except FetchError:
+                # Remove any incomplete file
+                removefile(ud.localpath)
+                # Finally, try fetching uri, u, from MIRRORS
+                mirrors = mirror_from_string(bb.data.getVar('MIRRORS', d, True))
+                localpath = try_mirrors (d, u, mirrors)
+                if not localpath or not os.path.exists(localpath):
+                    raise FetchError("Unable to fetch URL %s from any source." % u)
+
+        ud.localpath = localpath
+
+        if os.path.exists(ud.md5):
+            # Touch the md5 file to show active use of the download
+            try:
+                os.utime(ud.md5, None)
+            except:
+                # Errors aren't fatal here
+                pass
+        else:
+            # Only check the checksums if we've not seen this item before
+            verify_checksum(u, ud, d)
+            Fetch.write_md5sum(u, ud, d)
+
+        bb.utils.unlockfile(lf)
+
+def checkstatus(d, urls = None):
+    """
+    Check all urls exist upstream
+    init must have previously been called
+    """
+    urldata = init([], d, True)
+
+    if not urls:
+        urls = urldata
+
+    for u in urls:
+        ud = urldata[u]
+        m = ud.method
+        logger.debug(1, "Testing URL %s" % u)
+        # First try checking uri, u, from PREMIRRORS
+        mirrors = mirror_from_string(bb.data.getVar('PREMIRRORS', d, True))
+        ret = try_mirrors(d, u, mirrors, True)
+        if not ret:
+            # Next try checking from the original uri, u
+            try:
+                ret = m.checkstatus(u, ud, d)
+            except:
+                # Finally, try checking uri, u, from MIRRORS
+                mirrors = mirror_from_string(bb.data.getVar('MIRRORS', d, True))
+                ret = try_mirrors (d, u, mirrors, True)
+
+        if not ret:
+            raise FetchError("URL %s doesn't work" % u)
+
+def localpaths(d):
+    """
+    Return a list of the local filenames, assuming successful fetch
+    """
+    local = []
+    urldata = init([], d, True)
+
+    for u in urldata:
+        ud = urldata[u]
+        local.append(ud.localpath)
+
+    return local
+
+srcrev_internal_call = False
+
+def get_srcrev(d):
+    """
+    Return the version string for the current package
+    (usually to be used as PV)
+    Most packages usually only have one SCM so we just pass on the call.
+    In the multi SCM case, we build a value based on SRCREV_FORMAT which must
+    have been set.
+    """
+
+    #
+    # Ugly code alert. localpath in the fetchers will try to evaluate SRCREV which
+    # could translate into a call to here. If it does, we need to catch this
+    # and provide some way so it knows get_srcrev is active instead of being
+    # some number etc. hence the srcrev_internal_call tracking and the magic
+    # "SRCREVINACTION" return value.
+    #
+    # Neater solutions welcome!
+    #
+    if bb.fetch.srcrev_internal_call:
+        return "SRCREVINACTION"
+
+    scms = []
+
+    # Only call setup_localpath on URIs which supports_srcrev()
+    urldata = init(bb.data.getVar('SRC_URI', d, 1).split(), d, False)
+    for u in urldata:
+        ud = urldata[u]
+        if ud.method.supports_srcrev():
+            if not ud.setup:
+                ud.setup_localpath(d)
+            scms.append(u)
+
+    if len(scms) == 0:
+        logger.error("SRCREV was used yet no valid SCM was found in SRC_URI")
+        raise ParameterError
+
+    if bb.data.getVar('BB_SRCREV_POLICY', d, True) != "cache":
+        bb.data.setVar('__BB_DONT_CACHE', '1', d)
+
+    if len(scms) == 1:
+        return urldata[scms[0]].method.sortable_revision(scms[0], urldata[scms[0]], d)
+
+    #
+    # Mutiple SCMs are in SRC_URI so we resort to SRCREV_FORMAT
+    #
+    format = bb.data.getVar('SRCREV_FORMAT', d, 1)
+    if not format:
+        logger.error("The SRCREV_FORMAT variable must be set when multiple SCMs are used.")
+        raise ParameterError
+
+    for scm in scms:
+        if 'name' in urldata[scm].parm:
+            name = urldata[scm].parm["name"]
+            rev = urldata[scm].method.sortable_revision(scm, urldata[scm], d)
+            format = format.replace(name, rev)
+
+    return format
+
+def localpath(url, d, cache = True):
+    """
+    Called from the parser with cache=False since the cache isn't ready
+    at this point. Also called from classed in OE e.g. patch.bbclass
+    """
+    ud = init([url], d)
+    if ud[url].method:
+        return ud[url].localpath
+    return url
+
+def runfetchcmd(cmd, d, quiet = False):
+    """
+    Run cmd returning the command output
+    Raise an error if interrupted or cmd fails
+    Optionally echo command output to stdout
+    """
+
+    # Need to export PATH as binary could be in metadata paths
+    # rather than host provided
+    # Also include some other variables.
+    # FIXME: Should really include all export varaiables?
+    exportvars = ['PATH', 'GIT_PROXY_COMMAND', 'GIT_PROXY_HOST',
+                  'GIT_PROXY_PORT', 'GIT_CONFIG', 'http_proxy', 'ftp_proxy',
+                  'https_proxy', 'no_proxy', 'ALL_PROXY', 'all_proxy',
+                  'SSH_AUTH_SOCK', 'SSH_AGENT_PID', 'HOME']
+
+    for var in exportvars:
+        val = data.getVar(var, d, True)
+        if val:
+            cmd = 'export ' + var + '=\"%s\"; %s' % (val, cmd)
+
+    logger.debug(1, "Running %s", cmd)
+
+    # redirect stderr to stdout
+    stdout_handle = os.popen(cmd + " 2>&1", "r")
+    output = ""
+
+    while True:
+        line = stdout_handle.readline()
+        if not line:
+            break
+        if not quiet:
+            print(line, end=' ')
+        output += line
+
+    status = stdout_handle.close() or 0
+    signal = status >> 8
+    exitstatus = status & 0xff
+
+    if signal:
+        raise FetchError("Fetch command %s failed with signal %s, output:\n%s" % (cmd, signal, output))
+    elif status != 0:
+        raise FetchError("Fetch command %s failed with exit code %s, output:\n%s" % (cmd, status, output))
+
+    return output
+
+def try_mirrors(d, uri, mirrors, check = False, force = False):
+    """
+    Try to use a mirrored version of the sources.
+    This method will be automatically called before the fetchers go.
+
+    d Is a bb.data instance
+    uri is the original uri we're trying to download
+    mirrors is the list of mirrors we're going to try
+    """
+    fpath = os.path.join(data.getVar("DL_DIR", d, 1), os.path.basename(uri))
+    if not check and os.access(fpath, os.R_OK) and not force:
+        logger.debug(1, "%s already exists, skipping checkout." % fpath)
+        return fpath
+
+    ld = d.createCopy()
+    for (find, replace) in mirrors:
+        newuri = uri_replace(uri, find, replace, ld)
+        if newuri != uri:
+            try:
+                ud = FetchData(newuri, ld)
+            except bb.fetch.NoMethodError:
+                logger.debug(1, "No method for %s", uri)
+                continue
+
+            ud.setup_localpath(ld)
+
+            try:
+                if check:
+                    found = ud.method.checkstatus(newuri, ud, ld)
+                    if found:
+                        return found
+                else:
+                    ud.method.go(newuri, ud, ld)
+                    return ud.localpath
+            except (bb.fetch.MissingParameterError,
+                    bb.fetch.FetchError,
+                    bb.fetch.MD5SumError):
+                import sys
+                (type, value, traceback) = sys.exc_info()
+                logger.debug(2, "Mirror fetch failure: %s" % value)
+                removefile(ud.localpath)
+                continue
+    return None
+
+
+class FetchData(object):
+    """
+    A class which represents the fetcher state for a given URI.
+    """
+    def __init__(self, url, d):
+        self.localfile = ""
+        (self.type, self.host, self.path, self.user, self.pswd, self.parm) = decodeurl(data.expand(url, d))
+        self.date = Fetch.getSRCDate(self, d)
+        self.url = url
+        if not self.user and "user" in self.parm:
+            self.user = self.parm["user"]
+        if not self.pswd and "pswd" in self.parm:
+            self.pswd = self.parm["pswd"]
+        self.setup = False
+
+        if "name" in self.parm:
+            self.md5_name = "%s.md5sum" % self.parm["name"]
+            self.sha256_name = "%s.sha256sum" % self.parm["name"]
+        else:
+            self.md5_name = "md5sum"
+            self.sha256_name = "sha256sum"
+        self.md5_expected = bb.data.getVarFlag("SRC_URI", self.md5_name, d)
+        self.sha256_expected = bb.data.getVarFlag("SRC_URI", self.sha256_name, d)
+
+        for m in methods:
+            if m.supports(url, self, d):
+                self.method = m
+                return
+        raise NoMethodError("Missing implementation for url %s" % url)
+
+    def setup_localpath(self, d):
+        self.setup = True
+        if "localpath" in self.parm:
+            # if user sets localpath for file, use it instead.
+            self.localpath = self.parm["localpath"]
+            self.basename = os.path.basename(self.localpath)
+        else:
+            premirrors = bb.data.getVar('PREMIRRORS', d, True)
+            local = ""
+            if premirrors and self.url:
+                aurl = self.url.split(";")[0]
+                mirrors = mirror_from_string(premirrors)
+                for (find, replace) in mirrors:
+                    if replace.startswith("file://"):
+                        path = aurl.split("://")[1]
+                        path = path.split(";")[0]
+                        local = replace.split("://")[1] + os.path.basename(path)
+                        if local == aurl or not os.path.exists(local) or os.path.isdir(local):
+                            local = ""
+                self.localpath = local
+            if not local:
+                try:
+                    bb.fetch.srcrev_internal_call = True
+                    self.localpath = self.method.localpath(self.url, self, d)
+                finally:
+                    bb.fetch.srcrev_internal_call = False
+                # We have to clear data's internal caches since the cached value of SRCREV is now wrong.
+                # Horrible...
+                bb.data.delVar("ISHOULDNEVEREXIST", d)
+
+        if self.localpath is not None:
+            # Note: These files should always be in DL_DIR whereas localpath may not be.
+            basepath = bb.data.expand("${DL_DIR}/%s" % os.path.basename(self.localpath), d)
+            self.md5 = basepath + '.md5'
+            self.lockfile = basepath + '.lock'
+
+
+class Fetch(object):
+    """Base class for 'fetch'ing data"""
+
+    def __init__(self, urls = []):
+        self.urls = []
+
+    def supports(self, url, urldata, d):
+        """
+        Check to see if this fetch class supports a given url.
+        """
+        return 0
+
+    def localpath(self, url, urldata, d):
+        """
+        Return the local filename of a given url assuming a successful fetch.
+        Can also setup variables in urldata for use in go (saving code duplication
+        and duplicate code execution)
+        """
+        return url
+    def _strip_leading_slashes(self, relpath):
+        """
+        Remove leading slash as os.path.join can't cope
+        """
+        while os.path.isabs(relpath):
+            relpath = relpath[1:]
+        return relpath
+
+    def setUrls(self, urls):
+        self.__urls = urls
+
+    def getUrls(self):
+        return self.__urls
+
+    urls = property(getUrls, setUrls, None, "Urls property")
+
+    def forcefetch(self, url, urldata, d):
+        """
+        Force a fetch, even if localpath exists?
+        """
+        return False
+
+    def supports_srcrev(self):
+        """
+        The fetcher supports auto source revisions (SRCREV)
+        """
+        return False
+
+    def go(self, url, urldata, d):
+        """
+        Fetch urls
+        Assumes localpath was called first
+        """
+        raise NoMethodError("Missing implementation for url")
+
+    def try_premirror(self, url, urldata, d):
+        """
+        Should premirrors be used?
+        """
+        if urldata.method.forcefetch(url, urldata, d):
+            return True
+        elif os.path.exists(urldata.md5) and os.path.exists(urldata.localfile):
+            return False
+        else:
+            return True
+
+    def checkstatus(self, url, urldata, d):
+        """
+        Check the status of a URL
+        Assumes localpath was called first
+        """
+        logger.info("URL %s could not be checked for status since no method exists.", url)
+        return True
+
+    def getSRCDate(urldata, d):
+        """
+        Return the SRC Date for the component
+
+        d the bb.data module
+        """
+        if "srcdate" in urldata.parm:
+            return urldata.parm['srcdate']
+
+        pn = data.getVar("PN", d, 1)
+
+        if pn:
+            return data.getVar("SRCDATE_%s" % pn, d, 1) or data.getVar("CVSDATE_%s" % pn, d, 1) or data.getVar("SRCDATE", d, 1) or data.getVar("CVSDATE", d, 1) or data.getVar("DATE", d, 1)
+
+        return data.getVar("SRCDATE", d, 1) or data.getVar("CVSDATE", d, 1) or data.getVar("DATE", d, 1)
+    getSRCDate = staticmethod(getSRCDate)
+
+    def srcrev_internal_helper(ud, d):
+        """
+        Return:
+            a) a source revision if specified
+            b) True if auto srcrev is in action
+            c) False otherwise
+        """
+
+        if 'rev' in ud.parm:
+            return ud.parm['rev']
+
+        if 'tag' in ud.parm:
+            return ud.parm['tag']
+
+        rev = None
+        if 'name' in ud.parm:
+            pn = data.getVar("PN", d, 1)
+            rev = data.getVar("SRCREV_%s_pn-%s" % (ud.parm['name'], pn), d, 1)
+            if not rev:
+                rev = data.getVar("SRCREV_pn-%s_%s" % (pn, ud.parm['name']), d, 1)
+            if not rev:
+                rev = data.getVar("SRCREV_%s" % (ud.parm['name']), d, 1)           
+        if not rev:
+            rev = data.getVar("SRCREV", d, 1)
+        if rev == "INVALID":
+            raise InvalidSRCREV("Please set SRCREV to a valid value")
+        if not rev:
+            return False
+        if rev is "SRCREVINACTION":
+            return True
+        return rev
+
+    srcrev_internal_helper = staticmethod(srcrev_internal_helper)
+
+    def localcount_internal_helper(ud, d):
+        """
+        Return:
+            a) a locked localcount if specified
+            b) None otherwise
+        """
+
+        localcount = None
+        if 'name' in ud.parm:
+            pn = data.getVar("PN", d, 1)
+            localcount = data.getVar("LOCALCOUNT_" + ud.parm['name'], d, 1)
+        if not localcount:
+            localcount = data.getVar("LOCALCOUNT", d, 1)
+        return localcount
+
+    localcount_internal_helper = staticmethod(localcount_internal_helper)
+
+    def verify_md5sum(ud, got_sum):
+        """
+        Verify the md5sum we wanted with the one we got
+        """
+        wanted_sum = ud.parm.get('md5sum')
+        if not wanted_sum:
+            return True
+
+        return wanted_sum == got_sum
+    verify_md5sum = staticmethod(verify_md5sum)
+
+    def write_md5sum(url, ud, d):
+        md5data = bb.utils.md5_file(ud.localpath)
+        # verify the md5sum
+        if not Fetch.verify_md5sum(ud, md5data):
+            raise MD5SumError(url)
+
+        md5out = file(ud.md5, 'w')
+        md5out.write(md5data)
+        md5out.close()
+    write_md5sum = staticmethod(write_md5sum)
+
+    def latest_revision(self, url, ud, d):
+        """
+        Look in the cache for the latest revision, if not present ask the SCM.
+        """
+        if not hasattr(self, "_latest_revision"):
+            raise ParameterError
+
+        pd = persist_data.persist(d)
+        revs = pd['BB_URI_HEADREVS']
+        key = self.generate_revision_key(url, ud, d)
+        rev = revs[key]
+        if rev != None:
+            return str(rev)
+
+        revs[key] = rev = self._latest_revision(url, ud, d)
+        return rev
+
+    def sortable_revision(self, url, ud, d):
+        """
+
+        """
+        if hasattr(self, "_sortable_revision"):
+            return self._sortable_revision(url, ud, d)
+
+        pd = persist_data.persist(d)
+        localcounts = pd['BB_URI_LOCALCOUNT']
+        key = self.generate_revision_key(url, ud, d)
+
+        latest_rev = self._build_revision(url, ud, d)
+        last_rev = localcounts[key + '_rev']
+        uselocalcount = bb.data.getVar("BB_LOCALCOUNT_OVERRIDE", d, True) or False
+        count = None
+        if uselocalcount:
+            count = Fetch.localcount_internal_helper(ud, d)
+        if count is None:
+            count = localcounts[key + '_count']
+
+        if last_rev == latest_rev:
+            return str(count + "+" + latest_rev)
+
+        buildindex_provided = hasattr(self, "_sortable_buildindex")
+        if buildindex_provided:
+            count = self._sortable_buildindex(url, ud, d, latest_rev)
+
+        if count is None:
+            count = "0"
+        elif uselocalcount or buildindex_provided:
+            count = str(count)
+        else:
+            count = str(int(count) + 1)
+
+        localcounts[key + '_rev'] = latest_rev
+        localcounts[key + '_count'] = count
+
+        return str(count + "+" + latest_rev)
+
+    def generate_revision_key(self, url, ud, d):
+        key = self._revision_key(url, ud, d)
+        return "%s-%s" % (key, bb.data.getVar("PN", d, True) or "")
+
+from . import cvs
+from . import git
+from . import local
+from . import svn
+from . import wget
+from . import svk
+from . import ssh
+from . import perforce
+from . import bzr
+from . import hg
+from . import osc
+from . import repo
+
+methods.append(local.Local())
+methods.append(wget.Wget())
+methods.append(svn.Svn())
+methods.append(git.Git())
+methods.append(cvs.Cvs())
+methods.append(svk.Svk())
+methods.append(ssh.SSH())
+methods.append(perforce.Perforce())
+methods.append(bzr.Bzr())
+methods.append(hg.Hg())
+methods.append(osc.Osc())
+methods.append(repo.Repo())
bitbake/lib/bb/fetch2/bzr.py new file +148 -0

148 lines not on this page · raw message

bitbake/lib/bb/fetch2/cvs.py new file +172 -0

172 lines not on this page · raw message

bitbake/lib/bb/fetch2/git.py new file +261 -0

261 lines not on this page · raw message

bitbake/lib/bb/fetch2/hg.py new file +180 -0

180 lines not on this page · raw message

bitbake/lib/bb/fetch2/local.py new file +73 -0

73 lines not on this page · raw message

bitbake/lib/bb/fetch2/osc.py new file +143 -0

143 lines not on this page · raw message

bitbake/lib/bb/fetch2/perforce.py new file +206 -0

206 lines not on this page · raw message

bitbake/lib/bb/fetch2/repo.py new file +98 -0

98 lines not on this page · raw message

bitbake/lib/bb/fetch2/ssh.py new file +118 -0

118 lines not on this page · raw message

bitbake/lib/bb/fetch2/svk.py new file +104 -0

104 lines not on this page · raw message

bitbake/lib/bb/fetch2/svn.py new file +204 -0

204 lines not on this page · raw message

bitbake/lib/bb/fetch2/wget.py new file +93 -0

93 lines not on this page · raw message

Signature · 1 line
1.7.0.4
author
#3 lore raw

PATCH 3/7 bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

In reply to Yu Ke

bb.fetcher is introduced to swtich between bb.fetch and bb.fetch2. all bb.fetch/bb.fetch2 referrence can be replaced with bb.fetcher.instance, so that we can cleanly switch between bb.fetch and bb.fetch2

---
 bitbake/lib/bb/fetcher.py |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 bitbake/lib/bb/fetcher.py
bitbake/lib/bb/fetcher.py new file +26 -0
new file mode 100644
index 0000000..3818d78
@@ -0,0 +1,26 @@
+#!/usr/bin/env python
+# ex:ts=4:sw=4:sts=4:et
+# -*- tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*-
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+import bb
+from bb import fetch, fetch2
+
+# switch between fetch and fetch2
+instance = bb.fetch
+__version__ = "1"
+
+#instance = bb.fetch2
+#__version__ = "2"
Signature · 1 line
1.7.0.4
author
#13 lore raw

PATCH 4/7 BBHandler: remove bb.fetch referrence

In reply to Yu Ke

BBHandler.py no longer use bb.fetch, so remove its import statement

---
 bitbake/lib/bb/parse/parse_py/BBHandler.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
bitbake/lib/bb/parse/parse_py/BBHandler.py +1 -1
index 81554b9..eb58eef 100644
@@ -28,7 +28,7 @@
 from __future__ import absolute_import
 import re, bb, os
 import logging
-import bb.fetch, bb.build, bb.utils
+import bb.build, bb.utils
 from bb import data
 
 from . import ConfHandler
Signature · 1 line
1.7.0.4
author
#14 lore raw

PATCH 5/7 bb.cooker: remove bb.fetch.persistent_database_connection referrence

In reply to Yu Ke

persistent_database_connection is already removed in bb.fetch, so remove its referrence in bb.cooker accordingly.

---
 bitbake/lib/bb/cooker.py |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
bitbake/lib/bb/cooker.py +0 -6
index 23fd72f..77544cd 100644
@@ -644,9 +644,6 @@ class BBCooker:
         buildname = bb.data.getVar("BUILDNAME", self.configuration.data)
         bb.event.fire(bb.event.BuildStarted(buildname, [item]), self.configuration.event_data)
 
-        # Clear locks
-        bb.fetch.persistent_database_connection = {}
-
         # Execute the runqueue
         runlist = [[item, "do_%s" % task]]
 
@@ -728,9 +725,6 @@ class BBCooker:
             runlist.append([k, "do_%s" % task])
         taskdata.add_unresolved(localdata, self.status)
 
-        # Clear locks
-        bb.fetch.persistent_database_connection = {}
-
         rq = bb.runqueue.RunQueue(self, self.configuration.data, self.status, taskdata, runlist)
 
         self.server.register_idle_function(buildTargetsIdle, rq)
Signature · 1 line
1.7.0.4
author
#15 lore raw

PATCH 6/7 bb: replace bb.fetch referrence with bb.fetcher instance

In reply to Yu Ke

bb.fetcher.instance is a wraper for bb.fetch/bb.fetch2, which allow easy switch between bb.fetch and bb.fetch2. so replace all the bb.fetch referrence with bb.fetcher.instance

---
 bitbake/lib/bb/command.py |    3 ++-
 bitbake/lib/bb/cooker.py  |    4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)
bitbake/lib/bb/command.py +2 -1
index b880892..28bccd0 100644
@@ -31,6 +31,7 @@ Commands are queued in a CommandQueue
 import bb.event
 import bb.cooker
 import bb.data
+import bb.fetcher
 
 async_cmds = {}
 sync_cmds = {}
@@ -264,7 +265,7 @@ class CommandsAsync:
         """
         Parse the .bb files
         """
-        if bb.fetch.fetcher_compare_revisions(command.cooker.configuration.data):
+        if bb.fetcher.instance.fetcher_compare_revisions(command.cooker.configuration.data):
             command.finishAsyncCommand(code=1)
         else:
             command.finishAsyncCommand()
bitbake/lib/bb/cooker.py +2 -2
index 77544cd..f6235c3 100644
@@ -34,7 +34,7 @@ import threading
 from cStringIO import StringIO
 from contextlib import closing
 import bb
-from bb import utils, data, parse, event, cache, providers, taskdata, command, runqueue
+from bb import utils, data, parse, event, cache, providers, taskdata, command, runqueue, fetcher
 
 logger      = logging.getLogger("BitBake")
 collectlog  = logging.getLogger("BitBake.Collection")
@@ -524,7 +524,7 @@ class BBCooker:
             bb.event.register(var, bb.data.getVar(var, self.configuration.data))
 
         if bb.data.getVar("BB_WORKERCONTEXT", self.configuration.data) is None:
-            bb.fetch.fetcher_init(self.configuration.data)
+            bb.fetcher.instance.fetcher_init(self.configuration.data)
         bb.codeparser.parser_cache_init(self.configuration.data)
         bb.parse.init_parser(data)
         bb.event.fire(bb.event.ConfigParsed(), self.configuration.data)
Signature · 1 line
1.7.0.4
author
#16 lore raw

PATCH 7/7 bbclass: replace the bb.fetch referrence with bb.fetcher instance

In reply to Yu Ke

bb.fetcher.instance is a wraper for bb.fetch/bb.fetch2, which allow easy switch between bb.fetch and bb.fetch2. so replace all the bb.fetch referrence with bb.fetcher.instance

---
 meta/classes/base.bbclass          |   20 ++++++++++----------
 meta/classes/distrodata.bbclass    |   18 +++++++++---------
 meta/classes/patch.bbclass         |    4 ++--
 meta/classes/sstate.bbclass        |   10 +++++-----
 meta/classes/utility-tasks.bbclass |   12 ++++++------
 meta/classes/utils.bbclass         |    2 +-
 6 files changed, 33 insertions(+), 33 deletions(-)
meta/classes/base.bbclass +10 -10
index f8ce123..eb4bac2 100644
@@ -126,8 +126,8 @@ python base_do_fetch() {
 		return 1
 
 	try:
-		bb.fetch.init(src_uri.split(),d)
-	except bb.fetch.NoMethodError:
+		bb.fetcher.instance.init(src_uri.split(),d)
+	except bb.fetcher.instance.NoMethodError:
 		(type, value, traceback) = sys.exc_info()
 		raise bb.build.FuncFailed("No method: %s" % value)
 	except bb.MalformedUrl:
@@ -135,14 +135,14 @@ python base_do_fetch() {
 		raise bb.build.FuncFailed("Malformed URL: %s" % value)
 
 	try:
-		bb.fetch.go(localdata)
-	except bb.fetch.MissingParameterError:
+		bb.fetcher.instance.go(localdata)
+	except bb.fetcher.instance.MissingParameterError:
 		(type, value, traceback) = sys.exc_info()
 		raise bb.build.FuncFailed("Missing parameters: %s" % value)
-	except bb.fetch.FetchError:
+	except bb.fetcher.instance.FetchError:
 		(type, value, traceback) = sys.exc_info()
 		raise bb.build.FuncFailed("Fetch failed: %s" % value)
-	except bb.fetch.MD5SumError:
+	except bb.fetcher.instance.MD5SumError:
 		(type, value, traceback) = sys.exc_info()
 		raise bb.build.FuncFailed("MD5  failed: %s" % value)
 	except:
@@ -242,14 +242,14 @@ python base_do_unpack() {
 	localdata = bb.data.createCopy(d)
 	bb.data.update_data(localdata)
 
-	urldata = bb.fetch.init([], localdata, True)
+	urldata = bb.fetcher.instance.init([], localdata, True)
 
 	src_uri = bb.data.getVar('SRC_URI', localdata, True)
 	if not src_uri:
 		return
 	for url in src_uri.split():
 		try:
-			local = bb.data.expand(bb.fetch.localpath(url, localdata), localdata)
+			local = bb.data.expand(bb.fetcher.instance.localpath(url, localdata), localdata)
 		except bb.MalformedUrl, e:
 			raise FuncFailed('Unable to generate local path for malformed uri: %s' % e)
 		if local is None:
@@ -536,7 +536,7 @@ python () {
             for s in srcuri.split():
                 if not s.startswith("file://"):
                     continue
-                local = bb.data.expand(bb.fetch.localpath(s, d), d)
+                local = bb.data.expand(bb.fetcher.instance.localpath(s, d), d)
                 for mp in paths:
                     if local.startswith(mp):
                         #bb.note("overriding PACKAGE_ARCH from %s to %s" % (pkg_arch, mach_arch))
@@ -585,7 +585,7 @@ python do_cleanall() {
 		return
 	for url in src_uri.split():
 		try:
-			local = bb.data.expand(bb.fetch.localpath(url, localdata), localdata)
+			local = bb.data.expand(bb.fetcher.instance.localpath(url, localdata), localdata)
 		except bb.MalformedUrl, e:
 			raise FuncFailed('Unable to generate local path for malformed uri: %s' % e)
 		if local is None:
meta/classes/distrodata.bbclass +9 -9
index 1866f98..8b0bce8 100644
@@ -308,17 +308,17 @@ python do_checkpkg() {
 			bitbake check url multiple times when looping through a single url
 			"""
 			fn = bb.data.getVar('FILE', d, 1)
-			bb.fetch.urldata_cache[fn] = {}
-			bb.fetch.init([url], d)
-		except bb.fetch.NoMethodError:
+			bb.fetcher.instance.urldata_cache[fn] = {}
+			bb.fetcher.instance.init([url], d)
+		except bb.fetcher.instance.NoMethodError:
 			status = "ErrFetchNoMethod"
 		except:
 			status = "ErrInitUrlUnknown"
 		else:
 			"""
 			To avoid impacting bitbake build engine, this trick is required for reusing bitbake
-			interfaces. bb.fetch.go() is not appliable as it checks downloaded content in ${DL_DIR}
-			while we don't want to pollute that place. So bb.fetch.checkstatus() is borrowed here
+			interfaces. bb.fetcher.instance.go() is not appliable as it checks downloaded content in ${DL_DIR}
+			while we don't want to pollute that place. So bb.fetcher.instance.checkstatus() is borrowed here
 			which is designed for check purpose but we override check command for our own purpose
 			"""
 			ld = bb.data.createCopy(d)
@@ -327,12 +327,12 @@ python do_checkpkg() {
 			bb.data.update_data(ld)
 
 			try:
-				bb.fetch.checkstatus(ld)
-			except bb.fetch.MissingParameterError:
+				bb.fetcher.instance.checkstatus(ld)
+			except bb.fetcher.instance.MissingParameterError:
 				status = "ErrMissParam"
-			except bb.fetch.FetchError:
+			except bb.fetcher.instance.FetchError:
 				status = "ErrFetch"
-			except bb.fetch.MD5SumError:
+			except bb.fetcher.instance.MD5SumError:
 				status = "ErrMD5Sum"
 			except:
 				status = "ErrFetchUnknown"
meta/classes/patch.bbclass +2 -2
index ee8a202..76a5319 100644
@@ -58,9 +58,9 @@ python patch_do_patch() {
 			continue
 
 		if not local:
-			bb.fetch.init([url],d)
+			bb.fetcher.instance.init([url],d)
 			url = bb.encodeurl((type, host, path, user, pswd, []))
-			local = os.path.join('/', bb.fetch.localpath(url, d))
+			local = os.path.join('/', bb.fetcher.instance.localpath(url, d))
 		local = bb.data.expand(local, d)
 
 		if "striplevel" in parm:
meta/classes/sstate.bbclass +5 -5
index b6e6c92..ab03a3c 100644
@@ -318,11 +318,11 @@ def pstaging_fetch(sstatepkg, d):
         # Try a fetch from the sstate mirror, if it fails just return and
         # we will build the package
         try:
-            bb.fetch.init([srcuri], localdata)
-            bb.fetch.go(localdata, [srcuri])
+            bb.fetcher.instance.init([srcuri], localdata)
+            bb.fetcher.instance.go(localdata, [srcuri])
             # Need to optimise this, if using file:// urls, the fetcher just changes the local path
             # For now work around by symlinking
-            localpath = bb.data.expand(bb.fetch.localpath(srcuri, localdata), localdata)
+            localpath = bb.data.expand(bb.fetcher.instance.localpath(srcuri, localdata), localdata)
             if localpath != sstatepkg and os.path.exists(localpath):
                 os.symlink(localpath, sstatepkg)
         except:
@@ -421,8 +421,8 @@ def sstate_checkhashes(sq_fn, sq_task, sq_hash, sq_hashfn, d):
             #bb.note(str(srcuri))
 
             try:
-                bb.fetch.init(srcuri.split(), localdata)
-                bb.fetch.checkstatus(localdata, srcuri.split())
+                bb.fetcher.instance.init(srcuri.split(), localdata)
+                bb.fetcher.instance.checkstatus(localdata, srcuri.split())
                 ret.append(task)
             except:
                 pass     
meta/classes/utility-tasks.bbclass +6 -6
index db22973..4295151 100644
@@ -58,20 +58,20 @@ python do_checkuri() {
 	src_uri = bb.data.getVar('SRC_URI', localdata, 1)
 
 	try:
-		bb.fetch.init(src_uri.split(),d)
-	except bb.fetch.NoMethodError:
+		bb.fetcher.instance.init(src_uri.split(),d)
+	except bb.fetcher.instance.NoMethodError:
 		(type, value, traceback) = sys.exc_info()
 		raise bb.build.FuncFailed("No method: %s" % value)
 
 	try:
-		bb.fetch.checkstatus(localdata)
-	except bb.fetch.MissingParameterError:
+		bb.fetcher.instance.checkstatus(localdata)
+	except bb.fetcher.instance.MissingParameterError:
 		(type, value, traceback) = sys.exc_info()
 		raise bb.build.FuncFailed("Missing parameters: %s" % value)
-	except bb.fetch.FetchError:
+	except bb.fetcher.instance.FetchError:
 		(type, value, traceback) = sys.exc_info()
 		raise bb.build.FuncFailed("Fetch failed: %s" % value)
-	except bb.fetch.MD5SumError:
+	except bb.fetcher.instance.MD5SumError:
 		(type, value, traceback) = sys.exc_info()
 		raise bb.build.FuncFailed("MD5  failed: %s" % value)
 	except:
meta/classes/utils.bbclass +1 -1
index 746f46c..d0e7a44 100644
@@ -51,7 +51,7 @@ def machine_paths(d):
 def is_machine_specific(d):
     """Determine whether the current recipe is machine specific"""
     machinepaths = set(machine_paths(d))
-    urldatadict = bb.fetch.init(d.getVar("SRC_URI", True).split(), d, True)
+    urldatadict = bb.fetcher.instance.init(d.getVar("SRC_URI", True).split(), d, True)
     for urldata in (urldata for urldata in urldatadict.itervalues()
                     if urldata.type == "file"):
         if any(urldata.localpath.startswith(mp + "/") for mp in machinepaths):
Signature · 1 line
1.7.0.4
#4 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

In reply to Yu Ke
Quoted 32 lines · Yu Ke

bb.fetcher is introduced to swtich between bb.fetch and bb.fetch2. all bb.fetch/bb.fetch2 referrence can be replaced with bb.fetcher.instance, so that we can cleanly switch between bb.fetch and bb.fetch2

---
 bitbake/lib/bb/fetcher.py |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 bitbake/lib/bb/fetcher.py
bitbake/lib/bb/fetcher.py new file +16 -0
new file mode 100644
index 0000000..3818d78
@@ -0,0 +1,26 @@
+#!/usr/bin/env python
+# ex:ts=4:sw=4:sts=4:et
+# -*- tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*-
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

bitbake/lib/bb/fetcher.py line 26

Quoted 10 lines
bitbake/lib/bb/fetcher.py new file +10 -0
+
+import bb
+from bb import fetch, fetch2
+
+# switch between fetch and fetch2
+instance = bb.fetch
+__version__ = "1"
+
+#instance = bb.fetch2
+#__version__ = "2"

I'm not very happy with this, it doesn't feel right. Can we not add some runtime determination of which module to use (a variable in bitbake.conf?) and then use some dynamic Python magic to add it to the imported modules list?

A quick Google makes me thing we could do something more dynamic with the __import__() function.

Cheers,
Joshua

Signature · 2 lines
Joshua Lock
        Intel Open Source Technology Centre
#5 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

Quoted 49 lines · Joshua Lock
Quoted 32 lines · Yu Ke

bb.fetcher is introduced to swtich between bb.fetch and bb.fetch2. all bb.fetch/bb.fetch2 referrence can be replaced with bb.fetcher.instance, so that we can cleanly switch between bb.fetch and bb.fetch2

---
 bitbake/lib/bb/fetcher.py |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 bitbake/lib/bb/fetcher.py
bitbake/lib/bb/fetcher.py new file +16 -0
new file mode 100644
index 0000000..3818d78
@@ -0,0 +1,26 @@
+#!/usr/bin/env python
+# ex:ts=4:sw=4:sts=4:et
+# -*- tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*-
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

bitbake/lib/bb/fetcher.py line 26

Quoted 10 lines
bitbake/lib/bb/fetcher.py new file +10 -0
+
+import bb
+from bb import fetch, fetch2
+
+# switch between fetch and fetch2
+instance = bb.fetch
+__version__ = "1"
+
+#instance = bb.fetch2
+#__version__ = "2"

I'm not very happy with this, it doesn't feel right. Can we not add some runtime determination of which module to use (a variable in bitbake.conf?) and then use some dynamic Python magic to add it to the imported modules list?

Quoted 2 lines

A quick Google makes me thing we could do something more dynamic with the __import__() function.

Agreed, I was also thinking about this but wanted to come up with a suggestion about how to better handle it. There is some interesting info in this webpage:

http://stackoverflow.com/questions/1096216/override-namespace-in-python

This example in particular looks useful:

def weirdimport(fullpath):
global project

import os
import sys sys.path.append(os.path.dirname(fullpath)) try:
project = __import__(os.path.basename(fullpath)) sys.modules['project'] = project
finally:

      del sys.path[-1]

Although we shouldn't need to manipulate sys.path in our case.

As Joshua mentions, overriding the __import__ builtin should also work and might avoid some ordering issues we'd have with the above.

Cheers,

Richard

#6 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

Quoted 38 lines · Richard Purdie
Quoted 16 lines · Joshua Lock

bitbake/lib/bb/fetcher.py line 26

Quoted 9 lines · Yu Ke
bitbake/lib/bb/fetcher.py new file +9 -0
+import bb
+from bb import fetch, fetch2
+
+# switch between fetch and fetch2
+instance = bb.fetch
+__version__ = "1"
+
+#instance = bb.fetch2
+#__version__ = "2"

I'm not very happy with this, it doesn't feel right. Can we not add some runtime determination of which module to use (a variable in bitbake.conf?) and then use some dynamic Python magic to add it to the imported modules list?

Quoted 2 lines

A quick Google makes me thing we could do something more dynamic with the __import__() function.

Agreed, I was also thinking about this but wanted to come up with a suggestion about how to better handle it. There is some interesting info in this webpage:

http://stackoverflow.com/questions/1096216/override-namespace-in-python

This example in particular looks useful:

def weirdimport(fullpath):
global project

import os
import sys sys.path.append(os.path.dirname(fullpath)) try:
project = __import__(os.path.basename(fullpath)) sys.modules['project'] = project
finally:

Quoted 6 lines
      del sys.path[-1]

Although we shouldn't need to manipulate sys.path in our case.

As Joshua mentions, overriding the __import__ builtin should also work and might avoid some ordering issues we'd have with the above.

I did come up with this code inserted at the start of bin/bitbake:

origimport = __builtins__.__import__
def bbimport(name, *args, **kwargs):
newname = name
if name.find("bb.fetch") != -1:
newname = name.replace("bb.fetch", "bb.fetch2")
ret = origimport(newname, *args, **kwargs) if name != newname:
sys.modules[name] = sys.modules[newname] if name == "bb.fetch":
bb.fetch = sys.modules[newname]
return ret
if os.environ.get('BBFETCH2'):

    __builtins__.__import__ = bbimport

which is pretty ugly :(. The big advantage of this is that it does redirect any bb.fetch calls into bb.fetch2 calls, even within the bb.fetch2 codebase.

I'm working through some other ideas as time permits.

Cheers,

Richard

#7 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

Quoted 60 lines · Richard Purdie
Quoted 38 lines · Richard Purdie
Quoted 16 lines · Joshua Lock

bitbake/lib/bb/fetcher.py line 26

Quoted 9 lines · Yu Ke
bitbake/lib/bb/fetcher.py new file +9 -0
+import bb
+from bb import fetch, fetch2
+
+# switch between fetch and fetch2
+instance = bb.fetch
+__version__ = "1"
+
+#instance = bb.fetch2
+#__version__ = "2"

I'm not very happy with this, it doesn't feel right. Can we not add some runtime determination of which module to use (a variable in bitbake.conf?) and then use some dynamic Python magic to add it to the imported modules list?

Quoted 2 lines

A quick Google makes me thing we could do something more dynamic with the __import__() function.

Agreed, I was also thinking about this but wanted to come up with a suggestion about how to better handle it. There is some interesting info in this webpage:

http://stackoverflow.com/questions/1096216/override-namespace-in-python

This example in particular looks useful:

def weirdimport(fullpath):
global project

import os
import sys sys.path.append(os.path.dirname(fullpath)) try:
project = __import__(os.path.basename(fullpath)) sys.modules['project'] = project
finally:

Quoted 6 lines
      del sys.path[-1]

Although we shouldn't need to manipulate sys.path in our case.

As Joshua mentions, overriding the __import__ builtin should also work and might avoid some ordering issues we'd have with the above.

I did come up with this code inserted at the start of bin/bitbake:

origimport = __builtins__.__import__
def bbimport(name, *args, **kwargs):
newname = name
if name.find("bb.fetch") != -1:
newname = name.replace("bb.fetch", "bb.fetch2")
ret = origimport(newname, *args, **kwargs) if name != newname:
sys.modules[name] = sys.modules[newname] if name == "bb.fetch":
bb.fetch = sys.modules[newname]
return ret
if os.environ.get('BBFETCH2'):

Quoted 7 lines
    __builtins__.__import__ = bbimport

which is pretty ugly :(. The big advantage of this is that it does redirect any bb.fetch calls into bb.fetch2 calls, even within the bb.fetch2 codebase.

I'm working through some other ideas as time permits.

If we assume bb.fetch2 will not make calls to bb.fetch we can simplify this to:

if os.environ.get("BBFETCH2"):
from bb import fetch2 as fetch sys.modules['bb.fetch'] = sys.modules['bb.fetch2']

so from the environment you can trigger the new fetcher code. For Poky, I've added something to hardcode that behaviour since I don't want it to break.

I've pushed this both into Poky and bitbake upstream so we're in sync and can move forward on improving the fetcher code :).

Cheers,

Richard

author
#8 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

Quoted 76 lines · Richard Purdie
Quoted 60 lines · Richard Purdie
Quoted 38 lines · Richard Purdie
Quoted 16 lines · Joshua Lock

bitbake/lib/bb/fetcher.py line 26

Quoted 9 lines · Yu Ke
bitbake/lib/bb/fetcher.py new file +9 -0
+import bb
+from bb import fetch, fetch2
+
+# switch between fetch and fetch2
+instance = bb.fetch
+__version__ = "1"
+
+#instance = bb.fetch2
+#__version__ = "2"

I'm not very happy with this, it doesn't feel right. Can we not add some runtime determination of which module to use (a variable in bitbake.conf?) and then use some dynamic Python magic to add it to the imported modules list?

Quoted 2 lines

A quick Google makes me thing we could do something more dynamic with the __import__() function.

Agreed, I was also thinking about this but wanted to come up with a suggestion about how to better handle it. There is some interesting info in this webpage:

http://stackoverflow.com/questions/1096216/override-namespace-in-python

This example in particular looks useful:

def weirdimport(fullpath):
global project

import os
import sys sys.path.append(os.path.dirname(fullpath)) try:
project = __import__(os.path.basename(fullpath)) sys.modules['project'] = project
finally:

Quoted 6 lines
      del sys.path[-1]

Although we shouldn't need to manipulate sys.path in our case.

As Joshua mentions, overriding the __import__ builtin should also work and might avoid some ordering issues we'd have with the above.

I did come up with this code inserted at the start of bin/bitbake:

origimport = __builtins__.__import__
def bbimport(name, *args, **kwargs):
newname = name
if name.find("bb.fetch") != -1:
newname = name.replace("bb.fetch", "bb.fetch2")
ret = origimport(newname, *args, **kwargs) if name != newname:
sys.modules[name] = sys.modules[newname] if name == "bb.fetch":
bb.fetch = sys.modules[newname]
return ret
if os.environ.get('BBFETCH2'):

Quoted 7 lines
    __builtins__.__import__ = bbimport

which is pretty ugly :(. The big advantage of this is that it does redirect any bb.fetch calls into bb.fetch2 calls, even within the bb.fetch2 codebase.

I'm working through some other ideas as time permits.

If we assume bb.fetch2 will not make calls to bb.fetch we can simplify this to:

if os.environ.get("BBFETCH2"):
from bb import fetch2 as fetch sys.modules['bb.fetch'] = sys.modules['bb.fetch2']

Quoted 6 lines

so from the environment you can trigger the new fetcher code. For Poky, I've added something to hardcode that behaviour since I don't want it to break.

I've pushed this both into Poky and bitbake upstream so we're in sync and can move forward on improving the fetcher code :).

Thanks Josh and Richard. I did think about the dynamic switch by bb config variable, but did not find a good implementation. Richard's approach looks simple and clean. A good learning on the python powerful dynamicness for me.

Regards
Ke

Quoted 14 lines

Cheers,

Richard

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

author
#9 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

In reply to Richard Purdie
Quoted 67 lines · Richard Purdie
Quoted 66 lines · Richard Purdie
Quoted 38 lines · Richard Purdie
Quoted 16 lines · Joshua Lock

bitbake/lib/bb/fetcher.py line 26

Quoted 9 lines · Yu Ke
bitbake/lib/bb/fetcher.py new file +9 -0
+import bb
+from bb import fetch, fetch2
+
+# switch between fetch and fetch2
+instance = bb.fetch
+__version__ = "1"
+
+#instance = bb.fetch2
+#__version__ = "2"

I'm not very happy with this, it doesn't feel right. Can we not add some runtime determination of which module to use (a variable in bitbake.conf?) and then use some dynamic Python magic to add it to the imported modules list?

Quoted 2 lines

A quick Google makes me thing we could do something more dynamic with the __import__() function.

Agreed, I was also thinking about this but wanted to come up with a suggestion about how to better handle it. There is some interesting info in this webpage:

http://stackoverflow.com/questions/1096216/override-namespace-in-python

This example in particular looks useful:

def weirdimport(fullpath):
global project

import os
import sys sys.path.append(os.path.dirname(fullpath)) try:
project = __import__(os.path.basename(fullpath)) sys.modules['project'] = project
finally:

Quoted 6 lines
      del sys.path[-1]

Although we shouldn't need to manipulate sys.path in our case.

As Joshua mentions, overriding the __import__ builtin should also work and might avoid some ordering issues we'd have with the above.

I did come up with this code inserted at the start of bin/bitbake:

origimport = __builtins__.__import__
def bbimport(name, *args, **kwargs):
newname = name
if name.find("bb.fetch") != -1:
newname = name.replace("bb.fetch", "bb.fetch2")
ret = origimport(newname, *args, **kwargs) if name != newname:
sys.modules[name] = sys.modules[newname] if name == "bb.fetch":
bb.fetch = sys.modules[newname]
return ret
if os.environ.get('BBFETCH2'):

    __builtins__.__import__ = bbimport

which is pretty ugly :(. The big advantage of this is that it does redirect any bb.fetch calls into bb.fetch2 calls, even within the bb.fetch2 codebase.

Quoted 8 lines
Quoted 1 line

I'm working through some other ideas as time permits.

If we assume bb.fetch2 will not make calls to bb.fetch we can simplify this to:

if os.environ.get("BBFETCH2"):
from bb import fetch2 as fetch sys.modules['bb.fetch'] = sys.modules['bb.fetch2']

BTW, a quick question. with sys.modules['bb.fetch'] = sys.modules['bb.fetch2'], will the future "import bb.fetch" override the bb.fetch in namespeace ? I assume not, but just want to double confirm. I know that "import <module>" will not be executed if the <module> is already imported. So does python use sys.modules[<module>] to decide if it is already imported?

Regards
Ke

Quoted 21 lines

so from the environment you can trigger the new fetcher code. For Poky, I've added something to hardcode that behaviour since I don't want it to break.

I've pushed this both into Poky and bitbake upstream so we're in sync and can move forward on improving the fetcher code :).

Cheers,

Richard

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

#10 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

Quoted 7 lines · Yu Ke
Quoted 6 lines

If we assume bb.fetch2 will not make calls to bb.fetch we can simplify this to:

if os.environ.get("BBFETCH2"):
from bb import fetch2 as fetch sys.modules['bb.fetch'] = sys.modules['bb.fetch2']

Quoted 6 lines

BTW, a quick question. with sys.modules['bb.fetch'] = sys.modules['bb.fetch2'], will the future "import bb.fetch" override the bb.fetch in namespeace ? I assume not, but just want to double confirm. I know that "import <module>" will not be executed if the <module> is already imported. So does python use sys.modules[<module>] to decide if it is already imported?

This is correct, yes. Python uses sys.modules behind the scenes when it sees "import X". You can prove this by placing a sys.exit(1) in the bb.fetch code :)

Cheers,

Richard

author
#11 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

Quoted 15 lines · Richard Purdie
Quoted 7 lines · Yu Ke
Quoted 6 lines

If we assume bb.fetch2 will not make calls to bb.fetch we can simplify this to:

if os.environ.get("BBFETCH2"):
from bb import fetch2 as fetch sys.modules['bb.fetch'] = sys.modules['bb.fetch2']

Quoted 6 lines

BTW, a quick question. with sys.modules['bb.fetch'] = sys.modules['bb.fetch2'], will the future "import bb.fetch" override the bb.fetch in namespeace ? I assume not, but just want to double confirm. I know that "import <module>" will not be executed if the <module> is already imported. So does python use sys.modules[<module>] to decide if it is already imported?

Quoted 3 lines

This is correct, yes. Python uses sys.modules behind the scenes when it sees "import X". You can prove this by placing a sys.exit(1) in the bb.fetch code :)

Thanks, yes, it is clear to me now.

Regards
Ke

Quoted 7 lines

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

#12 lore raw

Re: [PATCH 3/7] bb: add bb.fetcher as dynamic fetch module instance for fetch/fetch2

In reply to Richard Purdie
Quoted 67 lines · Richard Purdie
Quoted 66 lines · Richard Purdie
Quoted 38 lines · Richard Purdie
Quoted 16 lines · Joshua Lock

bitbake/lib/bb/fetcher.py line 26

Quoted 9 lines · Yu Ke
bitbake/lib/bb/fetcher.py new file +9 -0
+import bb
+from bb import fetch, fetch2
+
+# switch between fetch and fetch2
+instance = bb.fetch
+__version__ = "1"
+
+#instance = bb.fetch2
+#__version__ = "2"

I'm not very happy with this, it doesn't feel right. Can we not add some runtime determination of which module to use (a variable in bitbake.conf?) and then use some dynamic Python magic to add it to the imported modules list?

Quoted 2 lines

A quick Google makes me thing we could do something more dynamic with the __import__() function.

Agreed, I was also thinking about this but wanted to come up with a suggestion about how to better handle it. There is some interesting info in this webpage:

http://stackoverflow.com/questions/1096216/override-namespace-in-python

This example in particular looks useful:

def weirdimport(fullpath):
global project

import os
import sys sys.path.append(os.path.dirname(fullpath)) try:
project = __import__(os.path.basename(fullpath)) sys.modules['project'] = project
finally:

Quoted 6 lines
      del sys.path[-1]

Although we shouldn't need to manipulate sys.path in our case.

As Joshua mentions, overriding the __import__ builtin should also work and might avoid some ordering issues we'd have with the above.

I did come up with this code inserted at the start of bin/bitbake:

origimport = __builtins__.__import__
def bbimport(name, *args, **kwargs):
newname = name
if name.find("bb.fetch") != -1:
newname = name.replace("bb.fetch", "bb.fetch2")
ret = origimport(newname, *args, **kwargs) if name != newname:
sys.modules[name] = sys.modules[newname] if name == "bb.fetch":
bb.fetch = sys.modules[newname]
return ret
if os.environ.get('BBFETCH2'):

    __builtins__.__import__ = bbimport

which is pretty ugly :(. The big advantage of this is that it does redirect any bb.fetch calls into bb.fetch2 calls, even within the bb.fetch2 codebase.

Quoted 8 lines
Quoted 1 line

I'm working through some other ideas as time permits.

If we assume bb.fetch2 will not make calls to bb.fetch we can simplify this to:

if os.environ.get("BBFETCH2"):
from bb import fetch2 as fetch sys.modules['bb.fetch'] = sys.modules['bb.fetch2']

Lovely, this is almost exactly what I had envisaged :-)

Cheers,
Joshua

Quoted 17 lines

so from the environment you can trigger the new fetcher code. For Poky, I've added something to hardcode that behaviour since I don't want it to break.

I've pushed this both into Poky and bitbake upstream so we're in sync and can move forward on improving the fetcher code :).

Cheers,

Richard

Signature · 2 lines
Joshua Lock
        Intel Open Source Technology Centre