Skip to contentSkip to conversation

scons misc patches

PATCH In review Víctor Manuel Jáquez Leal 2 participants 8 messages Jan 25, 2011

lore
Share & tools
lore
#0 lore raw

v2 cover scons misc patches

I order to keep the atomic nature of the git commits, I splitted in two this change set.

The version two is based on the previous requests for the first approach submitted to the list (move the line to a better position in the recipe and verifying the licence of the project).

Víctor Manuel Jáquez Leal (2):
python-scons_1.3.0: add missing dependencies
python-scons_1.3.0: fix licence type

 recipes/python/python-scons_1.3.0.bb |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH v2 1/2 python-scons_1.3.0: add missing dependencies

In order to launch scons in a board it depends on a couple python packages which were not managed by the recipe.

This patch adds them.

---
 recipes/python/python-scons_1.3.0.bb |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
recipes/python/python-scons_1.3.0.bb +9 -0
index 792e3a5..a0690d1 100644
@@ -3,6 +3,7 @@ SECTION = "devel/python"
 PRIORITY = "optional"
 LICENSE = "GPL"
 SRCNAME = "scons"
+PR = "r1"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz;name=scons \
            file://toolchain-from-env.SConscript \
@@ -21,3 +22,11 @@ do_install_append() {
 
 NATIVE_INSTALL_WORKS = "1"
 BBCLASSEXTEND = "native"
+
+RDEPENDS_${PN} = "python-shell \
+	       python-stringold \
+	       python-lang \
+	       python-io \
+	       python-fcntl \
+	       python-pickle \
+	       python-crypt"
Signature · 1 line
1.7.2.3
#3 lore raw

PATCH v2 2/2 python-scons_1.3.0: fix licence type

In reply to Víctor Manuel Jáquez Leal

According to the wiki [1], the licence of the project [2] is MIT, not GPL.

1. http://www.scons.org/wiki/FrequentlyAskedQuestions#head-4fe23271137d5e5e95370a1360909ca303157c0d
2. http://scons.tigris.org/source/browse/scons/trunk/LICENSE?revision=557&view=markup

---
 recipes/python/python-scons_1.3.0.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/python/python-scons_1.3.0.bb +1 -1
index a0690d1..82231f2 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "A Software Construction Tool"
 SECTION = "devel/python"
 PRIORITY = "optional"
-LICENSE = "GPL"
+LICENSE = "MIT"
 SRCNAME = "scons"
 PR = "r1"
 
Signature · 1 line
1.7.2.3
Acked-by on v2 1/2
#2 lore raw

Re: [PATCHv2 1/2] python-scons_1.3.0: add missing dependencies

In reply to Víctor Manuel Jáquez Leal

Op 25 jan 2011, om 17:16 heeft Víctor Manuel Jáquez Leal het volgende geschreven:

Quoted 6 lines

In order to launch scons in a board it depends on a couple python packages which were not managed by the recipe.

This patch adds them.

Quoted 31 lines

---
recipes/python/python-scons_1.3.0.bb | 9 +++++++++

1 files changed, 9 insertions(+), 0 deletions(-)
recipes/python/python-scons_1.3.0.bb +0 -0
index 792e3a5..a0690d1 100644
@@ -3,6 +3,7 @@ SECTION = "devel/python"

PRIORITY = "optional"
LICENSE = "GPL"
SRCNAME = "scons"
+PR = "r1"

SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz;name=scons \
           file://toolchain-from-env.SConscript \
recipes/python/python-scons_1.3.0.bb +0 -0
@@ -21,3 +22,11 @@ do_install_append() {
 

NATIVE_INSTALL_WORKS = "1"
BBCLASSEXTEND = "native"

recipes/python/python-scons_1.3.0.bb +8 -0
+
+RDEPENDS_${PN} = "python-shell \
+	       python-stringold \
+	       python-lang \
+	       python-io \
+	       python-fcntl \
+	       python-pickle \
+	       python-crypt"
Signature · 1 line
1.7.2.3
Acked-by on v2 2/2
#4 lore raw

Re: [PATCHv2 2/2] python-scons_1.3.0: fix licence type

In reply to Víctor Manuel Jáquez Leal

Op 25 jan 2011, om 17:16 heeft Víctor Manuel Jáquez Leal het volgende geschreven:

Quoted 4 lines

According to the wiki [1], the licence of the project [2] is MIT, not GPL.

1. http://www.scons.org/wiki/FrequentlyAskedQuestions#head-4fe23271137d5e5e95370a1360909ca303157c0d
2. http://scons.tigris.org/source/browse/scons/trunk/LICENSE?revision=557&view=markup

Missing sign-off?

Quoted 20 lines

---
recipes/python/python-scons_1.3.0.bb | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
recipes/python/python-scons_1.3.0.bb +0 -0
index a0690d1..82231f2 100644
@@ -1,7 +1,7 @@

DESCRIPTION = "A Software Construction Tool"
SECTION = "devel/python"
PRIORITY = "optional"

recipes/python/python-scons_1.3.0.bb +1 -1
-LICENSE = "GPL"
+LICENSE = "MIT"

SRCNAME = "scons"
PR = "r1"

Signature · 1 line
1.7.2.3
#5 lore raw

Re: [PATCHv2 2/2] python-scons_1.3.0: fix licence type

Quoted 9 lines · Koen Kooi

Op 25 jan 2011, om 17:16 heeft Víctor Manuel Jáquez Leal het volgende geschreven:

Quoted 4 lines

According to the wiki [1], the licence of the project [2] is MIT, not GPL.

1. http://www.scons.org/wiki/FrequentlyAskedQuestions#head-4fe23271137d5e5e95370a1360909ca303157c0d
2. http://scons.tigris.org/source/browse/scons/trunk/LICENSE?revision=557&view=markup

Missing sign-off?

D'oh!

Do I resend it?

vmjl

#6 lore raw

Re: [PATCHv2 2/2] python-scons_1.3.0: fix licence type

Op 25 jan 2011, om 17:25 heeft Víctor M. Jáquez L. het volgende geschreven:

Quoted 6 lines · Koen Kooi
Quoted 5 lines

Op 25 jan 2011, om 17:16 heeft Víctor Manuel Jáquez Leal het volgende geschreven:

Quoted 2 lines

According to the wiki [1], the licence of the project [2] is MIT, not GPL.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

1. http://www.scons.org/wiki/FrequentlyAskedQuestions#head-4fe23271137d5e5e95370a1360909ca303157c0d
2. http://scons.tigris.org/source/browse/scons/trunk/LICENSE?revision=557&view=markup

Missing sign-off?

D'oh!

Do I resend it?

Just reply to it, patchwork will pick it up

#7 lore raw

PATCH v3 1/1 python-scons_1.3.0: fix licence type

In reply to Víctor Manuel Jáquez Leal

According to the wiki [1], the licence of the project [2] is MIT, not GPL.

1. http://www.scons.org/wiki/FrequentlyAskedQuestions#head-4fe23271137d5e5e95370a1360909ca303157c0d
2. http://scons.tigris.org/source/browse/scons/trunk/LICENSE?revision=557&view=markup

---
 recipes/python/python-scons_1.3.0.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/python/python-scons_1.3.0.bb +1 -1
index a0690d1..82231f2 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "A Software Construction Tool"
 SECTION = "devel/python"
 PRIORITY = "optional"
-LICENSE = "GPL"
+LICENSE = "MIT"
 SRCNAME = "scons"
 PR = "r1"
 
Signature · 1 line
1.7.2.3