Skip to contentSkip to conversation

Ensure Bash is used when spawning terminals

PATCH New Joshua Lock 1 participant 1 message Feb 23, 2011 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 Ensure Bash is used when spawning terminals

From: Joshua Lock <[email protected]>

We rely on Bashisms when spawning a terminal so ensure that bash is used when using devshell and menuconfig.

Fixes [BUGID #119]

---
 meta/classes/devshell.bbclass |    4 ++--
 meta/classes/kernel.bbclass   |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
meta/classes/devshell.bbclass +2 -2
index 4fb3e63..5f262f4 100644
@@ -9,7 +9,8 @@ devshell_do_devshell() {
 	export XAUTHORITY='${XAUTHORITY}'
 	export TERMWINDOWTITLE="Bitbake Developer Shell"
 	export EXTRA_OEMAKE='${EXTRA_OEMAKE}'
-	${TERMCMD}
+	export SHELLCMDS="bash"
+	${TERMCMDRUN}
 	if [ $? -ne 0 ]; then
 	    echo "Fatal: '${TERMCMD}' not found. Check TERMCMD variable."
 	    exit 1
@@ -17,6 +18,5 @@ devshell_do_devshell() {
 }
 addtask devshell after do_patch
 
-
 EXPORT_FUNCTIONS do_devshell
 
meta/classes/kernel.bbclass +1 -1
index a1b1354..5d9b86a 100644
@@ -202,7 +202,7 @@ do_menuconfig() {
         export DBUS_SESSION_BUS_ADDRESS='${DBUS_SESSION_BUS_ADDRESS}'
         export XAUTHORITY='${XAUTHORITY}'
 	export TERMWINDOWTITLE="${PN} Kernel Configuration"
-	export SHELLCMDS="make menuconfig"
+	export SHELLCMDS="bash make menuconfig"
 	${TERMCMDRUN}
 	if [ $? -ne 0 ]; then
 		echo "Fatal: '${TERMCMD}' not found. Check TERMCMD variable."
Signature · 1 line
1.7.4