Skip to contentSkip to conversation

Two minor fixes for oe-core

PATCH Applied Mark Hatle 2 participants 4 messages Mar 3, 2011

lore
Share & tools
lore

Mark Hatle

author
#0 lore raw

cover Two minor fixes for oe-core

The first fix implementes the workaround I posted in the oe-core getting started. Simply adding the BBFETCH2=True is all that is needed.

The second fixes the ELF qa loaders bit size identification.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: mhatle/oecore/fixes
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/oecore/fixes

Thanks,
Mark Hatle <[email protected]>
---

Mark Hatle (2):
poky-env-internal: Add FETCH2 enablement
qa.py: Fix a typo when evaluating bitsize

 meta/lib/oe/qa.py         |    4 ++--
 scripts/poky-env-internal |    2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.4
author
#1 lore raw

PATCH 1/2 poky-env-internal: Add FETCH2 enablement

We need to enable the new fetch2 implementation out of bitbake. Otherwise we get various errors about SRCPV issues.

---
 scripts/poky-env-internal |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
scripts/poky-env-internal +2 -0
index 80b7a12..724a6e4 100755
@@ -56,3 +56,5 @@ export BUILDDIR
 export PATH
 
 export BB_ENV_EXTRAWHITE="MACHINE DISTRO POKYMODE POKYLIBC http_proxy ftp_proxy https_proxy all_proxy ALL_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK BB_SRCREV_POLICY SDKMACHINE BB_NUMBER_THREADS GIT_PROXY_COMMAND PSEUDO_DISABLED"
+
+export BBFETCH2=True
Signature · 1 line
1.7.4
author
#2 lore raw

PATCH 2/2 qa.py: Fix a typo when evaluating bitsize

In reply to Mark Hatle

This should be setting a variable, not performing a comparison.

---
 meta/lib/oe/qa.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta/lib/oe/qa.py +2 -2
index 7adf4d0..d380012 100644
@@ -40,9 +40,9 @@ class ELFFile:
         self.my_assert(self.data[3], 'F')
         if self.bits == 0:
             if self.data[ELFFile.EI_CLASS] == chr(ELFFile.ELFCLASS32):
-                self.bits == 32
+                self.bits = 32
             elif self.data[ELFFile.EI_CLASS] == chr(ELFFile.ELFCLASS64):
-                self.bits == 64
+                self.bits = 64
             else:
                 # Not 32-bit or 64.. lets assert
                 raise Exception("ELF but not 32 or 64 bit.")
Signature · 1 line
1.7.4
#3 lore raw
In reply to Mark Hatle
Quoted 15 lines · Mark Hatle

The first fix implementes the workaround I posted in the oe-core getting started. Simply adding the BBFETCH2=True is all that is needed.

The second fixes the ELF qa loaders bit size identification.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: mhatle/oecore/fixes
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/oecore/fixes

Thanks,
Mark Hatle <[email protected]>
---

Quoted 7 lines

Mark Hatle (2):
poky-env-internal: Add FETCH2 enablement
qa.py: Fix a typo when evaluating bitsize

 meta/lib/oe/qa.py         |    4 ++--
 scripts/poky-env-internal |    2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

Merged into OE-Core master, thanks.

Richard