Skip to contentSkip to conversation

formfactor: Assume HAVE_TOUCHSCREEN=0

PATCH Applied Darren Hart 2 participants 2 messages Mar 16, 2011 1 message not in the archive

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 formfactor: Assume HAVE_TOUCHSCREEN=0

In reply to a message not in the archive

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: dvhart/bernard/n450
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/bernard/n450

Thanks,
Darren Hart <[email protected]>
---

Darren Hart (1):
formfactor: Assume HAVE_TOUCHSCREEN=0

 meta/recipes-bsp/formfactor/files/config |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

If no machine specific formfactor is found, the formfactor config defaults to HAVE_TOUCHSCREEN=1. The result is for the matchbox session to disable the cursor. This can lead to a lot of churn sorting out why the cursor doesn't
appear: xorg bug, xorg driver bug, kernel drm driver bug, kms bug, many of which appear when searching for invisible cursor on the web.

On the other hand, if a cursor appears on a touchscreen device, one is much more likely to reach a correct conclusion: "I need to set HAVE_TOUCHSCREEN=1 in my custom machine formfactor config". Which likely exists or is needed for other formfactor specific things such as dpi, screen size, rotation, etc.

---
 meta/recipes-bsp/formfactor/files/config |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-bsp/formfactor/files/config +1 -1
index ed15d9e..e936916 100755
@@ -5,7 +5,7 @@ if [ -e /etc/formfactor/machconfig ]; then
 fi
 
 if [ -z "$HAVE_TOUCHSCREEN" ]; then
-    HAVE_TOUCHSCREEN=1
+    HAVE_TOUCHSCREEN=0
 fi
 
 if [ -z "$HAVE_KEYBOARD" ]; then
Signature · 1 line
1.7.1