Fix Keyboard and Mouse on n450 [YOCTO #869]

PATCH In review Darren Hart 2 participants 7 messages Mar 16, 2011

lore

Share & tools

lore

Darren Hart

author

2011-03-16 00:19 UTC #0 lore raw

cover Fix Keyboard and Mouse on n450 [YOCTO #869]

From: Darren Hart <[email protected]>

Before committing these patches to the meta-intel layer, I'd appreciate a review, perhaps from Tom, to ensure I didn't miss anything - seeing how close we are to release.

Pull URL: git://git.pokylinux.org/meta-intel.git
Branch: dvhart/bernard/n450
Browse: http://git.pokylinux.org/cgit.cgi/meta-intel/log/?h=dvhart/bernard/n450

Thanks,
Darren Hart <[email protected]>
---

Darren Hart (2):
n450: add formfactor config
n450: add xorg.conf to disable AutoAddDevices

 .../formfactor/formfactor/n450/machconfig          |    3 ++
 .../recipes-bsp/formfactor/formfactor_0.0.bbappend |    3 ++
 .../xserver-xf86-config/n450/xorg.conf             |   26 ++++++++++++++++++++
 .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    3 ++
 4 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 meta-n450/recipes-bsp/formfactor/formfactor/n450/machconfig
 create mode 100644 meta-n450/recipes-bsp/formfactor/formfactor_0.0.bbappend
 create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf
 create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend

Darren Hart

author

2011-03-16 00:19 UTC #1 lore raw

PATCH 1/2 n450: add formfactor config

From: Darren Hart <[email protected]>

Fixes [YOCTO #869] (1 of 2)

Add a formfactor config for the n450 to include a keyboard and no touchscreen. Without defining HAVE_TOUCHSCREEN=0, the default was to set it to 1, and the matchbox session disables the cursor in the case of a touchscreen device.

Signed-off-by Darren Hart <[email protected]>

CC Tom Zanussi <[email protected]>

---
 .../formfactor/formfactor/n450/machconfig          |    3 +++
 .../recipes-bsp/formfactor/formfactor_0.0.bbappend |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)
 create mode 100644 meta-n450/recipes-bsp/formfactor/formfactor/n450/machconfig
 create mode 100644 meta-n450/recipes-bsp/formfactor/formfactor_0.0.bbappend

meta-n450/recipes-bsp/formfactor/formfactor/n450/machconfig new file +3 -0

new file mode 100644
index 0000000..ffce012
@@ -0,0 +1,3 @@
+# Assume a USB mouse and keyboard are connected
+HAVE_TOUCHSCREEN=0
+HAVE_KEYBOARD=1

meta-n450/recipes-bsp/formfactor/formfactor_0.0.bbappend new file +3 -0

new file mode 100644
index 0000000..4a41d48
@@ -0,0 +1,3 @@
+FILESEXTRAPATHS := "${THISDIR}/${PN}"
+ 
+PRINC = "1"

Signature · 1 line

1.7.1

Darren Hart

author

2011-03-16 00:19 UTC #3 lore raw

PATCH 2/2 n450: add xorg.conf to disable AutoAddDevices

In reply to Darren Hart

From: Darren Hart <[email protected]>

Fixes [YOCTO #869] (2 of 2)

The n450 needs:

Option "AutoAddDevices" "False"

In the ServerFlags, or it will fail to detect the keyboard.

Signed-off-by Darren Hart <[email protected]>

CC Tom Zanussi <[email protected]>

---
 .../xserver-xf86-config/n450/xorg.conf             |   26 ++++++++++++++++++++
 .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    3 ++
 2 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf
 create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend

meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf new file +26 -0

new file mode 100644
index 0000000..e18b911
@@ -0,0 +1,26 @@
+Section "Device"
+    Identifier    "Intel Graphics Driver"
+    Driver        "intel"
+EndSection
+
+Section "Monitor"
+    Identifier    "Generic Monitor"
+    Option        "DPMS"
+EndSection
+
+Section "Screen"
+    Identifier    "Default Screen"
+    Device        "Intel Graphics Driver"
+    Monitor        "Generic Monitor"
+    DefaultDepth    24
+EndSection
+
+Section "ServerLayout"
+    Identifier    "Default Layout"
+    Screen        "Default Screen"
+EndSection
+
+Section "ServerFlags"
+    Option        "DontZap"  "0"
+    Option	  "AutoAddDevices" "False"
+EndSection

meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend new file +3 -0

new file mode 100644
index 0000000..4b8d0e6
@@ -0,0 +1,3 @@
+THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
+FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
+

Signature · 1 line

1.7.1

Tom Zanussi

2011-03-16 00:43 UTC #6 lore raw

In reply to Darren Hart

Quoted 5 lines · Darren Hart

From: Darren Hart <[email protected]>
Before committing these patches to the meta-intel layer, I'd appreciate a review, perhaps from Tom, to ensure I didn't miss anything - seeing how close we are to release.

Hi Darren,

They both look ok to me...

Thanks,

Tom

Quoted 24 lines

Pull URL: git://git.pokylinux.org/meta-intel.git
Branch: dvhart/bernard/n450
Browse: http://git.pokylinux.org/cgit.cgi/meta-intel/log/?h=dvhart/bernard/n450

Thanks,
Darren Hart <[email protected]>
---

Darren Hart (2):
n450: add formfactor config
n450: add xorg.conf to disable AutoAddDevices

 .../formfactor/formfactor/n450/machconfig          |    3 ++
 .../recipes-bsp/formfactor/formfactor_0.0.bbappend |    3 ++
 .../xserver-xf86-config/n450/xorg.conf             |   26 ++++++++++++++++++++
 .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    3 ++
 4 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 meta-n450/recipes-bsp/formfactor/formfactor/n450/machconfig
 create mode 100644 meta-n450/recipes-bsp/formfactor/formfactor_0.0.bbappend
 create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf
 create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend

Tom Zanussi

Acked-by on v1 1/2

2011-03-16 00:44 UTC #2 lore raw

Re: [PATCH 1/2] n450: add formfactor config

In reply to Darren Hart

Quoted 11 lines · Darren Hart

From: Darren Hart <[email protected]>
Fixes [YOCTO #869] (1 of 2)
Add a formfactor config for the n450 to include a keyboard and no touchscreen. Without defining HAVE_TOUCHSCREEN=0, the default was to set it to 1, and the matchbox session disables the cursor in the case of a touchscreen device.
Signed-off-by Darren Hart <[email protected]>
CC Tom Zanussi <[email protected]>

Acked-by Tom Zanussi <[email protected]>

Quoted 25 lines

---
 .../formfactor/formfactor/n450/machconfig          |    3 +++
 .../recipes-bsp/formfactor/formfactor_0.0.bbappend |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)
 create mode 100644 meta-n450/recipes-bsp/formfactor/formfactor/n450/machconfig
 create mode 100644 meta-n450/recipes-bsp/formfactor/formfactor_0.0.bbappend

meta-n450/recipes-bsp/formfactor/formfactor/n450/machconfig new file +3 -0

new file mode 100644
index 0000000..ffce012
@@ -0,0 +1,3 @@
+# Assume a USB mouse and keyboard are connected
+HAVE_TOUCHSCREEN=0
+HAVE_KEYBOARD=1

meta-n450/recipes-bsp/formfactor/formfactor_0.0.bbappend new file +3 -0

new file mode 100644
index 0000000..4a41d48
@@ -0,0 +1,3 @@
+FILESEXTRAPATHS := "${THISDIR}/${PN}"
+ 
+PRINC = "1"

Tom Zanussi

Acked-by on v1 2/2

2011-03-16 00:45 UTC #4 lore raw

Re: [PATCH 2/2] n450: add xorg.conf to disable AutoAddDevices

In reply to Darren Hart

Quoted 9 lines · Darren Hart

From: Darren Hart <[email protected]>
Fixes [YOCTO #869] (2 of 2)
The n450 needs:
Option "AutoAddDevices" "False"
In the ServerFlags, or it will fail to detect the keyboard.

It looks like this patch does more than that, but anyway...

Acked-by Tom Zanussi <[email protected]>

Quoted 50 lines

Signed-off-by Darren Hart <[email protected]>

CC Tom Zanussi <[email protected]>

---
 .../xserver-xf86-config/n450/xorg.conf             |   26 ++++++++++++++++++++
 .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    3 ++
 2 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf
 create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend

meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf new file +26 -0

new file mode 100644
index 0000000..e18b911
@@ -0,0 +1,26 @@
+Section "Device"
+    Identifier    "Intel Graphics Driver"
+    Driver        "intel"
+EndSection
+
+Section "Monitor"
+    Identifier    "Generic Monitor"
+    Option        "DPMS"
+EndSection
+
+Section "Screen"
+    Identifier    "Default Screen"
+    Device        "Intel Graphics Driver"
+    Monitor        "Generic Monitor"
+    DefaultDepth    24
+EndSection
+
+Section "ServerLayout"
+    Identifier    "Default Layout"
+    Screen        "Default Screen"
+EndSection
+
+Section "ServerFlags"
+    Option        "DontZap"  "0"
+    Option	  "AutoAddDevices" "False"
+EndSection

meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend new file +3 -0

new file mode 100644
index 0000000..4b8d0e6
@@ -0,0 +1,3 @@
+THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
+FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
+

Darren Hart

author

2011-03-16 01:55 UTC #5 lore raw

Re: [PATCH 2/2] n450: add xorg.conf to disable AutoAddDevices

Quoted 5 lines · Tom Zanussi

Quoted 4 lines · Darren Hart
From: Darren Hart<[email protected]>
Fixes [YOCTO #869] (2 of 2)

Quoted 7 lines

Quoted 5 lines
The n450 needs:
Option "AutoAddDevices" "False"
In the ServerFlags, or it will fail to detect the keyboard.
It looks like this patch does more than that, but anyway...

Right, this is the delta from whatever it pulls in by default, but the common practice seems to be to just install a new xorg.conf for each machine, even if they are very similar.

Quoted 2 lines

Acked-by Tom Zanussi<[email protected]>

Thanks!

Quoted 53 lines

Quoted 51 lines

Signed-off-by Darren Hart<[email protected]>

CC Tom Zanussi<[email protected]>

---
  .../xserver-xf86-config/n450/xorg.conf             |   26 ++++++++++++++++++++
  .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    3 ++
  2 files changed, 29 insertions(+), 0 deletions(-)

create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf create mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend

meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf new file +26 -0

new file mode 100644
index 0000000..e18b911
@@ -0,0 +1,26 @@
+Section "Device"
+    Identifier    "Intel Graphics Driver"
+    Driver        "intel"
+EndSection
+
+Section "Monitor"
+    Identifier    "Generic Monitor"
+    Option        "DPMS"
+EndSection
+
+Section "Screen"
+    Identifier    "Default Screen"
+    Device        "Intel Graphics Driver"
+    Monitor        "Generic Monitor"
+    DefaultDepth    24
+EndSection
+
+Section "ServerLayout"
+    Identifier    "Default Layout"
+    Screen        "Default Screen"
+EndSection
+
+Section "ServerFlags"
+    Option        "DontZap"  "0"
+    Option	  "AutoAddDevices" "False"
+EndSection

meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend new file +3 -0

new file mode 100644
index 0000000..4b8d0e6
@@ -0,0 +1,3 @@
+THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
+FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
+

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel