Call stty sane before exiting qemu

PATCH Superseded Khem Raj 1 participant 3 messages Mar 21, 2011

Share & tools

Khem Raj

author

2011-03-21 18:21 UTC #0 lore raw

cover Call stty sane before exiting qemu

In nographic mode when qemu is exited e.g. qemuppc then the shell does not respond as expected (experienced on ubuntu). So we add a call to stty sane just before exit which fixes the issue.

Pull URL: git://git.openembedded.org/openembedded-core-contrib
Branch: kraj/qemu-sane-stty
Browse: http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/qemu-sane-stty

Thanks,
Khem Raj <[email protected]>
---

Khem Raj (1):
scripts/poky-qemu-internal: Add call to stty

 scripts/poky-qemu-internal |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Signature · 1 line

1.7.4.1

Khem Raj

author

2011-03-21 18:21 UTC #1 lore raw

PATCH 1/1 scripts/poky-qemu-internal: Add call to stty

When qemu is booted into console with -nographics then after exiting the terminal line settings are messed up. This patch calls stty sane to restore the terminal settings to default.

stty is part of coreutils which is installed on all host distros hence there is no need to warn about it being available or not

Signed-off-by Khem Raj <[email protected]>

---
 scripts/poky-qemu-internal |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

scripts/poky-qemu-internal +2 -1

index 82ef265..ea6539e 100755
@@ -187,6 +187,7 @@ cleanup() {
         echo "poky-export-rootfs stop $ROOTFS"
         poky-export-rootfs stop $ROOTFS
     fi
+    stty sane
 }
 
 n1=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]

@@ -377,7 +378,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
     MACHINE_SUBTYPE=prep
     CPU_SUBTYPE=603e
     BIOS=powerpc_rom.bin
-    QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -nographic"
+    QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS"
     if [ "$FSTYPE" = "ext3" ]; then
         KERNCMDLINE="root=/dev/hda console=ttyS0 console=tty0 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
         QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -hda $ROOTFS -no-reboot $QEMU_UI_OPTIONS"

Signature · 1 line

1.7.4.1

Khem Raj

author

2011-03-21 18:29 UTC #2 lore raw

Re: [PATCH 1/1] scripts/poky-qemu-internal: Add call to stty

Quoted 9 lines · Khem Raj

When qemu is booted into console with -nographics then after exiting the terminal line settings are messed up. This patch calls stty sane to restore the terminal settings to default.
stty is part of coreutils which is installed on all host distros hence there is no need to warn about it being available or not

this has another hunk which was not intended. I will resend it

Quoted 30 lines

Signed-off-by Khem Raj <[email protected]>
---
scripts/poky-qemu-internal | 3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
scripts/poky-qemu-internal +0 -0
index 82ef265..ea6539e 100755
@@ -187,6 +187,7 @@ cleanup() {
echo "poky-export-rootfs stop $ROOTFS" poky-export-rootfs stop $ROOTFS
fi
+ stty sane
}
n1=$[ (echo $TAP | sed 's/tap//' * 2) + 1 ]
scripts/poky-qemu-internal +0 -0
@@ -377,7 +378,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
MACHINE_SUBTYPE=prep
CPU_SUBTYPE=603e
BIOS=powerpc_rom.bin
- QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -nographic"
+ QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS"
if [ "$FSTYPE" = "ext3" ]; then
KERNCMDLINE="root=/dev/hda console=ttyS0 console=tty0 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY" QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -hda $ROOTFS -no-reboot $QEMU_UI_OPTIONS" --
1.7.4.1