staging/keucr: use pr_<level> for messages
cover staging/keucr: use pr_<level> for messages
staging/keucr: init use pr_<level> for messages staging/keucr: msscsi use pr_<level> for messages staging/keucr: scsiglue use pr_<level> for messages staging/keucr: smilmain use pr_<level> for messages staging/keucr: transport usb use pr_<level>
drivers/staging/keucr/init.c | 95 ++++++++++++------------- drivers/staging/keucr/msscsi.c | 29 +++++--- drivers/staging/keucr/scsiglue.c | 35 +++++---- drivers/staging/keucr/smilmain.c | 16 +++-- drivers/staging/keucr/transport.c | 140 +++++++++++++++++++----------------- drivers/staging/keucr/usb.c | 88 ++++++++++++----------- 6 files changed, 210 insertions(+), 193 deletions(-)
PATCH 1/5 staging/keucr: init use pr_<level> for messages
init.c use pr_<level> for messages
--- drivers/staging/keucr/init.c | 95 ++++++++++++++++++++--------------------- 1 files changed, 46 insertions(+), 49 deletions(-)
drivers/staging/keucr/init.c +46 -49
@@ -1,3 +1,5 @@ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/sched.h> #include <linux/errno.h> #include <linux/slab.h>
@@ -22,13 +24,13 @@ int ENE_InitMedia(struct us_data *us)int result;BYTE MiscReg03 =0 ; -printk (KERN_INFO "--- Init Media ---\n" ); +pr_info ("--- Init Media ---\n" ); result =ENE_Read_BYTE (us,REG_CARD_STATUS , &MiscReg03);if (result !=USB_STOR_XFER_GOOD ) { -printk (KERN_ERR "Read register fail !!\n" ); +pr_err ("Read register fail !!\n" );return USB_STOR_TRANSPORT_ERROR ; } -printk (KERN_INFO "MiscReg03 = %x\n" , MiscReg03); +pr_info ("MiscReg03 = %x\n" , MiscReg03);if (MiscReg03 &0x02 ) {if (!us->SM_Status.Ready && !us->MS_Status.Ready) {
@@ -74,10 +76,10 @@ int ENE_MSInit(struct us_data *us)BYTE buf[0x200 ];WORD MSP_BlockSize, MSP_UserAreaBlocks; -printk (KERN_INFO "transport --- ENE_MSInit\n" ); +pr_info ("transport --- ENE_MSInit\n" ); result =ENE_LoadBinCode (us,MS_INIT_PATTERN );if (result !=USB_STOR_XFER_GOOD ) { -printk (KERN_ERR "Load MS Init Code Fail !!\n" ); +pr_err ("Load MS Init Code Fail !!\n" );return USB_STOR_TRANSPORT_ERROR ; }
@@ -90,18 +92,18 @@ int ENE_MSInit(struct us_data *us) result =ENE_SendScsiCmd (us,FDIR_READ , &buf,0 );if (result !=USB_STOR_XFER_GOOD ) { -printk (KERN_ERR "Exection MS Init Code Fail !!\n" ); +pr_err ("Exection MS Init Code Fail !!\n" );return USB_STOR_TRANSPORT_ERROR ; } us->MS_Status = *(PMS_STATUS )&buf[0 ];if (us->MS_Status.Insert && us->MS_Status.Ready) { -printk (KERN_INFO "Insert = %x\n" , us->MS_Status.Insert); -printk (KERN_INFO "Ready = %x\n" , us->MS_Status.Ready); -printk (KERN_INFO "IsMSPro = %x\n" , us->MS_Status.IsMSPro); -printk (KERN_INFO "IsMSPHG = %x\n" , us->MS_Status.IsMSPHG); -printk (KERN_INFO "WtP = %x\n" , us->MS_Status.WtP); +pr_info ("Insert = %x\n" , us->MS_Status.Insert); +pr_info ("Ready = %x\n" , us->MS_Status.Ready); +pr_info ("IsMSPro = %x\n" , us->MS_Status.IsMSPro); +pr_info ("IsMSPHG = %x\n" , us->MS_Status.IsMSPHG); +pr_info ("WtP = %x\n" , us->MS_Status.WtP);if (us->MS_Status.IsMSPro) { MSP_BlockSize = (buf[6 ] <<8 ) | buf[7 ]; MSP_UserAreaBlocks = (buf[10 ] <<8 ) | buf[11 ];
@@ -109,9 +111,9 @@ int ENE_MSInit(struct us_data *us) }else {MS_CardInit (us); } -printk (KERN_INFO "MS Init Code OK !!\n" ); +pr_info ("MS Init Code OK !!\n" ); }else { -printk (KERN_INFO "MS Card Not Ready --- %x\n" , buf[0 ]); +pr_info ("MS Card Not Ready --- %x\n" , buf[0 ]);return USB_STOR_TRANSPORT_ERROR ; }
@@ -127,11 +129,11 @@ int ENE_SMInit(struct us_data *us)int result;BYTE buf[0x200 ]; -printk (KERN_INFO "transport --- ENE_SMInit\n" ); +pr_info ("transport --- ENE_SMInit\n" ); result =ENE_LoadBinCode (us,SM_INIT_PATTERN );if (result !=USB_STOR_XFER_GOOD ) { -printk (KERN_INFO "Load SM Init Code Fail !!\n" ); +pr_info ("Load SM Init Code Fail !!\n" );return USB_STOR_TRANSPORT_ERROR ; }
@@ -144,8 +146,7 @@ int ENE_SMInit(struct us_data *us) result =ENE_SendScsiCmd (us,FDIR_READ , &buf,0 );if (result !=USB_STOR_XFER_GOOD ) { -printk (KERN_ERR -"Exection SM Init Code Fail !! result = %x\n" , result); +pr_err ("Exection SM Init Code Fail !! result = %x\n" , result);return USB_STOR_TRANSPORT_ERROR ; }
@@ -155,15 +156,15 @@ int ENE_SMInit(struct us_data *us) us->SM_CardID = buf[2 ];if (us->SM_Status.Insert && us->SM_Status.Ready) { -printk (KERN_INFO "Insert = %x\n" , us->SM_Status.Insert); -printk (KERN_INFO "Ready = %x\n" , us->SM_Status.Ready); -printk (KERN_INFO "WtP = %x\n" , us->SM_Status.WtP); -printk (KERN_INFO "DeviceID = %x\n" , us->SM_DeviceID); -printk (KERN_INFO "CardID = %x\n" , us->SM_CardID); +pr_info ("Insert = %x\n" , us->SM_Status.Insert); +pr_info ("Ready = %x\n" , us->SM_Status.Ready); +pr_info ("WtP = %x\n" , us->SM_Status.WtP); +pr_info ("DeviceID = %x\n" , us->SM_DeviceID); +pr_info ("CardID = %x\n" , us->SM_CardID); MediaChange =1 ;Check_D_MediaFmt (us); }else { -printk (KERN_ERR "SM Card Not Ready --- %x\n" , buf[0 ]); +pr_err ("SM Card Not Ready --- %x\n" , buf[0 ]);return USB_STOR_TRANSPORT_ERROR ; }
@@ -180,7 +181,7 @@ int ENE_LoadBinCode(struct us_data *us, BYTE flag)/* void *buf; */ PBYTE buf; -/* printk(KERN_INFO "transport --- ENE_LoadBinCode\n"); */ +/* pr_info("transport --- ENE_LoadBinCode\n"); */ if (us->BIN_FLAG == flag)return USB_STOR_TRANSPORT_GOOD ;
@@ -190,24 +191,24 @@ int ENE_LoadBinCode(struct us_data *us, BYTE flag)switch (flag) {/* For MS */ case MS_INIT_PATTERN : -printk (KERN_INFO "MS_INIT_PATTERN\n" ); +pr_info ("MS_INIT_PATTERN\n" );memcpy (buf, MS_Init,0x800 );break ;case MSP_RW_PATTERN : -printk (KERN_INFO "MSP_RW_PATTERN\n" ); +pr_info ("MSP_RW_PATTERN\n" );memcpy (buf, MSP_Rdwr,0x800 );break ;case MS_RW_PATTERN : -printk (KERN_INFO "MS_RW_PATTERN\n" ); +pr_info ("MS_RW_PATTERN\n" );memcpy (buf, MS_Rdwr,0x800 );break ;/* For SS */ case SM_INIT_PATTERN : -printk (KERN_INFO "SM_INIT_PATTERN\n" ); +pr_info ("SM_INIT_PATTERN\n" );memcpy (buf, SM_Init,0x800 );break ;case SM_RW_PATTERN : -printk (KERN_INFO "SM_RW_PATTERN\n" ); +pr_info ("SM_RW_PATTERN\n" );memcpy (buf, SM_Rdwr,0x800 );break ; }
@@ -238,12 +239,12 @@ int ENE_SendScsiCmd(struct us_data *us, BYTE fDir, void *buf, int use_sg) cswlen =0 , partial =0 ;unsigned int residue; -/* printk(KERN_INFO "transport --- ENE_SendScsiCmd\n"); */ +/* pr_info("transport --- ENE_SendScsiCmd\n"); */ /* send cmd to out endpoint */ result =usb_stor_bulk_transfer_buf (us, us->send_bulk_pipe, bcb,US_BULK_CB_WRAP_LEN ,NULL );if (result !=USB_STOR_XFER_GOOD ) { -printk (KERN_ERR "send cmd to out endpoint fail ---\n" ); +pr_err ("send cmd to out endpoint fail ---\n" );return USB_STOR_TRANSPORT_ERROR ; }
@@ -262,7 +263,7 @@ int ENE_SendScsiCmd(struct us_data *us, BYTE fDir, void *buf, int use_sg) result =usb_stor_bulk_transfer_sg (us, pipe, buf, transfer_length,0 , &partial);if (result !=USB_STOR_XFER_GOOD ) { -printk (KERN_ERR "data transfer fail ---\n" ); +pr_err ("data transfer fail ---\n" );return USB_STOR_TRANSPORT_ERROR ; } }
@@ -272,14 +273,14 @@ int ENE_SendScsiCmd(struct us_data *us, BYTE fDir, void *buf, int use_sg) US_BULK_CS_WRAP_LEN, &cswlen);if (result ==USB_STOR_XFER_SHORT && cswlen ==0 ) { -printk (KERN_WARNING "Received 0-length CSW; retrying...\n" ); +pr_warning ("Received 0-length CSW; retrying...\n" ); result =usb_stor_bulk_transfer_buf (us, us->recv_bulk_pipe, bcs,US_BULK_CS_WRAP_LEN , &cswlen); }if (result ==USB_STOR_XFER_STALLED ) {/* get the status again */ -printk (KERN_WARNING "Attempting to get CSW (2nd try)...\n" ); +pr_warning ("Attempting to get CSW (2nd try)...\n" ); result =usb_stor_bulk_transfer_buf (us, us->recv_bulk_pipe, bcs,US_BULK_CS_WRAP_LEN ,NULL ); }
@@ -316,7 +317,7 @@ int ENE_Read_Data(struct us_data *us, void *buf, unsigned int length)struct bulk_cs_wrap *bcs = (struct bulk_cs_wrap *) us->iobuf;int result; -/* printk(KERN_INFO "transport --- ENE_Read_Data\n"); */ +/* pr_info("transport --- ENE_Read_Data\n"); */ /* set up the command wrapper */ memset (bcb,0 ,sizeof (struct bulk_cb_wrap )); bcb->Signature =cpu_to_le32 (US_BULK_CB_SIGN );
@@ -358,7 +359,7 @@ int ENE_Write_Data(struct us_data *us, void *buf, unsigned int length)struct bulk_cs_wrap *bcs = (struct bulk_cs_wrap *) us->iobuf;int result; -/* printk("transport --- ENE_Write_Data\n"); */ +/* pr_info("transport --- ENE_Write_Data\n"); */ /* set up the command wrapper */ memset (bcb,0 ,sizeof (struct bulk_cb_wrap )); bcb->Signature =cpu_to_le32 (US_BULK_CB_SIGN );
@@ -406,37 +407,33 @@ void usb_stor_print_cmd(struct scsi_cmnd *srb)switch (cmd) {case TEST_UNIT_READY : -/* printk(KERN_INFO -"scsi cmd %X --- SCSIOP_TEST_UNIT_READY\n", cmd); */ +/* pr_info("scsi cmd %X --- SCSIOP_TEST_UNIT_READY\n", cmd); */ break ;case INQUIRY : -printk (KERN_INFO "scsi cmd %X --- SCSIOP_INQUIRY\n" , cmd); +pr_info ("scsi cmd %X --- SCSIOP_INQUIRY\n" , cmd);break ;case MODE_SENSE : -printk (KERN_INFO "scsi cmd %X --- SCSIOP_MODE_SENSE\n" , cmd); +pr_info ("scsi cmd %X --- SCSIOP_MODE_SENSE\n" , cmd);break ;case START_STOP : -printk (KERN_INFO "scsi cmd %X --- SCSIOP_START_STOP\n" , cmd); +pr_info ("scsi cmd %X --- SCSIOP_START_STOP\n" , cmd);break ;case READ_CAPACITY : -printk (KERN_INFO "scsi cmd %X --- SCSIOP_READ_CAPACITY\n" , cmd); +pr_info ("scsi cmd %X --- SCSIOP_READ_CAPACITY\n" , cmd);break ;case READ_10 : -/* printk(KERN_INFO -"scsi cmd %X --- SCSIOP_READ,bn = %X, blen = %X\n" +/* pr_info("scsi cmd %X --- SCSIOP_READ,bn = %X, blen = %X\n" ,cmd, bn, blen); */ break ;case WRITE_10 : -/* printk(KERN_INFO -"scsi cmd %X --- SCSIOP_WRITE, +/* pr_ifno("scsi cmd %X --- SCSIOP_WRITE, bn = %X, blen = %X\n" , cmd, bn, blen); */ break ;case ALLOW_MEDIUM_REMOVAL : -printk (KERN_INFO -"scsi cmd %X --- SCSIOP_ALLOW_MEDIUM_REMOVAL\n" , cmd); +pr_info ("scsi cmd %X --- SCSIOP_ALLOW_MEDIUM_REMOVAL\n" , cmd);break ;default : -printk (KERN_INFO "scsi cmd %X --- Other cmd\n" , cmd); +pr_info ("scsi cmd %X --- Other cmd\n" , cmd);break ; } bn =0 ;
Signature · 1 line
1.7.1
PATCH 2/5 staging/keucr: msscsi use pr_<level> for messages
In reply to Cho, Yu-Chenmsscsi.c use pr_<level> for messages
--- drivers/staging/keucr/msscsi.c | 29 +++++++++++++++++------------ 1 files changed, 17 insertions(+), 12 deletions(-)
drivers/staging/keucr/msscsi.c +17 -12
@@ -1,3 +1,5 @@ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/sched.h> #include <linux/errno.h> #include <linux/slab.h>
@@ -44,7 +46,7 @@ int MS_SCSIIrp(struct us_data *us, struct scsi_cmnd *srb)//----- MS_SCSI_Test_Unit_Ready() -------------------------------------------------- int MS_SCSI_Test_Unit_Ready (struct us_data *us,struct scsi_cmnd *srb) { -//printk("MS_SCSI_Test_Unit_Ready\n"); +/* pr_info("MS_SCSI_Test_Unit_Ready\n"); */ if (us->MS_Status.Insert && us->MS_Status.Ready)return USB_STOR_TRANSPORT_GOOD ;else
@@ -59,7 +61,7 @@ int MS_SCSI_Test_Unit_Ready(struct us_data *us, struct scsi_cmnd *srb)//----- MS_SCSI_Inquiry() -------------------------------------------------- int MS_SCSI_Inquiry (struct us_data *us,struct scsi_cmnd *srb) { -//printk("MS_SCSI_Inquiry\n"); +/* pr_info("MS_SCSI_Inquiry\n"); */ BYTE data_ptr[36 ] = {0x00 ,0x80 ,0x02 ,0x00 ,0x1F ,0x00 ,0x00 ,0x00 ,0x55 ,0x53 ,0x42 ,0x32 ,0x2E ,0x30 ,0x20 ,0x20 ,0x43 ,0x61 ,0x72 ,0x64 ,0x52 ,0x65 ,0x61 ,0x64 ,0x65 ,0x72 ,0x20 ,0x20 ,0x20 ,0x20 ,0x20 ,0x20 ,0x30 ,0x31 ,0x30 ,0x30 };usb_stor_set_xfer_buf (us, data_ptr,36 , srb,TO_XFER_BUF );
@@ -91,7 +93,7 @@ int MS_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)WORD bl_len;BYTE buf[8 ]; -printk ("MS_SCSI_Read_Capacity\n" ); +pr_info ("MS_SCSI_Read_Capacity\n" ); bl_len =0x200 ;if ( us->MS_Status.IsMSPro )
@@ -100,8 +102,8 @@ int MS_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb) bl_num = us->MS_Lib.NumberOfLogBlock * us->MS_Lib.blockSize *2 -1 ; us->bl_num = bl_num; -printk ("bl_len = %x\n" , bl_len); -printk ("bl_num = %x\n" , bl_num); +pr_info ("bl_len = %x\n" , bl_len); +pr_info ("bl_num = %x\n" , bl_num);//srb->request_bufflen = 8; buf[0 ] = (bl_num>>24 ) &0xff ;
@@ -130,7 +132,8 @@ int MS_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb)WORD blen = ((Cdb[7 ]<<8 ) &0xff00 ) | ((Cdb[8 ]<<0 ) &0x00ff );DWORD blenByte = blen *0x200 ; -//printk("SCSIOP_READ --- bn = %X, blen = %X, srb->use_sg = %X\n", bn, blen, srb->use_sg); +/* pr_info("SCSIOP_READ --- bn = %X, blen = %X, srb->use_sg = %X\n", +bn, blen, srb->use_sg); */ if (bn > us->bl_num)return USB_STOR_TRANSPORT_ERROR ;
@@ -140,7 +143,7 @@ int MS_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb) result =ENE_LoadBinCode (us,MSP_RW_PATTERN );if (result !=USB_STOR_XFER_GOOD ) { -printk ("Load MSP RW pattern Fail !!\n" ); +pr_info ("Load MSP RW pattern Fail !!\n" );return USB_STOR_TRANSPORT_ERROR ; }
@@ -174,7 +177,7 @@ int MS_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb) result =ENE_LoadBinCode (us,MS_RW_PATTERN );if (result !=USB_STOR_XFER_GOOD ) { -printk ("Load MS RW pattern Fail !!\n" ); +pr_info ("Load MS RW pattern Fail !!\n" ); result =USB_STOR_TRANSPORT_ERROR ; goto exit; }
@@ -207,7 +210,8 @@ int MS_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb) result =ENE_SendScsiCmd (us,FDIR_READ , buf+offset,0 );if (result !=USB_STOR_XFER_GOOD ) { -printk ("MS_SCSI_Read --- result = %x\n" , result); +pr_info ("MS_SCSI_Read --- result = %x\n" , + result); result =USB_STOR_TRANSPORT_ERROR ; goto exit; }
@@ -245,7 +249,7 @@ int MS_SCSI_Write(struct us_data *us, struct scsi_cmnd *srb) result =ENE_LoadBinCode (us,MSP_RW_PATTERN );if (result !=USB_STOR_XFER_GOOD ) { -printk ("Load MSP RW pattern Fail !!\n" ); +pr_info ("Load MSP RW pattern Fail !!\n" );return USB_STOR_TRANSPORT_ERROR ; }
@@ -280,7 +284,7 @@ int MS_SCSI_Write(struct us_data *us, struct scsi_cmnd *srb) result =ENE_LoadBinCode (us,MS_RW_PATTERN );if (result !=USB_STOR_XFER_GOOD ) { -printk ("Load MS RW pattern Fail !!\n" ); +pr_info ("Load MS RW pattern Fail !!\n" ); result =USB_STOR_TRANSPORT_ERROR ; goto exit; }
@@ -301,7 +305,8 @@ int MS_SCSI_Write(struct us_data *us, struct scsi_cmnd *srb) result =MS_ReaderCopyBlock (us, oldphy, newphy, PhyBlockAddr, PageNum, buf+offset, len);if (result !=USB_STOR_XFER_GOOD ) { -printk ("MS_SCSI_Write --- result = %x\n" , result); +pr_info ("MS_SCSI_Write --- result = %x\n" , + result); result =USB_STOR_TRANSPORT_ERROR ; goto exit; }
Signature · 1 line
1.7.1
PATCH 3/5 staging/keucr: scsiglue use pr_<level> for messages
In reply to Cho, Yu-Chenscsiglue.c use pr_<level> for messages
--- drivers/staging/keucr/scsiglue.c | 35 +++++++++++++++++++---------------- 1 files changed, 19 insertions(+), 16 deletions(-)
drivers/staging/keucr/scsiglue.c +19 -16
@@ -1,3 +1,5 @@ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/slab.h> #include <linux/module.h> #include <linux/mutex.h>
@@ -16,7 +18,7 @@//----- host_info() --------------------- static const char *host_info (struct Scsi_Host *host) { -//printk("scsiglue --- host_info\n"); +/* pr_info("scsiglue --- host_info\n"); */ return "SCSI emulation for USB Mass Storage devices" ; }
@@ -25,7 +27,7 @@ static int slave_alloc(struct scsi_device *sdev) {struct us_data *us =host_to_us (sdev->host); -//printk("scsiglue --- slave_alloc\n"); +/* pr_info("scsiglue --- slave_alloc\n"); */ sdev->inquiry_len =36 ;blk_queue_update_dma_alignment (sdev->request_queue, (512 -1 ));
@@ -41,7 +43,7 @@ static int slave_configure(struct scsi_device *sdev) {struct us_data *us =host_to_us (sdev->host); -//printk("scsiglue --- slave_configure\n"); +/* pr_info("scsiglue --- slave_configure\n"); */ if (us->fflags & (US_FL_MAX_SECTORS_64 |US_FL_MAX_SECTORS_MIN )) {unsigned int max_sectors =64 ;
@@ -91,19 +93,20 @@ static int queuecommand_lck(struct scsi_cmnd *srb, void (*done)(struct scsi_cmnd {struct us_data *us =host_to_us (srb->device->host); -//printk("scsiglue --- queuecommand\n"); +/* pr_info("scsiglue --- queuecommand\n"); */ /* check for state-transition errors */ if (us->srb !=NULL ) { -printk ("Error in %s: us->srb = %p\n" , __FUNCTION__, us->srb); +/* pr_info("Error in %s: us->srb = %p\n" +__FUNCTION__, us->srb); */ return SCSI_MLQUEUE_HOST_BUSY ; }/* fail the command if we are disconnecting */ if (test_bit (US_FLIDX_DISCONNECTING , &us->dflags)) { -printk ("Fail command during disconnect\n" ); +pr_info ("Fail command during disconnect\n" ); srb->result =DID_NO_CONNECT <<16 ;done (srb);return 0 ;
@@ -129,7 +132,7 @@ static int command_abort(struct scsi_cmnd *srb) {struct us_data *us =host_to_us (srb->device->host); -//printk("scsiglue --- command_abort\n"); +/* pr_info("scsiglue --- command_abort\n"); */ scsi_lock (us_to_host (us));if (us->srb != srb)
@@ -159,7 +162,7 @@ static int device_reset(struct scsi_cmnd *srb)struct us_data *us =host_to_us (srb->device->host);int result; -//printk("scsiglue --- device_reset\n"); +/* pr_info("scsiglue --- device_reset\n"); */ /* lock the device pointers and do the reset */ mutex_lock (&(us->dev_mutex));
@@ -175,7 +178,7 @@ static int bus_reset(struct scsi_cmnd *srb)struct us_data *us =host_to_us (srb->device->host);int result; -//printk("scsiglue --- bus_reset\n"); +/* pr_info("scsiglue --- bus_reset\n"); */ result =usb_stor_port_reset (us);return result <0 ?FAILED :SUCCESS ; }
@@ -186,7 +189,7 @@ void usb_stor_report_device_reset(struct us_data *us)int i;struct Scsi_Host *host =us_to_host (us); -//printk("scsiglue --- usb_stor_report_device_reset\n"); +/* pr_info("scsiglue --- usb_stor_report_device_reset\n"); */ scsi_report_device_reset (host,0 ,0 );if (us->fflags &US_FL_SCM_MULT_TARG ) {
@@ -200,7 +203,7 @@ void usb_stor_report_bus_reset(struct us_data *us) {struct Scsi_Host *host =us_to_host (us); -//printk("scsiglue --- usb_stor_report_bus_reset\n"); +/* pr_info("scsiglue --- usb_stor_report_bus_reset\n"); */ scsi_lock (host);scsi_report_bus_reset (host,0 );scsi_unlock (host);
@@ -222,7 +225,7 @@ static int proc_info (struct Scsi_Host *host, char *buffer, char **start, off_tchar *pos = buffer;const char *string; -//printk("scsiglue --- proc_info\n"); +/* pr_info("scsiglue --- proc_info\n"); */ if (inout)return length;
@@ -288,7 +291,7 @@ static ssize_t show_max_sectors(struct device *dev, struct device_attribute *att {struct scsi_device *sdev =to_scsi_device (dev); -//printk("scsiglue --- ssize_t show_max_sectors\n"); +/* pr_info("scsiglue --- ssize_t show_max_sectors\n"); */ return sprintf (buf,"%u\n" ,queue_max_sectors (sdev->request_queue)); }
@@ -299,7 +302,7 @@ static ssize_t store_max_sectors(struct device *dev, struct device_attribute *atstruct scsi_device *sdev =to_scsi_device (dev);unsigned short ms; -//printk("scsiglue --- ssize_t store_max_sectors\n"); +/* pr_info("scsiglue --- ssize_t store_max_sectors\n"); */ if (sscanf (buf,"%hu" , &ms) >0 && ms <=SCSI_DEFAULT_MAX_SECTORS ) {blk_queue_max_hw_sectors (sdev->request_queue, ms);
@@ -383,7 +386,7 @@ unsigned int usb_stor_access_xfer_buf(struct us_data *us, unsigned char *buffer, {unsigned int cnt; -//printk("transport --- usb_stor_access_xfer_buf\n"); +/* pr_info("transport --- usb_stor_access_xfer_buf\n"); */ struct scatterlist *sg = *sgptr;if (!sg)
@@ -441,7 +444,7 @@ void usb_stor_set_xfer_buf(struct us_data *us, unsigned char *buffer, unsigned iunsigned int offset =0 ;struct scatterlist *sg =NULL ; -//printk("transport --- usb_stor_set_xfer_buf\n"); +/* pr_info("transport --- usb_stor_set_xfer_buf\n"); */ // TO_XFER_BUF = 0, FROM_XFER_BUF = 1 buflen =min (buflen,scsi_bufflen (srb)); buflen =usb_stor_access_xfer_buf (us, buffer, buflen, srb, &sg, &offset, dir);
Signature · 1 line
1.7.1
PATCH 4/5 staging/keucr: smilmain use pr_<level> for messages
In reply to Cho, Yu-Chensmilmain.c use pr_<level> for messages
--- drivers/staging/keucr/smilmain.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-)
drivers/staging/keucr/smilmain.c +9 -7
@@ -102,12 +102,12 @@ int SM_FreeMem(void) {int i; -printk ("SM_FreeMem start\n" ); +pr_info ("SM_FreeMem start\n" );for (i=0 ; i<MAX_ZONENUM ; i++) {if (Log2Phy[i]!=NULL ) { -printk ("Free Zone = %x, Addr = %p\n" , i, Log2Phy[i]); +pr_info ("Free Zone = %x, Addr = %p\n" , i, Log2Phy[i]);kfree (Log2Phy[i]); Log2Phy[i] =NULL ; }
@@ -198,7 +198,7 @@ int Media_D_CopySector(struct us_data *us, DWORD start,WORD count,BYTE *buf)//SSFDCTYPE_T aa = (SSFDCTYPE_T ) &Ssfdc; //ADDRESS_T bb = (ADDRESS_T) &Media; -//printk("Media_D_CopySector !!!\n"); +/* pr_info("Media_D_CopySector !!!\n"); */ if (Conv_D_MediaAddr (us, start))return (ErrCode);
@@ -657,7 +657,7 @@ int Media_D_OneSectWriteFlush(PFDO_DEVICE_EXTENSION fdoExt)//----- Check_D_MediaFmt() --------------------------------------------- int Check_D_MediaFmt (struct us_data *us) { -printk ("Check_D_MediaFmt\n" ); +pr_info ("Check_D_MediaFmt\n" );//ULONG i,j, result=FALSE, zone,block; //usleep(56*1024);
@@ -1334,7 +1334,7 @@ int Copy_D_PhyOneSect(struct us_data *us)//SSFDCTYPE_T aa = (SSFDCTYPE_T ) &Ssfdc; //ADDRESS_T bb = (ADDRESS_T) &Media; -//printk("Copy_D_PhyOneSect --- Secotr = %x\n", Media.Sector); +/* pr_info("Copy_D_PhyOneSect --- Secotr = %x\n", Media.Sector); */ if (ReadBlock!=NO_ASSIGN ) { Media.PhyBlock=ReadBlock;
@@ -1620,7 +1620,8 @@ int Make_D_LogTable(struct us_data *us)if (Log2Phy[Media.Zone]==NULL ) { Log2Phy[Media.Zone] =kmalloc (MAX_LOGBLOCK *sizeof (WORD ),GFP_KERNEL ); -//printk("ExAllocatePool Zone = %x, Addr = %x\n", Media.Zone, Log2Phy[Media.Zone]); +/* pr_info("ExAllocatePool Zone = %x, Addr = %x\n", +Media.Zone, Log2Phy[Media.Zone]); */ if (Log2Phy[Media.Zone]==NULL )return (ERROR ); }
@@ -1630,7 +1631,8 @@ int Make_D_LogTable(struct us_data *us)//for(Media.Zone=0; Media.Zone<MAX_ZONENUM; Media.Zone++) //for(Media.Zone=0; Media.Zone<Ssfdc.MaxZones; Media.Zone++) { -//printk("Make_D_LogTable --- MediaZone = 0x%x\n", Media.Zone); +/* pr_info("Make_D_LogTable --- MediaZone = 0x%x\n", +Media.Zone); */ for (Media.LogBlock=0 ; Media.LogBlock<Ssfdc.MaxLogBlocks; Media.LogBlock++) Log2Phy[Media.Zone][Media.LogBlock]=NO_ASSIGN ;
Signature · 1 line
1.7.1
PATCH 5/5 staging/keucr: transport usb use pr_<level>
In reply to Cho, Yu-Chentransport.c usb.c use pr_<level> for messages
--- drivers/staging/keucr/transport.c | 140 +++++++++++++++++++----------------- drivers/staging/keucr/usb.c | 88 ++++++++++++----------- 2 files changed, 119 insertions(+), 109 deletions(-)
drivers/staging/keucr/transport.c +74 -66
@@ -1,3 +1,5 @@ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/sched.h> #include <linux/errno.h> #include <linux/slab.h>
@@ -18,7 +20,7 @@ static void usb_stor_blocking_completion(struct urb *urb) {struct completion *urb_done_ptr = urb->context; -//printk("transport --- usb_stor_blocking_completion\n"); +/* pr_info("transport --- usb_stor_blocking_completion\n"); */ complete (urb_done_ptr); }
@@ -29,7 +31,7 @@ static int usb_stor_msg_common(struct us_data *us, int timeout)long timeleft;int status; -//printk("transport --- usb_stor_msg_common\n"); +/* pr_info("transport --- usb_stor_msg_common\n"); */ if (test_bit (US_FLIDX_ABORTING , &us->dflags))return -EIO ;
@@ -56,7 +58,7 @@ static int usb_stor_msg_common(struct us_data *us, int timeout) {if (test_and_clear_bit (US_FLIDX_URB_ACTIVE , &us->dflags)) { -//printk("-- cancelling URB\n"); +/* pr_info("-- cancelling URB\n"); */ usb_unlink_urb (us->current_urb); } }
@@ -66,7 +68,8 @@ static int usb_stor_msg_common(struct us_data *us, int timeout)if (timeleft <=0 ) { -//printk("%s -- cancelling URB\n", timeleft == 0 ? "Timeout" : "Signal"); +/* pr_info("%s -- cancelling URB\n", +timeleft == 0 ? "Timeout" : "Signal"); */ usb_kill_urb (us->current_urb); }
@@ -80,7 +83,7 @@ int usb_stor_control_msg(struct us_data *us, unsigned int pipe, {int status; -//printk("transport --- usb_stor_control_msg\n"); +/* pr_info("transport --- usb_stor_control_msg\n"); */ /* fill in the devrequest structure */ us->cr->bRequestType = requesttype;
@@ -107,7 +110,7 @@ int usb_stor_clear_halt(struct us_data *us, unsigned int pipe)int result;int endp =usb_pipeendpoint (pipe); -//printk("transport --- usb_stor_clear_halt\n"); +/* pr_info("transport --- usb_stor_clear_halt\n"); */ if (usb_pipein (pipe)) endp |=USB_DIR_IN ;
@@ -128,41 +131,41 @@ int usb_stor_clear_halt(struct us_data *us, unsigned int pipe)static int interpret_urb_result (struct us_data *us,unsigned int pipe,unsigned int length,int result,unsigned int partial) { -//printk("transport --- interpret_urb_result\n"); +/* pr_info("transport --- interpret_urb_result\n"); */ switch (result) {/* no error code; did we send all the data? */ case 0 :if (partial != length) { -//printk("-- short transfer\n"); +/* pr_info("-- short transfer\n"); */ return USB_STOR_XFER_SHORT ; } -//printk("-- transfer complete\n"); +/* pr_info("-- transfer complete\n"); */ return USB_STOR_XFER_GOOD ;case -EPIPE :if (usb_pipecontrol (pipe)) { -//printk("-- stall on control pipe\n"); +/* pr_info("-- stall on control pipe\n"); */ return USB_STOR_XFER_STALLED ; } -//printk("clearing endpoint halt for pipe 0x%x\n", pipe); +/* pr_info("clearing endpoint halt for pipe 0x%x\n", pipe); */ if (usb_stor_clear_halt (us, pipe) <0 )return USB_STOR_XFER_ERROR ;return USB_STOR_XFER_STALLED ;case -EOVERFLOW : -//printk("-- babble\n"); +/* pr_info("-- babble\n"); */ return USB_STOR_XFER_LONG ;case -ECONNRESET : -//printk("-- transfer cancelled\n"); +/* pr_info("-- transfer cancelled\n"); */ return USB_STOR_XFER_ERROR ;case -EREMOTEIO : -//printk("-- short read transfer\n"); +/* pr_info("-- short read transfer\n"); */ return USB_STOR_XFER_SHORT ;case -EIO : -//printk("-- abort or disconnect in progress\n"); +/* pr_info("-- abort or disconnect in progress\n"); */ return USB_STOR_XFER_ERROR ;default : -//printk("-- unknown error\n"); +/* pr_info("-- unknown error\n"); */ return USB_STOR_XFER_ERROR ; } }
@@ -173,7 +176,7 @@ int usb_stor_bulk_transfer_buf(struct us_data *us, unsigned int pipe, {int result; -//printk("transport --- usb_stor_bulk_transfer_buf\n"); +/* pr_info("transport --- usb_stor_bulk_transfer_buf\n"); */ /* fill and submit the URB */ usb_fill_bulk_urb (us->current_urb, us->pusb_dev, pipe, buf, length, usb_stor_blocking_completion,NULL );
@@ -193,7 +196,7 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, {int result; -//printk("transport --- usb_stor_bulk_transfer_sglist\n"); +/* pr_info("transport --- usb_stor_bulk_transfer_sglist\n"); */ if (test_bit (US_FLIDX_ABORTING , &us->dflags))return USB_STOR_XFER_ERROR ;
@@ -201,7 +204,7 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, result =usb_sg_init (&us->current_sg, us->pusb_dev, pipe,0 , sg, num_sg, length,GFP_NOIO );if (result) { -//printk("usb_sg_init returned %d\n", result); +/* pr_info("usb_sg_init returned %d\n", result); */ return USB_STOR_XFER_ERROR ; }
@@ -214,7 +217,7 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe,/* cancel the request, if it hasn't been cancelled already */ if (test_and_clear_bit (US_FLIDX_SG_ACTIVE , &us->dflags)) { -//printk("-- cancelling sg request\n"); +/* pr_info("-- cancelling sg request\n"); */ usb_sg_cancel (&us->current_sg); } }
@@ -249,7 +252,7 @@ int usb_stor_bulk_transfer_sg(struct us_data* us, unsigned int pipe,int result;unsigned int partial; -//printk("transport --- usb_stor_bulk_transfer_sg\n"); +/* pr_info("transport --- usb_stor_bulk_transfer_sg\n"); */ /* are we scatter-gathering? */ if (use_sg) {
@@ -281,7 +284,7 @@ void usb_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)int need_auto_sense;int result; -//printk("transport --- usb_stor_invoke_transport\n"); +/* pr_info("transport --- usb_stor_invoke_transport\n"); */ usb_stor_print_cmd (srb);/* send the command to the transport layer */ scsi_set_resid (srb,0 );
@@ -290,7 +293,7 @@ void usb_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)/* if the command gets aborted by the higher layers, we need to short-circuit all other processing */ if (test_bit (US_FLIDX_TIMED_OUT , &us->dflags)) { -//printk("-- command was aborted\n"); +/* pr_info("-- command was aborted\n"); */ srb->result =DID_ABORT <<16 ; goto Handle_Errors; }
@@ -298,7 +301,7 @@ void usb_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)/* if there is a transport error, reset and don't auto-sense */ if (result ==USB_STOR_TRANSPORT_ERROR ) { -//printk("-- transport indicates error, resetting\n"); +/* pr_info("-- transport indicates error, resetting\n"); */ srb->result =DID_ERROR <<16 ; goto Handle_Errors; }
@@ -317,13 +320,13 @@ void usb_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)if ((us->protocol ==USB_PR_CB || us->protocol ==USB_PR_DPCM_USB ) && srb->sc_data_direction !=DMA_FROM_DEVICE ) { -//printk("-- CB transport device requiring auto-sense\n"); +/* pr_info("-- CB transport device requiring auto-sense\n"); */ need_auto_sense =1 ; }if (result ==USB_STOR_TRANSPORT_FAILED ) { -//printk("-- transport indicates command failure\n"); +/* pr_info("-- transport indicates command failure\n"); */ need_auto_sense =1 ; }
@@ -333,7 +336,7 @@ void usb_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)int temp_result;struct scsi_eh_save ses; -printk ("Issuing auto-REQUEST_SENSE\n" ); +pr_info ("Issuing auto-REQUEST_SENSE\n" );scsi_eh_prep_cmnd (srb, &ses,NULL ,0 ,US_SENSE_SIZE );
@@ -352,13 +355,13 @@ void usb_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)if (test_bit (US_FLIDX_TIMED_OUT , &us->dflags)) { -//printk("-- auto-sense aborted\n"); +/* pr_info("-- auto-sense aborted\n"); */ srb->result =DID_ABORT <<16 ; goto Handle_Errors; }if (temp_result !=USB_STOR_TRANSPORT_GOOD ) { -//printk("-- auto-sense failure\n"); +/* pr_info("-- auto-sense failure\n"); */ srb->result =DID_ERROR <<16 ;if (!(us->fflags &US_FL_SCM_MULT_TARG )) goto Handle_Errors;
@@ -409,7 +412,7 @@ void ENE_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us) {int result=0 ; -//printk("transport --- ENE_stor_invoke_transport\n"); +/* pr_info("transport --- ENE_stor_invoke_transport\n"); */ usb_stor_print_cmd (srb);/* send the command to the transport layer */ scsi_set_resid (srb,0 );
@@ -427,7 +430,7 @@ void ENE_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)/* if the command gets aborted by the higher layers, we need to short-circuit all other processing */ if (test_bit (US_FLIDX_TIMED_OUT , &us->dflags)) { -//printk("-- command was aborted\n"); +/* pr_info("-- command was aborted\n"); */ srb->result =DID_ABORT <<16 ; goto Handle_Errors; }
@@ -435,7 +438,7 @@ void ENE_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)/* if there is a transport error, reset and don't auto-sense */ if (result ==USB_STOR_TRANSPORT_ERROR ) { -//printk("-- transport indicates error, resetting\n"); +/* pr_info("-- transport indicates error, resetting\n"); */ srb->result =DID_ERROR <<16 ; goto Handle_Errors; }
@@ -450,7 +453,7 @@ void ENE_stor_invoke_transport(struct scsi_cmnd *srb, struct us_data *us) srb->result =SAM_STAT_GOOD ;if (result ==USB_STOR_TRANSPORT_FAILED ) { -//printk("-- transport indicates command failure\n"); +/* pr_info("-- transport indicates command failure\n"); */ //need_auto_sense = 1; BuildSenseBuffer (srb, us->SrbStatus); srb->result =SAM_STAT_CHECK_CONDITION ;
@@ -488,7 +491,7 @@ void BuildSenseBuffer(struct scsi_cmnd *srb, int SrbStatus)BYTE *buf = srb->sense_buffer;BYTE asc; -printk ("transport --- BuildSenseBuffer\n" ); +pr_info ("transport --- BuildSenseBuffer\n" );switch (SrbStatus) {case SS_NOT_READY : asc =0x3a ;break ;// sense key = 0x02
@@ -507,17 +510,17 @@ void BuildSenseBuffer(struct scsi_cmnd *srb, int SrbStatus)//----- usb_stor_stop_transport() --------------------- void usb_stor_stop_transport (struct us_data *us) { -//printk("transport --- usb_stor_stop_transport\n"); +/* pr_info("transport --- usb_stor_stop_transport\n"); */ if (test_and_clear_bit (US_FLIDX_URB_ACTIVE , &us->dflags)) { -//printk("-- cancelling URB\n"); +/* pr_info("-- cancelling URB\n"); */ usb_unlink_urb (us->current_urb); }if (test_and_clear_bit (US_FLIDX_SG_ACTIVE , &us->dflags)) { -//printk("-- cancelling sg request\n"); +/* pr_info("-- cancelling sg request\n"); */ usb_sg_cancel (&us->current_sg); } }
@@ -527,7 +530,7 @@ int usb_stor_Bulk_max_lun(struct us_data *us) {int result; -//printk("transport --- usb_stor_Bulk_max_lun\n"); +/* pr_info("transport --- usb_stor_Bulk_max_lun\n"); */ /* issue the command */ us->iobuf[0 ] =0 ; result = usb_stor_control_msg(us, us->recv_ctrl_pipe,
@@ -536,7 +539,8 @@ int usb_stor_Bulk_max_lun(struct us_data *us)USB_RECIP_INTERFACE , 0, us->ifnum, us->iobuf, 1, HZ); -//printk("GetMaxLUN command result is %d, data is %d\n", result, us->iobuf[0]); +/* pr_info("GetMaxLUN command result is %d, data is %d\n", +result, us->iobuf[0]); */ /* if we have a successful request, return the result */ if (result >0 )
@@ -557,7 +561,7 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us)unsigned int cswlen;unsigned int cbwlen =US_BULK_CB_WRAP_LEN ; -//printk("transport --- usb_stor_Bulk_transport\n"); +/* pr_info("transport --- usb_stor_Bulk_transport\n"); */ /* Take care of BULK32 devices; set extra byte to 0 */ if (unlikely (us->fflags &US_FL_BULK32 )) {
@@ -581,13 +585,13 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us)// send command /* send it to out endpoint */ -/*printk("Bulk Command S 0x%x T 0x%x L %d F %d Trg %d LUN %d CL %d\n", +/* pr_info("Bulk Command S 0x%x T 0x%x L %d F %d Trg %d LUN %d CL %d\n", le32_to_cpu(bcb->Signature), bcb->Tag, le32_to_cpu(bcb->DataTransferLength), bcb->Flags, (bcb->Lun >> 4), (bcb->Lun & 0x0F), -bcb->Length);*/ +bcb->Length); */ result =usb_stor_bulk_transfer_buf (us, us->send_bulk_pipe, bcb, cbwlen,NULL ); -//printk("Bulk command transfer result=%d\n", result); +/* pr_info("Bulk command transfer result=%d\n", result); */ if (result !=USB_STOR_XFER_GOOD )return USB_STOR_TRANSPORT_ERROR ;
@@ -599,7 +603,7 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us) {unsigned int pipe = srb->sc_data_direction ==DMA_FROM_DEVICE ? us->recv_bulk_pipe : us->send_bulk_pipe; result =usb_stor_bulk_srb (us, pipe, srb); -//printk("Bulk data transfer result 0x%x\n", result); +/* pr_info("Bulk data transfer result 0x%x\n", result); */ if (result ==USB_STOR_XFER_ERROR )return USB_STOR_TRANSPORT_ERROR ;
@@ -608,12 +612,12 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us) }/* get CSW for device status */ -//printk("Attempting to get CSW...\n"); +/* pr_info("Attempting to get CSW...\n"); */ result =usb_stor_bulk_transfer_buf (us, us->recv_bulk_pipe, bcs,US_BULK_CS_WRAP_LEN , &cswlen);if (result ==USB_STOR_XFER_SHORT && cswlen ==0 ) { -//printk("Received 0-length CSW; retrying...\n"); +/* pr_info("Received 0-length CSW; retrying...\n"); */ result =usb_stor_bulk_transfer_buf (us, us->recv_bulk_pipe, bcs,US_BULK_CS_WRAP_LEN , &cswlen); }
@@ -621,21 +625,23 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us)if (result ==USB_STOR_XFER_STALLED ) {/* get the status again */ -//printk("Attempting to get CSW (2nd try)...\n"); +/* pr_info("Attempting to get CSW (2nd try)...\n"); */ result =usb_stor_bulk_transfer_buf (us, us->recv_bulk_pipe, bcs,US_BULK_CS_WRAP_LEN ,NULL ); }/* if we still have a failure at this point, we're in trouble */ -//printk("Bulk status result = %d\n", result); +/* pr_info("Bulk status result = %d\n", result); */ if (result !=USB_STOR_XFER_GOOD )return USB_STOR_TRANSPORT_ERROR ;/* check bulk status */ residue =le32_to_cpu (bcs->Residue); -//printk("Bulk Status S 0x%x T 0x%x R %u Stat 0x%x\n", le32_to_cpu(bcs->Signature), bcs->Tag, residue, bcs->Status); +/* pr_info("Bulk Status S 0x%x T 0x%x R %u Stat 0x%x\n", +le32_to_cpu(bcs->Signature), +bcs->Tag, residue, bcs->Status); */ if (!(bcs->Tag == us->tag || (us->fflags &US_FL_BULK_IGNORE_TAG )) || bcs->Status >US_BULK_STAT_PHASE ) { -//printk("Bulk logical error\n"); +/* pr_info("Bulk logical error\n"); */ return USB_STOR_TRANSPORT_ERROR ; }
@@ -643,13 +649,14 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us) { us->bcs_signature = bcs->Signature;//if (us->bcs_signature != cpu_to_le32(US_BULK_CS_SIGN)) -// printk("Learnt BCS signature 0x%08X\n", le32_to_cpu(us->bcs_signature)); +/* pr_info("Learnt BCS signature 0x%08X\n", +le32_to_cpu(us->bcs_signature)); */ } else if (bcs->Signature != us->bcs_signature) { -/*printk("Signature mismatch: got %08X, expecting %08X\n", +/* pr_info("Signature mismatch: got %08X, expecting %08X\n", le32_to_cpu(bcs->Signature), -le32_to_cpu(us->bcs_signature));*/ +le32_to_cpu(us->bcs_signature)); */ return USB_STOR_TRANSPORT_ERROR ; }
@@ -710,47 +717,47 @@ static int usb_stor_reset_common(struct us_data *us,int result;int result2; -//printk("transport --- usb_stor_reset_common\n"); +/* pr_info("transport --- usb_stor_reset_common\n"); */ if (test_bit (US_FLIDX_DISCONNECTING , &us->dflags)) { -//printk("No reset during disconnect\n"); +/* pr_info("No reset during disconnect\n"); */ return -EIO ; } result =usb_stor_control_msg (us, us->send_ctrl_pipe, request, requesttype, value, index, data, size,5 *HZ );if (result <0 ) { -//printk("Soft reset failed: %d\n", result); +/* pr_info("Soft reset failed: %d\n", result); */ return result; }wait_event_interruptible_timeout (us->delay_wait,test_bit (US_FLIDX_DISCONNECTING , &us->dflags),HZ *6 );if (test_bit (US_FLIDX_DISCONNECTING , &us->dflags)) { -//printk("Reset interrupted by disconnect\n"); +/* pr_info("Reset interrupted by disconnect\n"); */ return -EIO ; } -//printk("Soft reset: clearing bulk-in endpoint halt\n"); +/* pr_info("Soft reset: clearing bulk-in endpoint halt\n"); */ result =usb_stor_clear_halt (us, us->recv_bulk_pipe); -//printk("Soft reset: clearing bulk-out endpoint halt\n"); +/* pr_info("Soft reset: clearing bulk-out endpoint halt\n"); */ result2 =usb_stor_clear_halt (us, us->send_bulk_pipe);/* return a result code based on the result of the clear-halts */ if (result >=0 ) result = result2;//if (result < 0) -// printk("Soft reset failed\n"); +/* pr_info("Soft reset failed\n"); */ //else -// printk("Soft reset done\n"); +/* pr_info("Soft reset done\n"); */ return result; }//----- usb_stor_Bulk_reset() --------------------- int usb_stor_Bulk_reset (struct us_data *us) { -//printk("transport --- usb_stor_Bulk_reset\n"); +/* pr_info("transport --- usb_stor_Bulk_reset\n"); */ return usb_stor_reset_common (us,US_BULK_RESET_REQUEST ,USB_TYPE_CLASS |USB_RECIP_INTERFACE ,0 , us->ifnum,NULL ,0 );
@@ -761,18 +768,19 @@ int usb_stor_port_reset(struct us_data *us) {int result; -//printk("transport --- usb_stor_port_reset\n"); +/* pr_info("transport --- usb_stor_port_reset\n"); */ result =usb_lock_device_for_reset (us->pusb_dev, us->pusb_intf);if (result <0 ) -printk ("unable to lock device for reset: %d\n" , result); +pr_info ("unable to lock device for reset: %d\n" , result);else {/* Were we disconnected while waiting for the lock? */ if (test_bit (US_FLIDX_DISCONNECTING , &us->dflags)) { result = -EIO ; -//printk("No reset during disconnect\n"); +/* pr_info("No reset during disconnect\n"); */ }else { result =usb_reset_device (us->pusb_dev); -//printk("usb_reset_composite_device returns %d\n", result); +/* pr_info("usb_reset_composite_device returns %d\n", +result); */ }usb_unlock_device (us->pusb_dev); }
drivers/staging/keucr/usb.c +45 -43
320 lines not on this page · raw message
Signature · 1 line
1.7.1
Re: [PATCH 1/5] staging/keucr: init use pr_<level> for messages
In reply to Cho, Yu-ChenQuoted 3 lines · Yu-Chen
init.cuse pr_<level> for messagesSigned-off-by Cho, Yu-Chen <[email protected]>
This patch did not apply, but your others did, weird :(
thanks,
greg k-h