Patch series against Bernard for Fedora 15 users
PATCH 4/7 xorg-[lib-common|proto-common]: disable use of fop document generation
In reply to Joshua LockFrom: Joshua Lock <[email protected]>
On Fedora 15 I see a huge Java backtrace when document generation runs for some xorg libs. As fop is automatically detected, with the possibility of detecting fop on the host whilst doing target builds, the safest bet is to explicitly disable fop for document generation.
--- meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 2 +- .../xorg-proto/xorg-proto-common.inc | 1 + 2 files changed, 2 insertions(+), 1 deletions(-)
meta/recipes-graphics/xorg-lib/xorg-lib-common.inc +1 -1
@@ -13,4 +13,4 @@ S = "${WORKDIR}/${XORG_PN}-${PV}" inherit autotools pkgconfig -EXTRA_OECONF = "--enable-malloc0returnsnull" +EXTRA_OECONF = "--enable-malloc0returnsnull --with-fop=no"
meta/recipes-graphics/xorg-proto/xorg-proto-common.inc +1 -0
@@ -14,6 +14,7 @@ S = "${WORKDIR}/${XORG_PN}-${PV}" DEPENDS = "util-macros" inherit autotools pkgconfig +EXTRA_OECONF = "--with-fop=no" # ${PN} is empty so we need to tweak -dev and -dbg package dependencies RDEPENDS_${PN}-dev = ""
Signature · 1 line
1.7.4.1
PATCH 5/7 libx11: disable building of specs
In reply to Joshua LockFrom: Joshua Lock <[email protected]>
Generating Postscript specs fails on Fedora 15, I don't *think* we need them so disable them.
--- meta/recipes-graphics/xorg-lib/libx11.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-graphics/xorg-lib/libx11.inc +1 -1
@@ -11,7 +11,7 @@ PROVIDES = "virtual/libx11" XORG_PN = "libX11" LEAD_SONAME = "libX11.so" -EXTRA_OECONF += "--with-keysymdef=${STAGING_INCDIR}/X11/keysymdef.h" +EXTRA_OECONF += "--with-keysymdef=${STAGING_INCDIR}/X11/keysymdef.h --disable-specs" FILES_${PN} += "${datadir}/X11/XKeysymDB ${datadir}/X11/XErrorDB ${libdir}/X11/Xcms.txt" FILES_${PN}-locale += "${datadir}/X11/locale ${libdir}/X11/locale"
Signature · 1 line
1.7.4.1
PATCH 6/7 openjade: fix build with GCC 4.6
In reply to Joshua LockFrom: Joshua Lock <[email protected]>
In GCC 4.6 the compiler no longer allows objects of const-qualified type to be default initialized unless the type has a user-declared default constructor.
Patch from Gentoo bugzilla: http://bugs.gentoo.org/show_bug.cgi?id=358021
--- .../user-declared-default-constructor.patch | 88 ++++++++++++++++++++ .../openjade/openjade-native_1.3.2.bb | 5 +- 2 files changed, 91 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/user-declared-default-constructor.patch
meta/recipes-devtools/openjade/openjade-1.3.2/user-declared-default-constructor.patch new file +88 -0
@@ -0,0 +1,88 @@ +In GCC 4.6 the compiler no longer allows objects of const-qualified type to +be default initialized unless the type has a user-declared default +constructor. + +Patch from Gentoo bugzilla: http://bugs.gentoo.org/show_bug.cgi?id=358021 + +Gentoo Bugzilla description follows: +"If a class or struct has no user-defined default constructor, C++ doesn't +allow you to default construct a const instance of it. + +https://bugs.gentoo.org/358021 +http://clang.llvm.org/compatibility.html#default_init_const +http://gcc.gnu.org/PR44499" + +--- a/jade/TeXFOTBuilder.cxx ++++ b/jade/TeXFOTBuilder.cxx +@@ -88,6 +88,8 @@ public: + value.convertString(nic_.placement); + } + ExtensionFlowObj *copy() const { return new PageFloatFlowObj(*this); } ++ public: ++ PageFloatFlowObj() {} + private: + PageFloatNIC nic_; + StringC name_; +@@ -101,6 +103,8 @@ public: + fotb.endPageFootnote(); + } + ExtensionFlowObj *copy() const { return new PageFootnoteFlowObj(*this); } ++ public: ++ PageFootnoteFlowObj() {} + private: + }; + ////////////////////////////////////////////////////////////////////// +--- a/jade/TransformFOTBuilder.cxx ++++ b/jade/TransformFOTBuilder.cxx +@@ -41,6 +41,7 @@ public: + }; + class EntityRefFlowObj : public TransformExtensionFlowObj { + public: ++ EntityRefFlowObj() {} + void atomic(TransformFOTBuilder &fotb, const NodePtr &) const { + fotb.entityRef(name_); + } +@@ -56,6 +57,7 @@ public: + }; + class ProcessingInstructionFlowObj : public TransformExtensionFlowObj { + public: ++ ProcessingInstructionFlowObj() {} + void atomic(TransformFOTBuilder &fotb, const NodePtr &) const { + fotb.processingInstruction(data_); + } +@@ -98,6 +100,8 @@ public: + } + } + ExtensionFlowObj *copy() const { return new EmptyElementFlowObj(*this); } ++ public: ++ EmptyElementFlowObj() {} + private: + ElementNIC nic_; + }; +@@ -133,6 +137,8 @@ public: + } + } + ExtensionFlowObj *copy() const { return new ElementFlowObj(*this); } ++ public: ++ ElementFlowObj() {} + private: + ElementNIC nic_; + }; +@@ -150,6 +156,8 @@ public: + value.convertString(systemId_); + } + ExtensionFlowObj *copy() const { return new EntityFlowObj(*this); } ++ public: ++ EntityFlowObj() {} + private: + StringC systemId_; + }; +@@ -174,6 +182,8 @@ public: + } + } + ExtensionFlowObj *copy() const { return new DocumentTypeFlowObj(*this); } ++ public: ++ DocumentTypeFlowObj() {} + private: + DocumentTypeNIC nic_; + };
meta/recipes-devtools/openjade/openjade-native_1.3.2.bb +3 -2
@@ -7,13 +7,14 @@ SECTION = "base" LICENSE = "BSD" LIC_FILES_CHKSUM = "file://COPYING;md5=641ff1e4511f0a87044ad42f87cb1045" -PR = "r1" +PR = "r2" DEPENDS = "opensp-native sgml-common-native" RDEPENDS_${PN} = "sgml-common" SRC_URI = "${SOURCEFORGE_MIRROR}/openjade/openjade-${PV}.tar.gz \ - file://makefile.patch" + file://makefile.patch \ + file://user-declared-default-constructor.patch" SRC_URI[md5sum] = "7df692e3186109cc00db6825b777201e" SRC_URI[sha256sum] = "1d2d7996cc94f9b87d0c51cf0e028070ac177c4123ecbfd7ac1cb8d0b7d322d1"
Signature · 1 line
1.7.4.1
PATCH 7/7 xserver-xf86: explicitly disable fop document generation
In reply to Joshua LockFrom: Joshua Lock <[email protected]>
--- .../xorg-xserver/xserver-xf86-common.inc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
meta/recipes-graphics/xorg-xserver/xserver-xf86-common.inc +1 -0
@@ -34,3 +34,4 @@ FILES_${PN}-dbg += "${libdir}/xorg/modules/.debug \ SRC_URI += "file://macro_tweak.patch" +EXTRA_OECONF = "--with-fop=no"
Signature · 1 line
1.7.4.1
cover Patch series against Bernard for Fedora 15 users
From: Joshua Lock <[email protected]>
I decided to punish myself by testing how well our branch fares on Fedora 15.
I don't think any of these should be too controversial and with the series applied I am able to build both minimal and sato images on my Fedora 15 box.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: josh/bernard-f15
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=josh/bernard-f15
Thanks,
Joshua Lock <[email protected]>
---
Joshua Lock (7):
elfutils: fix builds with gcc 4.6
python-native: add missing SRC_URI hashes
libx11: add missing SRC_URI hashes xorg-[lib-common|proto-common]: disable use of fop document
generation
libx11: disable building of specs
openjade: fix build with GCC 4.6
xserver-xf86: explicitly disable fop document generation
meta/recipes-devtools/elfutils/elfutils_0.148.bb | 4 + .../user-declared-default-constructor.patch | 88 ++++++++++++++++++++ .../openjade/openjade-native_1.3.2.bb | 5 +- .../recipes-devtools/python/python-native_2.6.6.bb | 3 + meta/recipes-graphics/xorg-lib/libx11.inc | 2 +- meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb | 3 + meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 2 +- .../xorg-proto/xorg-proto-common.inc | 1 + .../xorg-xserver/xserver-xf86-common.inc | 1 + 9 files changed, 105 insertions(+), 4 deletions(-) create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/user-declared-default-constructor.patch
Signature · 1 line
1.7.4.1
PATCH 1/7 elfutils: fix builds with gcc 4.6
From: Joshua Lock <[email protected]>
gcc 4.6 (as used in Fedora 15) adds some extra warnings which are included with Werror. The new unused-but-set variable warning causes an error in libasm of elfutils. Work around this by removing unused-but-set from Werror.
--- meta/recipes-devtools/elfutils/elfutils_0.148.bb | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
meta/recipes-devtools/elfutils/elfutils_0.148.bb +4 -0
@@ -40,6 +40,10 @@ SRC_URI += "\ inherit autotools +# GCC 4.6.0 raises an unused-but-set warning in libasm, for now remove +# this warning from Werror +CFLAGS_virtclass-native += "-Wno-error=unused-but-set-variable" + EXTRA_OECONF = "--program-prefix=eu-" do_configure_prepend() {
Signature · 1 line
1.7.4.1
PATCH 2/7 python-native: add missing SRC_URI hashes
In reply to Joshua LockFrom: Joshua Lock <[email protected]>
--- .../recipes-devtools/python/python-native_2.6.6.bb | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
meta/recipes-devtools/python/python-native_2.6.6.bb +3 -0
@@ -14,6 +14,9 @@ SRC_URI = "http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.bz2 \ file://nohostlibs.patch" S = "${WORKDIR}/Python-${PV}" +SRC_URI[md5sum] = "cf4e6881bb84a7ce6089e4a307f71f14" +SRC_URI[sha256sum] = "134c5e0736bae2e5570d0b915693374f11108ded63c35a23a35d282737d2ce83" + inherit native EXTRA_OEMAKE = '\
Signature · 1 line
1.7.4.1
PATCH 3/7 libx11: add missing SRC_URI hashes
In reply to Joshua LockFrom: Joshua Lock <[email protected]>
--- meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb +3 -0
@@ -10,6 +10,9 @@ SRC_URI += "file://x11_disable_makekeys.patch \ file://nodolt.patch \ file://include_fix.patch" +SRC_URI[md5sum] = "f65c9c7ecbfb64c19dbd7927160d63fd" +SRC_URI[sha256sum] = "88d7238ce5f7cd123450567de7a3b56a43556e4ccc45df38b8324147c889a844" + DEPENDS += "bigreqsproto xproto xextproto xtrans libxau xcmiscproto \ libxdmcp xf86bigfontproto kbproto inputproto xproto-native gettext"
Signature · 1 line
1.7.4.1
Re: [PATCH 4/7] xorg-[lib-common|proto-common]: disable use of fop document generation
In reply to Joshua LockQuoted 6 lines · Joshua Lock
From: Joshua Lock <[email protected]>
On Fedora 15 I see a huge Java backtrace when document generation runs for some xorg libs. As fop is automatically detected, with the possibility of detecting fop on the host whilst doing target builds, the safest bet is to explicitly disable fop for document generation.
This is actually a bug in the GCJ stack; it should go away if you use OpenJDK. Try using "update-alternatives --config java".
But yeah, I doubt any embeds care about the docs, and certainly fop pulls in a frightening dependency chain; so cool by me to disable.
Re: [PATCH 4/7] xorg-[lib-common|proto-common]: disable use of fop document generation
In reply to Joshua LockQuoted 30 lines · Joshua Lock
From: Joshua Lock <[email protected]>
On Fedora 15 I see a huge Java backtrace when document generation runs for some xorg libs. As fop is automatically detected, with the possibility of detecting fop on the host whilst doing target builds, the safest bet is to explicitly disable fop for document generation.
Signed-off-by Joshua Lock <[email protected]>---
meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 2 +- .../xorg-proto/xorg-proto-common.inc | 1 +2 files changed, 2 insertions(+), 1 deletions(-)meta/recipes-graphics/xorg-lib/xorg-lib-common.inc +0
-0@@ -13,4 +13,4 @@ S = "${WORKDIR}/${XORG_PN}-${PV}"inherit autotools pkgconfig
meta/recipes-graphics/xorg-lib/xorg-lib-common.inc +1
-1-EXTRA_OECONF = "--enable-malloc0returnsnull" +EXTRA_OECONF = "--enable-malloc0returnsnull --with-fop=no"meta/recipes-graphics/xorg-proto/xorg-proto-common.inc +0
-0@@ -14,6 +14,7 @@ S = "${WORKDIR}/${XORG_PN}-${PV}"DEPENDS = "util-macros"
Quoted 2 lines
inherit autotools pkgconfig
+EXTRA_OECONF = "--with-fop=no"
after this I get
| checking for xmlto... no | configure: WARNING: xmlto not found - documentation targets will be skipped | configure: error: --with-fop expects 'yes' or 'no' | FATAL: oe_runconf failed | ERROR: Function 'do_configure' failed (see
/OE/shr-core/tmp/work/x86_64-linux/xproto-native-1_7.0.20-r0/temp/log.do_configure.29076 for further information)
NOTE: package xproto-native-1_7.0.20-r0: task do_configure: Failed
ERROR: Task 957 (virtual:native:/OE/shr-core/openembedded-core/meta/recipes-graphics/xorg-proto/xproto_7.0.20.bb, do_configure) failed with exit code '1'
because there is
--with-fop=no--enable-specs=no
so you had to put space after no, or before this
OE nokia900@shr ~/shr-core $ grep OECONF openembedded-core/meta/recipes-graphics/xorg-proto/xproto_7.0.20.bb EXTRA_OECONF_append = "--enable-specs=no"
Quoted 11 lines
# ${PN} is empty so we need to tweak -dev and -dbg package dependencies RDEPENDS_${PN}-dev = ""
--
1.7.4.1_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky
Re: [PATCH 1/7] elfutils: fix builds with gcc 4.6
In reply to Joshua LockQuoted 24 lines · Joshua Lock
From: Joshua Lock <[email protected]>
gcc 4.6 (as used in Fedora 15) adds some extra warnings which are included with Werror. The new unused-but-set variable warning causes an error in libasm of elfutils. Work around this by removing unused-but-set from Werror.
Signed-off-by Joshua Lock <[email protected]>---
meta/recipes-devtools/elfutils/elfutils_0.148.bb | 4 ++++1 files changed, 4 insertions(+), 0 deletions(-)meta/recipes-devtools/elfutils/elfutils_0.148.bb +0
-0@@ -40,6 +40,10 @@ SRC_URI += "\inherit autotools
meta/recipes-devtools/elfutils/elfutils_0.148.bb +4
-0+# GCC 4.6.0 raises an unused-but-set warning in libasm, for now remove +# this warning from Werror +CFLAGS_virtclass-native += "-Wno-error=unused-but-set-variable" +
Quoted 1 line
EXTRA_OECONF = "--program-prefix=eu-"
this breaks all other distros not yet using gcc-4.6..
configure:2892: checking whether the C compiler works configure:2914: gcc -Wno-error=unused-but-set-variable -isystem/OE/shr-core/tmp/sysroots/x86_64-linux/usr/include -L/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath-link,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-O1 conftest.c >&5
cc1: error: -Werror=unused-but-set-variable: No option -Wunused-but-set-variable configure:2918: $? = 1
configure:2956: result: no
configure: failed program was:
| /* confdefs.h */ | #define PACKAGE_NAME "Red Hat elfutils" | #define PACKAGE_TARNAME "elfutils" | #define PACKAGE_VERSION "0.148" | #define PACKAGE_STRING "Red Hat elfutils 0.148" | #define PACKAGE_BUGREPORT "http://bugzilla.redhat.com/bugzilla/" | #define PACKAGE_URL "" | #define PACKAGE "elfutils" | #define VERSION "0.148" | #define MODVERSION "Build on jama 2011-04-04T23:34:25+0200" | /* end confdefs.h. */ | | int | main () | { | | ; | return 0; | }
configure:2961: error: in `/OE/shr-core/tmp/work/x86_64-linux/elfutils-native-0.148-r1/elfutils-0.148':
configure:2965: error: C compiler cannot create executables
See `config.log' for more details.
Regards,
Quoted 10 lines
do_configure_prepend() {
--
1.7.4.1_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky
Re: [PATCH 1/7] elfutils: fix builds with gcc 4.6
Quoted 60 lines · Martin Jansa
Quoted 17 lines · Joshua Lock
From: Joshua Lock <[email protected]>
gcc 4.6 (as used in Fedora 15) adds some extra warnings which are included with Werror. The new unused-but-set variable warning causes an error in libasm of elfutils. Work around this by removing unused-but-set from Werror.
Signed-off-by Joshua Lock <[email protected]>--- meta/recipes-devtools/elfutils/elfutils_0.148.bb | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)meta/recipes-devtools/elfutils/elfutils_0.148.bb +0
-0meta/recipes-devtools/elfutils/elfutils_0.148.bb SRC_URI += "\ · line 47
Quoted 8 lines
meta/recipes-devtools/elfutils/elfutils_0.148.bb +4
-0@@ -40,6 +40,10 @@ SRC_URI += "\ inherit autotools +# GCC 4.6.0 raises an unused-but-set warning in libasm, for now remove +# this warning from Werror +CFLAGS_virtclass-native += "-Wno-error=unused-but-set-variable" + EXTRA_OECONF = "--program-prefix=eu-"this breaks all other distros not yet using gcc-4.6..
configure:2892: checking whether the C compiler works configure:2914: gcc -Wno-error=unused-but-set-variable
(quoted diff) +0
-4-isystem/OE/shr-core/tmp/sysroots/x86_64-linux/usr/include -L/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath-link,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-O1
conftest.c>&5
cc1: error: -Werror=unused-but-set-variable: No option -Wunused-but-set-variable configure:2918: $? = 1
configure:2956: result: no
configure: failed program was:| /* confdefs.h */ | #define PACKAGE_NAME "Red Hat elfutils" | #define PACKAGE_TARNAME "elfutils" | #define PACKAGE_VERSION "0.148" | #define PACKAGE_STRING "Red Hat elfutils 0.148" | #define PACKAGE_BUGREPORT "http://bugzilla.redhat.com/bugzilla/" | #define PACKAGE_URL "" | #define PACKAGE "elfutils" | #define VERSION "0.148" | #define MODVERSION "Build on jama 2011-04-04T23:34:25+0200" | /* end confdefs.h. */ | | int | main () | { | | ; | return 0; | }
Quoted 4 lines
configure:2961: error: in `/OE/shr-core/tmp/work/x86_64-linux/elfutils-native-0.148-r1/elfutils-0.148':
configure:2965: error: C compiler cannot create executables
See `config.log' for more details.
Ouch, I'm going to revert this, we'll need an alternative fix. Thanks for reporting!
Cheers,
Richard
Re: [PATCH 4/7] xorg-[lib-common|proto-common]: disable use of fop document generation
In reply to Martin JansaQuoted 14 lines · Martin Jansa
Quoted 1 line · Joshua Lock
From: Joshua Lock <[email protected]>
| checking for xmlto... no | configure: WARNING: xmlto not found - documentation targets will be skipped | configure: error: --with-fop expects 'yes' or 'no' | FATAL: oe_runconf failed | ERROR: Function 'do_configure' failed (see/OE/shr-core/tmp/work/x86_64-linux/xproto-native-1_7.0.20-r0/temp/log.do_configure.29076 for further information)
NOTE: package xproto-native-1_7.0.20-r0: taskdo_configure: Failed
ERROR: Task 957 (virtual:native:/OE/shr-core/openembedded-core/meta/recipes-graphics/xorg-proto/xproto_7.0.20.bb,do_configure) failed with exit code '1'
Quoted 8 lines
because there is
--with-fop=no--enable-specs=noso you had to put space after no, or before this
OE nokia900@shr ~/shr-core $ grep OECONF openembedded-core/meta/recipes-graphics/xorg-proto/xproto_7.0.20.bb
EXTRA_OECONF_append= "--enable-specs=no"
Thanks, I'll fix this.
Cheers,
Richard
Re: [PATCH 1/7] elfutils: fix builds with gcc 4.6
In reply to Richard PurdieQuoted 57 lines · Richard Purdie
Quoted 56 lines · Martin Jansa
Quoted 17 lines · Joshua Lock
From: Joshua Lock <[email protected]>
gcc 4.6 (as used in Fedora 15) adds some extra warnings which are included with Werror. The new unused-but-set variable warning causes an error in libasm of elfutils. Work around this by removing unused-but-set from Werror.
Signed-off-by Joshua Lock <[email protected]>--- meta/recipes-devtools/elfutils/elfutils_0.148.bb | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)meta/recipes-devtools/elfutils/elfutils_0.148.bb +0
-0meta/recipes-devtools/elfutils/elfutils_0.148.bb SRC_URI += "\ · line 47
Quoted 8 lines
meta/recipes-devtools/elfutils/elfutils_0.148.bb +4
-0@@ -40,6 +40,10 @@ SRC_URI += "\ inherit autotools +# GCC 4.6.0 raises an unused-but-set warning in libasm, for now remove +# this warning from Werror +CFLAGS_virtclass-native += "-Wno-error=unused-but-set-variable" + EXTRA_OECONF = "--program-prefix=eu-"this breaks all other distros not yet using gcc-4.6..
configure:2892: checking whether the C compiler works configure:2914: gcc -Wno-error=unused-but-set-variable
(quoted diff) +0
-4-isystem/OE/shr-core/tmp/sysroots/x86_64-linux/usr/include -L/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath-link,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-O1
conftest.c>&5
cc1: error: -Werror=unused-but-set-variable: No option -Wunused-but-set-variable configure:2918: $? = 1
configure:2956: result: no
configure: failed program was:| /* confdefs.h */ | #define PACKAGE_NAME "Red Hat elfutils" | #define PACKAGE_TARNAME "elfutils" | #define PACKAGE_VERSION "0.148" | #define PACKAGE_STRING "Red Hat elfutils 0.148" | #define PACKAGE_BUGREPORT "http://bugzilla.redhat.com/bugzilla/" | #define PACKAGE_URL "" | #define PACKAGE "elfutils" | #define VERSION "0.148" | #define MODVERSION "Build on jama 2011-04-04T23:34:25+0200" | /* end confdefs.h. */ | | int | main () | {
Quoted 8 lines
Quoted 8 lines
| | ; | return 0; | }configure:2961: error: in `/OE/shr-core/tmp/work/x86_64-linux/elfutils-native-0.148-r1/elfutils-0.148':
configure:2965: error: C compiler cannot create executables
See `config.log' for more details.
Sorry about this Martin. Thanks for catching and reporting.
Quoted 3 lines
Ouch, I'm going to revert this, we'll need an alternative fix. Thanks for reporting!
I've worked up an alternative fix and sent a pull request to oe-core. I took the approach of consolidating several patches from the upstream source repository which remove the unused variables.
I consolidated them into a single patch so that they are easier to drop once we update elfutils to 0.152 or higher.
Regards,
Joshua
Signature · 3 lines
Joshua Lock
Yocto Build System Monkey
Intel Open Source Technology CentreRe: [PATCH 1/7] elfutils: fix builds with gcc 4.6
Quoted 73 lines · Joshua Lock
Quoted 57 lines · Richard Purdie
Quoted 56 lines · Martin Jansa
Quoted 24 lines · Joshua Lock
From: Joshua Lock <[email protected]>
gcc 4.6 (as used in Fedora 15) adds some extra warnings which are included with Werror. The new unused-but-set variable warning causes an error in libasm of elfutils. Work around this by removing unused-but-set from Werror.
Signed-off-by Joshua Lock <[email protected]>---
meta/recipes-devtools/elfutils/elfutils_0.148.bb | 4 ++++1 files changed, 4 insertions(+), 0 deletions(-)meta/recipes-devtools/elfutils/elfutils_0.148.bb +0
-0@@ -40,6 +40,10 @@ SRC_URI += "\inherit autotools
meta/recipes-devtools/elfutils/elfutils_0.148.bb +4
-0+# GCC 4.6.0 raises an unused-but-set warning in libasm, for now remove +# this warning from Werror +CFLAGS_virtclass-native += "-Wno-error=unused-but-set-variable" +Quoted 1 line
EXTRA_OECONF = "--program-prefix=eu-"
this breaks all other distros not yet using gcc-4.6..
configure:2892: checking whether the C compiler works configure:2914: gcc -Wno-error=unused-but-set-variable
(quoted diff) +0
-4-isystem/OE/shr-core/tmp/sysroots/x86_64-linux/usr/include -L/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath-link,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-O1
conftest.c>&5
cc1: error: -Werror=unused-but-set-variable: No option -Wunused-but-set-variable configure:2918: $? = 1
configure:2956: result: no
configure: failed program was:| /* confdefs.h */ | #define PACKAGE_NAME "Red Hat elfutils" | #define PACKAGE_TARNAME "elfutils" | #define PACKAGE_VERSION "0.148" | #define PACKAGE_STRING "Red Hat elfutils 0.148" | #define PACKAGE_BUGREPORT "http://bugzilla.redhat.com/bugzilla/" | #define PACKAGE_URL "" | #define PACKAGE "elfutils" | #define VERSION "0.148" | #define MODVERSION "Build on jama 2011-04-04T23:34:25+0200" | /* end confdefs.h. */ | | int | main () | {Quoted 8 lines
Quoted 8 lines
| | ; | return 0; | }configure:2961: error: in `/OE/shr-core/tmp/work/x86_64-linux/elfutils-native-0.148-r1/elfutils-0.148':
configure:2965: error: C compiler cannot create executables
See `config.log' for more details.Sorry about this Martin. Thanks for catching and reporting.
Quoted 3 lines
Ouch, I'm going to revert this, we'll need an alternative fix. Thanks for reporting!
Quoted 7 lines
I've worked up an alternative fix and sent a pull request to oe-core. I took the approach of consolidating several patches from the upstream source repository which remove the unused variables.
I consolidated them into a single patch so that they are easier to drop once we update elfutils to 0.152 or higher.
Why not update to 0.152 then
Quoted 12 lines
Regards,
Joshua
--
Joshua Lock
Yocto Build System Monkey
Intel Open Source Technology Centre_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky
Re: [PATCH 1/7] elfutils: fix builds with gcc 4.6
Quoted 78 lines · Khem Raj
Quoted 77 lines · Joshua Lock
Quoted 57 lines · Richard Purdie
Quoted 56 lines · Martin Jansa
Quoted 17 lines · Joshua Lock
From: Joshua Lock <[email protected]>
gcc 4.6 (as used in Fedora 15) adds some extra warnings which are included with Werror. The new unused-but-set variable warning causes an error in libasm of elfutils. Work around this by removing unused-but-set from Werror.
Signed-off-by Joshua Lock <[email protected]>--- meta/recipes-devtools/elfutils/elfutils_0.148.bb | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)meta/recipes-devtools/elfutils/elfutils_0.148.bb +0
-0meta/recipes-devtools/elfutils/elfutils_0.148.bb SRC_URI += "\ · line 47
Quoted 8 lines
meta/recipes-devtools/elfutils/elfutils_0.148.bb +4
-0@@ -40,6 +40,10 @@ SRC_URI += "\ inherit autotools +# GCC 4.6.0 raises an unused-but-set warning in libasm, for now remove +# this warning from Werror +CFLAGS_virtclass-native += "-Wno-error=unused-but-set-variable" + EXTRA_OECONF = "--program-prefix=eu-"this breaks all other distros not yet using gcc-4.6..
configure:2892: checking whether the C compiler works configure:2914: gcc -Wno-error=unused-but-set-variable
(quoted diff) +0
-4-isystem/OE/shr-core/tmp/sysroots/x86_64-linux/usr/include -L/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath-link,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-rpath,/OE/shr-core/tmp/sysroots/x86_64-linux/usr/lib -Wl,-O1
conftest.c>&5
cc1: error: -Werror=unused-but-set-variable: No option -Wunused-but-set-variable configure:2918: $? = 1
configure:2956: result: no
configure: failed program was:| /* confdefs.h */ | #define PACKAGE_NAME "Red Hat elfutils" | #define PACKAGE_TARNAME "elfutils" | #define PACKAGE_VERSION "0.148" | #define PACKAGE_STRING "Red Hat elfutils 0.148" | #define PACKAGE_BUGREPORT "http://bugzilla.redhat.com/bugzilla/" | #define PACKAGE_URL "" | #define PACKAGE "elfutils" | #define VERSION "0.148" | #define MODVERSION "Build on jama 2011-04-04T23:34:25+0200" | /* end confdefs.h. */ | | int | main () | {Quoted 8 lines
Quoted 8 lines
| | ; | return 0; | }configure:2961: error: in `/OE/shr-core/tmp/work/x86_64-linux/elfutils-native-0.148-r1/elfutils-0.148':
configure:2965: error: C compiler cannot create executables
See `config.log' for more details.Sorry about this Martin. Thanks for catching and reporting.
Quoted 3 lines
Ouch, I'm going to revert this, we'll need an alternative fix. Thanks for reporting!
I've worked up an alternative fix and sent a pull request to oe-core. I took the approach of consolidating several patches from the upstream source repository which remove the unused variables.
Quoted 5 lines
Quoted 3 lines
I consolidated them into a single patch so that they are easier to drop once we update elfutils to 0.152 or higher.
Why not update to 0.152 then
The patch series is intended for a Bernard point release, the Bernard release is already out with eflutils 0.148.
Regards,
Joshua
Signature · 3 lines
Joshua Lock
Yocto Build System Monkey
Intel Open Source Technology CentreRe: [PATCH 1/7] elfutils: fix builds with gcc 4.6
Quoted 6 lines · Joshua Lock
Quoted 5 lines · Khem Raj
Quoted 4 lines · Joshua Lock
I've worked up an alternative fix and sent a pull request to oe-core. I took the approach of consolidating several patches from the upstream source repository which remove the unused variables.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
I consolidated them into a single patch so that they are easier to drop once we update elfutils to 0.152 or higher.
Why not update to 0.152 then
The patch series is intended for a Bernard point release, the Bernard release is already out with eflutils 0.148.
I think this is a good approach given the issues we know we're going to have with Bernard. I'll obviously take a version upgrade patch too :)
Cheers,
Richard