RTC: Ensure msecure is mux'd to be able to set RTC for beagleboard

PATCH In review Jingdong Lu 4 participants 7 messages Jun 16, 2011 – Jun 17, 2011

Subsystems (3)

Arm (32-bit) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

Jingdong Lu

author

2011-06-16 06:06 UTC #0 lore raw

cover RTC: Ensure msecure is mux'd to be able to set RTC for beagleboard

From: Jingdong Lu <[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong Lu (1):
RTC: Ensure msecure is mux'd to be able to set RTC

 arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Jingdong Lu

author

2011-06-16 06:06 UTC #1 lore raw

PATCH 1/1 RTC: Ensure msecure is mux'd to be able to set RTC

From: Jingdong Lu <[email protected]>

commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git

arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC. "Msecure" signal provides for protection of the RTC register in TPS65950 be disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC.

Tested with a BeagleBoard C4.
Fixes bug [YOCTO #767]

Signed-off-by Alexander Holler <[email protected]>

Signed-off-by Tony Lindgren <[email protected]>

Integrated-by Jingdong Lu <[email protected]>

---
 arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/board-omap3beagle.c +3 -0

index af1166b..925c0b3 100644
@@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
 	usb_ehci_init(&ehci_pdata);
 	omap3beagle_flash_init();
 
+	/* Ensure msecure is mux'd to be able to set the RTC. */
+	omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
 	/* Ensure SDRC pins are mux'd for self-refresh */
 	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
 	omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);

Signature · 1 line

1.7.0.4

Liming Wang

2011-06-16 06:13 UTC #2 lore raw

Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC

Quoted 3 lines · Jingdong Lu

From: Jingdong Lu<[email protected]>
commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git

It's fine if you break this line into two lines.

Quoted 7 lines

arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC. "Msecure" signal provides for protection of the RTC register in TPS65950 be disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC.
Tested with a BeagleBoard C4.
Fixes bug [YOCTO #767]

I think it's best to put your comment in the top line.

Liming Wang

Quoted 21 lines

Signed-off-by Alexander Holler<[email protected]>

Signed-off-by Tony Lindgren<[email protected]>

Integrated-by Jingdong Lu<[email protected]>

---
  arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/board-omap3beagle.c +3 -0

index af1166b..925c0b3 100644
@@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
  	usb_ehci_init(&ehci_pdata);
  	omap3beagle_flash_init();
 
+	/* Ensure msecure is mux'd to be able to set the RTC. */
+	omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
  	/* Ensure SDRC pins are mux'd for self-refresh */
  	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
  	omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);

Koen Kooi

2011-06-16 07:27 UTC #5 lore raw

Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC

In reply to Jingdong Lu

Op 16 jun 2011, om 08:07 heeft Jingdong Lu het volgende geschreven:

Quoted 3 lines

From: Jingdong Lu <[email protected]>
commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git

When I do 'git show e2a346a2a054f702fd76f328ff747b9ad9264a4' I get:

commit e2a346a2a054f702fd76f328ff747b9ad9264a4c
Author: Alexander Holler <[email protected]>

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Date: Tue Apr 5 15:40:08 2011 +0200

arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC

Without msecure beeing high it isn't possible to set (or start) the RTC.

Tested with a BeagleBoard C4.

Signed-off-by Alexander Holler <[email protected]>

Signed-off-by Tony Lindgren <[email protected]>

arch/arm/mach-omap2/board-omap3beagle.c +3 -0

index be71426..d64ed97 100644
@@ -579,6 +579,9 @@ static void __init omap3_beagle_init(void)
        omap_nand_flash_init(NAND_BUSWIDTH_16, omap3beagle_nand_partitions,
                             ARRAY_SIZE(omap3beagle_nand_partitions));
 
+       /* Ensure msecure is mux'd to be able to set the RTC. */
+       omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
        /* Ensure SDRC pins are mux'd for self-refresh */
        omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
        omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);

So if you're going to change the author, you'd also need to remove the SOBs.

Quoted 37 lines

arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC. "Msecure" signal provides for protection of the RTC register in TPS65950 be disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC.
Tested with a BeagleBoard C4.
Fixes bug [YOCTO #767]
Signed-off-by Alexander Holler <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
Integrated-by Jingdong Lu <[email protected]>
---
arch/arm/mach-omap2/board-omap3beagle.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +3 -0
index af1166b..925c0b3 100644
@@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
 	usb_ehci_init(&ehci_pdata);
 	omap3beagle_flash_init();
 
+	/* Ensure msecure is mux'd to be able to set the RTC. */
+	omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
 	/* Ensure SDRC pins are mux'd for self-refresh */
 	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
 	omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);
Signature · 6 lines
1.7.0.4

_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Bruce Ashfield

2011-06-16 13:20 UTC #3 lore raw

Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC

In reply to Liming Wang

Quoted 12 lines · Liming Wang

Quoted 4 lines · Jingdong Lu
From: Jingdong Lu<[email protected]>
commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
It's fine if you break this line into two lines.
Quoted 6 lines
arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC. "Msecure" signal provides for protection of the RTC register in TPS65950 be
disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC.

Quoted 3 lines

Quoted 2 lines
Tested with a BeagleBoard C4.
Fixes bug [YOCTO #767]
I think it's best to put your comment in the top line.

And we don't want the bug tracking information directly in the kernel commits, it just ends up cluttering things.

It's fine to include this in the 0/N email, but not in the commit message itself.

Cheers,

Bruce

Quoted 29 lines

Liming Wang
Quoted 13 lines
Signed-off-by Alexander Holler<[email protected]>
Signed-off-by Tony Lindgren<[email protected]>
Integrated-by Jingdong Lu<[email protected]>
---
arch/arm/mach-omap2/board-omap3beagle.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +0 -0
index af1166b..925c0b3 100644
arch/arm/mach-omap2/board-omap3beagle.c static void __init omap3_beagle_init(void) · line 588
Quoted 9 lines
arch/arm/mach-omap2/board-omap3beagle.c +3 -0
@@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
 usb_ehci_init(&ehci_pdata);
 omap3beagle_flash_init();
 
+ /* Ensure msecure is mux'd to be able to set the RTC. */
+ omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
 /* Ensure SDRC pins are mux'd for self-refresh */
 omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
 omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Bruce Ashfield

2011-06-16 13:22 UTC #6 lore raw

Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC

In reply to Koen Kooi

Quoted 42 lines · Koen Kooi

Op 16 jun 2011, om 08:07 heeft Jingdong Lu het volgende geschreven:
Quoted 3 lines
From: Jingdong Lu<[email protected]>
commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
When I do 'git show e2a346a2a054f702fd76f328ff747b9ad9264a4' I get:
commit e2a346a2a054f702fd76f328ff747b9ad9264a4c
Author: Alexander Holler<[email protected]>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Date: Tue Apr 5 15:40:08 2011 +0200
arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC
Without msecure beeing high it isn't possible to set (or start) the RTC.
Tested with a BeagleBoard C4.
Signed-off-by Alexander Holler<[email protected]>
Signed-off-by Tony Lindgren<[email protected]>
arch/arm/mach-omap2/board-omap3beagle.c +3 -0
index be71426..d64ed97 100644
@@ -579,6 +579,9 @@ static void __init omap3_beagle_init(void)
         omap_nand_flash_init(NAND_BUSWIDTH_16, omap3beagle_nand_partitions,
                              ARRAY_SIZE(omap3beagle_nand_partitions));
 
+       /* Ensure msecure is mux'd to be able to set the RTC. */
+       omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
         /* Ensure SDRC pins are mux'd for self-refresh */
         omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
         omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);

Quoted 1 line

So if you're going to change the author, you'd also need to remove the SOBs.

It's likely just a glitch in patch generation.

Jindong: did you cherry-pick or git am this for the import into your tree ? Or did you use another technique ? If done properly, the author is always maintained in our imported patches.

Cheers,

Bruce

Quoted 43 lines

Quoted 34 lines
arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC. "Msecure" signal provides for protection of the RTC register in TPS65950 be disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC.
Tested with a BeagleBoard C4.
Fixes bug [YOCTO #767]
Signed-off-by Alexander Holler<[email protected]>
Signed-off-by Tony Lindgren<[email protected]>
Integrated-by Jingdong Lu<[email protected]>
---
arch/arm/mach-omap2/board-omap3beagle.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +3 -1
index af1166b..925c0b3 100644
@@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
 	usb_ehci_init(&ehci_pdata);
 	omap3beagle_flash_init();
 
+	/* Ensure msecure is mux'd to be able to set the RTC. */
+	omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
 	/* Ensure SDRC pins are mux'd for self-refresh */
 	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
 	omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);
--
1.7.0.4
Quoted 4 lines
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Liming Wang

2011-06-17 02:46 UTC #4 lore raw

Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC

In reply to Bruce Ashfield

Quoted 15 lines · Bruce Ashfield

Quoted 14 lines · Liming Wang
Quoted 4 lines · Jingdong Lu
From: Jingdong Lu<[email protected]>
commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
It's fine if you break this line into two lines.
Quoted 8 lines
arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC. "Msecure" signal provides for protection of the RTC register in TPS65950 be
disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC.
Tested with a BeagleBoard C4.
Fixes bug [YOCTO #767]

Quoted 7 lines

Quoted 1 line
I think it's best to put your comment in the top line.
And we don't want the bug tracking information directly in the kernel commits, it just ends up cluttering things.
It's fine to include this in the 0/N email, but not in the commit message itself.

Yes, I agree.
Jingdong should generate a new patch by cherry-pick or format-patch.

Liming Wang

Quoted 36 lines

Cheers,
Bruce
Quoted 29 lines
Liming Wang
Quoted 13 lines
Signed-off-by Alexander Holler<[email protected]>
Signed-off-by Tony Lindgren<[email protected]>
Integrated-by Jingdong Lu<[email protected]>
---
arch/arm/mach-omap2/board-omap3beagle.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +0 -0
index af1166b..925c0b3 100644
arch/arm/mach-omap2/board-omap3beagle.c static void __init omap3_beagle_init(void) · line 588
Quoted 9 lines
arch/arm/mach-omap2/board-omap3beagle.c +3 -0
@@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
 usb_ehci_init(&ehci_pdata);
 omap3beagle_flash_init();
 
+ /* Ensure msecure is mux'd to be able to set the RTC. */
+ omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
 /* Ensure SDRC pins are mux'd for self-refresh */
 omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
 omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto