Skip to contentSkip to conversation

routerstationpro: Enable IPC config

PATCH In review Jingdong Lu 2 participants 5 messages Jun 24, 2011 – Jun 28, 2011

lore
Share & tools
lore

Jingdong Lu

author
#0 lore raw

cover routerstationpro: Enable IPC config

From: Jingdong Lu <[email protected]>

Enable IPC and related configurations for routerstation. Fixes bug [YOCTO #1161]

Jingdong Lu (1):
routerstationpro: IPC config

 .../bsp/routerstationpro/routerstationpro.cfg      |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)
author
#1 lore raw

PATCH 1/1 routerstationpro: IPC config

From: Jingdong Lu <[email protected]>

Add IPC config for routestationpro

Signed-off-by Jingdong Lu <[email protected]>
---
 .../bsp/routerstationpro/routerstationpro.cfg      |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +7 -3
index f58dfe8..88222ca 100644
@@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
 #
 # General setup
 #
-# CONFIG_EXPERIMENTAL is not set
+CONFIG_EXPERIMENTAL=y
 CONFIG_BROKEN_ON_SMP=y
 CONFIG_INIT_ENV_ARG_LIMIT=32
 CONFIG_LOCALVERSION=""
 CONFIG_LOCALVERSION_AUTO=y
 CONFIG_SWAP=y
-# CONFIG_SYSVIPC is not set
-# CONFIG_BSD_PROCESS_ACCT is not set
+CONFIG_SYSVIPC=y
+CONFIG_SYSVIPC_SYSCTL=y
+CONFIG_POSIX_MQUEUE=y
+CONFIG_POSIX_MQUEUE_SYSCTL=y
+CONFIG_BSD_PROCESS_ACCT=y
+CONFIG_BSD_PROCESS_ACCT_V3=y
 # CONFIG_TASKSTATS is not set
 # CONFIG_AUDIT is not set
Signature · 1 line
1.7.0.4
#2 lore raw

Re: [PATCH 1/1] routerstationpro: IPC config

Quoted 14 lines · Jingdong Lu

From: Jingdong Lu<[email protected]>

Add IPC config for routestationpro

Signed-off-by Jingdong Lu<[email protected]>
---
  .../bsp/routerstationpro/routerstationpro.cfg      |   10 +++++++---
  1 files changed, 7 insertions(+), 3 deletions(-)
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +0 -0
index f58dfe8..88222ca 100644

meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg CONFIG_CONSTRUCTORS=y · line 212

Quoted 5 lines
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +1 -1
@@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
  #
  # General setup
  #
-# CONFIG_EXPERIMENTAL is not set
+CONFIG_EXPERIMENTAL=y

We typically do not want to enable this. What options is this triggering that are essential to the IPC config ?

meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg CONFIG_CONSTRUCTORS=y · line 220

Quoted 10 lines
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +3 -2
  CONFIG_BROKEN_ON_SMP=y
  CONFIG_INIT_ENV_ARG_LIMIT=32
  CONFIG_LOCALVERSION=""
  CONFIG_LOCALVERSION_AUTO=y
  CONFIG_SWAP=y
-# CONFIG_SYSVIPC is not set
-# CONFIG_BSD_PROCESS_ACCT is not set
+CONFIG_SYSVIPC=y
+CONFIG_SYSVIPC_SYSCTL=y
+CONFIG_POSIX_MQUEUE=y

These options are already provided by the base configuration and are supposed to be baseline options for any BSP. Can you elaborate on why you needed these here ?

Bruce

Quoted 6 lines
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +3 -0
+CONFIG_POSIX_MQUEUE_SYSCTL=y
+CONFIG_BSD_PROCESS_ACCT=y
+CONFIG_BSD_PROCESS_ACCT_V3=y
  # CONFIG_TASKSTATS is not set
  # CONFIG_AUDIT is not set
author
#3 lore raw

Re: [PATCH 1/1] routerstationpro: IPC config

Quoted 10 lines · Bruce Ashfield
Quoted 9 lines · Jingdong Lu

From: Jingdong Lu<[email protected]>

Add IPC config for routestationpro

Signed-off-by Jingdong Lu<[email protected]>
---
  .../bsp/routerstationpro/routerstationpro.cfg      |   10 +++++++---
  1 files changed, 7 insertions(+), 3 deletions(-)
Quoted 13 lines

meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg CONFIG_CONSTRUCTORS=y · line 212

Quoted 10 lines
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +1 -1
index f58dfe8..88222ca 100644
@@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
  #
  # General setup
  #
-# CONFIG_EXPERIMENTAL is not set
+CONFIG_EXPERIMENTAL=y

We typically do not want to enable this. What options is this triggering that are essential to the IPC config ?

Configuration "POSIX_MQUEUE" depends on "CONFIG_EXPERIMENTAL=y", so it should be enabled. This configuration has been enabled in meta/cfg/kernel-cache/ktypes/base/base.cfg #
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y

But it was redefined in meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg #
# General setup
#
# CONFIG_EXPERIMENTAL is not set

So CONFIG_EXPERIMENTAL is not set in the final kernel config.

I also can find the redefinition in .../meta/cfg/yocto/standard/routerstationpro/redefinition.txt

Value of CONFIG_EXPERIMENTAL is redefined by fragment /home/eric/poky/poky/build-routerstation/tmp/work/routerstationpro-poky-linux/linux-yocto-2.6.37+git1+06d3793d459048ee1b4db7170f24670c479e8b29_1+d6aadb767fdcbb9886c430e90b92f49cd3a9ddcc-r18/linux/meta/cfg//kernel-cache/bsp/routerstationpro/routerstationpro.cfg:
Old value: CONFIG_EXPERIMENTAL=y
New value: # CONFIG_EXPERIMENTAL is not set

Quoted 16 lines

meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg CONFIG_CONSTRUCTORS=y · line 220

Quoted 11 lines
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +3 -2
  CONFIG_BROKEN_ON_SMP=y
  CONFIG_INIT_ENV_ARG_LIMIT=32
  CONFIG_LOCALVERSION=""
  CONFIG_LOCALVERSION_AUTO=y
  CONFIG_SWAP=y
-# CONFIG_SYSVIPC is not set
-# CONFIG_BSD_PROCESS_ACCT is not set
+CONFIG_SYSVIPC=y
+CONFIG_SYSVIPC_SYSCTL=y
+CONFIG_POSIX_MQUEUE=y

These options are already provided by the base configuration and are supposed to be baseline options for any BSP. Can you elaborate on why you needed these here ?

These options also were redefined in meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg # CONFIG_SYSVIPC is not set
# CONFIG_BSD_PROCESS_ACCT is not set

So these options were disabled in kernel configure file. But they are needed by LTP test.

I took a look at the routerstationpro.cfg and found that it is a complete configure file. It is different from other BSPs. So I think we should modify routerstationpro.cfg and only leave some special platform, hardware configure options in it. Or at least we should omit the above options which conflict with the base configurations.

Quoted 10 lines

Bruce

Quoted 6 lines
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +3 -0
+CONFIG_POSIX_MQUEUE_SYSCTL=y
+CONFIG_BSD_PROCESS_ACCT=y
+CONFIG_BSD_PROCESS_ACCT_V3=y
  # CONFIG_TASKSTATS is not set
  # CONFIG_AUDIT is not set
Signature · 3 lines
Lu Jingdong
[email protected]
China, Wind River
#4 lore raw

Re: [PATCH 1/1] routerstationpro: IPC config

Quoted 46 lines · Lu Jingdong
Quoted 10 lines · Bruce Ashfield
Quoted 9 lines · Jingdong Lu

From: Jingdong Lu<[email protected]>

Add IPC config for routestationpro

Signed-off-by Jingdong Lu<[email protected]>

---
.../bsp/routerstationpro/routerstationpro.cfg | 10 +++++++---

1 files changed, 7 insertions(+), 3 deletions(-)
Quoted 15 lines

meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg CONFIG_CONSTRUCTORS=y · line 212

Quoted 12 lines

diff --git a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg index f58dfe8..88222ca 100644

meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +1 -1
@@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
 #
 # General setup
 #
-# CONFIG_EXPERIMENTAL is not set
+CONFIG_EXPERIMENTAL=y

We typically do not want to enable this. What options is this triggering that are essential to the IPC config ?

Configuration "POSIX_MQUEUE" depends on "CONFIG_EXPERIMENTAL=y", so it should be enabled.
This configuration has been enabled in meta/cfg/kernel-cache/ktypes/base/base.cfg
#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y

But it was redefined in meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg #
# General setup
#
# CONFIG_EXPERIMENTAL is not set

So CONFIG_EXPERIMENTAL is not set in the final kernel config.

Quoted 8 lines

I also can find the redefinition in .../meta/cfg/yocto/standard/routerstationpro/redefinition.txt

Value of CONFIG_EXPERIMENTAL is redefined by fragment /home/eric/poky/poky/build-routerstation/tmp/work/routerstationpro-poky-linux/linux-yocto-2.6.37+git1+06d3793d459048ee1b4db7170f24670c479e8b29_1+d6aadb767fdcbb9886c430e90b92f49cd3a9ddcc-r18/linux/meta/cfg//kernel-cache/bsp/routerstationpro/routerstationpro.cfg:

Old value: CONFIG_EXPERIMENTAL=y
New value: # CONFIG_EXPERIMENTAL is not set

Indeed. So in this case, we should just be dropping the # CONFIG_EXPERIMENTAL is not set from this fragment.

Quoted 21 lines
Quoted 16 lines

meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg CONFIG_CONSTRUCTORS=y · line 220

Quoted 11 lines

CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_SWAP=y

meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +3 -2
-# CONFIG_SYSVIPC is not set
-# CONFIG_BSD_PROCESS_ACCT is not set
+CONFIG_SYSVIPC=y
+CONFIG_SYSVIPC_SYSCTL=y
+CONFIG_POSIX_MQUEUE=y

These options are already provided by the base configuration and are supposed to be baseline options for any BSP. Can you elaborate on why you needed these here ?

These options also were redefined in meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg # CONFIG_SYSVIPC is not set
# CONFIG_BSD_PROCESS_ACCT is not set

Quoted 7 lines

So these options were disabled in kernel configure file. But they are needed by LTP test.

I took a look at the routerstationpro.cfg and found that it is a complete configure file. It is different
from other BSPs. So I think we should modify routerstationpro.cfg and only leave some special platform,

This definitely needs to be done, it was on our list to revisit, so perhaps this is a good time.

Quoted 3 lines

hardware configure options in it. Or at least we should omit the above options which conflict with
the base configurations.

At the minimum we should do this, BSPs should not be overriding base settings without good reasons .. and we definitely do not have good reasons here!

Bruce

Quoted 11 lines
Quoted 10 lines

Bruce

Quoted 6 lines
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg +3 -0
+CONFIG_POSIX_MQUEUE_SYSCTL=y
+CONFIG_BSD_PROCESS_ACCT=y
+CONFIG_BSD_PROCESS_ACCT_V3=y

# CONFIG_TASKSTATS is not set
# CONFIG_AUDIT is not set