Yet more gcc warnings fixes
cover Yet more gcc warnings fixes
More places that have write only variables.
Once here, why we have clovvered arg7 is a good question (TM)
abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6, abi_long arg7, abi_long arg8)
{
.....
abi_ulong arg_sigset, *arg7;
....Using a different name could be a good idea.
Please, apply.
Later, Juan.
Juan Quintela (2):
xen_mapcache: remove unused variable
syscall: pselect arg_sigsize variable was write only
linux-user/syscall.c | 3 +-- xen-mapcache.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.6
PATCH 1/2 xen_mapcache: remove unused variable
--- xen-mapcache.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
xen-mapcache.c +1 -2
@@ -232,7 +232,7 @@ uint8_t *qemu_map_cache(target_phys_addr_t phys_addr, target_phys_addr_t size, uram_addr_t qemu_ram_addr_from_mapcache (void *ptr) { -MapCacheEntry *entry =NULL , *pentry =NULL ; +MapCacheEntry *entry =NULL ;MapCacheRev *reventry;target_phys_addr_t paddr_index;target_phys_addr_t size;
@@ -258,7 +258,6 @@ ram_addr_t qemu_ram_addr_from_mapcache(void *ptr) entry = &mapcache->entry[paddr_index % mapcache->nr_buckets];while (entry && (entry->paddr_index != paddr_index || entry->size != size)) { - pentry = entry; entry = entry->next; }if (!entry) {
Signature · 1 line
1.7.6
PATCH 2/2 syscall: pselect arg_sigsize variable was write only
In reply to Juan QuintelaRemove it.
--- linux-user/syscall.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
linux-user/syscall.c +1 -2
@@ -5634,7 +5634,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,size_t size; } sig, *sig_ptr; -abi_ulong arg_sigset, arg_sigsize, *arg7; +abi_ulong arg_sigset, *arg7;target_sigset_t *target_sigset; n = arg1;
@@ -5679,7 +5679,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, goto efault; } arg_sigset =tswapl (arg7[0 ]); - arg_sigsize =tswapl (arg7[1 ]);unlock_user (arg7, arg6,0 );if (arg_sigset) {
Signature · 1 line
1.7.6
Re: [Qemu-devel] [PATCH 2/2] syscall: pselect arg_sigsize variable was write only
Quoted 3 lines · Juan Quintela
Remove it.
Signed-off-by Juan Quintela <[email protected]>
http://patchwork.ozlabs.org/patch/104232/ in the current linux-user pullreq is a fix for this.
-- PMM
Re: [Qemu-devel] [PATCH 2/2] syscall: pselect arg_sigsize variable was write only
In reply to Juan QuintelaQuoted 3 lines · Juan Quintela
Remove it.
Signed-off-by Juan Quintela <[email protected]>
/me nacks himself
Peter one is better, it even makes sense, go figure O:-)
Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable
In reply to Juan QuintelaQuoted 2 lines · Juan Quintela
Signed-off-by Juan Quintela <[email protected]>
Quoted 29 lines
--- xen-mapcache.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)xen-mapcache.c +1
-2@@ -232,7 +232,7 @@ uint8_t *qemu_map_cache(target_phys_addr_t phys_addr, target_phys_addr_t size, uram_addr_t qemu_ram_addr_from_mapcache (void *ptr) { -MapCacheEntry *entry =NULL , *pentry =NULL ; +MapCacheEntry *entry =NULL ;MapCacheRev *reventry;target_phys_addr_t paddr_index;target_phys_addr_t size;@@ -258,7 +258,6 @@ ram_addr_t qemu_ram_addr_from_mapcache(void *ptr) entry = &mapcache->entry[paddr_index % mapcache->nr_buckets];while (entry && (entry->paddr_index != paddr_index || entry->size != size)) { - pentry = entry; entry = entry->next; }if (!entry) {Signature · 1 line
1.7.6
Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable
In reply to Juan QuintelaQuoted 1 line · Juan Quintela
Signed-off-by Juan Quintela<[email protected]>
Been pointed to this patch after having posted the same.
Stefan
Quoted 25 lines
--- xen-mapcache.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)xen-mapcache.c +1
-2@@ -232,7 +232,7 @@ uint8_t *qemu_map_cache(target_phys_addr_t phys_addr, target_phys_addr_t size, uram_addr_t qemu_ram_addr_from_mapcache (void *ptr) { -MapCacheEntry *entry =NULL , *pentry =NULL ; +MapCacheEntry *entry =NULL ;MapCacheRev *reventry;target_phys_addr_t paddr_index;target_phys_addr_t size;@@ -258,7 +258,6 @@ ram_addr_t qemu_ram_addr_from_mapcache(void *ptr) entry =&mapcache->entry[paddr_index % mapcache->nr_buckets];while (entry&& (entry->paddr_index != paddr_index || entry->size != size)) { - pentry = entry; entry = entry->next; }if (!entry) {
Stefan Hajnoczi
AppliedRe: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable
In reply to Juan QuintelaQuoted 5 lines · Juan Quintela
Signed-off-by Juan Quintela <[email protected]>--- xen-mapcache.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
Since Stefano has acked it but it was not merged into qemu.git yet...
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan