Skip to contentSkip to conversation

bb-matrix: correct BB and PM number canonicalization

PATCH New Darren Hart 1 participant 2 messages Jul 14, 2011

lore
Share & tools
lore
#0 lore raw

cover bb-matrix: correct BB and PM number canonicalization

The following changes since commit f7fd215749e12852378a3a1cce7d316078ead54d:

perl: Use SITEINFO variables not functions (2011-07-14 15:40:48 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib dvhart/bb-perf
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/bb-perf

Darren Hart (1):
bb-matrix: correct BB and PM number canonicalization

 scripts/contrib/bb-perf/bb-matrix.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
#1 lore raw

PATCH 1/1 bb-matrix: correct BB and PM number canonicalization

The bash string operation ${BB##*0} was greedy and in addition to converting "02" to "2", also converted "20" to "", causing all builds for a BB value ending in 0 to run with BB_NUMBER_THREADS=1.

---
 scripts/contrib/bb-perf/bb-matrix.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
scripts/contrib/bb-perf/bb-matrix.sh +2 -2
index 64d5513..b9edd5f 100755
@@ -62,8 +62,8 @@ for BB in $BB_RANGE; do
 		echo "BB=$BB PM=$PM Logging to $BB_LOG"
 
 		# Export the variables under test and run the bitbake command
-		export BB_NUMBER_THREADS="${BB##*0}"
-		export PARALLEL_MAKE="-j ${PM##*0}"
+		export BB_NUMBER_THREADS=$(echo $BB | sed 's/^0*//')
+		export PARALLEL_MAKE="-j $(echo $PM | sed 's/^0*//')"
 		/usr/bin/time -f "$BB $PM $TIME_STR" -a -o $RUNTIME_LOG $BB_CMD &> $BB_LOG
 		
 		echo "  $(tail -n1 $RUNTIME_LOG)"
Signature · 1 line
1.7.1