runqemu bugfix
cover runqemu bugfix
This fixes an issue Jessica Zhang reported to me today:
Invoking runqemu outside of the build directory for an in-tree setup results in an empty TMPDIR because bitbake -e cannot be run to find it.
A symptom of this problem is running runqemu and getting the following error:
Error: Unable to find tunctl binary in <directory>
Catch this case and report the error to the user.
This fixes [YOCTO #1278]
The following changes since commit eea4bd731ef286516ee1fb934fe2222a09c06e70:
mpc8315e-rdb: Set TARGET_FPU correct (2011-07-22 09:02:58 -0700)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib sgarman/runqemu-fix
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/runqemu-fix
Scott Garman (1):
runqemu: report error if TMPDIR cannot be determined
scripts/runqemu | 27 ++++++++++++++++----------- 1 files changed, 16 insertions(+), 11 deletions(-)
PATCH 1/1 runqemu: report error if TMPDIR cannot be determined
Invoking runqemu outside of the build directory for an in-tree setup results in an empty TMPDIR because bitbake -e cannot be run to find it.
A symptom of this problem is running runqemu and getting the following error:
Error: Unable to find tunctl binary in <directory>
Catch this case and report the error to the user.
This fixes [YOCTO #1278]
--- scripts/runqemu | 27 ++++++++++++++++----------- 1 files changed, 16 insertions(+), 11 deletions(-)
scripts/runqemu +17 -12
@@ -272,22 +272,27 @@ setup_tmpdir() { # We have bitbake in PATH, get TMPDIR from bitbake TMPDIR=`bitbake -e | grep TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2` + if [ -z "$TMPDIR" ]; then + echo "Error: this script needs to be run from your build directory," + echo "or you need to explicitly set TMPDIR in your environment" + exit 1 + fi fi } setup_sysroot() { - # Toolchain installs set up $OECORE_NATIVE_SYSROOT in their - # environment script. If that variable isn't set, we're - # either in an in-tree build scenario or the environment - # script wasn't source'd. - if [ -z "$OECORE_NATIVE_SYSROOT" ]; then - setup_tmpdir - BUILD_ARCH=`uname -m` - BUILD_OS=`uname | tr '[A-Z]' '[a-z]'` - BUILD_SYS="$BUILD_ARCH-$BUILD_OS" - - OECORE_NATIVE_SYSROOT=$TMPDIR/sysroots/$BUILD_SYS - fi + # Toolchain installs set up $OECORE_NATIVE_SYSROOT in their + # environment script. If that variable isn't set, we're + # either in an in-tree build scenario or the environment + # script wasn't source'd. + if [ -z "$OECORE_NATIVE_SYSROOT" ]; then + setup_tmpdir + BUILD_ARCH=`uname -m` + BUILD_OS=`uname | tr '[A-Z]' '[a-z]'` + BUILD_SYS="$BUILD_ARCH-$BUILD_OS" + + OECORE_NATIVE_SYSROOT=$TMPDIR/sysroots/$BUILD_SYS + fi } # Locate a rootfs image based on defaults defined above
Signature · 1 line
1.7.1
Saul Wold
AppliedQuoted 26 lines · Scott Garman
This fixes an issue Jessica Zhang reported to me today:
Invoking runqemu outside of the build directory for an in-tree setup results in an empty TMPDIR because bitbake -e cannot be run to find it.
A symptom of this problem is running runqemu and getting the following error:
Error: Unable to find tunctl binary in<directory>
Catch this case and report the error to the user.
This fixes [YOCTO #1278]
The following changes since commit
eea4bd731ef286516ee1fb934fe2222a09c06e70:mpc8315e-rdb: Set TARGET_FPU correct (2011-07-22 09:02:58 -0700)are available in the git repository at:
git://git.pokylinux.org/poky-contribsgarman/runqemu-fix
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/runqemu-fixScott Garman (1):
runqemu: report error if TMPDIR cannot be determined
Quoted 9 lines
scripts/runqemu | 27 ++++++++++++++++----------- 1 files changed, 16 insertions(+), 11 deletions(-)_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Merged into OE-Core
Thanks
Sau!