Skip to contentSkip to conversation

Fix PACKAGE_EXTRA_ARCHS

PATCH In review Paul Eggleton 3 participants 4 messages Jul 28, 2011 – Aug 1, 2011

lore
Share & tools
lore
#0 lore raw

cover Fix PACKAGE_EXTRA_ARCHS

Here's a fix as discussed for the PACKAGE_EXTRA_ARCHS issue since the tune file changes. It may not be the proper fix but it does at least it makes the value of this variable correct again.

The following changes since commit 1fe892ab6876c405599c79657221a8b4675b6ecf:

Update TERMCMD message to align with previous change (2011-07-27 17:43:27 +0100)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/core-pkgarch-fix
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/core-pkgarch-fix

Paul Eggleton (1):
bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default

 meta/conf/bitbake.conf |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default

Because of the way BitBake handles ??= under certain circumstances, this default setting ends up stepping all over the real setting from the arch include file. Since virtually all arch include files or tune files define a real value for this we shouldn't need to have a default (or it needs to be done in a different way).

---
 meta/conf/bitbake.conf |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
meta/conf/bitbake.conf +0 -1
index 6e109ec..9c80f11 100644
@@ -84,7 +84,6 @@ HOST_EXEEXT = ""
 TUNE_ARCH ??= "INVALID"
 TUNE_CCARGS ??= ""
 TUNE_FEATURES ??= "${TUNE_FEATURES_tune-${DEFAULTTUNE}}"
-PACKAGE_EXTRA_ARCHS_tune-${DEFAULTTUNE} ??= "${TARGET_ARCH}"
 LIBCEXTENSION ??= ""
 ABIEXTENSION ??= ""
 
Signature · 1 line
1.7.4.1
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default

Quoted 10 lines · Paul Eggleton

Because of the way BitBake handles ??= under certain circumstances, this default setting ends up stepping all over the real setting from the arch include file. Since virtually all arch include files or tune files define a real value for this we shouldn't need to have a default (or it needs to be done in a different way).

---
meta/conf/bitbake.conf | 1 -

1 files changed, 0 insertions(+), 1 deletions(-)

- k

#3 lore raw
In reply to Paul Eggleton
Quoted 12 lines · Paul Eggleton

Here's a fix as discussed for the PACKAGE_EXTRA_ARCHS issue since the tune file changes. It may not be the proper fix but it does at least it makes the value of this variable correct again.

The following changes since commit 1fe892ab6876c405599c79657221a8b4675b6ecf:

Update TERMCMD message to align with previous change (2011-07-27 17:43:27 +0100)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/core-pkgarch-fix
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/core-pkgarch-fix

Quoted 6 lines

Paul Eggleton (1):
bitbake.conf: remove PACKAGE_EXTRA_ARCHS_tune-XXX default

  meta/conf/bitbake.conf |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

Pulled into OE-Core
Thanks
Sau!