Skip to contentSkip to conversation

Remove cp -n option as discussed

PATCH In review Paul Eggleton 3 participants 5 messages Aug 23, 2011

lore
Share & tools
lore
#0 lore raw

cover Remove cp -n option as discussed

The following changes since commit 9134800548a03bfe3a7e351a15f2129bcb3cc680:

xcb/libpthreads: Add BBCLASSEXTEND to resolve missing providers in world builds (2011-08-19 16:27:29 -0700)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/sanity3a
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/sanity3a

Paul Eggleton (1):
image.bbclass: remove non-standard -n option from cp command

 meta/classes/image.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 image.bbclass: remove non-standard -n option from cp command

-n is not a POSIX option and does not work on some systems (e.g. Debian Lenny); in any case it is not strictly necessary here, so remove it.

---
 meta/classes/image.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image.bbclass +1 -1
index 286ae01..bf8b73a 100644
@@ -138,7 +138,7 @@ fakeroot do_rootfs () {
 	mkdir -p ${IMAGE_ROOTFS}
 	mkdir -p ${DEPLOY_DIR_IMAGE}
 
-	cp -n ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOY_DIR_IMAGE}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
+	cp ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOY_DIR_IMAGE}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
 
 	if [ "${USE_DEVFS}" != "1" ]; then
 		for devtable in ${@get_devtable_list(d)}; do
Signature · 1 line
1.7.4.1
Tested-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] image.bbclass: remove non-standard -n option from cp command

Op 23 aug. 2011, om 12:11 heeft Paul Eggleton het volgende geschreven:

Quoted 4 lines

-n is not a POSIX option and does not work on some systems (e.g. Debian Lenny); in any case it is not strictly necessary here, so remove it.

Quoted 25 lines

---
meta/classes/image.bbclass | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image.bbclass +1 -1
index 286ae01..bf8b73a 100644
@@ -138,7 +138,7 @@ fakeroot do_rootfs () {
 	mkdir -p ${IMAGE_ROOTFS}
 	mkdir -p ${DEPLOY_DIR_IMAGE}
 
-	cp -n ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOY_DIR_IMAGE}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
+	cp ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOY_DIR_IMAGE}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
 
 	if [ "${USE_DEVFS}" != "1" ]; then
 		for devtable in ${@get_devtable_list(d)}; do
Signature · 7 lines
1.7.4.1


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
#3 lore raw

Re: [PATCH 1/1] image.bbclass: remove non-standard -n option from cp command

In reply to Paul Eggleton
Quoted 13 lines · Paul Eggleton

-n is not a POSIX option and does not work on some systems (e.g. Debian Lenny); in any case it is not strictly necessary here, so remove it.

---
  meta/classes/image.bbclass |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image.bbclass +0 -0
index 286ae01..bf8b73a 100644

meta/classes/image.bbclass fakeroot do_rootfs () { · line 144

Quoted 8 lines
meta/classes/image.bbclass +1 -1
@@ -138,7 +138,7 @@ fakeroot do_rootfs () {
  	mkdir -p ${IMAGE_ROOTFS}
  	mkdir -p ${DEPLOY_DIR_IMAGE}
 
-	cp -n ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOY_DIR_IMAGE}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
+	cp ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOY_DIR_IMAGE}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
 
  	if [ "${USE_DEVFS}" != "1" ]; then
  		for devtable in ${@get_devtable_list(d)}; do

Paul,

Is this in addition to the previous image.bbclass patch you provided? If so, there are 2 usages of -n in original patch that is merged.

Sau!

#4 lore raw

Re: [PATCH 1/1] image.bbclass: remove non-standard -n option from cp command

Quoted 2 lines · On Tuesday 23 August 2011 16:12:24 Saul Wold wrote:

Is this in addition to the previous image.bbclass patch you provided? If so, there are 2 usages of -n in original patch that is merged.

Oops, sorry about that. V2 is coming in a few minutes.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre