Fix MakeMaker's finding of perl.real

PATCH In review Saul Wold 4 participants 5 messages Sep 7, 2011

Share & tools

Saul Wold

author

2011-09-07 05:14 UTC #0 lore raw

cover Fix MakeMaker's finding of perl.real

When configuring cpan packages, the directories passed to MakeMaker are the target directories. There was a patch that was applied to the native perl to find perl.real and convert that to perl. This does not apply for the target perl modules and therefore MakeMaker find perl.real.

This patch to cpan configure modifies the Makefile after configure and changes the perl.real to just straight perl so we have the correct paths and shared state info in usable.

Sau!

The following changes since commit 41b7c955cfdc7b4d5c667c8a8742237d5edaca4f:

icu-3.6: fix building with big make -j (2011-09-05 20:38:50 +0100)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib sgw/fix2
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/fix2

Saul Wold (1):
cpan.bbclass: fix native perl issue

 meta/classes/cpan.bbclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Signature · 1 line

1.7.6

Saul Wold

author

2011-09-07 05:14 UTC #1 lore raw

PATCH 1/1 cpan.bbclass: fix native perl issue

Signed-off-by Saul Wold <[email protected]>

---
 meta/classes/cpan.bbclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

meta/classes/cpan.bbclass +2 -1

index cb1c2f4..587e688 100644
@@ -24,7 +24,8 @@ cpan_do_configure () {
 		for f in `find -name Makefile.PL`; do
 			f2=`echo $f | sed -e 's/.PL//'`
 			sed -i -e "s:\(PERL_ARCHLIB = \).*:\1${PERL_ARCHLIB}:" \
-			$f2
+				-e 's/perl.real/perl/' \
+				$f2
 		done
 	fi
 }

Signature · 1 line

1.7.6

Eric Bénard

2011-09-07 06:43 UTC #2 lore raw

In reply to Saul Wold

Hi,

Quoted 9 lines · Saul Wold

When configuring cpan packages, the directories passed to MakeMaker are the target directories. There was a patch that was applied to the native perl to find perl.real and convert that to perl. This does not apply for the target perl modules and therefore MakeMaker find perl.real.
This patch to cpan configure modifies the Makefile after configure and changes the perl.real to just straight perl so we have the correct paths and shared state info in usable.

when sending 1 patch, is it possible to not use cover letter in order to have the explanation in the patch commit ?
That's easier to understand what the patch is doing when browsing log.

Eric

Anders Darander

2011-09-07 09:12 UTC #3 lore raw

Quoted 6 lines · Eric Bénard

Quoted 5 lines · Saul Wold
When configuring cpan packages, the directories passed to MakeMaker are the target directories. There was a patch that was applied to the native perl to find perl.real and convert that to perl. This does not apply for the target perl modules and therefore MakeMaker find perl.real.

Quoted 7 lines

Quoted 4 lines
This patch to cpan configure modifies the Makefile after configure and changes the perl.real to just straight perl so we have the correct paths and shared state info in usable.
when sending 1 patch, is it possible to not use cover letter in order to have the explanation in the patch commit ?
That's easier to understand what the patch is doing when browsing log.

Cover letter or not, the patch should include a commit message that explains the patch. It doesn't really matter if there is only one patch or a large patch series.

For a single patch, the cover letter can be usefull to provide some extra information and discussion. In other cases, it can be pretty useless IMHO.

Regards,
Anders

Signature · 2 lines

Anders Darander
ChargeStorm AB

Richard Purdie

2011-09-07 22:47 UTC #4 lore raw

Quoted 15 lines · Anders Darander

Quoted 6 lines · Eric Bénard
Quoted 5 lines · Saul Wold
When configuring cpan packages, the directories passed to MakeMaker are the target directories. There was a patch that was applied to the native perl to find perl.real and convert that to perl. This does not apply for the target perl modules and therefore MakeMaker find perl.real.
Quoted 7 lines
Quoted 4 lines
This patch to cpan configure modifies the Makefile after configure and changes the perl.real to just straight perl so we have the correct paths and shared state info in usable.
when sending 1 patch, is it possible to not use cover letter in order to have the explanation in the patch commit ?
That's easier to understand what the patch is doing when browsing log.

Quoted 7 lines

Cover letter or not, the patch should include a commit message that explains the patch. It doesn't really matter if there is only one patch or a large patch series.
For a single patch, the cover letter can be usefull to provide some extra information and discussion. In other cases, it can be pretty useless IMHO.

This commit has slipped into the tree this time but I agree in future more explanation of a commit is needed...

Cheers,

Richard