Fix hard path of opensp, Edwin, Sep9, 2011

RFC PATCH In review [email protected] 2 participants 6 messages Sep 9, 2011 – Sep 10, 2011

lore

Share & tools

lore

[email protected]

author

2011-09-09 03:01 UTC #0 lore raw

cover Fix hard path of opensp, Edwin, Sep9, 2011

From: Zhai Edwin <[email protected]>

Saul,
This is one fix to use "-D" as wrapper rather than environment val according to your suggestion. Could you pls. have a look?

Thanks,
Edwin

The following changes since commit 52835dd30110d51a839872f198eef3b12e369850:

avahi: only use gtk if DISTRO_FEATURES includes x11 (2011-09-07 23:44:29 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib gzhai/master2
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/master2

Zhai Edwin (1):
opensp: Fix hard path in native nsgmls.

 meta/recipes-devtools/opensp/opensp_1.5.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

[email protected]

author

2011-09-09 03:01 UTC #1 lore raw

PATCH 1/1 opensp: Fix hard path in native nsgmls.

From: Zhai Edwin <[email protected]>

This relocation issues caused following bug and introduce one partial fix bb024d:
[YOCTO #1440]

But the environment val hacking is not working all the time, as nsgmsl may append wrong path in some case. This fix use search directory "-D" as solution. It's better if got fixed from opensp side when next upgrade.

Signed-off-by Zhai Edwin <[email protected]>

CC Saul Would <[email protected]>

---
 meta/recipes-devtools/opensp/opensp_1.5.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

meta/recipes-devtools/opensp/opensp_1.5.bb +2 -2

index 0269c87..d692137 100644
@@ -44,8 +44,8 @@ do_install_append() {
 
 do_install_append_virtclass-native() {
 	for util in nsgmls sgmlnorm spam spcat spent sx; do
-		create_wrapper ${D}/${bindir}/$util \
-		    SGML_CATALOG_FILES=${sysconfdir}/sgml/catalog 
+		create_cmdline_wrapper ${D}/${bindir}/$util \
+		    -D ${sysconfdir}/sgml
 	done
 }

Signature · 1 line

1.7.1

Saul Wold

2011-09-09 04:54 UTC #2 lore raw

Re: [PATCH 1/1] opensp: Fix hard path in native nsgmls.

Quoted 20 lines · On 09/08/2011 07:53 PM, [email protected] wrote:

From: Zhai Edwin<[email protected]>
This relocation issues caused following bug and introduce one partial fix bb024d:
[YOCTO #1440]
But the environment val hacking is not working all the time, as nsgmsl may append wrong path in some case. This fix use search directory "-D" as solution. It's better if got fixed from opensp side when next upgrade.
Signed-off-by Zhai Edwin<[email protected]>
CC Saul Would<[email protected]>
---
  meta/recipes-devtools/opensp/opensp_1.5.bb |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/opensp/opensp_1.5.bb +0 -0
index 0269c87..d692137 100644

meta/recipes-devtools/opensp/opensp_1.5.bb do_install_append() { · line 51

Quoted 10 lines

meta/recipes-devtools/opensp/opensp_1.5.bb +2 -2

@@ -44,8 +44,8 @@ do_install_append() {
 
  do_install_append_virtclass-native() {
  	for util in nsgmls sgmlnorm spam spcat spent sx; do
-		create_wrapper ${D}/${bindir}/$util \
-		    SGML_CATALOG_FILES=${sysconfdir}/sgml/catalog
+		create_cmdline_wrapper ${D}/${bindir}/$util \
+		    -D ${sysconfdir}/sgml
  	done
  }

Have you tested this with iputils? When I tried this, it did not work correctly for me, can you give me more of idea of how you tested this.

Sau!

Zhai, Edwin

author

2011-09-09 14:22 UTC #3 lore raw

Re: [PATCH 1/1] opensp: Fix hard path in native nsgmls.

Quoted 22 lines · Saul Wold

Quoted 21 lines · On 09/08/2011 07:53 PM, [email protected] wrote:
From: Zhai Edwin<[email protected]>
This relocation issues caused following bug and introduce one partial fix bb024d:
[YOCTO #1440]
But the environment val hacking is not working all the time, as nsgmsl may append wrong path in some case. This fix use search directory "-D" as solution. It's better if got fixed from opensp side when next upgrade.
Signed-off-by Zhai Edwin<[email protected]>
CC Saul Would<[email protected]>
---
   meta/recipes-devtools/opensp/opensp_1.5.bb |    4 ++--
   1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/opensp/opensp_1.5.bb +0 -0
index 0269c87..d692137 100644
@@ -44,8 +44,8 @@ do_install_append() {
 

Quoted 11 lines

meta/recipes-devtools/opensp/opensp_1.5.bb do_install_append() { · line 51
Quoted 9 lines
meta/recipes-devtools/opensp/opensp_1.5.bb +2 -2
   do_install_append_virtclass-native() {
   	for util in nsgmls sgmlnorm spam spcat spent sx; do
-		create_wrapper ${D}/${bindir}/$util \
-		    SGML_CATALOG_FILES=${sysconfdir}/sgml/catalog
+		create_cmdline_wrapper ${D}/${bindir}/$util \
+		    -D ${sysconfdir}/sgml
   	done
   }
 
Have you tested this with iputils? When I tried this, it did not work correctly for me, can you give me more of idea of how you tested this.

Sorry, I forgot to rename the tmp to make sysroot unavailable:( After renaming, the bug still exist.
Upgrading to 1.5.2 doesn't help. After debug with strace, I found nsgmls append ".." to other paths when inputting "../index.db" as you said. It's reasonable for entity such as ping.sgml, as they usually sit in same dir as index.db. But catalog should not do this.

I have tried "-c" to specify catalog path, and found it works. Could you pls. have a try on the same contrib tree? contrib/gzhai/master2

Thanks,
Edwin

Quoted 3 lines

Sau!

Saul Wold

2011-09-09 15:16 UTC #4 lore raw

Re: [PATCH 1/1] opensp: Fix hard path in native nsgmls.

Quoted 46 lines · Edwin

Quoted 26 lines · Saul Wold
Quoted 25 lines · On 09/08/2011 07:53 PM, [email protected] wrote:
From: Zhai Edwin<[email protected]>
This relocation issues caused following bug and introduce one partial fix bb024d:
[YOCTO #1440]
But the environment val hacking is not working all the time, as nsgmsl may
append wrong path in some case. This fix use search directory "-D" as solution.
It's better if got fixed from opensp side when next upgrade.
Signed-off-by Zhai Edwin<[email protected]>
CC Saul Would<[email protected]>
---
meta/recipes-devtools/opensp/opensp_1.5.bb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/opensp/opensp_1.5.bb +0 -0
index 0269c87..d692137 100644
@@ -44,8 +44,8 @@ do_install_append() {
 
Quoted 11 lines
Quoted 9 lines
meta/recipes-devtools/opensp/opensp_1.5.bb +0 -0
 do_install_append_virtclass-native() {
for util in nsgmls sgmlnorm spam spcat spent sx; do
- create_wrapper ${D}/${bindir}/$util \
- SGML_CATALOG_FILES=${sysconfdir}/sgml/catalog
+ create_cmdline_wrapper ${D}/${bindir}/$util \
+ -D ${sysconfdir}/sgml
done
}
Have you tested this with iputils? When I tried this, it did not work correctly for me, can you give me more of idea of how you tested this.
Sorry, I forgot to rename the tmp to make sysroot unavailable:( After renaming, the bug still exist.
Upgrading to 1.5.2 doesn't help. After debug with strace, I found nsgmls append ".." to other paths when inputting "../index.db" as you said. It's reasonable for entity such as ping.sgml, as they usually sit in same dir as index.db. But catalog should not do this.

Quoted 4 lines

I have tried "-c" to specify catalog path, and found it works. Could you pls. have a try on the same contrib tree? contrib/gzhai/master2

Edwin,

Did you try the -c with the linuxdoc-tools-native recipe also? I found that when I used -c option with that recipe I then get a failure, so as I have mentioned before I think the problem maybe in the opensp code itself and it should not append the ".." to the catalog search patch.

Sau!

Quoted 8 lines

Thanks,
Edwin
Quoted 3 lines
Sau!

Zhai, Edwin

author

2011-09-10 01:05 UTC #5 lore raw

Re: [PATCH 1/1] opensp: Fix hard path in native nsgmls.

Quoted 46 lines · Saul Wold

Quoted 45 lines · Edwin
Quoted 26 lines · Saul Wold
Quoted 25 lines · On 09/08/2011 07:53 PM, [email protected] wrote:
From: Zhai Edwin<[email protected]>
This relocation issues caused following bug and introduce one partial fix bb024d:
[YOCTO #1440]
But the environment val hacking is not working all the time, as nsgmsl may
append wrong path in some case. This fix use search directory "-D" as solution.
It's better if got fixed from opensp side when next upgrade.
Signed-off-by Zhai Edwin<[email protected]>
CC Saul Would<[email protected]>
---
meta/recipes-devtools/opensp/opensp_1.5.bb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/opensp/opensp_1.5.bb +0 -0
index 0269c87..d692137 100644
@@ -44,8 +44,8 @@ do_install_append() {
 
Quoted 11 lines
Quoted 9 lines
meta/recipes-devtools/opensp/opensp_1.5.bb +0 -0
 do_install_append_virtclass-native() {
for util in nsgmls sgmlnorm spam spcat spent sx; do
- create_wrapper ${D}/${bindir}/$util \
- SGML_CATALOG_FILES=${sysconfdir}/sgml/catalog
+ create_cmdline_wrapper ${D}/${bindir}/$util \
+ -D ${sysconfdir}/sgml
done
}
Have you tested this with iputils? When I tried this, it did not work correctly for me, can you give me more of idea of how you tested this.
Sorry, I forgot to rename the tmp to make sysroot unavailable:( After renaming, the bug still exist.
Upgrading to 1.5.2 doesn't help. After debug with strace, I found nsgmls append ".." to other paths when inputting "../index.db" as you said. It's reasonable for entity such as ping.sgml, as they usually sit in same dir as index.db. But catalog should not do this.

Quoted 8 lines

Quoted 4 lines
I have tried "-c" to specify catalog path, and found it works. Could you pls. have a try on the same contrib tree? contrib/gzhai/master2
Edwin,
Did you try the -c with the linuxdoc-tools-native recipe also? I found that when I used -c option with that recipe I then get a failure,

No. You have mentioned focus on iputils. Seems this fix is same as the one in poky.

Quoted 3 lines

so as
I have mentioned before I think the problem maybe in the opensp code itself and it should not append the ".." to the catalog search patch.

Agree with you. but hack in the source code need some time.

Quoted 6 lines

Quoted 6 lines
Thanks,
Edwin
Quoted 2 lines
Sau!