Skip to contentSkip to conversation

Update to latest prelinker -- fix arm and x86 issues

PATCH In review Mark Hatle 3 participants 5 messages Sep 14, 2011

lore
Share & tools
lore

Mark Hatle

author
#0 lore raw

cover Update to latest prelinker -- fix arm and x86 issues

This fixes yocto bugzilla bug 1473. It addresses an issue where a typecast wasn't being specified and the compiler was doing the wrong thing in a printf.

The symbols of the previous failure were, on a 32-bit IA32 host, targeting either a 32-bit IA32 target or ARM target the results of a prelinked image may not work properly.

The following changes since commit 3be290aac4da885fe5bc31797c4a689196c63b7a:

libzypp: move package-manger to it own package (2011-09-13 16:19:30 -0700)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib mhatle/prelink
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/prelink

Mark Hatle (1):
Uprev to latest version of prelink_git, fixing TLS issues

 meta/recipes-devtools/prelink/prelink_git.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.3.4
author
#1 lore raw

PATCH 1/1 Uprev to latest version of prelink_git, fixing TLS issues

[YOCTO #1473]

From the upstream cross prelink respository:

Fix printf typecast problem

Without this fix the printed TLS(...) information is incorrect, which causes the core prelinker code to incorrectly prelink. This bug triggers primarily on x86 (32-bit) hosts, targeting x86 (32-bit) targets and arm targets.

---
 meta/recipes-devtools/prelink/prelink_git.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/prelink/prelink_git.bb +2 -2
index 1565ca6..af6de8e 100644
@@ -8,9 +8,9 @@ and executables, so that far fewer relocations need to be resolved at \
 runtime and thus programs come up faster."
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
-SRCREV = "964f6eba613bf1c791a2a0b858cd044f05e2f151"
+SRCREV = "3e3f9b0876aa5ac83a783a95b8bab52cb38ed785"
 PV = "1.0+git${SRCPV}"
-PR = "r6"
+PR = "r7"
 
 #
 # The cron script attempts to re-prelink the system daily -- on
Signature · 1 line
1.7.3.4
author
#2 lore raw

Re: [PATCH 1/1] Uprev to latest version of prelink_git, fixing TLS issues

Just an FYI if anyone is curious, the actual fix is:

trunk/src/rtld/rtld.c +1 -1
@@ -1120,7 +1120,7 @@ process_one_dso (DSO *dso, int host_paths)
                   (size_t) (l->l_map_start - cur_dso_ent->dso->base));
 
           if (l->l_tls_modid)
-            printf (" TLS(0x%Zx, 0x%0*Zx)\n", l->l_tls_modid,
+            printf (" TLS(0x%Zx, 0x%0*Zx)\n", (size_t) l->l_tls_modid,
                     (int) size_pointer,
                     (size_t) l->l_tls_offset);
           else

l->l_tls_modid is a uint64_t....

--Mark

Quoted 32 lines · Mark Hatle

[YOCTO #1473]

From the upstream cross prelink respository:

Fix printf typecast problem

Without this fix the printed TLS(...) information is incorrect, which causes the core prelinker code to incorrectly prelink. This bug triggers primarily on x86 (32-bit) hosts, targeting x86 (32-bit) targets and arm targets.

---
 meta/recipes-devtools/prelink/prelink_git.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/prelink/prelink_git.bb +2 -2
index 1565ca6..af6de8e 100644
@@ -8,9 +8,9 @@ and executables, so that far fewer relocations need to be resolved at \
 runtime and thus programs come up faster."
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
-SRCREV = "964f6eba613bf1c791a2a0b858cd044f05e2f151"
+SRCREV = "3e3f9b0876aa5ac83a783a95b8bab52cb38ed785"
 PV = "1.0+git${SRCPV}"
-PR = "r6"
+PR = "r7"
 
 #
 # The cron script attempts to re-prelink the system daily -- on
#3 lore raw
In reply to Mark Hatle
Quoted 8 lines · Mark Hatle

This fixes yocto bugzilla bug 1473. It addresses an issue where a typecast wasn't being specified and the compiler was doing the wrong thing in a printf.

The symbols of the previous failure were, on a 32-bit IA32 host, targeting either a 32-bit IA32 target or ARM target the results of a prelinked image may not work properly.

Mark,

There is still a problem with the prelinker, it seems to clobber text in X11 on qemux86, we get a build that has square blocks for text.

Sau!

Quoted 14 lines

The following changes since commit 3be290aac4da885fe5bc31797c4a689196c63b7a:

libzypp: move package-manger to it own package (2011-09-13 16:19:30 -0700)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib mhatle/prelink
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/prelink

Mark Hatle (1):
Uprev to latest version of prelink_git, fixing TLS issues

 meta/recipes-devtools/prelink/prelink_git.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
#4 lore raw

Bug 1482 filed for it.

- Jessica

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Saul Wold
Sent: Wednesday, September 14, 2011 10:04 AM
To: [email protected]
Subject: Re: [OE-core] [PATCH 0/1] Update to latest prelinker -- fix arm and x86 issues

Quoted 8 lines · Mark Hatle

This fixes yocto bugzilla bug 1473. It addresses an issue where a typecast wasn't being specified and the compiler was doing the wrong thing in a printf.

The symbols of the previous failure were, on a 32-bit IA32 host, targeting either a 32-bit IA32 target or ARM target the results of a prelinked image may not work properly.

Mark,

There is still a problem with the prelinker, it seems to clobber text in X11 on qemux86, we get a build that has square blocks for text.

Sau!

Quoted 8 lines

The following changes since commit 3be290aac4da885fe5bc31797c4a689196c63b7a:

libzypp: move package-manger to it own package (2011-09-13 16:19:30 -0700)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib mhatle/prelink
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/prelink

Quoted 6 lines

Mark Hatle (1):
Uprev to latest version of prelink_git, fixing TLS issues

 meta/recipes-devtools/prelink/prelink_git.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core