Skip to contentSkip to conversation

Minor autoconf & autotools.bbclass fixes (supercedes previous misc fixes request)

PATCH Applied Christopher Larson 2 participants 4 messages Oct 10, 2011 – Oct 14, 2011

lore
Share & tools
lore
#0 lore raw

cover Minor autoconf & autotools.bbclass fixes (supercedes previous misc fixes request)

The following changes since commit 4732222c46652951e66aae377631f4a361179d8f:

Fix sysprof for powerpc64 (2011-10-10 09:54:03 +0100)

are available in the git repository at:
http://github.com/kergoth/oe-core misc-fixes

Christopher Larson (2):
autotools: fix multi-word arguments for EXTRA_OECONF
autoconf: no need to hardcode the full path to m4

 meta/classes/autotools.bbclass                  |    6 ++----
 meta/recipes-devtools/autoconf/autoconf_2.68.bb |    4 +++-
 2 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.3.2.430.g208247
#1 lore raw

PATCH 2/2 autoconf: no need to hardcode the full path to m4

This way autom4te uses m4 as it finds it in the PATH, rather than hardcoding any particular path.

---
 meta/recipes-devtools/autoconf/autoconf_2.68.bb |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
meta/recipes-devtools/autoconf/autoconf_2.68.bb +3 -1
index c6209a3..21b5fb3 100644
@@ -1,6 +1,6 @@
 require autoconf.inc
 
-PR = "r2"
+PR = "r3"
 
 PARALLEL_MAKE = ""
 
@@ -27,4 +27,6 @@ RDEPENDS_${PN}_virtclass-native = "m4-native gnu-config-native"
 
 SRC_URI_append_virtclass-native = " file://fix_path_xtra.patch"
 
+EXTRA_OECONF += "ac_cv_path_M4=m4"
+
 BBCLASSEXTEND = "native"
Signature · 1 line
1.7.3.2.430.g208247
#2 lore raw

PATCH v2 1/2 autotools: fix multi-word arguments for EXTRA_OECONF

In reply to Christopher Larson

This is needed to better support things like the following (with a multi-word BUILD_CC):

    EXTRA_OECONF += '"ac_cv_prog_CC_FOR_BUILD=${BUILD_CC}"'
---
 meta/classes/autotools.bbclass |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
meta/classes/autotools.bbclass +2 -4
index a4ce851..937e2ba 100644
@@ -71,10 +71,8 @@ CONFIGUREOPT_DEPTRACK = "--disable-dependency-tracking"
 
 oe_runconf () {
 	if [ -x ${S}/configure ] ; then
-		cfgcmd="${S}/configure \
-		${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
-		bbnote "Running $cfgcmd..."
-		$cfgcmd || bbfatal "oe_runconf failed" 
+		bbnote "Running ${S}/configure ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
+		${S}/configure ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@" || bbfatal "oe_runconf failed"
 	else
 		bbfatal "no configure script found"
 	fi
Signature · 1 line
1.7.3.2.430.g208247
Applied
#3 lore raw
In reply to Christopher Larson
Quoted 7 lines · Christopher Larson

The following changes since commit 4732222c46652951e66aae377631f4a361179d8f:

   Fix sysprof for powerpc64 (2011-10-10 09:54:03 +0100)

are available in the git repository at:
http://github.com/kergoth/oe-core misc-fixes

Quoted 8 lines

Christopher Larson (2):
autotools: fix multi-word arguments for EXTRA_OECONF
autoconf: no need to hardcode the full path to m4

  meta/classes/autotools.bbclass                  |    6 ++----
  meta/recipes-devtools/autoconf/autoconf_2.68.bb |    4 +++-
  2 files changed, 5 insertions(+), 5 deletions(-)

Merged into OE-Core

Thanks
Sau!