Skip to contentSkip to conversation

Can we drop Clutter bbappends?

RFC PATCH In review Joshua Lock 2 participants 6 messages Nov 16, 2011 – Nov 30, 2011

lore
Share & tools
lore

Joshua Lock

author
#0 lore raw

cover Can we drop Clutter bbappends?

All,

The subject says it all. My reading of recent changes in oe-core around X and clutter lead me to believe that our bbappend is redundant so I'm proposing we drop it.

Both virtual/libgl being in DEPENDS and passing the --with-flavour=glx option are part of the standard clutter.inc now.

I may well be wrong but I like patches as a way to start discussion.

Cheers,
Joshua

Please review the following changes for suitability for inclusion. If you have any objections or suggestions for improvement, please respond to the patches. If you agree with the changes, please provide your Acked-by.

The following changes since commit fa81f8dfb7a342e355b608aa4204cf23ed2b251c:

mime.bbclass: fix typo (2011-11-15 12:05:30 +0000)

are available in the git repository at:
git://git.yoctoproject.org/poky-contrib josh/work
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=josh/work

Joshua Lock (1):
clutter: drop unneeded bbappends

 .../clutter/clutter-1.6_1.6.18.bbappend            |    4 ----
 .../clutter/clutter-1.8_1.8.0.bbappend             |    4 ----
 .../recipes-graphics/clutter/clutter_git.bbappend  |    4 ----
 3 files changed, 0 insertions(+), 12 deletions(-)
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
Signature · 1 line
1.7.7.1
author
#1 lore raw

RFC PATCH 1/1 clutter: drop unneeded bbappends

The --with-flavour-glx option is the default in clutter.inc now

Signed-off-by Joshua Lock <[email protected]>
---
 .../clutter/clutter-1.6_1.6.18.bbappend            |    4 ----
 .../clutter/clutter-1.8_1.8.0.bbappend             |    4 ----
 .../recipes-graphics/clutter/clutter_git.bbappend  |    4 ----
 3 files changed, 0 insertions(+), 12 deletions(-)
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend deleted +0 -4
deleted file mode 100644
index c7cc683..0000000
@@ -1,4 +0,0 @@
-DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
-EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
-PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"
-
meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend deleted +0 -4
deleted file mode 100644
index c7cc683..0000000
@@ -1,4 +0,0 @@
-DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
-EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
-PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"
-
meta-yocto/recipes-graphics/clutter/clutter_git.bbappend deleted +0 -4
deleted file mode 100644
index c7cc683..0000000
@@ -1,4 +0,0 @@
-DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
-EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
-PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"
-
Signature · 1 line
1.7.7.1
author
#4 lore raw
In reply to Joshua Lock
Quoted 10 lines · Joshua Lock

All,

The subject says it all. My reading of recent changes in oe-core around X and clutter lead me to believe that our bbappend is redundant so I'm proposing we drop it.

Both virtual/libgl being in DEPENDS and passing the --with-flavour=glx option are part of the standard clutter.inc now.

I may well be wrong but I like patches as a way to start discussion.

Any discusser's?

Cheers,
Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
#2 lore raw

Re: [RFC PATCH 1/1] clutter: drop unneeded bbappends

In reply to Joshua Lock
Quoted 18 lines · Joshua Lock

The --with-flavour-glx option is the default in clutter.inc now

Signed-off-by Joshua Lock <[email protected]>
---
 .../clutter/clutter-1.6_1.6.18.bbappend            |    4 ----
 .../clutter/clutter-1.8_1.8.0.bbappend             |    4 ----
 .../recipes-graphics/clutter/clutter_git.bbappend  |    4 ----
 3 files changed, 0 insertions(+), 12 deletions(-)
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
 delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend deleted +0 -0
deleted file mode 100644
index c7cc683..0000000

meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend line 3

Quoted 3 lines
meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend deleted +0 -3
@@ -1,4 +0,0 @@
-DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
-EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
-PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"

I'm fine with this but one question - is the virtual/xserver dependency still needed? If so we should add it to .inc. I'm in favour of merging this patch though.

Cheers,

Richard

author
#3 lore raw

Re: [RFC PATCH 1/1] clutter: drop unneeded bbappends

Quoted 13 lines · Richard Purdie
Quoted 12 lines · Joshua Lock

The --with-flavour-glx option is the default in clutter.inc now

Signed-off-by Joshua Lock<[email protected]>
---
  .../clutter/clutter-1.6_1.6.18.bbappend            |    4 ----
  .../clutter/clutter-1.8_1.8.0.bbappend             |    4 ----
  .../recipes-graphics/clutter/clutter_git.bbappend  |    4 ----
  3 files changed, 0 insertions(+), 12 deletions(-)

delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter_git.bbappend

Quoted 14 lines

meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend line 3

Quoted 9 lines
meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend deleted +0 -3
deleted file mode 100644
index c7cc683..0000000
@@ -1,4 +0,0 @@
-DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
-EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
-PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"

I'm fine with this but one question - is the virtual/xserver dependency still needed? If so we should add it to .inc. I'm in favour of merging this patch though.

My git fu is failing me so I've not been able to work out why virtual/xserver was added to the DEPENDS for atom-pc. I suspect it's not needed, though - I've been able to build clutter-1.8 for atom-pc in a clean TMPDIR without virtual/xserver in DEPENDS (though I have found a fix for cogl - expect it soon).

Cheers,
Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
#5 lore raw
In reply to Joshua Lock
Quoted 20 lines · Joshua Lock

All,

The subject says it all. My reading of recent changes in oe-core around X and clutter lead me to believe that our bbappend is redundant so I'm proposing we drop it.

Both virtual/libgl being in DEPENDS and passing the --with-flavour=glx option are part of the standard clutter.inc now.

I may well be wrong but I like patches as a way to start discussion.

Cheers,
Joshua

Please review the following changes for suitability for inclusion. If you have any objections or suggestions for improvement, please respond to the patches. If you agree with the changes, please provide your Acked-by.

The following changes since commit fa81f8dfb7a342e355b608aa4204cf23ed2b251c:

Quoted 8 lines

mime.bbclass: fix typo (2011-11-15 12:05:30 +0000)

are available in the git repository at:
git://git.yoctoproject.org/poky-contrib josh/work
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=josh/work

Joshua Lock (1):
clutter: drop unneeded bbappends

I've went ahead and merged this.

Cheers,

Richard