Skip to contentSkip to conversation

archive.bbclass: archive work directory

PATCH In review [email protected] 2 participants 5 messages Jan 11, 2012 – Jan 12, 2012

lore
Share & tools
lore
#1 lore raw

PATCH v2 1/1 archive.bbclass: archive work directory

In reply to [email protected]

From: Wenzong Fan <[email protected]>

Some legal departments believe a complete archive of the work directory is required for certain license compliance issues. We could therefore do with a class which archives up the work directories in each build and provide them so those legal departments can be happy.

Implementations:

Add a new class named 'archive.bbclass' to provide task 'do_archive', and get it called after 'do_patch' before 'do_configure'.

Following cases should be considered to the sources dirs:
1) The sources dir is under $WORKDIR:
Just archive sources and temp/run.* up.

2) The sources dir is outside of $WORKDIR, such as gcc:
Copy its sources and temp/run.* to a temporary dir and then archive them up.

3) The sources dir is equal to $WORKDIR:
Just archive whole work dir up.

[YOCTO #1590]

---
 meta/classes/archive.bbclass |   49 ++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 49 insertions(+), 0 deletions(-)
 create mode 100644 meta/classes/archive.bbclass
meta/classes/archive.bbclass new file +49 -0
new file mode 100644
index 0000000..e529793
@@ -0,0 +1,49 @@
+# Archive the patched sources and build scripts to assist in license
+# compliance by the end user or legal departments.
+
+ARCHIVE_DIR = "${TMPDIR}/archives/${MULTIMACH_TARGET_SYS}/"
+do_archive[dirs] = "${ARCHIVE_DIR}"
+
+archive_do_archive() {
+    # In mostly scenarios the $S is under $WORKDIR and has a separate
+    # dir for storing the sources; but sometimes we also put the same
+    # sources 'tmp/work-shared/' for sharing between different build.
+    if [ -d ${S} -a ${S} != ${WORKDIR} ]; then
+        sources_shared="0"
+
+        if echo ${S} | grep "${TMPDIR}/work-shared" > /dev/null; then
+            sources_shared="1"
+        fi
+
+        if [ x$sources_shared == "x1" ]; then
+            # Create temporary sources directory
+            mkdir -p ${PF}/temp
+            cp -r ${S} ${PF}
+            cp -r ${S}/../temp/* ${PF}/temp
+            cp -r ${WORKDIR}/temp/* ${PF}/temp
+            tarbase=`pwd`
+            sourcedir=`basename ${S}`
+        else
+            tarbase=`dirname ${WORKDIR}`
+            sourcedir=`echo ${S}|sed -e "s#${WORKDIR}/*##g"`
+        fi
+
+        tar -C $tarbase -cjf ${PF}.tar.bz2 ${PF}/$sourcedir \
+            ${PF}/temp --exclude log.do_*
+
+        # Remove the temporary sources directory
+        if [ x$sources_shared == "x1" -a -d ${PF} ]; then
+            rm -rf ${PF}
+        fi
+    fi
+
+    # Just archive whole build directory up when $S is equal to $WORKDIR
+    if [ -d ${S} -a ${S} == ${WORKDIR} ]; then
+        tarbase=`dirname ${WORKDIR}`
+        tar -C $tarbase -cjf ${PF}.tar.bz2 ${PF} --exclude log.do_*
+    fi
+}
+
+addtask do_archive after do_patch before do_configure
+
+EXPORT_FUNCTIONS do_archive
Signature · 1 line
1.7.0.4
#0 lore raw

v2 cover archive.bbclass: archive work directory

From: Wenzong Fan <[email protected]>

v2 updates:

1) Remove the special-casing for gcc, checking for any packages under 'tmp/work-shared';

2) Remove some bash-specific code, replase the '[[regular-expression]]' with isovalent 'grep' statement.

The following changes since commit 4a8a3c503fd896593b787c26edbe46a7324e494e:
Richard Purdie (1):
Revert "site/common-uclibc: Cache gl_cv_func_wcwidth_works"

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/1590
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/1590

Wenzong Fan (1):
archive.bbclass: archive work directory

 meta/classes/archive.bbclass |   49 ++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 49 insertions(+), 0 deletions(-)
 create mode 100644 meta/classes/archive.bbclass
#2 lore raw
Quoted 11 lines · On 01/10/2012 11:34 PM, [email protected] wrote:

From: Wenzong Fan<[email protected]>

v2 updates:

1) Remove the special-casing for gcc, checking for any packages under 'tmp/work-shared';

2) Remove some bash-specific code, replase the '[[regular-expression]]' with isovalent 'grep' statement.

So how is this work different than that of Xiaofeng's doing the tar_archive? Can these two be merged somehow? We also have something called copyleft complaince, is this similar or somehow different?

We also have src_distribute.bbclass and sourcepkg.bbclass, seems like we have a more ways to package up source code than we know what to do with.

Mark, we might want to sync up on this and figure out what we really have and what's really needed here.

Thanks
Sau!

Quoted 22 lines

The following changes since commit 4a8a3c503fd896593b787c26edbe46a7324e494e:
Richard Purdie (1):
Revert "site/common-uclibc: Cache gl_cv_func_wcwidth_works"

are available in the git repository at:

   git://git.pokylinux.org/poky-contrib wenzong/1590
   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/1590

Wenzong Fan (1):
archive.bbclass: archive work directory

  meta/classes/archive.bbclass |   49 ++++++++++++++++++++++++++++++++++++++++++
  1 files changed, 49 insertions(+), 0 deletions(-)

create mode 100644 meta/classes/archive.bbclass

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 5 lines · Saul Wold
Quoted 4 lines · On 01/10/2012 11:34 PM, [email protected] wrote:

From: Wenzong Fan<[email protected]>

v2 updates:

Quoted 8 lines
Quoted 7 lines

1) Remove the special-casing for gcc, checking for any packages under 'tmp/work-shared';

2) Remove some bash-specific code, replase the '[[regular-expression]]' with isovalent 'grep' statement.

So how is this work different than that of Xiaofeng's doing the tar_archive? Can these two be merged somehow? We also have something called copyleft complaince, is this similar or somehow different?

They are a little similar but mostly are different, #1655 (Xiaofeng's) will need to export the source packages (such as *.tar, *.rpm ...) for using, Mark also commented the details at:

http://bugzilla.pokylinux.org/show_bug.cgi?id=1655

But the #1590 (mine) only archive the patched sources/build_scripts up for later checking.

Thanks
Wenzong

Quoted 35 lines

We also have src_distribute.bbclass and sourcepkg.bbclass, seems like we have a more ways to package up source code than we know what to do with.

Mark, we might want to sync up on this and figure out what we really have and what's really needed here.

Thanks
Sau!

Quoted 23 lines

The following changes since commit 4a8a3c503fd896593b787c26edbe46a7324e494e:
Richard Purdie (1):
Revert "site/common-uclibc: Cache gl_cv_func_wcwidth_works"

are available in the git repository at:

   git://git.pokylinux.org/poky-contrib wenzong/1590
   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/1590

Wenzong Fan (1):
archive.bbclass: archive work directory

  meta/classes/archive.bbclass |   49 
++++++++++++++++++++++++++++++++++++++++++
  1 files changed, 49 insertions(+), 0 deletions(-)

create mode 100644 meta/classes/archive.bbclass

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

#4 lore raw
Quoted 13 lines · wenzong fan
Quoted 12 lines · Saul Wold
Quoted 11 lines · On 01/10/2012 11:34 PM, [email protected] wrote:

From: Wenzong Fan<[email protected]>

v2 updates:

1) Remove the special-casing for gcc, checking for any packages under 'tmp/work-shared';

2) Remove some bash-specific code, replase the '[[regular-expression]]' with isovalent 'grep' statement.

Quoted 7 lines
Quoted 1 line

So how is this work different than that of Xiaofeng's doing the tar_archive? Can these two be merged somehow? We also have something called copyleft complaince, is this similar or somehow different?

They are a little similar but mostly are different, #1655 (Xiaofeng's) will need to export the source packages (such as *.tar, *.rpm ...) for using, Mark also commented the details at:

http://bugzilla.pokylinux.org/show_bug.cgi?id=1655

But the #1590 (mine) only archive the patched sources/build_scripts up for later checking.

And I think both the 'archive.bbclass' and 'copyleft_complaince.bbclass' were designed for some license related issues, but the 'archive.bbclass' will create snapshot for all sources and 'copyleft_complaince.bbclass' will do dynamic checking for the licenses.

Thanks
Wenzong

Quoted 46 lines

Thanks
Wenzong

Quoted 35 lines

We also have src_distribute.bbclass and sourcepkg.bbclass, seems like we have a more ways to package up source code than we know what to do with.

Mark, we might want to sync up on this and figure out what we really have and what's really needed here.

Thanks
Sau!

Quoted 23 lines

The following changes since commit 4a8a3c503fd896593b787c26edbe46a7324e494e:
Richard Purdie (1):
Revert "site/common-uclibc: Cache gl_cv_func_wcwidth_works"

are available in the git repository at:

   git://git.pokylinux.org/poky-contrib wenzong/1590
   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/1590

Wenzong Fan (1):
archive.bbclass: archive work directory

  meta/classes/archive.bbclass |   49 
++++++++++++++++++++++++++++++++++++++++++
  1 files changed, 49 insertions(+), 0 deletions(-)

create mode 100644 meta/classes/archive.bbclass

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core