Skip to contentSkip to conversation

Enable spaces in RPM packages

PATCH In review Mark Hatle 2 participants 3 messages Jan 17, 2012

lore
Share & tools
lore

Mark Hatle

author
#0 lore raw

cover Enable spaces in RPM packages

RPM packages could not handle spaces in filenames, fix this.

The following changes since commit 7257ded5355ffdc0fc169e7f34daeedb0b3dcd78:

busybox/uglibc: remove obsolete check for "kernel24" (2012-01-17 15:15:29 +0000)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib mhatle/rpm
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/rpm

Mark Hatle (1):
package_rpm.bbclass: Add support for filenames with spaces

 meta/classes/package_rpm.bbclass |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.3.4
author
#1 lore raw

PATCH 1/1 package_rpm.bbclass: Add support for filenames with spaces

Files with spaces must be fully quoted in an RPM spec file. It was easier to quote all file paths, then to do it selectively.

---
 meta/classes/package_rpm.bbclass |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
meta/classes/package_rpm.bbclass +4 -4
index 2d92efe..bac9de5 100644
@@ -543,12 +543,12 @@ python write_specfile () {
 			path = rootpath.replace(walkpath, "")
 			for dir in dirs:
 				# All packages own the directories their files are in...
-				target.append("%dir " + path + "/" + dir)
+				target.append('%dir "' + path + '/' + dir + '"')
 			for file in files:
-				if conffiles.count(path + "/" + file):
-					target.append("%config " + path + "/" + file)
+				if conffiles.count(path + '/' + file):
+					target.append('%config "' + path + '/' + file + '"')
 				else:
-					target.append(path + "/" + file)
+					target.append('"' + path + '/' + file + '"')
 
 	# Prevent the prerm/postrm scripts from being run during an upgrade
 	def wrap_uninstall(scriptvar):
Signature · 1 line
1.7.3.4
Tested-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] package_rpm.bbclass: Add support for filenames with spaces

Op 17 jan. 2012, om 16:47 heeft Mark Hatle het volgende geschreven:

Quoted 4 lines

Files with spaces must be fully quoted in an RPM spec file. It was easier to quote all file paths, then to do it selectively.