Hob2: bitbake related changes
Hi Richard,
This pull request revise the sceneQueueTaskStarted event change, please help to review and pull.
Changes from last pull request:
- sceneQueueTaskStarted inherits runQueueEvent instead of runQueueTaskStarted.
- Also change sceneQueueTaskFailed to inherit runQueueEvent.
Thanks,
Dongxiao
The following changes since commit 9ede881620c501574f014e600cea6947ea908ac2:
bitbake: change for adding progress bar in Hob2. (2012-02-23 22:51:50 +0000)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib dxu4/hob2-bitbake-changes-v2
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob2-bitbake-changes-v2
Dongxiao Xu (1):
runqueue: fire sceneQueueTaskStarted event when a setscene queue
starts
lib/bb/runqueue.py | 16 ++++++++++++++-- 1 files changed, 14 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.4.1
PATCH 1/1 runqueue: fire sceneQueueTaskStarted event when a setscene queue starts
The current code prints a log when a setscene task starts, therefore the progressbar in hob will not receive it. Use a sceneQueueTaskStarted event instead.
Besides, change the sceneQueueTaskFailed event to inherit runQueueEvent directly to avoid confusion to event receiver.
--- lib/bb/runqueue.py | 16 ++++++++++++++-- 1 files changed, 14 insertions(+), 2 deletions(-)
lib/bb/runqueue.py +14 -2
@@ -1653,6 +1653,9 @@ class RunQueueExecuteScenequeue(RunQueueExecute): self.task_skip(task) return True + startevent = sceneQueueTaskStarted(task, self.stats, self.rq) + bb.event.fire(startevent, self.cfgData) + pid, pipein, pipeout = self.fork_off_task(fn, realtask, taskname) self.build_pids[pid] = task
@@ -1720,6 +1723,14 @@ class runQueueTaskStarted(runQueueEvent): runQueueEvent.__init__(self, task, stats, rq) self.noexec = noexec +class sceneQueueTaskStarted(runQueueEvent): + """ + Event notifing a setscene task was started + """ + def __init__(self, task, stats, rq, noexec=False): + runQueueEvent.__init__(self, task, stats, rq) + self.noexec = noexec + class runQueueTaskFailed(runQueueEvent): """ Event notifing a task failed
@@ -1728,12 +1739,13 @@ class runQueueTaskFailed(runQueueEvent): runQueueEvent.__init__(self, task, stats, rq) self.exitcode = exitcode -class sceneQueueTaskFailed(runQueueTaskFailed): +class sceneQueueTaskFailed(runQueueEvent): """ Event notifing a setscene task failed """ def __init__(self, task, stats, exitcode, rq): - runQueueTaskFailed.__init__(self, task, stats, exitcode, rq) + runQueueEvent.__init__(self, task, stats, rq) + self.exitcode = exitcode self.taskstring = rq.rqdata.get_user_idstring(task, "_setscene") class runQueueTaskCompleted(runQueueEvent):
Signature · 1 line
1.7.4.1
Richard Purdie
AppliedRe: [PATCH 1/1] runqueue: fire sceneQueueTaskStarted event when a setscene queue starts
Quoted 4 lines · Dongxiao Xu
The current code prints a log when a setscene task starts, therefore the progressbar in hob will not receive it. Use a sceneQueueTaskStarted event instead.
Quoted 8 lines
Besides, change the sceneQueueTaskFailed event to inherit runQueueEvent directly to avoid confusion to event receiver.
Signed-off-by Shane Wang <[email protected]>Signed-off-by Dongxiao Xu <[email protected]>--- lib/bb/runqueue.py | 16 ++++++++++++++-- 1 files changed, 14 insertions(+), 2 deletions(-)
Merged to master, thanks.
Richard