Qt4 qmake & other fixes
cover Qt4 qmake & other fixes
This patchset enables building qmake for the target with other target utilities. I also fixed a couple of build failures in the process.
In addition I've used the same method to build qmake in the qt4-tools-nativesdk recipe. This wasn't strictly necessary, however I think it would be good to be consistent and incidentally the resulting qmake executable is slightly smaller.
Since the RFC version, a few issues were fixed:
* Ensure the qmake changes work when the platform is different e.g. linux-gnueabi-oe-g++ instead of linux-oe-g++
* Install an appropriate environment setup script adapted from the former separate qmake2 recipe
* Fix the gcc 4.6 error by fixing the root cause (inability to correctly detect the C++ compiler as g++) rather than hacking around it.
* Format some of the patches so they can be used with git am
Thanks to Philip Balister for helping me test the qmake improvements.
The following changes since commit 30253358f5e76fb7b25be27198b4c125e0dbdf2c:
Quoting fixes (2012-02-26 12:50:36 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/qmake-target
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/qmake-target
Paul Eggleton (4):
qt4: fix compile error in Qt 4.8.0 with gcc 4.6
qt4: build qmake for the target
qt4-tools-nativesdk: fix build of 4.7.4
qt4-tools-nativesdk: improve and tidy up qmake build
meta/recipes-qt/qt4/files/qmake-exists-check.patch | 19 ------- meta/recipes-qt/qt4/files/target_qmake.patch | 16 ++++++ meta/recipes-qt/qt4/qt-4.7.4.inc | 11 +---- meta/recipes-qt/qt4/qt-4.8.0.inc | 13 +---- .../qt4/qt-4.8.0/configure_oe_compiler.patch | 31 ++++++++++++ meta/recipes-qt/qt4/qt-4.8.0/qmake_pri_fixes.patch | 51 ++++++++++++++++++++ meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4-embedded_4.8.0.bb | 2 +- meta/recipes-qt/qt4/qt4-tools-nativesdk.inc | 29 +++++++---- meta/recipes-qt/qt4/qt4-tools-nativesdk_4.8.0.bb | 2 + meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4.inc | 47 ++++++++++++++++-- 12 files changed, 168 insertions(+), 57 deletions(-) delete mode 100644 meta/recipes-qt/qt4/files/qmake-exists-check.patch create mode 100644 meta/recipes-qt/qt4/files/target_qmake.patch create mode 100644 meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch create mode 100644 meta/recipes-qt/qt4/qt-4.8.0/qmake_pri_fixes.patch
Signature · 1 line
1.7.5.4
PATCH 1/4 qt4: fix compile error in Qt 4.8.0 with gcc 4.6
Ensure the Qt configure script can can detect the compiler correctly as g++. This fixes the following compile error with gcc 4.6:
./wtf/NullPtr.h:48:1: error: identifier 'nullptr' will become a keyword in C++0x [-Werror=c++0x-compat]
--- meta/recipes-qt/qt4/qt-4.8.0.inc | 1 + .../qt4/qt-4.8.0/configure_oe_compiler.patch | 31 ++++++++++++++++++++ meta/recipes-qt/qt4/qt4-embedded_4.8.0.bb | 2 +- 3 files changed, 33 insertions(+), 1 deletions(-) create mode 100644 meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch
meta/recipes-qt/qt4/qt-4.8.0.inc +1 -0
@@ -14,6 +14,7 @@ SRC_URI = "http://get.qt.nokia.com/qt/source/qt-everywhere-opensource-src-${PV}. file://fix-translations.patch \ file://add_nostrip_for_debug_packages.diff \ file://qmake_cxx_eval.patch \ + file://configure_oe_compiler.patch \ file://g++.conf \ file://linux.conf \ "
meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch new file +31 -0
@@ -0,0 +1,31 @@ +Ensure we identify the compiler as g++ in configure + +Our PLATFORM in OE is ${TARGET_OS}-oe-g++, and previously the configure +script was interpreting from this that the compiler was "oe-g++" and thus +g++ specific checks were not being run since this string did not match; +among other things this resulted in a compiler version check in the +QtWebKit build code not working, and hence the following error at build +time: + +./wtf/NullPtr.h:48:1: error: identifier 'nullptr' will become a keyword in C++0x [-Werror=c++0x-compat] + +The easiest thing since our PLATFORM is entirely artificial is to just +force COMPILER to "g++" in the configure script if it is detected as +"oe-g++". + +Upstream-Status: Inappropriate [configuration] + +Signed-off-by: Paul Eggleton <[email protected]> + +--- qt-everywhere-opensource-src-4.8.0.orig/configure ++++ qt-everywhere-opensource-src-4.8.0/configure +@@ -7444,6 +7444,9 @@ elif [ "$XPLATFORM" != "$PLATFORM" ]; th + else + COMPILER=`echo $PLATFORM | cut -f 2- -d-` + fi ++case $COMPILER in ++ *oe-g++) COMPILER="g++" ;; ++esac + if [ "$CFG_EXCEPTIONS" = "unspecified" -a "$PLATFORM_QWS" = "yes" ]; then + CFG_EXCEPTIONS=no + fi
meta/recipes-qt/qt4/qt4-embedded_4.8.0.bb +1 -1
@@ -1,7 +1,7 @@ require qt-${PV}.inc require qt4-embedded.inc -PR = "${INC_PR}.0" +PR = "${INC_PR}.1" DEFAULT_PREFERENCE = "-1"
Signature · 1 line
1.7.5.4
PATCH 2/4 qt4: build qmake for the target
In reply to Paul Eggletonqmake was not being built at all (since we had the host version from qt4-native) and the default is to build for the host machine within configure. With a minor hack we can build qmake for the target as well, which is useful if you want to build Qt 4 software on an actual device. This is now installed as part of the tools package (together with uic, moc etc.)
Additionally, add an environment setup script (installed in /usr/share/qt4/environment-setup or /usr/share/qtopia/environment-setup for the embedded version) as part of the mkspecs package since the mkspecs will not work without the paths set up by this script. The code to create this script was adapted from the qmake2 recipe in meta-oe.
Also move do_compile() from qt-${PV}.inc up to qt4.inc as both versions have the exact same content.
--- meta/recipes-qt/qt4/files/target_qmake.patch | 16 ++++++ meta/recipes-qt/qt4/qt-4.7.4.inc | 11 +---- meta/recipes-qt/qt4/qt-4.8.0.inc | 12 +---- meta/recipes-qt/qt4/qt-4.8.0/qmake_pri_fixes.patch | 51 ++++++++++++++++++++ meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4.inc | 47 ++++++++++++++++-- 7 files changed, 115 insertions(+), 26 deletions(-) create mode 100644 meta/recipes-qt/qt4/files/target_qmake.patch create mode 100644 meta/recipes-qt/qt4/qt-4.8.0/qmake_pri_fixes.patch
meta/recipes-qt/qt4/files/target_qmake.patch new file +16 -0
@@ -0,0 +1,16 @@ +Allow building a separate qmake for the target + +Signed-off-by: Paul Eggleton <[email protected]> + +Upstream-Status: Inappropriate [config] + +--- qt-everywhere-opensource-src-4.8.0.orig/qmake/qmake.pro ++++ qt-everywhere-opensource-src-4.8.0/qmake/qmake.pro +@@ -7,6 +7,7 @@ CONFIG += console bootstrap + CONFIG -= qt shared app_bundle uic + DEFINES += QT_BUILD_QMAKE QT_BOOTSTRAPPED + DESTDIR = ../bin/ ++TARGET = qmake2 + + OBJECTS_DIR = . + MOC_DIR = .
meta/recipes-qt/qt4/qt-4.7.4.inc +1 -10
@@ -15,6 +15,7 @@ SRC_URI = "http://get.qt.nokia.com/qt/source/qt-everywhere-opensource-src-${PV}. file://blacklist-diginotar-certs.diff \ file://fix-translations.patch \ file://add_nostrip_for_debug_packages.diff \ + file://target_qmake.patch \ file://g++.conf \ file://linux.conf \ file://fix-qtbug-20925.patch \
@@ -43,13 +44,3 @@ do_configure_prepend() { ${S}/configure } -do_compile() { - # Fixup missing wsegl header in some SGX SDKs - if ! [ -e ${STAGING_INCDIR}/wsegl.h ] ; then - cp src/3rdparty/powervr/wsegl.h src/plugins/gfxdrivers/powervr/QWSWSEGL/ - fi - - unset CFLAGS CXXFLAGS - - oe_runmake ${EXTRA_ENV} -}
meta/recipes-qt/qt4/qt-4.8.0.inc +2 -10
@@ -15,6 +15,8 @@ SRC_URI = "http://get.qt.nokia.com/qt/source/qt-everywhere-opensource-src-${PV}. file://add_nostrip_for_debug_packages.diff \ file://qmake_cxx_eval.patch \ file://configure_oe_compiler.patch \ + file://target_qmake.patch \ + file://qmake_pri_fixes.patch \ file://g++.conf \ file://linux.conf \ "
@@ -50,13 +52,3 @@ do_configure_prepend() { unset LD } -do_compile() { - # Fixup missing wsegl header in some SGX SDKs - if ! [ -e ${STAGING_INCDIR}/wsegl.h ] ; then - cp src/3rdparty/powervr/wsegl.h src/plugins/gfxdrivers/powervr/QWSWSEGL/ - fi - - unset CFLAGS CXXFLAGS - - oe_runmake ${EXTRA_ENV} -}
meta/recipes-qt/qt4/qt-4.8.0/qmake_pri_fixes.patch new file +51 -0
51 lines not on this page · raw message
meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb +1 -1
@@ -1,7 +1,7 @@ require qt-${PV}.inc require qt4-embedded.inc -PR = "${INC_PR}.6" +PR = "${INC_PR}.7" QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb +1 -1
@@ -1,7 +1,7 @@ require qt4-x11-free.inc require qt-${PV}.inc -PR = "${INC_PR}.6" +PR = "${INC_PR}.7" QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
meta/recipes-qt/qt4/qt4.inc +43 -4
76 lines not on this page · raw message
Signature · 1 line
1.7.5.4
PATCH 3/4 qt4-tools-nativesdk: fix build of 4.7.4
In reply to Paul EggletonCommit 4ccae37db1aa77a1d15098c3720ea6e2d383fbdc introduced a sed command line to modify a file that only exists in 4.8.0, thus do_configure of 4.7.4 was failing; so make this conditional upon the file existing.
--- meta/recipes-qt/qt4/qt4-tools-nativesdk.inc | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-)
meta/recipes-qt/qt4/qt4-tools-nativesdk.inc +7 -4
@@ -4,7 +4,7 @@ SECTION = "libs" HOMEPAGE = "http://qt.nokia.com" LICENSE = "LGPLv2.1 | GPLv3" -INC_PR = "r8" +INC_PR = "r9" FILESEXTRAPATHS =. "${FILE_DIRNAME}/qt-${PV}:"
@@ -59,9 +59,12 @@ do_configure() { cp ../g++.conf mkspecs/common cp ../linux.conf mkspecs/common - # don't use host g++ even during configure - sed -i -e "s#g++#${CXX}#" mkspecs/common/g++-base.conf - sed -i -e "s#gcc#${CC}#" mkspecs/common/g++-base.conf + + if [ -f mkspecs/common/g++-base.conf ] ; then + # don't use host g++ even during configure (4.8.0+) + sed -i -e "s#g++#${CXX}#" mkspecs/common/g++-base.conf + sed -i -e "s#gcc#${CC}#" mkspecs/common/g++-base.conf + fi # first launch configure to get qmake compiled for the nativesdk (echo o; echo yes) | CC="${CC}" CXX="${CXX}" ./configure ${EXTRA_OECONF} || true
Signature · 1 line
1.7.5.4
PATCH 4/4 qt4-tools-nativesdk: improve and tidy up qmake build
In reply to Paul Eggleton* Use the same method to build qmake as in the qt4 target recipes
* We always have qmake from qt4-native so don't check if it exists - just skip the check like we do in the qt4 target recipes. This saves us a patch.
* Replace qt4-tools-native in DEPENDS with qt4-native
--- meta/recipes-qt/qt4/files/qmake-exists-check.patch | 19 ----------------- meta/recipes-qt/qt4/qt4-tools-nativesdk.inc | 22 +++++++++++-------- meta/recipes-qt/qt4/qt4-tools-nativesdk_4.8.0.bb | 2 + 3 files changed, 15 insertions(+), 28 deletions(-) delete mode 100644 meta/recipes-qt/qt4/files/qmake-exists-check.patch
meta/recipes-qt/qt4/files/qmake-exists-check.patch deleted +0 -19
@@ -1,19 +0,0 @@ -qt4-tools-nativesdk: avoid rebuilding qmake - -qt4-tools-nativesdk patch to avoids building qmake in configure if it already exists -(as it will, since we symlink it in from the native sysroot in do_configure) - -Signed-off-by: Paul Eggleton <[email protected]> -Upstream-Status: Inappropriate [configuration] - ---- qt-everywhere-opensource-src-4.6.3.orig/configure 2011-01-10 12:01:56.260607001 +0000 -+++ qt-everywhere-opensource-src-4.6.3/configure 2011-01-10 12:02:20.584607015 +0000 -@@ -4286,7 +4286,7 @@ - } - - # build qmake --if true; then ###[ '!' -f "$outpath/bin/qmake" ]; -+if [ '!' -f "$outpath/bin/qmake" ]; then - echo "Creating qmake. Please wait..." - - OLD_QCONFIG_H=
meta/recipes-qt/qt4/qt4-tools-nativesdk.inc +13 -9
@@ -1,21 +1,22 @@ DESCRIPTION = "SDK tools for Qt/[X11|Mac|Embedded] version 4.x" -DEPENDS = "zlib-nativesdk dbus-nativesdk libx11-nativesdk qt4-tools-native" +DEPENDS = "zlib-nativesdk dbus-nativesdk libx11-nativesdk qt4-native" SECTION = "libs" HOMEPAGE = "http://qt.nokia.com" LICENSE = "LGPLv2.1 | GPLv3" -INC_PR = "r9" +INC_PR = "r10" FILESEXTRAPATHS =. "${FILE_DIRNAME}/qt-${PV}:" inherit nativesdk qmake2 SRC_URI = "http://get.qt.nokia.com/qt/source/qt-everywhere-opensource-src-${PV}.tar.gz \ + file://0004-no-qmake.patch \ file://configure-lflags.patch \ file://qt-config.patch \ - file://qmake-exists-check.patch \ file://configure-paths.patch \ file://qt-dbus-const.patch \ + file://target_qmake.patch \ file://g++.conf \ file://linux.conf"
@@ -66,11 +67,7 @@ do_configure() { sed -i -e "s#gcc#${CC}#" mkspecs/common/g++-base.conf fi - # first launch configure to get qmake compiled for the nativesdk - (echo o; echo yes) | CC="${CC}" CXX="${CXX}" ./configure ${EXTRA_OECONF} || true - - # then backup the binary and start again with a qmake which can run on the build host - mv bin/qmake bin/qmake_nativesdk + # Use qmake from qt4-native for building if [ ! -e bin/qmake ]; then ln -sf ${STAGING_BINDIR_NATIVE}/qmake2 bin/qmake fi
@@ -99,11 +96,18 @@ do_compile() { for i in ${TOBUILD}; do cd ${S}/$i && oe_runmake CC="${CC}" CXX="${CXX}" done + + # Build nativesdk qmake + export QMAKESPEC="${S}/mkspecs/${TARGET_OS}-oe-g++" + cd ${S}/qmake + ${OE_QMAKE_QMAKE} + oe_runmake CC="${CC}" CXX="${CXX}" + cd ${S} } do_install() { install -d ${D}${bindir} - install -m 0755 bin/qmake_nativesdk ${D}${bindir}/qmake2 + install -m 0755 bin/qmake2 ${D}${bindir}/qmake2 for i in moc uic uic3 rcc lrelease lupdate qdbuscpp2xml qdbusxml2cpp; do install -m 0755 bin/${i} ${D}${bindir}/${i}4 done
meta/recipes-qt/qt4/qt4-tools-nativesdk_4.8.0.bb +2 -0
@@ -2,6 +2,8 @@ require qt4-tools-nativesdk.inc PR = "${INC_PR}.0" +SRC_URI += "file://qmake_pri_fixes.patch" + DEFAULT_PREFERENCE = "-1" SRC_URI[md5sum] = "e8a5fdbeba2927c948d9f477a6abe904"
Signature · 1 line
1.7.5.4
oops, wrong list... sorry for the noise, will resend.
Cheers,
Paul
Quoted 54 lines · On Sunday 26 February 2012 22:17:57 Paul Eggleton wrote:
This patchset enables building qmake for the target with other target utilities. I also fixed a couple of build failures in the process.
In addition I've used the same method to build qmake in the qt4-tools-nativesdk recipe. This wasn't strictly necessary, however I think it would be good to be consistent and incidentally the resulting qmake executable is slightly smaller.
Since the RFC version, a few issues were fixed:
* Ensure the qmake changes work when the platform is different e.g. linux-gnueabi-oe-g++ instead of linux-oe-g++
* Install an appropriate environment setup script adapted from the former separate qmake2 recipe
* Fix the gcc 4.6 error by fixing the root cause (inability to correctly detect the C++ compiler as g++) rather than hacking around it.
* Format some of the patches so they can be used with git amThanks to Philip Balister for helping me test the qmake improvements.
The following changes since commit
30253358f5e76fb7b25be27198b4c125e0dbdf2c:Quoting fixes (2012-02-26 12:50:36 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contribpaule/qmake-targethttp://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paul
e/qmake-targetPaul Eggleton (4):
qt4: fix compile error in Qt 4.8.0 with gcc 4.6
qt4: build qmake for the target
qt4-tools-nativesdk: fix build of 4.7.4
qt4-tools-nativesdk: improve and tidy up qmake buildmeta/recipes-qt/qt4/files/qmake-exists-check.patch | 19 ------- meta/recipes-qt/qt4/files/target_qmake.patch | 16 ++++++ meta/recipes-qt/qt4/qt-4.7.4.inc | 11 +---- meta/recipes-qt/qt4/qt-4.8.0.inc | 13 +---- .../qt4/qt-4.8.0/configure_oe_compiler.patch | 31 ++++++++++++ meta/recipes-qt/qt4/qt-4.8.0/qmake_pri_fixes.patch | 51 ++++++++++++++++++++ meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4-embedded_4.8.0.bb | 2 +- meta/recipes-qt/qt4/qt4-tools-nativesdk.inc | 29 +++++++---- meta/recipes-qt/qt4/qt4-tools-nativesdk_4.8.0.bb | 2 + meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4.inc | 47 ++++++++++++++++-- 12 files changed, 168 insertions(+), 57 deletions(-) delete mode 100644 meta/recipes-qt/qt4/files/qmake-exists-check.patch create mode 100644 meta/recipes-qt/qt4/files/target_qmake.patch create mode 100644 meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patchcreate mode 100644
meta/recipes-qt/qt4/qt-4.8.0/qmake_pri_fixes.patch
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [PATCH 1/4] qt4: fix compile error in Qt 4.8.0 with gcc 4.6
In reply to Paul EggletonOp 26 feb. 2012, om 23:27 heeft Paul Eggleton het volgende geschreven:
Quoted 39 lines
Ensure the Qt configure script can can detect the compiler correctly as g++. This fixes the following compile error with gcc 4.6:
./wtf/NullPtr.h:48:1: error: identifier 'nullptr' will become a keyword in C++0x [-Werror=c++0x-compat]Signed-off-by Paul Eggleton <[email protected]>---
meta/recipes-qt/qt4/qt-4.8.0.inc | 1 + .../qt4/qt-4.8.0/configure_oe_compiler.patch | 31 ++++++++++++++++++++ meta/recipes-qt/qt4/qt4-embedded_4.8.0.bb | 2 +- 3 files changed, 33 insertions(+), 1 deletions(-)create mode 100644
meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patchmeta/recipes-qt/qt4/qt-4.8.0.inc +1
-0@@ -14,6 +14,7 @@ SRC_URI = "http://get.qt.nokia.com/qt/source/qt-everywhere-opensource-src-${PV}. file://fix-translations.patch \ file://add_nostrip_for_debug_packages.diff \ file://qmake_cxx_eval.patch \ + file://configure_oe_compiler.patch \ file://g++.conf \ file://linux.conf \ "meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch new file +8
-0@@ -0,0 +1,31 @@ +Ensure we identify the compiler as g++ in configure + +Our PLATFORM in OE is ${TARGET_OS}-oe-g++, and previously the configure +script was interpreting from this that the compiler was "oe-g++" and thus +g++ specific checks were not being run since this string did not match; +among other things this resulted in a compiler version check in the +QtWebKit build code not working, and hence the following error at build +time:
meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch line 18
Quoted 10 lines
meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch new file +10
-0+ +./wtf/NullPtr.h:48:1: error: identifier 'nullptr' will become a keyword in C++0x [-Werror=c++0x-compat] + +The easiest thing since our PLATFORM is entirely artificial is to just +force COMPILER to "g++" in the configure script if it is detected as +"oe-g++". + +Upstream-Status: Inappropriate [configuration] + +Signed-off-by: Paul Eggleton <[email protected]>
Can I bribe you to make those proper git patches? :)
regards,
Koen
Re: [PATCH 1/4] qt4: fix compile error in Qt 4.8.0 with gcc 4.6
Quoted 5 lines · On Sunday 26 February 2012 23:55:25 Koen Kooi wrote:
meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch line 18
Quoted 3 lines
meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch new file +3
-0+Upstream-Status: Inappropriate [configuration] + +Signed-off-by: Paul Eggleton <[email protected]>Can I bribe you to make those proper git patches? :)
Is it useful given that it's not suitable for sending upstream?
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [PATCH 1/4] qt4: fix compile error in Qt 4.8.0 with gcc 4.6
Op 26 feb. 2012, om 23:59 heeft Paul Eggleton het volgende geschreven:
Quoted 8 lines · On Sunday 26 February 2012 23:55:25 Koen Kooi wrote:
Quoted 5 lines
meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch line 18
Quoted 3 lines
meta/recipes-qt/qt4/qt-4.8.0/configure_oe_compiler.patch new file +3
-0+Upstream-Status: Inappropriate [configuration] + +Signed-off-by: Paul Eggleton <[email protected]>Can I bribe you to make those proper git patches? :)
Is it useful given that it's not suitable for sending upstream?
It's useful for people like me that have a custom PATCHTOOL that uses git-am. It also makes git am -3 work when updating to a newer version.
regards,
Koen
Re: [PATCH 1/4] qt4: fix compile error in Qt 4.8.0 with gcc 4.6
Quoted 2 lines · On Monday 27 February 2012 00:05:53 Koen Kooi wrote:
It's useful for people like me that have a custom PATCHTOOL that uses git-am. It also makes git am -3 work when updating to a newer version.
OK, I've done this and pushed a new branch. I'm not going to send a new patch series though unless there are other changes.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre