Skip to contentSkip to conversation

treewide: Use vsprintf extention %pf

PATCH Applied Joe Perches 4 participants 14 messages Feb 28, 2012 – Mar 13, 2012

Subsystems (9)
Arm (32-bit) SCSI USB PowerPC +5 more subsystems
lore
Share & tools
lore

Joe Perches

author
#0 lore raw

cover treewide: Use vsprintf extention %pf

Emit the actual function name when possible

Joe Perches (9):
sparc: Use vsprintf extention %pf with builtin_return_address
alpha: Use vsprintf extention %pf with builtin_return_address
arm: Use vsprintf extention %pf with builtin_return_address
microblaze: Use vsprintf extention %pf with builtin_return_address
powerpc: Use vsprintf extention %pf with builtin_return_address
parisc: Use vsprintf extention %pf with builtin_return_address
scsi: Use vsprintf extention %pf with builtin_return_address
staging: ramster: Use vsprintf extention %pf with builtin_return_address
gadget: Use vsprintf extention %pf with builtin_return_address

 arch/alpha/kernel/pci_iommu.c               |   20 ++++++++++----------
 arch/arm/nwfpe/fpmodule.c                   |    2 +-
 arch/microblaze/mm/pgtable.c                |    2 +-
 arch/powerpc/mm/pgtable_32.c                |    2 +-
 arch/sparc/kernel/ds.c                      |    2 +-
 arch/sparc/mm/srmmu.c                       |    2 +-
 drivers/parisc/superio.c                    |    2 +-
 drivers/scsi/esp_scsi.c                     |    2 +-
 drivers/staging/ramster/cluster/heartbeat.c |    4 ++--
 drivers/usb/gadget/u_serial.c               |    2 +-
 10 files changed, 20 insertions(+), 20 deletions(-)
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#1 lore raw

PATCH 1/9 sparc: Use vsprintf extention %pf with builtin_return_address

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 arch/sparc/kernel/ds.c |    2 +-
 arch/sparc/mm/srmmu.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/sparc/kernel/ds.c +1 -1
index 381edcd..e65b9fc 100644
@@ -868,7 +868,7 @@ void ldom_power_off(void)
 
 static void ds_conn_reset(struct ds_info *dp)
 {
-	printk(KERN_ERR "ds-%llu: ds_conn_reset() from %p\n",
+	printk(KERN_ERR "ds-%llu: ds_conn_reset() from %pf\n",
 	       dp->id, __builtin_return_address(0));
 }
arch/sparc/mm/srmmu.c +1 -1
index cbef74e..f37fbb2 100644
@@ -705,7 +705,7 @@ static void swift_update_mmu_cache(struct vm_area_struct * vma, unsigned long ad
 		val = srmmu_hwprobe(address);
 		if (val != 0 && pte_val(*ptep) != val) {
 			printk("swift_update_mmu_cache: "
-			    "addr %lx put %08x probed %08x from %p\n",
+			    "addr %lx put %08x probed %08x from %pf\n",
 			    address, pte_val(*ptep), val,
 			    __builtin_return_address(0));
 			srmmu_flush_whole_tlb();
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#3 lore raw

PATCH 2/9 alpha: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 arch/alpha/kernel/pci_iommu.c |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)
arch/alpha/kernel/pci_iommu.c +10 -10
index cd63479..3f844d2 100644
@@ -236,7 +236,7 @@ static int pci_dac_dma_supported(struct pci_dev *dev, u64 mask)
 		ok = 0;
 
 	/* If both conditions above are met, we are fine. */
-	DBGA("pci_dac_dma_supported %s from %p\n",
+	DBGA("pci_dac_dma_supported %s from %pf\n",
 	     ok ? "yes" : "no", __builtin_return_address(0));
 
 	return ok;

@@ -268,7 +268,7 @@ pci_map_single_1(struct pci_dev *pdev, void *cpu_addr, size_t size,
 	    && paddr + size <= __direct_map_size) {
 		ret = paddr + __direct_map_base;
 
-		DBGA2("pci_map_single: [%p,%zx] -> direct %llx from %p\n",
+		DBGA2("pci_map_single: [%p,%zx] -> direct %llx from %pf\n",
 		      cpu_addr, size, ret, __builtin_return_address(0));
 
 		return ret;

@@ -279,7 +279,7 @@ pci_map_single_1(struct pci_dev *pdev, void *cpu_addr, size_t size,
 	if (dac_allowed) {
 		ret = paddr + alpha_mv.pci_dac_offset;
 
-		DBGA2("pci_map_single: [%p,%zx] -> DAC %llx from %p\n",
+		DBGA2("pci_map_single: [%p,%zx] -> DAC %llx from %pf\n",
 		      cpu_addr, size, ret, __builtin_return_address(0));
 
 		return ret;

@@ -316,7 +316,7 @@ pci_map_single_1(struct pci_dev *pdev, void *cpu_addr, size_t size,
 	ret = arena->dma_base + dma_ofs * PAGE_SIZE;
 	ret += (unsigned long)cpu_addr & ~PAGE_MASK;
 
-	DBGA2("pci_map_single: [%p,%zx] np %ld -> sg %llx from %p\n",
+	DBGA2("pci_map_single: [%p,%zx] np %ld -> sg %llx from %pf\n",
 	      cpu_addr, size, npages, ret, __builtin_return_address(0));
 
 	return ret;

@@ -385,14 +385,14 @@ static void alpha_pci_unmap_page(struct device *dev, dma_addr_t dma_addr,
 	    && dma_addr < __direct_map_base + __direct_map_size) {
 		/* Nothing to do.  */
 
-		DBGA2("pci_unmap_single: direct [%llx,%zx] from %p\n",
+		DBGA2("pci_unmap_single: direct [%llx,%zx] from %pf\n",
 		      dma_addr, size, __builtin_return_address(0));
 
 		return;
 	}
 
 	if (dma_addr > 0xffffffff) {
-		DBGA2("pci64_unmap_single: DAC [%llx,%zx] from %p\n",
+		DBGA2("pci64_unmap_single: DAC [%llx,%zx] from %pf\n",
 		      dma_addr, size, __builtin_return_address(0));
 		return;
 	}

@@ -424,7 +424,7 @@ static void alpha_pci_unmap_page(struct device *dev, dma_addr_t dma_addr,
 
 	spin_unlock_irqrestore(&arena->lock, flags);
 
-	DBGA2("pci_unmap_single: sg [%llx,%zx] np %ld from %p\n",
+	DBGA2("pci_unmap_single: sg [%llx,%zx] np %ld from %pf\n",
 	      dma_addr, size, npages, __builtin_return_address(0));
 }
 

@@ -447,7 +447,7 @@ try_again:
 	cpu_addr = (void *)__get_free_pages(gfp, order);
 	if (! cpu_addr) {
 		printk(KERN_INFO "pci_alloc_consistent: "
-		       "get_free_pages failed from %p\n",
+		       "get_free_pages failed from %pf\n",
 			__builtin_return_address(0));
 		/* ??? Really atomic allocation?  Otherwise we could play
 		   with vmalloc and sg if we can't find contiguous memory.  */

@@ -466,7 +466,7 @@ try_again:
 		goto try_again;
 	}
 
-	DBGA2("pci_alloc_consistent: %zx -> [%p,%llx] from %p\n",
+	DBGA2("pci_alloc_consistent: %zx -> [%p,%llx] from %pf\n",
 	      size, cpu_addr, *dma_addrp, __builtin_return_address(0));
 
 	return cpu_addr;

@@ -486,7 +486,7 @@ static void alpha_pci_free_coherent(struct device *dev, size_t size,
 	pci_unmap_single(pdev, dma_addr, size, PCI_DMA_BIDIRECTIONAL);
 	free_pages((unsigned long)cpu_addr, get_order(size));
 
-	DBGA2("pci_free_consistent: [%llx,%zx] from %p\n",
+	DBGA2("pci_free_consistent: [%llx,%zx] from %pf\n",
 	      dma_addr, size, __builtin_return_address(0));
 }
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#4 lore raw

PATCH 3/9 arm: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 arch/arm/nwfpe/fpmodule.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/nwfpe/fpmodule.c +1 -1
index cb7658e..4e729f0 100644
@@ -147,7 +147,7 @@ void float_raise(signed char flags)
 #ifdef CONFIG_DEBUG_USER
 	if (flags & debug)
  		printk(KERN_DEBUG
-		       "NWFPE: %s[%d] takes exception %08x at %p from %08lx\n",
+		       "NWFPE: %s[%d] takes exception %08x at %pf from %08lx\n",
 		       current->comm, current->pid, flags,
 		       __builtin_return_address(0), GET_USERREG()->ARM_pc);
 #endif
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#8 lore raw

PATCH 6/9 parisc: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 drivers/parisc/superio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/parisc/superio.c +1 -1
index e3b76d4..5003458 100644
@@ -348,7 +348,7 @@ int superio_fixup_irq(struct pci_dev *pcidev)
 		BUG();
 		return -1;
 	}
-	printk("superio_fixup_irq(%s) ven 0x%x dev 0x%x from %p\n",
+	printk("superio_fixup_irq(%s) ven 0x%x dev 0x%x from %pf\n",
 		pci_name(pcidev),
 		pcidev->vendor, pcidev->device,
 		__builtin_return_address(0));
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#9 lore raw

PATCH 7/9 scsi: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 drivers/scsi/esp_scsi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/esp_scsi.c +1 -1
index 394ed9e..34552bf 100644
@@ -1000,7 +1000,7 @@ static int esp_check_spur_intr(struct esp *esp)
 
 static void esp_schedule_reset(struct esp *esp)
 {
-	esp_log_reset("ESP: esp_schedule_reset() from %p\n",
+	esp_log_reset("ESP: esp_schedule_reset() from %pf\n",
 		      __builtin_return_address(0));
 	esp->flags |= ESP_FLAG_RESETTING;
 	esp_event(esp, ESP_EVENT_RESET);
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#5 lore raw

PATCH 4/9 microblaze: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 arch/microblaze/mm/pgtable.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/microblaze/mm/pgtable.c +1 -1
index 59bf233..e3a68bb 100644
@@ -80,7 +80,7 @@ static void __iomem *__ioremap(phys_addr_t addr, unsigned long size,
 		!(p >= virt_to_phys((unsigned long)&__bss_stop) &&
 		p < virt_to_phys((unsigned long)__bss_stop))) {
 		printk(KERN_WARNING "__ioremap(): phys addr "PTE_FMT
-			" is RAM lr %p\n", (unsigned long)p,
+			" is RAM lr %pf\n", (unsigned long)p,
 			__builtin_return_address(0));
 		return NULL;
 	}
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#7 lore raw

PATCH 5/9 powerpc: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 arch/powerpc/mm/pgtable_32.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/mm/pgtable_32.c +1 -1
index 51f8795..0907f92 100644
@@ -207,7 +207,7 @@ __ioremap_caller(phys_addr_t addr, unsigned long size, unsigned long flags,
 	 */
 	if (mem_init_done && (p < virt_to_phys(high_memory)) &&
 	    !(__allow_ioremap_reserved && memblock_is_region_reserved(p, size))) {
-		printk("__ioremap(): phys addr 0x%llx is RAM lr %p\n",
+		printk("__ioremap(): phys addr 0x%llx is RAM lr %pf\n",
 		       (unsigned long long)p, __builtin_return_address(0));
 		return NULL;
 	}
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#11 lore raw

PATCH 8/9 staging: ramster: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 drivers/staging/ramster/cluster/heartbeat.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ramster/cluster/heartbeat.c +2 -2
index 0020949..fe1db52 100644
@@ -398,7 +398,7 @@ int r2hb_register_callback(const char *region_uuid,
 	up_write(&r2hb_callback_sem);
 	ret = 0;
 out:
-	mlog(ML_CLUSTER, "returning %d on behalf of %p for funcs %p\n",
+	mlog(ML_CLUSTER, "returning %d on behalf of %pf for funcs %pf\n",
 	     ret, __builtin_return_address(0), hc);
 	return ret;
 }

@@ -409,7 +409,7 @@ void r2hb_unregister_callback(const char *region_uuid,
 {
 	BUG_ON(hc->hc_magic != R2HB_CB_MAGIC);
 
-	mlog(ML_CLUSTER, "on behalf of %p for funcs %p\n",
+	mlog(ML_CLUSTER, "on behalf of %pf for funcs %pf\n",
 	     __builtin_return_address(0), hc);
 
 	/* XXX Can this happen _with_ a region reference? */
Signature · 1 line
1.7.8.111.gad25c.dirty
author
#12 lore raw

PATCH 9/9 gadget: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 drivers/usb/gadget/u_serial.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/gadget/u_serial.c +1 -1
index 6597a68..a553bee 100644
@@ -920,7 +920,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
 	unsigned long	flags;
 	int		status;
 
-	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %p\n",
+	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
 		port->port_num, tty, ch, __builtin_return_address(0));
 
 	spin_lock_irqsave(&port->port_lock, flags);
Signature · 1 line
1.7.8.111.gad25c.dirty
Acked-by on v1 9/9
#13 lore raw

Re: [PATCH trivial next 9/9] gadget: Use vsprintf extention %pf with builtin_return_address

Quoted 7 lines · Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
Acked-by Felipe Balbi <[email protected]>
Quoted 20 lines
---
 drivers/usb/gadget/u_serial.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/gadget/u_serial.c +1 -1
index 6597a68..a553bee 100644
@@ -920,7 +920,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
 	unsigned long	flags;
 	int		status;
 
-	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %p\n",
+	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
 		port->port_num, tty, ch, __builtin_return_address(0));
 
 	spin_lock_irqsave(&port->port_lock, flags);
Signature · 1 line
1.7.8.111.gad25c.dirty
Signature · 1 line
balbi
maintainer Acked-by on v1 7/9
#10 lore raw

Re: [PATCH trivial next 7/9] scsi: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

From: Joe Perches <[email protected]>
Date: Tue, 28 Feb 2012 10:49:36 -0800

Quoted 7 lines

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
Acked-by David S. Miller <[email protected]>
maintainer Applied
#2 lore raw

Re: [PATCH trivial next 1/9] sparc: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches

From: Joe Perches <[email protected]>
Date: Tue, 28 Feb 2012 10:49:30 -0800

Quoted 7 lines

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>

Applied to sparc-next, thanks Joe.

maintainer Applied
#6 lore raw

Re: [PATCH trivial next 4/9] microblaze: Use vsprintf extention %pf with builtin_return_address

In reply to Joe Perches
Quoted 10 lines · Joe Perches

Emit the function name not the address when possible.

builtin_return_address() gives an address. When building a kernel with CONFIG_KALLSYMS, emit the actual function name not the address.

Signed-off-by Joe Perches <[email protected]>
---
 arch/microblaze/mm/pgtable.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied.

Thanks,
Michal

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian