Skip to contentSkip to conversation

More quoting fixes

PATCH Applied Paul Eggleton 4 participants 7 messages Feb 29, 2012

lore
Share & tools
lore

Paul Eggleton

author
#0 lore raw

cover More quoting fixes

The following changes since commit 3cb519598d9ce044ccccb2d6a52a3c0933433501:

tcl 8.5.11: fix packaging for native version (2012-02-28 13:33:22 +0000)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/quoting-fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/quoting-fixes

Paul Eggleton (1):
More quoting fixes

 .../opensync/libsyncml_0.5.4.bb                    |    2 +-
 meta/recipes-devtools/guile/guile_2.0.3.bb         |    2 +-
 meta/recipes-graphics/cairo/cairo.inc              |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH 1/1 More quoting fixes

Signed-off-by Paul Eggleton <[email protected]>
---
 .../opensync/libsyncml_0.5.4.bb                    |    2 +-
 meta/recipes-devtools/guile/guile_2.0.3.bb         |    2 +-
 meta/recipes-graphics/cairo/cairo.inc              |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb +1 -1
index c045698..e96463b 100644
@@ -14,4 +14,4 @@ PACKAGES += "${PN}-tools"
 FILES_${PN}-tools = "${bindir}"
 FILES_${PN} = "${libdir}/*.so.*"
 
-export VERBOSE=1
+export VERBOSE="1"
meta/recipes-devtools/guile/guile_2.0.3.bb +1 -1
index 729aed0..538ff46 100644
@@ -39,7 +39,7 @@ do_configure_prepend() {
 	mkdir -p po
 }
 
-export GUILE_FOR_BUILD=${BUILD_SYS}-guile
+export GUILE_FOR_BUILD="${BUILD_SYS}-guile"
 
 do_compile_append() {
 	# just for target recipe
meta/recipes-graphics/cairo/cairo.inc +1 -1
index 1d5d551..69984cb 100644
@@ -27,4 +27,4 @@ EXTRA_OECONF += "${@get_cairo_fpu_setting(bb, d)} \
 inherit autotools pkgconfig
 
 # We don't depend on binutils so we need to disable this
-export ac_cv_lib_bfd_bfd_openr=no
+export ac_cv_lib_bfd_bfd_openr="no"
Signature · 1 line
1.7.5.4
#2 lore raw

meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb PACKAGES += "${PN}-tools" · line 17

Quoted 2 lines · Paul Eggleton
meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb +1 -1
-export VERBOSE=1
+export VERBOSE="1"

I fully agree with the change but here it doesn't raise a parser error. Isn't it expected to happen?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
author
#3 lore raw
Quoted 8 lines · On Wednesday 29 February 2012 10:19:33 Otavio Salvador wrote:

On Wed, Feb 29, 2012 at 09:59, Paul Eggleton

meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb PACKAGES += "${PN}-tools" · line 17

Quoted 2 lines · <[email protected]> wrote:
meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb +1 -1
-export VERBOSE=1
+export VERBOSE="1"

I fully agree with the change but here it doesn't raise a parser error. Isn't it expected to happen?

Yes, that has also been fixed in bitbake master.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#4 lore raw
In reply to Otavio Salvador
Quoted 7 lines · Otavio Salvador

meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb PACKAGES += "${PN}-tools" · line 17

Quoted 2 lines · Paul Eggleton
meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb +1 -1
-export VERBOSE=1
+export VERBOSE="1"

I fully agree with the change but here it doesn't raise a parser error. Isn't it expected to happen?

No. I added something to bitbake a short while ago and these are parser errors now!

Cheers,

Richard

#5 lore raw
Quoted 2 lines · Richard Purdie

No. I added something to bitbake a short while ago and these are parser errors now!

Good.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Applied
#6 lore raw
In reply to Paul Eggleton
Quoted 10 lines · Paul Eggleton

The following changes since commit 3cb519598d9ce044ccccb2d6a52a3c0933433501:

tcl 8.5.11: fix packaging for native version (2012-02-28 13:33:22 +0000)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/quoting-fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/quoting-fixes

Paul Eggleton (1):
More quoting fixes

Merged to master, thanks.

Richard