Skip to contentSkip to conversation

Fix libpam's chmod

PATCH In review Robert Yang 2 participants 7 messages Mar 2, 2012

lore
Share & tools
lore
#0 lore raw

cover Fix libpam's chmod

Hi Saul,

This patch is based on oe-core, but I don't have permission to put the pull request on git://git.openembedded.org/openembedded-core-contrib, so I still put the pull request on poky-contrib.

//Robert

The following changes since commit 6b6aa170d5c618cfcd016dd1de926db647f7f932:

busybox: Restore 'date' compatability (2012-03-01 23:16:43 +0000)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/libpam
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/libpam

Robert Yang (1):
Fix libpam's chmod

 meta/recipes-extended/pam/libpam_1.1.5.bb |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 Fix libpam's chmod

The libpam's has an error when generating the rootfs:

chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory

This is because the following code in libpam_1.1.5.bb:

pkg_postinst_pam-plugin-unix () {

    # below is necessary to allow unix_chkpwd get user info from shadow file
    # on lsb images
    chmod 4755 ${sbindir}/unix_chkpwd
}

This is to set the setuid permission for unix_chkpwd (the lsb test requires this), but it lacks a "${D}", and we can do this in the install stage.

[YOCTO #2049]

---
 meta/recipes-extended/pam/libpam_1.1.5.bb |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
meta/recipes-extended/pam/libpam_1.1.5.bb +2 -5
index 283f477..8cddca9 100644
@@ -85,10 +85,7 @@ do_install() {
 
 	install -d ${D}${sysconfdir}/pam.d/     
 	install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/
-}
 
-pkg_postinst_pam-plugin-unix () {
-    # below is necessary to allow unix_chkpwd get user info from shadow file
-    # on lsb images
-    chmod 4755 ${sbindir}/unix_chkpwd
+    # The lsb requires unix_chkpwd has setuid permission
+    chmod 4755 ${D}${sbindir}/unix_chkpwd
 }
Signature · 1 line
1.7.4.1
#2 lore raw

Op 2 mrt. 2012, om 08:02 heeft Robert Yang het volgende geschreven:

Quoted 29 lines

The libpam's has an error when generating the rootfs:

chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory

This is because the following code in libpam_1.1.5.bb:

pkg_postinst_pam-plugin-unix () {

   # below is necessary to allow unix_chkpwd get user info from shadow file
   # on lsb images
   chmod 4755 ${sbindir}/unix_chkpwd
}

This is to set the setuid permission for unix_chkpwd (the lsb test requires this), but it lacks a "${D}", and we can do this in the install stage.

[YOCTO #2049]

---
meta/recipes-extended/pam/libpam_1.1.5.bb | 7 ++-----

1 files changed, 2 insertions(+), 5 deletions(-)
meta/recipes-extended/pam/libpam_1.1.5.bb +0 -0
index 283f477..8cddca9 100644
@@ -85,10 +85,7 @@ do_install() {
 

meta/recipes-extended/pam/libpam_1.1.5.bb do_install() { · line 90

Quoted 10 lines
meta/recipes-extended/pam/libpam_1.1.5.bb +2 -5
 	install -d ${D}${sysconfdir}/pam.d/     
 	install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/
-}
 
-pkg_postinst_pam-plugin-unix () {
-    # below is necessary to allow unix_chkpwd get user info from shadow file
-    # on lsb images
-    chmod 4755 ${sbindir}/unix_chkpwd
+    # The lsb requires unix_chkpwd has setuid permission
+    chmod 4755 ${D}${sbindir}/unix_chkpwd

MIssing PR bump

regards,

Koen

#3 lore raw
Quoted 36 lines · Koen Kooi

Op 2 mrt. 2012, om 08:02 heeft Robert Yang het volgende geschreven:

Quoted 33 lines

The libpam's has an error when generating the rootfs:

chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory

This is because the following code in libpam_1.1.5.bb:

pkg_postinst_pam-plugin-unix () {

    # below is necessary to allow unix_chkpwd get user info from shadow file
    # on lsb images
    chmod 4755 ${sbindir}/unix_chkpwd
}

This is to set the setuid permission for unix_chkpwd (the lsb test requires this), but it lacks a "${D}", and we can do this in the install stage.

[YOCTO #2049]

---
meta/recipes-extended/pam/libpam_1.1.5.bb | 7 ++-----

1 files changed, 2 insertions(+), 5 deletions(-)
meta/recipes-extended/pam/libpam_1.1.5.bb +0 -1
index 283f477..8cddca9 100644
@@ -85,10 +85,7 @@ do_install() {
 
 	install -d ${D}${sysconfdir}/pam.d/
 	install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/
-}
 
Quoted 9 lines

meta/recipes-extended/pam/libpam_1.1.5.bb do_install() { · line 90

Quoted 6 lines
meta/recipes-extended/pam/libpam_1.1.5.bb +2 -4
-pkg_postinst_pam-plugin-unix () {
-    # below is necessary to allow unix_chkpwd get user info from shadow file
-    # on lsb images
-    chmod 4755 ${sbindir}/unix_chkpwd
+    # The lsb requires unix_chkpwd has setuid permission
+    chmod 4755 ${D}${sbindir}/unix_chkpwd

MIssing PR bump

Thanks for your reply, but I'm sorry I don't what did you mean, I guess you mean the Pull Request, it is in the cover letter:

The following changes since commit 6b6aa170d5c618cfcd016dd1de926db647f7f932:

busybox: Restore 'date' compatability (2012-03-01 23:16:43 +0000)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/libpam
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/libpam

// Robert

Quoted 8 lines

regards,

Koen
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

#4 lore raw

Op 2 mrt. 2012, om 11:15 heeft Robert Yang het volgende geschreven:

Quoted 49 lines · Koen Kooi
Quoted 36 lines

Op 2 mrt. 2012, om 08:02 heeft Robert Yang het volgende geschreven:

Quoted 33 lines

The libpam's has an error when generating the rootfs:

chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory

This is because the following code in libpam_1.1.5.bb:

pkg_postinst_pam-plugin-unix () {

   # below is necessary to allow unix_chkpwd get user info from shadow file
   # on lsb images
   chmod 4755 ${sbindir}/unix_chkpwd
}

This is to set the setuid permission for unix_chkpwd (the lsb test requires this), but it lacks a "${D}", and we can do this in the install stage.

[YOCTO #2049]

---
meta/recipes-extended/pam/libpam_1.1.5.bb | 7 ++-----

1 files changed, 2 insertions(+), 5 deletions(-)
meta/recipes-extended/pam/libpam_1.1.5.bb +0 -1
index 283f477..8cddca9 100644
@@ -85,10 +85,7 @@ do_install() {
 
 	install -d ${D}${sysconfdir}/pam.d/
 	install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/
-}
 
Quoted 9 lines

meta/recipes-extended/pam/libpam_1.1.5.bb do_install() { · line 90

Quoted 6 lines
meta/recipes-extended/pam/libpam_1.1.5.bb +2 -4
-pkg_postinst_pam-plugin-unix () {
-    # below is necessary to allow unix_chkpwd get user info from shadow file
-    # on lsb images
-    chmod 4755 ${sbindir}/unix_chkpwd
+    # The lsb requires unix_chkpwd has setuid permission
+    chmod 4755 ${D}${sbindir}/unix_chkpwd

MIssing PR bump

Quoted 2 lines

Thanks for your reply, but I'm sorry I don't what did you mean, I guess you mean the Pull Request, it is in the cover letter:

No, I meant: you change the output package, so you need to increase PR

#5 lore raw
Quoted 52 lines · Koen Kooi

Op 2 mrt. 2012, om 11:15 heeft Robert Yang het volgende geschreven:

Quoted 49 lines · Koen Kooi
Quoted 45 lines

Op 2 mrt. 2012, om 08:02 heeft Robert Yang het volgende geschreven:

Quoted 29 lines

The libpam's has an error when generating the rootfs:

chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory

This is because the following code in libpam_1.1.5.bb:

pkg_postinst_pam-plugin-unix () {

    # below is necessary to allow unix_chkpwd get user info from shadow file
    # on lsb images
    chmod 4755 ${sbindir}/unix_chkpwd
}

This is to set the setuid permission for unix_chkpwd (the lsb test requires this), but it lacks a "${D}", and we can do this in the install stage.

[YOCTO #2049]

---
meta/recipes-extended/pam/libpam_1.1.5.bb | 7 ++-----

1 files changed, 2 insertions(+), 5 deletions(-)
meta/recipes-extended/pam/libpam_1.1.5.bb +0 -0
index 283f477..8cddca9 100644
@@ -85,10 +85,7 @@ do_install() {
 

meta/recipes-extended/pam/libpam_1.1.5.bb do_install() { · line 90

Quoted 10 lines
meta/recipes-extended/pam/libpam_1.1.5.bb +2 -5
 	install -d ${D}${sysconfdir}/pam.d/
 	install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/
-}
 
-pkg_postinst_pam-plugin-unix () {
-    # below is necessary to allow unix_chkpwd get user info from shadow file
-    # on lsb images
-    chmod 4755 ${sbindir}/unix_chkpwd
+    # The lsb requires unix_chkpwd has setuid permission
+    chmod 4755 ${D}${sbindir}/unix_chkpwd

MIssing PR bump

Quoted 4 lines
Quoted 2 lines

Thanks for your reply, but I'm sorry I don't what did you mean, I guess you mean the Pull Request, it is in the cover letter:

No, I meant: you change the output package, so you need to increase PR

Would you please give me more explanations? I'm sorry I don't know what does this mean:-).

// Robert

Quoted 5 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

#6 lore raw
In reply to Koen Kooi
Quoted 52 lines · Koen Kooi

Op 2 mrt. 2012, om 11:15 heeft Robert Yang het volgende geschreven:

Quoted 49 lines · Koen Kooi
Quoted 45 lines

Op 2 mrt. 2012, om 08:02 heeft Robert Yang het volgende geschreven:

Quoted 29 lines

The libpam's has an error when generating the rootfs:

chmod: cannot access `/usr/sbin/unix_chkpwd': No such file or directory

This is because the following code in libpam_1.1.5.bb:

pkg_postinst_pam-plugin-unix () {

    # below is necessary to allow unix_chkpwd get user info from shadow file
    # on lsb images
    chmod 4755 ${sbindir}/unix_chkpwd
}

This is to set the setuid permission for unix_chkpwd (the lsb test requires this), but it lacks a "${D}", and we can do this in the install stage.

[YOCTO #2049]

---
meta/recipes-extended/pam/libpam_1.1.5.bb | 7 ++-----

1 files changed, 2 insertions(+), 5 deletions(-)
meta/recipes-extended/pam/libpam_1.1.5.bb +0 -0
index 283f477..8cddca9 100644
@@ -85,10 +85,7 @@ do_install() {
 

meta/recipes-extended/pam/libpam_1.1.5.bb do_install() { · line 90

Quoted 10 lines
meta/recipes-extended/pam/libpam_1.1.5.bb +2 -5
 	install -d ${D}${sysconfdir}/pam.d/
 	install -m 0644 ${WORKDIR}/pam.d/* ${D}${sysconfdir}/pam.d/
-}
 
-pkg_postinst_pam-plugin-unix () {
-    # below is necessary to allow unix_chkpwd get user info from shadow file
-    # on lsb images
-    chmod 4755 ${sbindir}/unix_chkpwd
+    # The lsb requires unix_chkpwd has setuid permission
+    chmod 4755 ${D}${sbindir}/unix_chkpwd

MIssing PR bump

Quoted 4 lines
Quoted 2 lines

Thanks for your reply, but I'm sorry I don't what did you mean, I guess you mean the Pull Request, it is in the cover letter:

No, I meant: you change the output package, so you need to increase PR

Ah, got it, the PR field, I will send a V2.

// Robert

Quoted 5 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core