logrotate: upgrade from 3.7.9 to 3.8.1
cover logrotate: upgrade from 3.7.9 to 3.8.1
Test info:
* Has been tested on qemux86, qemuppc, qemuarm.
// Robert
The following changes since commit 1e6dce3228a483b2367286e49c4aa8a71733dcbb:
ncurses: fix install error (2012-03-15 13:14:10 +0000)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/logrotate
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/logrotate
Robert Yang (3):
upgrade logrotate: split the old patch into 3 upgrade logrotate: update the recipe
upgrade logrotate: update the distro_tracking_fields.inc
.../conf/distro/include/distro_tracking_fields.inc | 6 +-
.../act-as-mv-when-rotate.patch} | 73 ++++----------------
.../disable-check-different-filesystems.patch | 34 +++++++++
.../logrotate-3.8.1/update-the-manual.patch | 42 +++++++++++
.../{logrotate_3.7.9.bb => logrotate_3.8.1.bb} | 11 ++-
5 files changed, 99 insertions(+), 67 deletions(-)
rename meta/recipes-extended/logrotate/{logrotate-3.7.9/allow-across-different-filesystems.patch => logrotate-3.8.1/act-as-mv-when-rotate.patch} (54%)
create mode 100644 meta/recipes-extended/logrotate/logrotate-3.8.1/disable-check-different-filesystems.patch
create mode 100644 meta/recipes-extended/logrotate/logrotate-3.8.1/update-the-manual.patch
rename meta/recipes-extended/logrotate/{logrotate_3.7.9.bb => logrotate_3.8.1.bb} (72%)Signature · 1 line
1.7.4.1
PATCH 1/3 upgrade logrotate: split the old patch into 3
Split the old patch into 3 during upgrading, this makes it easier for the future's upgrade.
---
.../act-as-mv-when-rotate.patch} | 73 ++++----------------
.../disable-check-different-filesystems.patch | 34 +++++++++
.../logrotate-3.8.1/update-the-manual.patch | 42 +++++++++++
3 files changed, 89 insertions(+), 60 deletions(-)
rename meta/recipes-extended/logrotate/{logrotate-3.7.9/allow-across-different-filesystems.patch => logrotate-3.8.1/act-as-mv-when-rotate.patch} (54%)
create mode 100644 meta/recipes-extended/logrotate/logrotate-3.8.1/disable-check-different-filesystems.patch
create mode 100644 meta/recipes-extended/logrotate/logrotate-3.8.1/update-the-manual.patchmeta/recipes-extended/logrotate/logrotate-3.8.1/act-as-mv-when-rotate.patch renamed from meta/recipes-extended/logrotate/logrotate-3.7.9/allow-across-different-filesystems.patch +13 -60
@@ -1,67 +1,20 @@ -Allow rotate log across different filesystems +Act as the "mv" command when rotate log -* Remove the check for different filesystems -* Act as the "mv" command when rotate log -* Update the mannual -* Fix a bug in the mannual(\f should be \fR) +Act as the "mv" command when rotate log, first rename, if failed, then +read and write. Upstream-Status: Pending Signed-off-by: Robert Yang <[email protected]> --- - config.c | 8 -------- - logrotate.8 | 9 ++++----- logrotate.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++------ - 3 files changed, 57 insertions(+), 19 deletions(-) + 1 files changed, 53 insertions(+), 6 deletions(-) -diff --git a/config.c b/config.c ---- a/config.c -+++ b/config.c -@@ -1482,14 +1482,6 @@ duperror: - dirName, strerror(errno)); - goto error; - } -- -- if (sb.st_dev != sb2.st_dev) { -- message(MESS_ERROR, -- "%s:%d olddir %s and log file %s " -- "are on different devices\n", configFile, -- lineNum, newlog->oldDir, newlog->files[i]); -- goto error; -- } - } - } - -diff --git a/logrotate.8 b/logrotate.8 ---- a/logrotate.8 -+++ b/logrotate.8 -@@ -354,10 +354,9 @@ Do not rotate the log if it is empty (this overrides the \fBifempty\fR option). - .TP - \fBolddir \fIdirectory\fR - Logs are moved into \fIdirectory\fR for rotation. The \fIdirectory\fR --must be on the same physical device as the log file being rotated, --and is assumed to be relative to the directory holding the log file --unless an absolute path name is specified. When this option is used all --old versions of the log end up in \fIdirectory\fR. This option may be -+is assumed to be relative to the directory holding the log file unless -+an absolute path name is specified. When this option is used all old -+versions of the log end up in \fIdirectory\fR. This option may be - overridden by the \fBnoolddir\fR option. - - .TP -@@ -415,7 +414,7 @@ Log files are rotated when they grow bigger than \fIsize\fR bytes. If - \fIsize\fR is followed by \fIk\fR, the size is assumed to be in kilobytes. - If the \fIM\fR is used, the size is in megabytes, and if \fIG\fR is used, the - size is in gigabytes. So \fBsize 100\fR, \fIsize 100k\fR, \fIsize 100M\fR and --\fIsize 100G\f are all valid. -+\fIsize 100G\fR are all valid. - - .TP - \fBsharedscripts\fR diff --git a/logrotate.c b/logrotate.c +index 537e8d6..b04482f 100644 --- a/logrotate.c +++ b/logrotate.c -@@ -625,6 +625,53 @@ int findNeedRotating(struct logInfo *log, int logNum) +@@ -808,6 +808,53 @@ int findNeedRotating(struct logInfo *log, int logNum) return 0; }
@@ -115,7 +68,7 @@ diff --git a/logrotate.c b/logrotate.c int prerotateSingleLog(struct logInfo *log, int logNum, struct logState *state, struct logNames *rotNames) { -@@ -958,15 +1005,15 @@ int prerotateSingleLog(struct logInfo *log, int logNum, struct logState *state, +@@ -1148,15 +1195,15 @@ int prerotateSingleLog(struct logInfo *log, int logNum, struct logState *state, rotNames->baseName, i, fileext, compext); message(MESS_DEBUG,
@@ -134,18 +87,18 @@ diff --git a/logrotate.c b/logrotate.c oldName, newName, strerror(errno)); hasErrors = 1; } -@@ -1082,11 +1129,11 @@ int rotateSingleLog(struct logInfo *log, int logNum, struct logState *state, - log->files[logNum]); +@@ -1286,11 +1333,11 @@ int rotateSingleLog(struct logInfo *log, int logNum, struct logState *state, + } } - #endif + #endif /* WITH_ACL */ - message(MESS_DEBUG, "renaming %s to %s\n", log->files[logNum], -+ message(MESS_DEBUG, "moving %s to %s\n", log->files[logNum], ++ message(MESS_DEBUG, "moving %s to %s\n", log->files[logNum], rotNames->finalName); if (!debug && !hasErrors && - rename(log->files[logNum], rotNames->finalName)) { - message(MESS_ERROR, "failed to rename %s to %s: %s\n", -+ mvFile(log->files[logNum], rotNames->finalName, log)) { -+ message(MESS_ERROR, "failed to move %s to %s: %s\n", ++ mvFile(log->files[logNum], rotNames->finalName, log)) { ++ message(MESS_ERROR, "failed to move %s to %s: %s\n", log->files[logNum], rotNames->finalName, strerror(errno)); hasErrors = 1;
meta/recipes-extended/logrotate/logrotate-3.8.1/disable-check-different-filesystems.patch new file +34 -0
@@ -0,0 +1,34 @@ +Disable the check for different filesystems + +The logrotate supports rotate log across different filesystems now, so +disable the check for different filesystems. + +Upstream-Status: Pending + +Signed-off-by: Robert Yang <[email protected]> +--- + config.c | 8 -------- + 1 files changed, 0 insertions(+), 8 deletions(-) + +diff --git a/config.c b/config.c +index a85d1df..24575b3 100644 +--- a/config.c ++++ b/config.c +@@ -1453,14 +1453,6 @@ static int readConfigFile(const char *configFile, struct logInfo *defConfig) + dirName, strerror(errno)); + goto error; + } +- +- if (sb.st_dev != sb2.st_dev) { +- message(MESS_ERROR, +- "%s:%d olddir %s and log file %s " +- "are on different devices\n", configFile, +- lineNum, newlog->oldDir, newlog->files[i]); +- goto error; +- } + } + } + +-- +1.7.4.1 +
meta/recipes-extended/logrotate/logrotate-3.8.1/update-the-manual.patch new file +42 -0
42 lines not on this page · raw message
Signature · 1 line
1.7.4.1
PATCH 2/3 upgrade logrotate: update the recipe
In reply to Robert Yangupdate the recipe:
ogrotate_3.7.9.bb -> logrotate_3.8.1.bb
---
.../{logrotate_3.7.9.bb => logrotate_3.8.1.bb} | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
rename meta/recipes-extended/logrotate/{logrotate_3.7.9.bb => logrotate_3.8.1.bb} (72%)meta/recipes-extended/logrotate/logrotate_3.8.1.bb renamed from meta/recipes-extended/logrotate/logrotate_3.7.9.bb +7 -4
@@ -2,17 +2,20 @@ DESCRIPTION = "Rotates, compresses, removes and mails system log files" SECTION = "console/utils" HOMEPAGE = "https://fedorahosted.org/releases/l/o/logrotate" LICENSE = "GPLv2" -PR = "r2" +PR = "r0" DEPENDS="coreutils popt" LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760" SRC_URI = "https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.gz \ - file://allow-across-different-filesystems.patch" + file://act-as-mv-when-rotate.patch \ + file://disable-check-different-filesystems.patch \ + file://update-the-manual.patch \ + " -SRC_URI[md5sum] = "eeba9dbca62a9210236f4b83195e4ea5" -SRC_URI[sha256sum] = "080caf904e70e04da16b8dfa95a5a787ec7d722ee1af18ccea437d3ffdd6fec0" +SRC_URI[md5sum] = "bd2e20d8dc644291b08f9215397d28a5" +SRC_URI[sha256sum] = "c12471e70ae8bc923bd5c4f25e8fd6483b68c6301f3cd79f7cfe37bc5b370169" EXTRA_OEMAKE = "CC='${CC}'"
Signature · 1 line
1.7.4.1
PATCH 3/3 upgrade logrotate: update the distro_tracking_fields.inc
In reply to Robert Yangupdate the distro_tracking_fields.inc.
--- .../conf/distro/include/distro_tracking_fields.inc | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
meta/conf/distro/include/distro_tracking_fields.inc +3 -3
@@ -78,10 +78,10 @@ RECIPE_LAST_UPDATE_pn-linux-firmware = "Dec 30, 2011" RECIPE_MANUAL_CHECK_DATE_pn-linux-firmware = "Dec 30, 2011" RECIPE_MAINTAINER_pn-linux-firmware = "Dongxiao Xu <[email protected]>" -RECIPE_STATUS_pn-logrotate = "red" +RECIPE_STATUS_pn-logrotate = "green" RECIPE_LATEST_VERSION_pn-logrotate = "check" -RECIPE_LAST_UPDATE_pn-logrotate = "Sep 1, 2010" -RECIPE_MAINTAINER_pn-logrotate = "Xiaofeng.Yan <[email protected]>" +RECIPE_LAST_UPDATE_pn-logrotate = "Mar 14, 2012" +RECIPE_MAINTAINER_pn-logrotate = "Robert Yang <[email protected]>" RECIPE_STATUS_pn-loudmouth = "red" RECIPE_LATEST_VERSION_pn-loudmouth = "check"
Signature · 1 line
1.7.4.1
Saul Wold
AppliedQuoted 25 lines · Robert Yang
Test info:
* Has been tested on qemux86, qemuppc, qemuarm.
// Robert
The following changes since commit
1e6dce3228a483b2367286e49c4aa8a71733dcbb:ncurses: fix install error (2012-03-15 13:14:10 +0000)are available in the git repository at:
git://git.pokylinux.org/poky-contribrobert/logrotate
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/logrotateRobert Yang (3):
upgrade logrotate: split the old patch into 3 upgrade logrotate: update the recipe
upgrade logrotate: update the distro_tracking_fields.inc.../conf/distro/include/distro_tracking_fields.inc | 6 +- .../act-as-mv-when-rotate.patch} | 73 ++++---------------- .../disable-check-different-filesystems.patch | 34 +++++++++ .../logrotate-3.8.1/update-the-manual.patch | 42 +++++++++++ .../{logrotate_3.7.9.bb => logrotate_3.8.1.bb} | 11 ++- 5 files changed, 99 insertions(+), 67 deletions(-)
Quoted 5 lines
rename
meta/recipes-extended/logrotate/{logrotate-3.7.9/allow-across-different-filesystems.patch=>logrotate-3.8.1/act-as-mv-when-rotate.patch} (54%) create mode 100644meta/recipes-extended/logrotate/logrotate-3.8.1/disable-check-different-filesystems.patch
create mode 100644meta/recipes-extended/logrotate/logrotate-3.8.1/update-the-manual.patch
rename meta/recipes-extended/logrotate/{logrotate_3.7.9.bb => logrotate_3.8.1.bb} (72%)
Merged into OE-Core
Thanks
Sau!