Skip to contentSkip to conversation

native.bbclass: make TOOLCHAIN_OPTIONS empty

PATCH Applied Robert Yang 2 participants 3 messages Mar 16, 2012 – Mar 21, 2012

lore
Share & tools
lore
#0 lore raw

cover native.bbclass: make TOOLCHAIN_OPTIONS empty

Testinfo:
Has tested on qemux86, qemuppc and qemuarm.

// Robert

The following changes since commit d4f1ef6b8297826230a68e535098709d07de1f48:

qt4: package static libraries correctly to fix warnings (2012-03-15 13:33:37 +0000)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/native
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/native

Robert Yang (1):
native.bbclass: make TOOLCHAIN_OPTIONS empty

 meta/classes/native.bbclass |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 native.bbclass: make TOOLCHAIN_OPTIONS empty

The native pkg doesn't need the TOOLCHAIN_OPTIONS, but it maybe used by native pkgs, for example, the cmake.bbclass uses TOOLCHAIN_OPTIONS:

OECMAKE_C_FLAGS ?= "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS} ${CPPFLAGS}"

and TOOLCHAIN_OPTIONS is:
TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_TARGET}"

If a native pkg inherits cmake.bbclass, then:
TOOLCHAIN_OPTIONS = " --sysroot="

and OECMAKE_C_FLAGS would be:
${HOST_CC_ARCH} --sysroot= ${CPPFLAGS}

This would cause unexpected errors, I think that we can make TOOLCHAIN_OPTIONS empty in native.bbclass since native pkg doesn't need it.

[YOCTO #2124]

---
 meta/classes/native.bbclass |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
meta/classes/native.bbclass +3 -0
index 00196ba..871dda0 100644
@@ -45,6 +45,9 @@ LDFLAGS_build-darwin = "-L${STAGING_LIBDIR_NATIVE} "
 STAGING_BINDIR = "${STAGING_BINDIR_NATIVE}"
 STAGING_BINDIR_CROSS = "${STAGING_BINDIR_NATIVE}"
 
+# native pkg doesn't need the TOOLCHAIN_OPTIONS.
+TOOLCHAIN_OPTIONS = ""
+
 DEPENDS_GETTEXT = "gettext-native"
 
 # Don't use site files for native builds
Signature · 1 line
1.7.4.1
Applied
#2 lore raw
In reply to Robert Yang
Quoted 13 lines · Robert Yang

Testinfo:
Has tested on qemux86, qemuppc and qemuarm.

// Robert

The following changes since commit d4f1ef6b8297826230a68e535098709d07de1f48:

qt4: package static libraries correctly to fix warnings (2012-03-15 13:33:37 +0000)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/native
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/native

Quoted 6 lines

Robert Yang (1):
native.bbclass: make TOOLCHAIN_OPTIONS empty

  meta/classes/native.bbclass |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

Merged into OE-Core

Thanks
Sau!